227454 2021-06-28 10:41:45 -0700 REGRESSION (r279305) [Mac DEBUG] 4 SOAuthorizationRedirect Tests are Crashing with Assert: !m_sheetWindow 2021-06-28 16:57:03 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ehutchison bfulgham bfulgham ehutchison ews-watchlist jiewen_tan katherine_cheney kkinnunen webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1773125 0 ehutchison 2021-06-28 10:41:45 -0700 TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringHiding TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringHidingThenAnother TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringMiniaturization TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringMiniaturizationThenAnother These tests are failing with assert !m_sheetWindow introduced in r279305. https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringHiding&test=TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringHidingThenAnother&test=TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringMiniaturization&test=TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringMiniaturizationThenAnother TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringMiniaturization ASSERTION FAILED: !m_sheetWindow /Volumes/Data/worker/bigsur-debug/build/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm(153) : void WebKit::SOAuthorizationSession::becomeCompleted() 1 0x109389299 WTFCrash 2 0x11186adfb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x112d60ad5 WebKit::SOAuthorizationSession::becomeCompleted() 4 0x112d63783 WebKit::SOAuthorizationSession::abort() 5 0x112d68656 -[WKSOAuthorizationDelegate authorizationDidCancel:] 6 0x10322de4a TestWebKitAPI::SOAuthorizationRedirect_DismissUIDuringMiniaturization_Test::TestBody() 7 0x1036417e4 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 8 0x103603fdb void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 9 0x103603f13 testing::Test::Run() 10 0x1036050e4 testing::TestInfo::Run() 11 0x103606225 testing::TestSuite::Run() 12 0x10361534d testing::internal::UnitTestImpl::RunAllTests() 13 0x103646e24 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 14 0x103614ceb bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 15 0x103614bbd testing::UnitTest::Run() 16 0x103331691 RUN_ALL_TESTS() 17 0x103331622 TestWebKitAPI::TestsController::run(int, char**) 18 0x1035cb2ef main 19 0x7fff204f6f5d start 20 0x2 1773126 1 webkit-bug-importer 2021-06-28 10:42:51 -0700 <rdar://problem/79871423> 1773234 2 432432 bfulgham 2021-06-28 15:34:24 -0700 Created attachment 432432 Patch 1773237 3 432432 katherine_cheney 2021-06-28 15:38:17 -0700 Comment on attachment 432432 Patch r=me 1773238 4 432432 bfulgham 2021-06-28 15:42:41 -0700 Comment on attachment 432432 Patch Will cq+ once EWS is finished. 1773270 5 ews-feeder 2021-06-28 16:57:02 -0700 Committed r279352 (239220@main): <https://commits.webkit.org/239220@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432432. 432432 2021-06-28 15:34:24 -0700 2021-06-28 16:57:03 -0700 Patch bug-227454-20210628153424.patch text/plain 1923 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU0Y2NjZTg4YTZlYmE0MmY1 OTRlYzdkY2JiZjY0MDg1YWY5NjU3NjYuLjMxZThiYWY4ZDQxYTBlYTBiZDA2ZDc5NTIxZWQ0YTU3 MTc2OTA3YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDYtMjggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI3OTMw NSkgW01hYyBERUJVR10gNCBTT0F1dGhvcml6YXRpb25SZWRpcmVjdCBUZXN0cyBhcmUgQ3Jhc2hp bmcgd2l0aCBBc3NlcnQ6ICFtX3NoZWV0V2luZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc0NTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc5 ODcxNDIzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoZSBuZXcgYXNzZXJ0aW9uIGlzIHdyb25nIGluIHRoZSBjYXNlIHRoYXQgdGhlIGFwcCBpcyBo aWRkZW4uIFdoZW4gbWluaW1pemVkIChvciBoaWRkZW4pIHdlIG5lZWQgdG8gcmVtZW1iZXIKKyAg ICAgICAgdG8gZGlzbWlzcyB0aGUgc2hlZXQgb25jZSBDb2NvYSByZXN0b3JlcyB0aGUgYXBwIHRv IHZpc2libGUgc3RhdGUuIFNvIHRoZSBtX3NoZWV0V2luZG93IG1heSBzdGlsbCBleGlzdCBhZnRl cgorICAgICAgICByZXR1cm5pbmcgZnJvbSAnZGlzbWlzc1ZpZXdDb250cm9sbGVyJy4gV2Ugc2hv dWxkIGFzc2VydCB0aGF0IGVpdGhlciBtX3NoZWV0V2luZG93IGlzIG51bGxwdHIsIG9yIHRoYXQg Ym90aAorICAgICAgICBtX3NoZWV0V2luZG93IGFuZCBtX3NoZWV0V2luZG93V2lsbENsb3NlT2Jz ZXJ2ZXIgZXhpc3QuIAorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXphdGlv bi9TT0F1dGhvcml6YXRpb25TZXNzaW9uLm1tOgorICAgICAgICAoV2ViS2l0OjpTT0F1dGhvcml6 YXRpb25TZXNzaW9uOjpiZWNvbWVDb21wbGV0ZWQpOgorCiAyMDIxLTA2LTI4ICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFBhc3MgY29ycmVjdCB2YWx1ZSBvZiBBWCBw ZXIgYXBwIHNldHRpbmdzIHRvIHRoZSBXZWJDb250ZW50IHByb2Nlc3MKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXphdGlvbi9TT0F1dGhvcml6YXRp b25TZXNzaW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvU09BdXRob3JpemF0 aW9uL1NPQXV0aG9yaXphdGlvblNlc3Npb24ubW0KaW5kZXggMTk5NDlmYTNlZDg1ZGZkMjU3OWZm NzZhZGQxYzg3MGQ3ZTZhMjA5MC4uMzIzYzViZTg4YWU3MmRmY2ZjZDY3YTI3MTVmYzZlMjdmNGI5 NzdkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvU09BdXRob3Jp emF0aW9uL1NPQXV0aG9yaXphdGlvblNlc3Npb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1NPQXV0aG9yaXphdGlvblNlc3Npb24ubW0KQEAg LTE1MCw3ICsxNTAsNyBAQCB2b2lkIFNPQXV0aG9yaXphdGlvblNlc3Npb246OmJlY29tZUNvbXBs ZXRlZCgpCiAgICAgbV9zdGF0ZSA9IFN0YXRlOjpDb21wbGV0ZWQ7CiAgICAgZGlzbWlzc1ZpZXdD b250cm9sbGVyKCk7CiAjaWYgUExBVEZPUk0oTUFDKQotICAgIEFTU0VSVCghbV9zaGVldFdpbmRv dyk7CisgICAgQVNTRVJUKCFtX3NoZWV0V2luZG93IHx8IChtX3NoZWV0V2luZG93ICYmIG1fc2hl ZXRXaW5kb3dXaWxsQ2xvc2VPYnNlcnZlcikpOwogI2VuZGlmCiB9CiAK