227451 2021-06-28 08:03:19 -0700 ANGLE Metal index buffer restart range cache is could be maintained more consistently 2021-08-25 00:42:45 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 227371 1 kkinnunen kkinnunen dino ews-watchlist kbr kkinnunen kondapallykalyan kpiddington webkit-bug-importer oldest_to_newest 1773068 0 kkinnunen 2021-06-28 08:03:19 -0700 ANGLE Metal index buffer left mapped when building primitive restart ranges - When other cache buffers are marked dirty, the cache is cleared. When other cache buffers are detached, the cache is not cleared. - When buffer is interpreted differently, the cache is not cleared. 1773401 1 432477 kkinnunen 2021-06-29 06:55:08 -0700 Created attachment 432477 Patch 1773402 2 ews-watchlist 2021-06-29 06:56:17 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1773602 3 432477 kbr 2021-06-29 16:03:24 -0700 Comment on attachment 432477 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432477&action=review Looks good to me. r+ > Source/ThirdParty/ANGLE/ChangeLog:3 > + ANGLE Metal index buffer restart range cache is could be maintained more consistently "is could" -> "could" (bug description should be updated too) 1774812 4 webkit-bug-importer 2021-07-05 08:04:16 -0700 <rdar://problem/80177894> 1787106 5 ews-feeder 2021-08-25 00:42:43 -0700 Committed r281550 (240917@main): <https://commits.webkit.org/240917@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432477. 432477 2021-06-29 06:55:08 -0700 2021-08-25 00:42:44 -0700 Patch bug-227451-20210629165506.patch text/plain 5319 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZWEwNWRkZTk5MTEzNmY2ZTFiZGE5MzkxNTNjOWZlN2FkOTA2MGM3OC4uOTc3ZDM1MjU5Y2Yz OWFhMGJmNzViZjI5YTc4MzAzOGUyM2UyZGRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI5IEBACisyMDIxLTA2LTI4ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgTWV0YWwgaW5kZXggYnVmZmVyIHJlc3RhcnQg cmFuZ2UgY2FjaGUgaXMgY291bGQgYmUgbWFpbnRhaW5lZCBtb3JlIGNvbnNpc3RlbnRseQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NDUxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvbGliQU5H TEUvcmVuZGVyZXIvbWV0YWwvQnVmZmVyTXRsLmg6CisgICAgICAgIChyeDo6QnVmZmVyTXRsOjpS ZXN0YXJ0UmFuZ2VDYWNoZTo6UmVzdGFydFJhbmdlQ2FjaGUpOgorICAgICAgICBBZGQgb3B0aW9u YWw8UmVzdGFydFJhbmdlQ2FjaGU+IHdoaWNoIGNvbnRhaW5zIHRoZSByYW5nZXMgYW5kCisgICAg ICAgIHRoZSBpbmRleCB0eXBlIHVzZWQgdG8gYnVpbGQgdGhlIHJhbmdlcy4KKworICAgICAgICAq IHNyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9CdWZmZXJNdGwubW06CisgICAgICAgIChyeDo6 QnVmZmVyTXRsOjptYXJrQ29udmVyc2lvbkJ1ZmZlcnNEaXJ0eSk6CisgICAgICAgIChyeDo6QnVm ZmVyTXRsOjpjbGVhckNvbnZlcnNpb25CdWZmZXJzKToKKyAgICAgICAgSW52YWxpZGF0ZSB0aGUg cmFuZ2UgY2FjaGUgd2hlbiBjbGVhcmluZyBjb252ZXJzaW9uIGJ1ZmZlcnMuCisgICAgICAgIE90 aGVyd2lzZSB0aGUgY2FjaGUgd291bGQgYmUgbGVmdCBpbiBpbmNvbnNpc3RlbnQgc3RhdGUgdnMu CisgICAgICAgIHRoZSBjb250ZW50cyBvZiB0aGUgaW5kZXggYnVmZmVyIGluIGNhc2VzIG9mIGNv ZGUgbGlrZToKKyAgICAgICAgQnVmZmVyTXRsOjpzZXREYXRhSW1wbCgpIC4uLgorICAgICAgICAg ICBpZiAoLi4uKSB7CisgICAgICAgICAgICAgICBtYXJrQ29udmVyc2lvbkJ1ZmZlckRpcnR5KCk7 CisgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICBjbGVhckNvbnZlcnNpb25CdWZm ZXJzKCk7CisgICAgICAgICAgIH0KKyAgICAgICAgKHJ4OjpCdWZmZXJNdGw6OmdldFJlc3RhcnRJ bmRpY2VzKToKKwogMjAyMS0wNi0yOCAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIEFOR0xFIE1ldGFsIHByaW1pdGl2ZSByZXN0YXJ0IHJhbmdlIGNvbXB1 dGF0aW9uIGNvdWxkIGluZGV4IHdpdGggc2l6ZV90CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQnVmZmVyTXRsLmggYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQnVmZmVyTXRs LmgKaW5kZXggZTdlZWJjOTM5NDUwNWRlMzMyZmUwMTUxNzk5MTNkZjI4NTFmZjQyNy4uOTRhZjVi MzY3ZWJiZjQ3MTA5ODcyZWM0MzYzMGJhMzRhYzdhMTc1NyAxMDA2NDQKLS0tIGEvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL0J1ZmZlck10bC5oCisr KyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9C dWZmZXJNdGwuaApAQCAtMTIsNiArMTIsNyBAQAogCiAjaW1wb3J0IDxNZXRhbC9NZXRhbC5oPgog CisjaW5jbHVkZSA8b3B0aW9uYWw+CiAjaW5jbHVkZSA8dXRpbGl0eT4KIAogI2luY2x1ZGUgImxp YkFOR0xFL0J1ZmZlci5oIgpAQCAtMjEwLDEwICsyMTEsMTYgQEAgY2xhc3MgQnVmZmVyTXRsIDog cHVibGljIEJ1ZmZlckltcGwsIHB1YmxpYyBCdWZmZXJIb2xkZXJNdGwKICAgICBzdGQ6OnZlY3Rv cjxJbmRleENvbnZlcnNpb25CdWZmZXJNdGw+IG1JbmRleENvbnZlcnNpb25CdWZmZXJzOwogICAg IAogICAgIHN0ZDo6dmVjdG9yPFVuaWZvcm1Db252ZXJzaW9uQnVmZmVyTXRsPiBtVW5pZm9ybUNv bnZlcnNpb25CdWZmZXJzOwotICAgIAotICAgIGJvb2wgbVJlc3RhcnRJbmRpY2VzRGlydHk7Ci0g ICAgc3RkOjp2ZWN0b3I8SW5kZXhSYW5nZT4gbVJlc3RhcnRJbmRpY2VzOwotICAgIAorCisgICAg c3RydWN0IFJlc3RhcnRSYW5nZUNhY2hlCisgICAgeworICAgICAgICBSZXN0YXJ0UmFuZ2VDYWNo ZShzdGQ6OnZlY3RvcjxJbmRleFJhbmdlPiYmIHJhbmdlc18sICBnbDo6RHJhd0VsZW1lbnRzVHlw ZSBpbmRleFR5cGVfKQorICAgICAgICAgICAgOiByYW5nZXMocmFuZ2VzXyksIGluZGV4VHlwZShp bmRleFR5cGVfKQorICAgICAgICB7fQorICAgICAgICBjb25zdCBzdGQ6OnZlY3RvcjxJbmRleFJh bmdlPiByYW5nZXM7CisgICAgICAgIGNvbnN0IGdsOjpEcmF3RWxlbWVudHNUeXBlIGluZGV4VHlw ZTsKKyAgICB9OworICAgIHN0ZDo6b3B0aW9uYWw8UmVzdGFydFJhbmdlQ2FjaGU+IG1SZXN0YXJ0 UmFuZ2VDYWNoZTsKIH07CiAKIGNsYXNzIFNpbXBsZVdlYWtCdWZmZXJIb2xkZXJNdGwgOiBwdWJs aWMgQnVmZmVySG9sZGVyTXRsCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9z cmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQnVmZmVyTXRsLm1tIGIvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL0J1ZmZlck10bC5tbQppbmRleCA1 YjVhODc2MDAxZjQ5YmJhZDM2Yjg5NTZkZTNlYjY4OTI0ZmUyNmRmLi4wNjM0NTNjYjI2MWJkYjM3 YWRjOTI1ZWZlMTVkMjNjODc2N2YyNWViIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQnVmZmVyTXRsLm1tCisrKyBiL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9CdWZmZXJNdGwu bW0KQEAgLTQwMSw3ICs0MDEsNyBAQCB2b2lkIEJ1ZmZlck10bDo6bWFya0NvbnZlcnNpb25CdWZm ZXJzRGlydHkoKQogICAgICAgICBidWZmZXIuY29udmVydGVkQnVmZmVyID0gbnVsbHB0cjsKICAg ICAgICAgYnVmZmVyLmNvbnZlcnRlZE9mZnNldCA9IDA7CiAgICAgfQotICAgIG1SZXN0YXJ0SW5k aWNlc0RpcnR5ID0gdHJ1ZTsKKyAgICBtUmVzdGFydFJhbmdlQ2FjaGUgPSBzdGQ6Om51bGxvcHQ7 CiB9CiAKIHZvaWQgQnVmZmVyTXRsOjpjbGVhckNvbnZlcnNpb25CdWZmZXJzKCkKQEAgLTQwOSw2 ICs0MDksNyBAQCB2b2lkIEJ1ZmZlck10bDo6Y2xlYXJDb252ZXJzaW9uQnVmZmVycygpCiAgICAg bVZlcnRleENvbnZlcnNpb25CdWZmZXJzLmNsZWFyKCk7CiAgICAgbUluZGV4Q29udmVyc2lvbkJ1 ZmZlcnMuY2xlYXIoKTsKICAgICBtVW5pZm9ybUNvbnZlcnNpb25CdWZmZXJzLmNsZWFyKCk7Cisg ICAgbVJlc3RhcnRSYW5nZUNhY2hlID0gc3RkOjpudWxsb3B0OwogfQogCiB0ZW1wbGF0ZTx0eXBl bmFtZSBUPgpAQCAtNDM3LDI2ICs0MzgsMjcgQEAgc3RhdGljIHN0ZDo6dmVjdG9yPEluZGV4UmFu Z2U+IGNhbGN1bGF0ZVJlc3RhcnRSYW5nZXMoQ29udGV4dE10bCAqY3R4LCBtdGw6OkJ1ZmYKIAog Y29uc3Qgc3RkOjp2ZWN0b3I8SW5kZXhSYW5nZT4gJiBCdWZmZXJNdGw6OmdldFJlc3RhcnRJbmRp Y2VzKENvbnRleHRNdGwgKiBjdHgsIGdsOjpEcmF3RWxlbWVudHNUeXBlIGluZGV4VHlwZSkKIHsK LSAgICBpZihtUmVzdGFydEluZGljZXNEaXJ0eSkKKyAgICBpZiAoIW1SZXN0YXJ0UmFuZ2VDYWNo ZSB8fCBtUmVzdGFydFJhbmdlQ2FjaGUtPmluZGV4VHlwZSAhPSBpbmRleFR5cGUpCiAgICAgewot ICAgICAgICBzdGQ6OnZlY3RvcjxJbmRleFJhbmdlPigpLnN3YXAobVJlc3RhcnRJbmRpY2VzKTsK KyAgICAgICAgbVJlc3RhcnRSYW5nZUNhY2hlID0gc3RkOjpudWxsb3B0OworICAgICAgICBzdGQ6 OnZlY3RvcjxJbmRleFJhbmdlPiByYW5nZXM7CiAgICAgICAgIHN3aXRjaChpbmRleFR5cGUpCiAg ICAgICAgIHsKICAgICAgICAgICAgIGNhc2UgZ2w6OkRyYXdFbGVtZW50c1R5cGU6OlVuc2lnbmVk Qnl0ZToKLSAgICAgICAgICAgICAgICBtUmVzdGFydEluZGljZXMgPSBjYWxjdWxhdGVSZXN0YXJ0 UmFuZ2VzPHVpbnQ4X3Q+KGN0eCwgZ2V0Q3VycmVudEJ1ZmZlcigpKTsKKyAgICAgICAgICAgICAg ICByYW5nZXMgPSBjYWxjdWxhdGVSZXN0YXJ0UmFuZ2VzPHVpbnQ4X3Q+KGN0eCwgZ2V0Q3VycmVu dEJ1ZmZlcigpKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgZ2w6 OkRyYXdFbGVtZW50c1R5cGU6OlVuc2lnbmVkU2hvcnQ6Ci0gICAgICAgICAgICAgICAgbVJlc3Rh cnRJbmRpY2VzID0gY2FsY3VsYXRlUmVzdGFydFJhbmdlczx1aW50MTZfdD4oY3R4LCBnZXRDdXJy ZW50QnVmZmVyKCkpOworICAgICAgICAgICAgICAgIHJhbmdlcyA9IGNhbGN1bGF0ZVJlc3RhcnRS YW5nZXM8dWludDE2X3Q+KGN0eCwgZ2V0Q3VycmVudEJ1ZmZlcigpKTsKICAgICAgICAgICAgICAg ICBicmVhazsKICAgICAgICAgICAgIGNhc2UgZ2w6OkRyYXdFbGVtZW50c1R5cGU6OlVuc2lnbmVk SW50OgotICAgICAgICAgICAgICAgIG1SZXN0YXJ0SW5kaWNlcyA9IGNhbGN1bGF0ZVJlc3RhcnRS YW5nZXM8dWludDMyX3Q+KGN0eCwgZ2V0Q3VycmVudEJ1ZmZlcigpKTsKKyAgICAgICAgICAgICAg ICByYW5nZXMgPSBjYWxjdWxhdGVSZXN0YXJ0UmFuZ2VzPHVpbnQzMl90PihjdHgsIGdldEN1cnJl bnRCdWZmZXIoKSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0 OgogICAgICAgICAgICAgICAgIEFTU0VSVChmYWxzZSk7CiAgICAgICAgIH0KLSAgICAgICAgbVJl c3RhcnRJbmRpY2VzRGlydHkgPSBmYWxzZTsKKyAgICAgICAgbVJlc3RhcnRSYW5nZUNhY2hlLmVt cGxhY2Uoc3RkOjptb3ZlKHJhbmdlcyksIGluZGV4VHlwZSk7CiAgICAgfQotICAgIHJldHVybiBt UmVzdGFydEluZGljZXM7CisgICAgcmV0dXJuIG1SZXN0YXJ0UmFuZ2VDYWNoZS0+cmFuZ2VzOwog fQogYW5nbGU6OlJlc3VsdCBCdWZmZXJNdGw6OnNldERhdGFJbXBsKGNvbnN0IGdsOjpDb250ZXh0 ICpjb250ZXh0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdsOjpCdWZm ZXJCaW5kaW5nIHRhcmdldCwK