227444 2021-06-28 05:14:39 -0700 Make LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData hop to main thread before hopping to processing thread 2021-07-02 00:10:01 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez eric.carlson webkit-bug-importer youennf oldest_to_newest 1773031 0 youennf 2021-06-28 05:14:39 -0700 Make LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData hop to main thread before hopping to processing thread 1773032 1 youennf 2021-06-28 05:14:53 -0700 <rdar://79413368> 1773033 2 432384 youennf 2021-06-28 05:18:27 -0700 Created attachment 432384 Patch 1774066 3 youennf 2021-07-01 03:41:40 -0700 ping review 1774211 4 432384 cdumez 2021-07-01 12:32:34 -0700 Comment on attachment 432384 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432384&action=review > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:401 > + m_processingQueue->dispatch([this] { Why is this safe? What guarantees that |this| is still alive when the lambda runs? 1774220 5 youennf 2021-07-01 12:52:08 -0700 (In reply to Chris Dumez from comment #4) > Comment on attachment 432384 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=432384&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:401 > > + m_processingQueue->dispatch([this] { > > Why is this safe? What guarantees that |this| is still alive when the lambda > runs? We are doing a dispatchSync in LocalSampleBufferDisplayLayer destructor. 1774222 6 432384 cdumez 2021-07-01 12:54:21 -0700 Comment on attachment 432384 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432384&action=review >>> Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:401 >>> + m_processingQueue->dispatch([this] { >> >> Why is this safe? What guarantees that |this| is still alive when the lambda runs? > > We are doing a dispatchSync in LocalSampleBufferDisplayLayer destructor. Ah, sneaky :) Seems safe indeed then. Sorry about the noise. 1774375 7 ews-feeder 2021-07-02 00:09:59 -0700 Committed r279500 (239352@main): <https://commits.webkit.org/239352@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432384. 432384 2021-06-28 05:18:27 -0700 2021-07-02 00:10:00 -0700 Patch bug-227444-20210628141826.patch text/plain 3748 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzAxZjk2ODBjYWFiMjEz NzkxYzg3NTgyYzc5MDkxOTA0MDdiZjlmZi4uOWM5YmU0M2YwOWE3NjY2NzlkNmM4NTAwYzIxODc3 ODU3MTFkZTYyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTI4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIExvY2FsU2FtcGxl QnVmZmVyRGlzcGxheUxheWVyOjpyZXF1ZXN0Tm90aWZpY2F0aW9uV2hlblJlYWR5Rm9yVmlkZW9E YXRhIGhvcCB0byBtYWluIHRocmVhZCBiZWZvcmUgaG9wcGluZyB0byBwcm9jZXNzaW5nIHRocmVh ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NDQ0 CisgICAgICAgIDxyZGFyOi8vNzk0MTMzNjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSXQgaXMgc2FmZXIgdG8gaG9wIHRvIG1haW4gdGhyZWFkIGlu IHJlcXVlc3ROb3RpZmljYXRpb25XaGVuUmVhZHlGb3JWaWRlb0RhdGEgY2FsbGJhY2sgc28gdGhh dCB3ZSBjYW4gY2hlY2sgd2Vha1RoaXMgc2FmZWx5LgorICAgICAgICBXaGVuIGluIG1haW4gdGhy ZWFkLCBob3AgdG8gcHJvY2Vzc2luZyB0aHJlYWQgaWYgTG9jYWxTYW1wbGVCdWZmZXJEaXNwbGF5 TGF5ZXIgaXMgYWxpdmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vb2JqYy9Mb2NhbFNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllci5tbToKKyAgICAgICAgKFdlYkNv cmU6OkxvY2FsU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyOjp+TG9jYWxTYW1wbGVCdWZmZXJEaXNw bGF5TGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6TG9jYWxTYW1wbGVCdWZmZXJEaXNwbGF5TGF5 ZXI6OnJlcXVlc3ROb3RpZmljYXRpb25XaGVuUmVhZHlGb3JWaWRlb0RhdGEpOgorCiAyMDIxLTA2 LTI4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWFsdGlt ZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYSBzaG91bGQgc3VwcG9ydCBvdGhlciBzYW1wbGUgcmF0 ZSB0aGFuIDQ4MDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vb2JqYy9Mb2NhbFNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllci5tbSBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0xvY2FsU2Ft cGxlQnVmZmVyRGlzcGxheUxheWVyLm1tCmluZGV4IDFhZDQzY2NmZjg0YzgzYTc2MzExYzAzNjU5 NjU2Y2IzZmJhZDQxZDcuLjhiYTU4MTBhYWUzZDc3N2RjNDcyZDhiNWZiYWQ4ZDdiYzA2YTI2ODcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9vYmpjL0xvY2FsU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLm1tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0xvY2FsU2FtcGxlQnVmZmVy RGlzcGxheUxheWVyLm1tCkBAIC0xNTYsNiArMTU2LDcgQEAgTG9jYWxTYW1wbGVCdWZmZXJEaXNw bGF5TGF5ZXI6OkxvY2FsU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyKFJldGFpblB0cjxBVlNhbXBs ZUIKICAgICAsIG1fZnJhbWVSYXRlTW9uaXRvcihbdGhpc10oYXV0byBpbmZvKSB7IG9uSXJyZWd1 bGFyRnJhbWVSYXRlTm90aWZpY2F0aW9uKGluZm8uZnJhbWVUaW1lLCBpbmZvLmxhc3RGcmFtZVRp bWUpOyB9KQogI2VuZGlmCiB7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKIH0KIAogdm9p ZCBMb2NhbFNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllcjo6aW5pdGlhbGl6ZShib29sIGhpZGVSb290 TGF5ZXIsIEludFNpemUgc2l6ZSwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChib29sIGRpZFN1Y2Nl ZWQpPiYmIGNhbGxiYWNrKQpAQCAtMTg2LDYgKzE4Nyw4IEBAIHZvaWQgTG9jYWxTYW1wbGVCdWZm ZXJEaXNwbGF5TGF5ZXI6OmluaXRpYWxpemUoYm9vbCBoaWRlUm9vdExheWVyLCBJbnRTaXplIHNp emUsCiAKIExvY2FsU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyOjp+TG9jYWxTYW1wbGVCdWZmZXJE aXNwbGF5TGF5ZXIoKQogeworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CisKICAgICBtX3By b2Nlc3NpbmdRdWV1ZS0+ZGlzcGF0Y2hTeW5jKFtdIHsgfSk7CiAKICAgICBtX3Byb2Nlc3NpbmdR dWV1ZSA9IG51bGxwdHI7CkBAIC0zOTEsMjAgKzM5NCwyMiBAQCB2b2lkIExvY2FsU2FtcGxlQnVm ZmVyRGlzcGxheUxheWVyOjpjbGVhckVucXVldWVkU2FtcGxlcygpCiB2b2lkIExvY2FsU2FtcGxl QnVmZmVyRGlzcGxheUxheWVyOjpyZXF1ZXN0Tm90aWZpY2F0aW9uV2hlblJlYWR5Rm9yVmlkZW9E YXRhKCkKIHsKICAgICBhdXRvIHdlYWtUaGlzID0gbWFrZVdlYWtQdHIoKnRoaXMpOwotICAgIFtt X3NhbXBsZUJ1ZmZlckRpc3BsYXlMYXllciByZXF1ZXN0TWVkaWFEYXRhV2hlblJlYWR5T25RdWV1 ZTptX3Byb2Nlc3NpbmdRdWV1ZS0+ZGlzcGF0Y2hRdWV1ZSgpIHVzaW5nQmxvY2s6XnsKKyAgICBb bV9zYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXIgcmVxdWVzdE1lZGlhRGF0YVdoZW5SZWFkeU9uUXVl dWU6ZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSB1c2luZ0Jsb2NrOl57CiAgICAgICAgIGlmICgh d2Vha1RoaXMpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgW21fc2FtcGxlQnVmZmVy RGlzcGxheUxheWVyIHN0b3BSZXF1ZXN0aW5nTWVkaWFEYXRhXTsKKyAgICAgICAgbV9wcm9jZXNz aW5nUXVldWUtPmRpc3BhdGNoKFt0aGlzXSB7CisgICAgICAgICAgICBbbV9zYW1wbGVCdWZmZXJE aXNwbGF5TGF5ZXIgc3RvcFJlcXVlc3RpbmdNZWRpYURhdGFdOwogCi0gICAgICAgIHdoaWxlICgh bV9wZW5kaW5nVmlkZW9TYW1wbGVRdWV1ZS5pc0VtcHR5KCkpIHsKLSAgICAgICAgICAgIGlmICgh W21fc2FtcGxlQnVmZmVyRGlzcGxheUxheWVyIGlzUmVhZHlGb3JNb3JlTWVkaWFEYXRhXSkgewot ICAgICAgICAgICAgICAgIHJlcXVlc3ROb3RpZmljYXRpb25XaGVuUmVhZHlGb3JWaWRlb0RhdGEo KTsKLSAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB3aGlsZSAoIW1fcGVuZGlu Z1ZpZGVvU2FtcGxlUXVldWUuaXNFbXB0eSgpKSB7CisgICAgICAgICAgICAgICAgaWYgKCFbbV9z YW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXIgaXNSZWFkeUZvck1vcmVNZWRpYURhdGFdKSB7CisgICAg ICAgICAgICAgICAgICAgIHJlcXVlc3ROb3RpZmljYXRpb25XaGVuUmVhZHlGb3JWaWRlb0RhdGEo KTsKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgICAgIH0KKyAgICAg ICAgICAgICAgICBhdXRvIHNhbXBsZSA9IG1fcGVuZGluZ1ZpZGVvU2FtcGxlUXVldWUudGFrZUZp cnN0KCk7CisgICAgICAgICAgICAgICAgZW5xdWV1ZVNhbXBsZUJ1ZmZlcihzYW1wbGUpOwogICAg ICAgICAgICAgfQotICAgICAgICAgICAgYXV0byBzYW1wbGUgPSBtX3BlbmRpbmdWaWRlb1NhbXBs ZVF1ZXVlLnRha2VGaXJzdCgpOwotICAgICAgICAgICAgZW5xdWV1ZVNhbXBsZUJ1ZmZlcihzYW1w bGUpOwotICAgICAgICB9CisgICAgICAgIH0pOwogICAgIH1dOwogfQogCg==