227436 2021-06-27 23:27:00 -0700 Remove "function declared ‘static’ but never defined" build warnings since r278971. 2021-06-29 16:49:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jh718.park jh718.park ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1772981 0 jh718.park 2021-06-27 23:27:00 -0700 Static functions should be put in cpp file so that it is visible only within the file, and header file should include extern functions with single implementation, not static functions with different impls for each cpp files usually. 1772982 1 432366 jh718.park 2021-06-27 23:28:46 -0700 Created attachment 432366 Patch 1773066 2 mcatanzaro 2021-06-28 07:58:15 -0700 *** Bug 227450 has been marked as a duplicate of this bug. *** 1773067 3 432366 mcatanzaro 2021-06-28 08:00:58 -0700 Comment on attachment 432366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432366&action=review [5/491] Building CXX object Source/JavaScriptCore/CMakeFi...edSources/unified-sources/UnifiedSource-f2e18ffc-27.cpp.o In file included from ../../Source/JavaScriptCore/runtime/LiteralParser.cpp:39, from JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-27.cpp:5: JavaScriptCore/DerivedSources/KeywordLookup.h:87:27: warning: ‘bool JSC::cannotBeIdentPartOrEscapeStart(LChar)’ declared ‘static’ but never defined [-Wunused-function] 87 | static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ JavaScriptCore/DerivedSources/KeywordLookup.h:88:27: warning: ‘bool JSC::cannotBeIdentPartOrEscapeStart(UChar)’ declared ‘static’ but never defined [-Wunused-function] 88 | static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(UChar); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ These warnings were introduced in r278971 "[JSC] Optimize JSON.parse with small data by changing Identifier pool mechanism." Problem is KeywordLookup.h does not define these functions and expects the translation unit that it is #included in to do so. Previously that was only Lexer.cpp. Problem is it's now also #included from LiteralParser.cpp, which does not define cannotBeIdentPartOrEscapeStart(LChar) or cannotBeIdentPartOrEscapeStart(UChar). > Source/JavaScriptCore/parser/Lexer.cpp:788 > -static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar c) > +ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar c) Problem is using ALWAYS_INLINE for a function that's not defined in the header doesn't make sense. We need to either: (a) Also remove ALWAYS_INLINE, or (b) Move the definitions of these functions to KeywordLookup.h (which is generated by KeywordLookupGenerator.py) 1773120 4 432366 ysuzuki 2021-06-28 10:29:53 -0700 Comment on attachment 432366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432366&action=review >> Source/JavaScriptCore/parser/Lexer.cpp:788 >> +ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar c) > > Problem is using ALWAYS_INLINE for a function that's not defined in the header doesn't make sense. We need to either: > > (a) Also remove ALWAYS_INLINE, or > (b) Move the definitions of these functions to KeywordLookup.h (which is generated by KeywordLookupGenerator.py) Please do not remove ALWAYS_INLINE. They are *super* critical performance-sensitive function, and removing that can cause severe perf impact on several benchmarks. 1773122 5 432366 mcatanzaro 2021-06-28 10:33:17 -0700 Comment on attachment 432366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432366&action=review >>> Source/JavaScriptCore/parser/Lexer.cpp:788 >>> +ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar c) >> >> Problem is using ALWAYS_INLINE for a function that's not defined in the header doesn't make sense. We need to either: >> >> (a) Also remove ALWAYS_INLINE, or >> (b) Move the definitions of these functions to KeywordLookup.h (which is generated by KeywordLookupGenerator.py) > > Please do not remove ALWAYS_INLINE. They are *super* critical performance-sensitive function, and removing that can cause severe perf impact on several benchmarks. Let's do (b) then. 1773132 6 mcatanzaro 2021-06-28 10:46:28 -0700 Hi Joonghun, let me know if you want to submit another patch. Otherwise, I can try. 1773277 7 jh718.park 2021-06-28 17:13:25 -0700 (In reply to Michael Catanzaro from comment #6) > Hi Joonghun, let me know if you want to submit another patch. Otherwise, I > can try. Hi Michael, I will do the (b) in the next patchset. Please review that change:) 1773342 8 jh718.park 2021-06-29 00:39:07 -0700 (In reply to Joonghun Park from comment #7) > (In reply to Michael Catanzaro from comment #6) > > Hi Joonghun, let me know if you want to submit another patch. Otherwise, I > > can try. > > Hi Michael, I will do the (b) in the next patchset. > Please review that change:) Hi, Michael. While I was trying to move cannotBeIdentPartOrEscapeStart, I found that the depedent functions and variables seemed not appropriate to move to KeywordLookup.h. For example, if we move isSingleCharacterIdentPart(UChar c), then we need to move isIdentPart(CharacterType c) and typesOfLatin1Characters[256] array too, and it seems that typesOfLatin1Characters should be used only in Lexer.cpp translation unit. And if we only move the declaration of isIdentStart(CharacterType c), then it goes to the same place we are currently in. So I looked around some articles, 1) https://stackoverflow.com/questions/5057021/why-are-c-inline-functions-in-the-header 2) https://en.cppreference.com/w/cpp/language/inline and it seems that inline function's definition doesn't have to be placed in header file as long as all the definitions are identical(that's why usually inline function's definition is put in header, to keep it identical for all cpp files including the header file). So I wonder about 2 options below. a) If it's ok to keep the inline definitions in cpp files as it is now, and just remove static keyword(as the current patchset does). b) Or maybe simply we can keep 'static inline' keywords as it is now, and just add empty definitions in LiteralParser.cpp as below. static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar) { return false; } static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(UChar) { return false; } I confirmed that doing this removed the build warnings, warning: ‘bool JSC::cannotBeIdentPartOrEscapeStart()’ declared ‘static’ but never defined [-Wunused-function], but the cons is that it seems those functions has no meaning in LiteralParser.cpp. 1773387 9 mcatanzaro 2021-06-29 06:01:13 -0700 (In reply to Joonghun Park from comment #8) > So I wonder about 2 options below. > > a) If it's ok to keep the inline definitions in cpp files as it is now, > and just remove static keyword(as the current patchset does). I don't know. Under your proposal, these functions would not be defined in LiteralParser.cpp at all. I would avoid this. > b) Or maybe simply we can keep 'static inline' keywords as it is now, > and just add empty definitions in LiteralParser.cpp as below. > > static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar) > { > return false; > } > > static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(UChar) > { > return false; > } (b) would definitely be OK. I would make it RELEASE_ASSERT_NOT_REACHED() rather than return false. That should be perfectly safe. 1773406 10 jh718.park 2021-06-29 07:54:01 -0700 (In reply to Michael Catanzaro from comment #9) > (In reply to Joonghun Park from comment #8) > > So I wonder about 2 options below. > > > > a) If it's ok to keep the inline definitions in cpp files as it is now, > > and just remove static keyword(as the current patchset does). > > I don't know. Under your proposal, these functions would not be defined in > LiteralParser.cpp at all. I would avoid this. > > > b) Or maybe simply we can keep 'static inline' keywords as it is now, > > and just add empty definitions in LiteralParser.cpp as below. > > > > static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar) > > { > > return false; > > } > > > > static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(UChar) > > { > > return false; > > } > > (b) would definitely be OK. I would make it RELEASE_ASSERT_NOT_REACHED() > rather than return false. That should be perfectly safe. Thank you for your review. I will upload a patchset with (b). 1773419 11 432484 jh718.park 2021-06-29 09:19:39 -0700 Created attachment 432484 Patch 1773481 12 432484 mcatanzaro 2021-06-29 12:02:17 -0700 Comment on attachment 432484 Patch Maybe Yusuke will have a better proposal for how to reorganize the code to avoid this, but it seems like a pretty good solution for now. Thanks Joonghun! 1773608 13 jh718.park 2021-06-29 16:13:24 -0700 (In reply to Michael Catanzaro from comment #12) > Comment on attachment 432484 [details] > Patch > > Maybe Yusuke will have a better proposal for how to reorganize the code to > avoid this, but it seems like a pretty good solution for now. Thanks > Joonghun! I got it:) Thank you for your help, Michael. I will land this for now. 1773621 14 ews-feeder 2021-06-29 16:48:54 -0700 Committed r279393 (239258@main): <https://commits.webkit.org/239258@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432484. 1773622 15 webkit-bug-importer 2021-06-29 16:49:18 -0700 <rdar://problem/79939462> 432366 2021-06-27 23:28:46 -0700 2021-06-29 09:19:36 -0700 Patch bug-227436-20210628152844.patch text/plain 3390 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ZWVhOTBkZGQwMTU2NzY2MDJkMzlkOTJiNTU2OWI3OGY1MDE4MTlhLi45NDJkZTQzMGM1ZGIxZGMw ZjM0MzQxODEzMTQzMTczMzg2YTU3ZmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAyMS0wNi0yNyAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgQ2hhbmdlIHN0YXRpYyBmdW50aW9uIHRvIGV4dGVybiBpbiBLZXl3 b3JkTG9va3VwLmguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjc0MzYKKworICAgICAgICBUaGlzIHBhdGNoIHJlbW92ZXMgdGhlIGdjYyB3YXJuaW5n IGJlbG93LgorICAgICAgICB3YXJuaW5nOiDigJhib29sIEpTQzo6Y2Fubm90QmVJZGVudFBhcnRP ckVzY2FwZVN0YXJ0KCnigJkgZGVjbGFyZWQg4oCYc3RhdGlj4oCZIGJ1dCBuZXZlciBkZWZpbmVk IFstV3VudXNlZC1mdW5jdGlvbl0KKworICAgICAgICBTdGF0aWMgZnVuY3Rpb25zIHNob3VsZCBi ZSBwdXQgaW4gY3BwIGZpbGUgc28gdGhhdCBpdCBpcyB2aXNpYmxlIG9ubHkKKyAgICAgICAgd2l0 aGluIHRoZSBmaWxlLCBhbmQgaGVhZGVyIGZpbGUgc2hvdWxkIGluY2x1ZGUgZXh0ZXJuIGZ1bmN0 aW9ucworICAgICAgICB3aXRoIHNpbmdsZSBpbXBsZW1lbnRhdGlvbiwgbm90IHN0YXRpYyBmdW5j dGlvbnMgd2l0aCBkaWZmZXJlbnQgaW1wbHMKKyAgICAgICAgZm9yIGVhY2ggY3BwIGZpbGVzIHVz dWFsbHkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBLZXl3b3JkTG9va3VwR2VuZXJhdG9yLnB5OgorICAgICAgICAoVHJpZS5wcmludEFzQyk6Cisg ICAgICAgICogcGFyc2VyL0xleGVyLmNwcDoKKyAgICAgICAgKEpTQzo6Y2Fubm90QmVJZGVudFBh cnRPckVzY2FwZVN0YXJ0KToKKwogMjAyMS0wNi0yNSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1 ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzkyNjYu CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvS2V5d29yZExvb2t1cEdlbmVyYXRv ci5weSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9LZXl3b3JkTG9va3VwR2VuZXJhdG9yLnB5Cmlu ZGV4IDgwMjUxYTg4MDZkZmE1NTgwMzQ2YWM2MThiNTBhZDFkYTg3NjUzZGIuLjcyZjI3OTU4MTNi MTNlMDE2NzFhNzRhMTFjOGFlOTMzZTAzZDlhNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9LZXl3b3JkTG9va3VwR2VuZXJhdG9yLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9LZXl3b3JkTG9va3VwR2VuZXJhdG9yLnB5CkBAIC0xODQsMTAgKzE4NCwxMCBAQCBjbGFz cyBUcmllOgogICAgIGRlZiBwcmludEFzQyhzZWxmKToKICAgICAgICAgcHJpbnQoIm5hbWVzcGFj ZSBKU0MgeyIpCiAgICAgICAgIHByaW50KCIiKQotICAgICAgICBwcmludCgic3RhdGljIEFMV0FZ U19JTkxJTkUgYm9vbCBjYW5ub3RCZUlkZW50UGFydE9yRXNjYXBlU3RhcnQoTENoYXIpOyIpCi0g ICAgICAgIHByaW50KCJzdGF0aWMgQUxXQVlTX0lOTElORSBib29sIGNhbm5vdEJlSWRlbnRQYXJ0 T3JFc2NhcGVTdGFydChVQ2hhcik7IikKKyAgICAgICAgcHJpbnQoIkFMV0FZU19JTkxJTkUgYm9v bCBjYW5ub3RCZUlkZW50UGFydE9yRXNjYXBlU3RhcnQoTENoYXIpOyIpCisgICAgICAgIHByaW50 KCJBTFdBWVNfSU5MSU5FIGJvb2wgY2Fubm90QmVJZGVudFBhcnRPckVzY2FwZVN0YXJ0KFVDaGFy KTsiKQogICAgICAgICAjIG1heCBsZW5ndGggKyAxIHNvIHdlIGRvbid0IG5lZWQgdG8gZG8gYW55 IGJvdW5kcyBjaGVja2luZyBhdCBhbGwKLSAgICAgICAgcHJpbnQoInN0YXRpYyBjb25zdGV4cHIg aW50IG1heFRva2VuTGVuZ3RoID0gJWQ7IiAlIChzZWxmLm1heExlbmd0aCgpICsgMSkpCisgICAg ICAgIHByaW50KCJjb25zdGV4cHIgaW50IG1heFRva2VuTGVuZ3RoID0gJWQ7IiAlIChzZWxmLm1h eExlbmd0aCgpICsgMSkpCiAgICAgICAgIHByaW50KCIiKQogICAgICAgICBwcmludCgidGVtcGxh dGUgPD4iKQogICAgICAgICBwcmludCgidGVtcGxhdGUgPGJvb2wgc2hvdWxkQ3JlYXRlSWRlbnRp Zmllcj4gQUxXQVlTX0lOTElORSBKU1Rva2VuVHlwZSBMZXhlcjxVQ2hhcj46OnBhcnNlS2V5d29y ZChKU1Rva2VuRGF0YSogZGF0YSkiKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3BhcnNlci9MZXhlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNw cAppbmRleCAxOWM4MTVmODViMzk0YTcyMDliYmE1NjM3Y2JkNjQwZWRmN2VjYWQ5Li5jZWVhYzQ2 YTUxNmUxNjFkNWQyZGQ3ODIwNDgxYjRlYThlZjcyYTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cGFyc2VyL0xleGVyLmNwcApAQCAtNzg1LDE0ICs3ODUsMTQgQEAgc3RhdGljIEFMV0FZU19JTkxJ TkUgYm9vbCBpc1NpbmdsZUNoYXJhY3RlcklkZW50UGFydChVQ2hhciBjKQogICAgIHJldHVybiAh VTE2X0lTX1NVUlJPR0FURShjKSAmJiBpc0lkZW50UGFydChzdGF0aWNfY2FzdDxVQ2hhcjMyPihj KSk7CiB9CiAKLXN0YXRpYyBBTFdBWVNfSU5MSU5FIGJvb2wgY2Fubm90QmVJZGVudFBhcnRPckVz Y2FwZVN0YXJ0KExDaGFyIGMpCitBTFdBWVNfSU5MSU5FIGJvb2wgY2Fubm90QmVJZGVudFBhcnRP ckVzY2FwZVN0YXJ0KExDaGFyIGMpCiB7CiAgICAgcmV0dXJuICFpc0lkZW50UGFydChjKSAmJiBj ICE9ICdcXCc7CiB9CiAKIC8vIE5PVEU6IFRoaXMgbWF5IGdpdmUgZ2l2ZSBmYWxzZSBuZWdhdGl2 ZXMgKGZvciBub24tYXNjaWkpIGJ1dCB3b24ndCBnaXZlIGZhbHNlIHBvc2l0aXR2ZXMuCiAvLyBU aGlzIG1lYW5zIGl0IGNhbiBiZSB1c2VkIHRvIGRldGVjdCB0aGUgZW5kIG9mIGEga2V5d29yZCAo YWxsIGtleXdvcmRzIGFyZSBhc2NpaSkKLXN0YXRpYyBBTFdBWVNfSU5MSU5FIGJvb2wgY2Fubm90 QmVJZGVudFBhcnRPckVzY2FwZVN0YXJ0KFVDaGFyIGMpCitBTFdBWVNfSU5MSU5FIGJvb2wgY2Fu bm90QmVJZGVudFBhcnRPckVzY2FwZVN0YXJ0KFVDaGFyIGMpCiB7CiAgICAgaWYgKExJS0VMWShp c0xhdGluMShjKSkpCiAgICAgICAgIHJldHVybiBjYW5ub3RCZUlkZW50UGFydE9yRXNjYXBlU3Rh cnQoc3RhdGljX2Nhc3Q8TENoYXI+KGMpKTsK 432484 2021-06-29 09:19:39 -0700 2021-06-29 16:48:55 -0700 Patch bug-227436-20210630011938.patch text/plain 1800 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi YjBlYzcxNzhiNGM3NDI5MzNlYjA3Zjk1MjM4Y2M0MDFjOTZhN2MzLi5lMGE4NmEzMzFiZjFlOTM2 ZDNjZWNkNDZmYjVlMjA2YmZiMjZhN2VjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wNi0yOSAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgUmVtb3ZlICJmdW5jdGlvbiBkZWNsYXJlZCDigJhzdGF0aWPigJkg YnV0IG5ldmVyIGRlZmluZWQiIGJ1aWxkIHdhcm5pbmdzIHNpbmNlIHIyNzg5NzEuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc0MzYKKworICAgICAg ICBUaGlzIHBhdGNoIHJlbW92ZXMgdGhlIGJ1aWxkIHdhcm5pbmdzIGJlbG93LgorICAgICAgICB3 YXJuaW5nOiDigJhib29sIEpTQzo6Y2Fubm90QmVJZGVudFBhcnRPckVzY2FwZVN0YXJ0KExDaGFy KeKAmSBkZWNsYXJlZCDigJhzdGF0aWPigJkgYnV0IG5ldmVyIGRlZmluZWQgWy1XdW51c2VkLWZ1 bmN0aW9uXQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcnVudGltZS9MaXRlcmFsUGFyc2VyLmNwcDogQWRkIGRlZmluaXRpb25zIGZvciBjYW5ub3RC ZUlkZW50UGFydE9yRXNjYXBlU3RhcnQuCisgICAgICAgIChKU0M6OmNhbm5vdEJlSWRlbnRQYXJ0 T3JFc2NhcGVTdGFydCk6CisKIDIwMjEtMDYtMjggIFlpamlhIEh1YW5nICA8eWlqaWFfaHVhbmdA YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIG5ldyBwYXR0ZXJuIHRvIGluc3RydWN0aW9uIHNl bGVjdG9yIHRvIHVzZSBCSUMgc3VwcG9ydGVkIGJ5IEFSTTY0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9MaXRlcmFsUGFyc2VyLmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0xpdGVyYWxQYXJzZXIuY3BwCmluZGV4IGQxNDQ3ZTIzYTg4ODQ3Zjhi MWFiNTNlMjRlZGU5OTJmOWZiZmU5ZmIuLjQ0YjljMWMyNjUxMzJjZTI1ZTE4M2YwYTUyZGU1NWFl OThkN2U0OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0xpdGVy YWxQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0xpdGVyYWxQ YXJzZXIuY3BwCkBAIC0xODksNiArMTg5LDE2IEBAIEFMV0FZU19JTkxJTkUgSWRlbnRpZmllciBM aXRlcmFsUGFyc2VyPENoYXJUeXBlPjo6bWFrZUlkZW50aWZpZXIoY29uc3QgTGl0ZXJhbENoCiAg ICAgcmV0dXJuIHJlc3VsdDsKIH0KIAorc3RhdGljIEFMV0FZU19JTkxJTkUgYm9vbCBjYW5ub3RC ZUlkZW50UGFydE9yRXNjYXBlU3RhcnQoTENoYXIpCit7CisgICAgUkVMRUFTRV9BU1NFUlRfTk9U X1JFQUNIRUQoKTsKK30KKworc3RhdGljIEFMV0FZU19JTkxJTkUgYm9vbCBjYW5ub3RCZUlkZW50 UGFydE9yRXNjYXBlU3RhcnQoVUNoYXIpCit7CisgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNI RUQoKTsKK30KKwogLy8gMjU2IExhdGluLTEgY29kZXMKIHN0YXRpYyBjb25zdGV4cHIgY29uc3Qg VG9rZW5UeXBlIHRva2VuVHlwZXNPZkxhdGluMUNoYXJhY3RlcnNbMjU2XSA9IHsKIC8qICAgMCAt IE51bGwgICAgICAgICAgICAgICAqLyBUb2tFcnJvciwK