227435 2021-06-27 22:31:52 -0700 Used of non-existing symbols on Windows 2023-10-14 04:15:12 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=227250 InRadar P2 Normal --- 1 jean-yves.avenard webkit-unassigned ahmad.saleem792 eric.carlson fujii webkit-bug-importer oldest_to_newest 1772978 0 jean-yves.avenard 2021-06-27 22:31:52 -0700 Seen in bug 227250 When I removed some symbols from PAL/CoreMediaSoftLink.h as they aren't defined on Windows ; it caused a compilation error on the Windows bots: :\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(265,38): error C2065: 'kCMTextMarkupAttribute_ForegroundColorARGB': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(277,38): error C2065: 'kCMTextMarkupAttribute_BackgroundColorARGB': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKi tBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(289,38): error C2065: 'kCMTextMarkupAttribute_CharacterBackgroundColorARGB': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(515,42): error C3861: 'CMFormatDescriptionGetExtensions': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(519,121): error C2065: 'kCMFormatDescriptionExtension_SampleDescriptionExtensionAtoms': undeclared identifier [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Sour ce\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(562,23): error C3861: 'CMSampleBufferGetSampleTimingInfo': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(570,36): error C3861: 'CMSampleBufferGetDataBuffer': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(571,27): error C3861: 'CMBlockBufferGetDataLength': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\ Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(578,5): error C3861: 'CMBlockBufferCopyDataBytes': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\avfoundation\InbandTextTrackPrivateAVF.cpp(582,25): error C3861: 'CMSampleBufferGetFormatDescription': identifier not found [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] So they are used in code compiled on Windows, but those symbols can't be resolved which would lead to either an assert or a null deref at run time; so either we shouldn't use them at all or they should be added to the Framework (unlikely) 1772979 1 webkit-bug-importer 2021-06-27 22:32:19 -0700 <rdar://problem/79849694> 1985070 2 ahmad.saleem792 2023-10-14 03:15:06 -0700 @Fuji - is this applicable for win-cairo build? From below, it seems to look like 'AppleWin', I think we can mark this as "RESOLVED CONFIGURATION CHANGED".