227394 2021-06-25 04:06:49 -0700 [css-flexbox] Cleanup OverridingSizesScope RAII class 2021-06-25 04:24:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 svillar svillar cdumez changseok esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan pdr rbuis simon.fraser svillar webkit-bug-importer zalan oldest_to_newest 1772617 0 svillar 2021-06-25 04:06:49 -0700 [css-flexbox] Cleanup OverridingSizesScope RAII class 1772618 1 432254 svillar 2021-06-25 04:12:26 -0700 Created attachment 432254 Patch 1772619 2 432254 rbuis 2021-06-25 04:15:52 -0700 Comment on attachment 432254 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432254&action=review > Source/WebCore/ChangeLog:8 > + Int r279268 we added a new RAII class which adds an overriding sizes free scope to perform In. 1772620 3 svillar 2021-06-25 04:23:10 -0700 Committed r279274 (239153@main): <https://commits.webkit.org/239153@main> 1772621 4 webkit-bug-importer 2021-06-25 04:24:16 -0700 <rdar://problem/79771969> 432254 2021-06-25 04:12:26 -0700 2021-06-25 04:15:52 -0700 Patch bug-227394-20210625131224.patch text/plain 5761 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODIwNTNjYzU1ODdhOTc0 YTZlM2RjNmUzNzg5N2RhYTAzZWEyNDFiZS4uZjRhZGNiZjA4Mzk2ZWE3ODU4NWFiMjI3NGFhYzJk NTBiM2MwOGU2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTA2LTI1ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxl eGJveF0gQ2xlYW51cCBPdmVycmlkaW5nU2l6ZXNTY29wZSBSQUlJIGNsYXNzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjczOTQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnQgcjI3OTI2OCB3ZSBhZGRl ZCBhIG5ldyBSQUlJIGNsYXNzIHdoaWNoIGFkZHMgYW4gb3ZlcnJpZGluZyBzaXplcyBmcmVlIHNj b3BlIHRvIHBlcmZvcm0KKyAgICAgICAgbGF5b3V0IGNvbXB1dGF0aW9ucy4gVGhhdCBjbGFzcyBo ZWF2aWx5IHVzZXMgdGhlIGRpZmZlcmVudCBzZXQvZ2V0L2NsZWFyIG1ldGhvZHMgZm9yIG92ZXJy aWRpbmcKKyAgICAgICAgc2l6ZXMuIFdlIGNhbiB1c2UgYSBtYWNybyB3aXRoIHN1YnNpdHV0aW9u cyB0aGVyZSB0byByZWR1Y2UgdGhlIGFtb3VudCBvZiByZXF1aXJlZCBjb2RlLgorCisgICAgICAg IEFsc28gbW92aW5nIHRoZSBjb21wdXRlQ2hpbGRJbnRyaW5zaWNMb2dpY2FsV2lkdGhzKCkgbWV0 aG9kIHRvIHRoZSBwcml2YXRlIHNlY3Rpb24gYXMgaXQgZG9lcworICAgICAgICBub3QgcmVxdWly ZSBwcm90ZWN0ZWQgdmlzaWJpbGl0eS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgaXQncyBq dXN0IGEgY29kZSByZWZhY3RvcmluZyB0aGF0IGRvZXMgbm90IG1vZGlmeSB0aGUgZnVuY3Rpb25h bGl0eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpPdmVycmlkaW5nU2l6ZXNTY29wZTo6T3ZlcnJpZGluZ1NpemVzU2NvcGUp OgorICAgICAgICAoV2ViQ29yZTo6T3ZlcnJpZGluZ1NpemVzU2NvcGU6On5PdmVycmlkaW5nU2l6 ZXNTY29wZSk6CisgICAgICAgIChXZWJDb3JlOjpPdmVycmlkaW5nU2l6ZXNTY29wZTo6c2V0T3JD bGVhck92ZXJyaWRpbmdTaXplKTogRGVsZXRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy RmxleGlibGVCb3guaDoKKwogMjAyMS0wNi0yNSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29u QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW2Nzcy1zY3JvbGwtc25hcF0gU2ltcGxpZnkgc25hcCBw b2ludCBzZWxlY3Rpb24gaGVscGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJGbGV4aWJsZUJveC5jcHAKaW5kZXggNTBiNWE3NmM0ZmI2ZTEwZGU3ZjczZTM2NGJhOTczNDM5 NTZlOTc5Mi4uODZmM2E4NTEwNjZiMWY0YmU1MWJiZDI1NzgxZDJiYmVhMjJjNWQ0YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCkBAIC0xNTMs NiArMTUzLDE0IEBAIHZvaWQgUmVuZGVyRmxleGlibGVCb3g6OmNvbXB1dGVJbnRyaW5zaWNMb2dp Y2FsV2lkdGhzKExheW91dFVuaXQmIG1pbkxvZ2ljYWxXaWR0CiAgICAgYWRkU2Nyb2xsYmFyV2lk dGgoKTsKIH0KIAorI2RlZmluZSBTRVRfT1JfQ0xFQVJfT1ZFUlJJRElOR19TSVpFKGJveCwgU2l6 ZVR5cGUsIHNpemUpICAgXAorICAgIHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICBpZiAoc2l6ZSkgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICAgICAgYm94LnNldE92ZXJyaWRp bmdMb2dpY2FsIyNTaXplVHlwZSgqc2l6ZSk7ICAgICAgXAorICAgICAgICBlbHNlICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICAgICAgYm94 LmNsZWFyT3ZlcnJpZGluZ0xvZ2ljYWwjI1NpemVUeXBlKCk7ICAgICAgICAgXAorICAgIH0KKwog Ly8gUkFJSSBjbGFzcyB3aGljaCBkZWZpbmVzIGEgc2NvcGUgaW4gd2hpY2ggb3ZlcnJpZGluZyBz aXplcyBvZiBhIGJveCBhcmUgZWl0aGVyOgogLy8gICAxKSByZXBsYWNlZCBieSBvdGhlciBzaXpl IGluIG9uZSBheGlzIGlmIHNpemUgaXMgc3BlY2lmaWVkCiAvLyAgIDIpIGNsZWFyZWQgaW4gYm90 aCBheGlzIGlmIHNpemUgPT0gc3RkOjpudWxsb3B0CkBAIC0xNzUsNDAgKzE4MywyNCBAQCBwdWJs aWM6CiAgICAgICAgIGlmIChheGlzID09IEF4aXM6OkJvdGggfHwgYXhpcyA9PSBBeGlzOjpJbmxp bmUpIHsKICAgICAgICAgICAgIGlmIChib3guaGFzT3ZlcnJpZGluZ0xvZ2ljYWxXaWR0aCgpKQog ICAgICAgICAgICAgICAgIG1fb3ZlcnJpZGluZ1dpZHRoID0gYm94Lm92ZXJyaWRpbmdMb2dpY2Fs V2lkdGgoKTsKLSAgICAgICAgICAgIHNldE9yQ2xlYXJPdmVycmlkaW5nU2l6ZShzaXplLCBBeGlz OjpJbmxpbmUpOworICAgICAgICAgICAgU0VUX09SX0NMRUFSX09WRVJSSURJTkdfU0laRShtX2Jv eCwgV2lkdGgsIHNpemUpOwogICAgICAgICB9CiAgICAgICAgIGlmIChheGlzID09IEF4aXM6OkJv dGggfHwgYXhpcyA9PSBBeGlzOjpCbG9jaykgewogICAgICAgICAgICAgaWYgKGJveC5oYXNPdmVy cmlkaW5nTG9naWNhbEhlaWdodCgpKQogICAgICAgICAgICAgICAgIG1fb3ZlcnJpZGluZ0hlaWdo dCA9IGJveC5vdmVycmlkaW5nTG9naWNhbEhlaWdodCgpOwotICAgICAgICAgICAgc2V0T3JDbGVh ck92ZXJyaWRpbmdTaXplKHNpemUsIEF4aXM6OkJsb2NrKTsKKyAgICAgICAgICAgIFNFVF9PUl9D TEVBUl9PVkVSUklESU5HX1NJWkUobV9ib3gsIEhlaWdodCwgc2l6ZSk7CiAgICAgICAgIH0KICAg ICB9CiAgICAgfk92ZXJyaWRpbmdTaXplc1Njb3BlKCkKICAgICB7Ci0gICAgICAgIGlmIChtX2F4 aXMgPT0gQXhpczo6Qm90aCB8fCBtX2F4aXMgPT0gQXhpczo6SW5saW5lKQotICAgICAgICAgICAg c2V0T3JDbGVhck92ZXJyaWRpbmdTaXplKG1fb3ZlcnJpZGluZ1dpZHRoLCBBeGlzOjpJbmxpbmUp OworICAgICAgICBpZiAobV9heGlzID09IEF4aXM6OklubGluZSB8fCBtX2F4aXMgPT0gQXhpczo6 Qm90aCkKKyAgICAgICAgICAgIFNFVF9PUl9DTEVBUl9PVkVSUklESU5HX1NJWkUobV9ib3gsIFdp ZHRoLCBtX292ZXJyaWRpbmdXaWR0aCk7CiAKLSAgICAgICAgaWYgKG1fYXhpcyA9PSBBeGlzOjpC b3RoIHx8IG1fYXhpcyA9PSBBeGlzOjpCbG9jaykKLSAgICAgICAgICAgIHNldE9yQ2xlYXJPdmVy cmlkaW5nU2l6ZShtX292ZXJyaWRpbmdIZWlnaHQsIEF4aXM6OkJsb2NrKTsKKyAgICAgICAgaWYg KG1fYXhpcyA9PSBBeGlzOjpCbG9jayB8fCBtX2F4aXMgPT0gQXhpczo6Qm90aCkKKyAgICAgICAg ICAgIFNFVF9PUl9DTEVBUl9PVkVSUklESU5HX1NJWkUobV9ib3gsIEhlaWdodCwgbV9vdmVycmlk aW5nSGVpZ2h0KTsKICAgICB9CiAKIHByaXZhdGU6Ci0gICAgdm9pZCBzZXRPckNsZWFyT3ZlcnJp ZGluZ1NpemUoc3RkOjpvcHRpb25hbDxMYXlvdXRVbml0PiBzaXplLCBBeGlzIGF4aXMpCi0gICAg ewotICAgICAgICBBU1NFUlQoYXhpcyAhPSBBeGlzOjpCb3RoKTsKLSAgICAgICAgaWYgKHNpemUp IHsKLSAgICAgICAgICAgIGlmIChheGlzID09IEF4aXM6OklubGluZSkKLSAgICAgICAgICAgICAg ICBtX2JveC5zZXRPdmVycmlkaW5nTG9naWNhbFdpZHRoKCpzaXplKTsKLSAgICAgICAgICAgIGVs c2UKLSAgICAgICAgICAgICAgICBtX2JveC5zZXRPdmVycmlkaW5nTG9naWNhbEhlaWdodCgqc2l6 ZSk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLSAgICAgICAgaWYgKGF4aXMgPT0g QXhpczo6SW5saW5lKQotICAgICAgICAgICAgbV9ib3guY2xlYXJPdmVycmlkaW5nTG9naWNhbFdp ZHRoKCk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1fYm94LmNsZWFyT3ZlcnJpZGluZ0xv Z2ljYWxIZWlnaHQoKTsKLSAgICB9Ci0KICAgICBSZW5kZXJCb3gmIG1fYm94OwogICAgIEF4aXMg bV9heGlzOwogICAgIHN0ZDo6b3B0aW9uYWw8TGF5b3V0VW5pdD4gbV9vdmVycmlkaW5nV2lkdGg7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3gu aCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oCmluZGV4IDNi OTA2YTZmZTExMzJlNzc1MTdlZTg0Yzk5YWM5NTdhNzZjYTVmOWYuLmQyYzAyODc5NzQ5Y2ExNjVi OGNmMzEyZjhkNDU4NzM4MzVkMzVmMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJGbGV4aWJsZUJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJGbGV4aWJsZUJveC5oCkBAIC04OSw3ICs4OSw2IEBAIHB1YmxpYzoKIAogcHJvdGVjdGVk OgogICAgIHZvaWQgY29tcHV0ZUludHJpbnNpY0xvZ2ljYWxXaWR0aHMoTGF5b3V0VW5pdCYgbWlu TG9naWNhbFdpZHRoLCBMYXlvdXRVbml0JiBtYXhMb2dpY2FsV2lkdGgpIGNvbnN0IG92ZXJyaWRl OwotICAgIHZvaWQgY29tcHV0ZUNoaWxkSW50cmluc2ljTG9naWNhbFdpZHRocyhSZW5kZXJPYmpl Y3QmLCBMYXlvdXRVbml0JiBtaW5Mb2dpY2FsV2lkdGgsIExheW91dFVuaXQmIG1heExvZ2ljYWxX aWR0aCkgY29uc3Qgb3ZlcnJpZGU7CiAKICAgICBib29sIHNob3VsZFJlc2V0Q2hpbGRMb2dpY2Fs SGVpZ2h0QmVmb3JlTGF5b3V0KGNvbnN0IFJlbmRlckJveCYpIGNvbnN0IG92ZXJyaWRlIHsgcmV0 dXJuIG1fc2hvdWxkUmVzZXRDaGlsZExvZ2ljYWxIZWlnaHRCZWZvcmVMYXlvdXQ7IH0KIApAQCAt MTQ2LDYgKzE0NSw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBjaGlsZEhhc0NvbXB1dGFibGVBc3Bl Y3RSYXRpbyhjb25zdCBSZW5kZXJCb3gmKSBjb25zdDsKICAgICBib29sIGNoaWxkSGFzQ29tcHV0 YWJsZUFzcGVjdFJhdGlvQW5kQ3Jvc3NTaXplSXNDb25zaWRlcmVkRGVmaW5pdGUoY29uc3QgUmVu ZGVyQm94Jik7CiAgICAgYm9vbCBjaGlsZENyb3NzU2l6ZVNob3VsZFVzZUNvbnRhaW5lckNyb3Nz U2l6ZShjb25zdCBSZW5kZXJCb3gmIGNoaWxkKSBjb25zdDsKKyAgICB2b2lkIGNvbXB1dGVDaGls ZEludHJpbnNpY0xvZ2ljYWxXaWR0aHMoUmVuZGVyT2JqZWN0JiwgTGF5b3V0VW5pdCYgbWluTG9n aWNhbFdpZHRoLCBMYXlvdXRVbml0JiBtYXhMb2dpY2FsV2lkdGgpIGNvbnN0IG92ZXJyaWRlOwog ICAgIExheW91dFVuaXQgY29tcHV0ZU1haW5TaXplRnJvbUFzcGVjdFJhdGlvVXNpbmcoY29uc3Qg UmVuZGVyQm94JiBjaGlsZCwgTGVuZ3RoIGNyb3NzU2l6ZUxlbmd0aCkgY29uc3Q7CiAgICAgdm9p ZCBzZXRGbG93QXdhcmVMb2NhdGlvbkZvckNoaWxkKFJlbmRlckJveCYgY2hpbGQsIGNvbnN0IExh eW91dFBvaW50Jik7CiAgICAgTGF5b3V0VW5pdCBjb21wdXRlSW5uZXJGbGV4QmFzZVNpemVGb3JD aGlsZChSZW5kZXJCb3gmIGNoaWxkLCBMYXlvdXRVbml0IG1haW5BeGlzQm9yZGVyQW5kUGFkZGlu Zyk7Cg==