227386 2021-06-24 23:33:11 -0700 Fix null crash in AudioMediaStreamTrackRendererCocoa::start 2021-06-25 12:51:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1772559 0 achristensen 2021-06-24 23:33:11 -0700 Fix null crash in AudioMediaStreamTrackRendererCocoa::start 1772560 1 432240 achristensen 2021-06-24 23:37:13 -0700 Created attachment 432240 Patch 1772561 2 achristensen 2021-06-24 23:37:16 -0700 <rdar://problem/79045120> 1772623 3 432240 youennf 2021-06-25 05:06:48 -0700 Comment on attachment 432240 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432240&action=review > Source/WebCore/ChangeLog:11 > + has an early return or hasn't been called yet. It probably means we have an early return, which means we have an error case when creating the audio unit. Release logging would tell us what actually happened. 1772743 4 432240 achristensen 2021-06-25 12:41:36 -0700 Comment on attachment 432240 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432240&action=review >> Source/WebCore/ChangeLog:11 >> + has an early return or hasn't been called yet. > > It probably means we have an early return, which means we have an error case when creating the audio unit. > Release logging would tell us what actually happened. There's already release logging in LocalAudioMediaStreamTrackRendererInternalUnit::retrieveFormatDescription 1772746 5 ews-feeder 2021-06-25 12:51:42 -0700 Committed r279296 (239172@main): <https://commits.webkit.org/239172@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432240. 432240 2021-06-24 23:37:13 -0700 2021-06-25 12:51:43 -0700 Patch bug-227386-20210624233713.patch text/plain 2047 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI5YWY3MzQ5ZjJhNWU5 MjAzNDRiMDdiMmYwZWFkODZkYzYzYTUyMC4uZDc3ODY4MjQyZWFmOWRkM2I0NGRiMjQwOGEzZTdk ZDIxZDhhYjk3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA2LTI0ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IG51 bGwgY3Jhc2ggaW4gQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJDb2NvYTo6c3RhcnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzM4NgorICAg ICAgICA8cmRhcjovLzc5MDQ1MTIwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVySW50ZXJuYWxVbml0 TWFuYWdlcjo6UHJveHk6On5Qcm94eSBjYWxscyB0aG9zZSBjYWxsYmFja3Mgd2l0aCBudWxscHRy LgorICAgICAgICBTbyBjYW4gTG9jYWxBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckludGVy bmFsVW5pdDo6cmV0cmlldmVGb3JtYXREZXNjcmlwdGlvbiB3aGVuIGNyZWF0ZUF1ZGlvVW5pdElm TmVlZGVkCisgICAgICAgIGhhcyBhbiBlYXJseSByZXR1cm4gb3IgaGFzbid0IGJlZW4gY2FsbGVk IHlldC4KKworICAgICAgICBXaGVuIHRoaXMgaGFwcGVucywgbGV0J3Mgbm90IGNyYXNoLgorCisg ICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vY29jb2EvQXVkaW9NZWRpYVN0cmVhbVRyYWNr UmVuZGVyZXJDb2NvYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb01lZGlhU3RyZWFtVHJh Y2tSZW5kZXJlckNvY29hOjpzdGFydCk6CisKIDIwMjEtMDYtMjMgIEplYW4tWXZlcyBBdmVuYXJk ICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBOb3QgYWxsIHVzZXMgb2YgQXVkaW9Ub29sYm94 IGZyYW1ld29yayB1c2Ugc29mdCBsaW5raW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tZWRpYXN0cmVhbS9jb2NvYS9BdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckNv Y29hLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2NvY29hL0F1ZGlv TWVkaWFTdHJlYW1UcmFja1JlbmRlcmVyQ29jb2EuY3BwCmluZGV4IDY4NzJhODJlMzAxZmVmOWFl OWIyNGI1NjQzN2M4NGE1YjYwZGU2MmMuLjIyMDBlZjFiOGM3MmIzOGI2NmVkNTczM2RjOTFjOGVk MjdjMjg1MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L2NvY29hL0F1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVyQ29jb2EuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2NvY29hL0F1ZGlvTWVkaWFTdHJlYW1UcmFj a1JlbmRlcmVyQ29jb2EuY3BwCkBAIC00NSw3ICs0NSw3IEBAIHZvaWQgQXVkaW9NZWRpYVN0cmVh bVRyYWNrUmVuZGVyZXJDb2NvYTo6c3RhcnQoQ29tcGxldGlvbkhhbmRsZXI8dm9pZCgpPiYmIGNh bGxiCiAgICAgY2xlYXIoKTsKIAogICAgIEF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVyVW5p dDo6c2luZ2xldG9uKCkucmV0cmlldmVGb3JtYXREZXNjcmlwdGlvbihbd2Vha1RoaXMgPSBtYWtl V2Vha1B0cih0aGlzKSwgY2FsbGJhY2sgPSBXVEZNb3ZlKGNhbGxiYWNrKV0oYXV0byogZm9ybWF0 RGVzY3JpcHRpb24pIG11dGFibGUgewotICAgICAgICBpZiAod2Vha1RoaXMpCisgICAgICAgIGlm ICh3ZWFrVGhpcyAmJiBmb3JtYXREZXNjcmlwdGlvbikKICAgICAgICAgICAgIHdlYWtUaGlzLT5t X291dHB1dERlc2NyaXB0aW9uID0gbWFrZVVuaXF1ZTxDQUF1ZGlvU3RyZWFtRGVzY3JpcHRpb24+ KCpmb3JtYXREZXNjcmlwdGlvbik7CiAgICAgICAgIGNhbGxiYWNrKCk7CiAgICAgfSk7Cg==