227373 2021-06-24 12:12:16 -0700 REGRESSION(r275633): Revert to see if this was the cause for some crashes seen lately 2021-06-24 12:15:39 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 224160 1 commit-queue commit-queue koivisto simon.fraser webkit-bug-importer oldest_to_newest 1772409 0 commit-queue 2021-06-24 12:12:16 -0700 https://trac.webkit.org/changeset/275633 broke the build: Revert to see if this was the cause for some crashes seen lately This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1772411 1 432201 commit-queue 2021-06-24 12:12:22 -0700 Created attachment 432201 REVERT of r275633 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1772413 2 ews-feeder 2021-06-24 12:15:00 -0700 Committed r279242 (239127@main): <https://commits.webkit.org/239127@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432201. 1772414 3 webkit-bug-importer 2021-06-24 12:15:39 -0700 <rdar://problem/79736567> 432201 2021-06-24 12:12:22 -0700 2021-06-24 12:15:00 -0700 REVERT of r275633 bug-227373-20210624191222.patch text/plain 6140 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODc5ZTI4OWFlODA4ZTdi NDYwYWZmODZlNmUyZDQxNDMxYTc4MWNkNi4uNmI2OTc5MDA0YTVmNzhjYjhmYmRlZmJkYmM4ZGVi MGU4ODhmNTk3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA2LTI0ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI3NTYzMy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyNzM3MworCisgICAgICAgIFJldmVydCB0byBzZWUgaWYgdGhpcyB3YXMg dGhlIGNhdXNlIGZvciBzb21lIGNyYXNoZXMgc2VlbgorICAgICAgICBsYXRlbHkKKworICAgICAg ICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIlJlZHVjZSBWZWN0b3I8PiB3YXN0ZWQg Y2FwYWNpdHkgaW4gc29tZSBSdWxlU2V0IGNvZGUiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQxNjAKKyAgICAgICAgaHR0cHM6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LzI3NTYzMworCiAyMDIxLTA2LTI0ICBEbWl0cnkgS2FsaW5raW4gIDxk bWl0cnkua2FsaW5raW4rd2Via2l0QGdtYWlsLmNvbT4KIAogICAgICAgICBVc2UgPGNtYXRoPiBp bnN0ZWFkIG9mIDxtYXRoLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9SdWxl U2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1J1bGVTZXQuY3BwCmluZGV4IDRkZTczYTYy ODFkZDk3MDY3YTQxOWZhZGVlZmEzZTA0ODY1ZGFiMjQuLjgyY2IxYTliYmE0ZjQwYmFhZjJmMDRl M2VmMGUwMDcxNTg2YmY0ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1J1bGVT ZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1J1bGVTZXQuY3BwCkBAIC0zMTMsOSAr MzEzLDYgQEAgdm9pZCBSdWxlU2V0OjphZGRSdWxlc0Zyb21TaGVldChTdHlsZVNoZWV0Q29udGVu dHMmIHNoZWV0LCBjb25zdCBNZWRpYVF1ZXJ5RXZhbHUKIHsKICAgICBhdXRvIG1lZGlhUXVlcnlD b2xsZWN0b3IgPSBNZWRpYVF1ZXJ5Q29sbGVjdG9yIHsgZXZhbHVhdG9yIH07CiAgICAgYWRkUnVs ZXNGcm9tU2hlZXQoc2hlZXQsIG1lZGlhUXVlcnlDb2xsZWN0b3IsIG51bGxwdHIsIEFkZFJ1bGVz TW9kZTo6Tm9ybWFsKTsKLQotICAgIGlmIChtX2F1dG9TaHJpbmtUb0ZpdEVuYWJsZWQpCi0gICAg ICAgIHNocmlua1RvRml0KCk7CiB9CiAKIHZvaWQgUnVsZVNldDo6YWRkUnVsZXNGcm9tU2hlZXQo U3R5bGVTaGVldENvbnRlbnRzJiBzaGVldCwgTWVkaWFRdWVyeVNldCogc2hlZXRRdWVyeSwgY29u c3QgTWVkaWFRdWVyeUV2YWx1YXRvciYgZXZhbHVhdG9yLCBTdHlsZTo6UmVzb2x2ZXImIHJlc29s dmVyKQpAQCAtMzM2LDE2ICszMzMsMTQgQEAgdm9pZCBSdWxlU2V0OjphZGRSdWxlc0Zyb21TaGVl dChTdHlsZVNoZWV0Q29udGVudHMmIHNoZWV0LCBNZWRpYVF1ZXJ5U2V0KiBzaGVldFEKIAogICAg IG1faGFzVmlld3BvcnREZXBlbmRlbnRNZWRpYVF1ZXJpZXMgPSBtZWRpYVF1ZXJ5Q29sbGVjdG9y Lmhhc1ZpZXdwb3J0RGVwZW5kZW50TWVkaWFRdWVyaWVzOwogCi0gICAgaWYgKCFtZWRpYVF1ZXJ5 Q29sbGVjdG9yLmR5bmFtaWNNZWRpYVF1ZXJ5UnVsZXMuaXNFbXB0eSgpKSB7Ci0gICAgICAgIGF1 dG8gZmlyc3ROZXdJbmRleCA9IG1fZHluYW1pY01lZGlhUXVlcnlSdWxlcy5zaXplKCk7Ci0gICAg ICAgIG1fZHluYW1pY01lZGlhUXVlcnlSdWxlcy5hcHBlbmRWZWN0b3IoV1RGTW92ZShtZWRpYVF1 ZXJ5Q29sbGVjdG9yLmR5bmFtaWNNZWRpYVF1ZXJ5UnVsZXMpKTsKKyAgICBpZiAobWVkaWFRdWVy eUNvbGxlY3Rvci5keW5hbWljTWVkaWFRdWVyeVJ1bGVzLmlzRW1wdHkoKSkKKyAgICAgICAgcmV0 dXJuOwogCi0gICAgICAgIC8vIFNldCB0aGUgaW5pdGlhbCB2YWx1ZXMuCi0gICAgICAgIGV2YWx1 YXRlRHluYW1pY01lZGlhUXVlcnlSdWxlcyhldmFsdWF0b3IsIGZpcnN0TmV3SW5kZXgpOwotICAg IH0KKyAgICBhdXRvIGZpcnN0TmV3SW5kZXggPSBtX2R5bmFtaWNNZWRpYVF1ZXJ5UnVsZXMuc2l6 ZSgpOworICAgIG1fZHluYW1pY01lZGlhUXVlcnlSdWxlcy5hcHBlbmRWZWN0b3IoV1RGTW92ZSht ZWRpYVF1ZXJ5Q29sbGVjdG9yLmR5bmFtaWNNZWRpYVF1ZXJ5UnVsZXMpKTsKIAotICAgIGlmICht X2F1dG9TaHJpbmtUb0ZpdEVuYWJsZWQpCi0gICAgICAgIHNocmlua1RvRml0KCk7CisgICAgLy8g U2V0IHRoZSBpbml0aWFsIHZhbHVlcy4KKyAgICBldmFsdWF0ZUR5bmFtaWNNZWRpYVF1ZXJ5UnVs ZXMoZXZhbHVhdG9yLCBmaXJzdE5ld0luZGV4KTsKIH0KIAogdm9pZCBSdWxlU2V0OjphZGRSdWxl c0Zyb21TaGVldChTdHlsZVNoZWV0Q29udGVudHMmIHNoZWV0LCBNZWRpYVF1ZXJ5Q29sbGVjdG9y JiBtZWRpYVF1ZXJ5Q29sbGVjdG9yLCBSZXNvbHZlciogcmVzb2x2ZXIsIEFkZFJ1bGVzTW9kZSBt b2RlKQpAQCAtMzYwLDYgKzM1NSw5IEBAIHZvaWQgUnVsZVNldDo6YWRkUnVsZXNGcm9tU2hlZXQo U3R5bGVTaGVldENvbnRlbnRzJiBzaGVldCwgTWVkaWFRdWVyeUNvbGxlY3RvciYKICAgICB9CiAK ICAgICBhZGRDaGlsZFJ1bGVzKHNoZWV0LmNoaWxkUnVsZXMoKSwgbWVkaWFRdWVyeUNvbGxlY3Rv ciwgcmVzb2x2ZXIsIG1vZGUpOworCisgICAgaWYgKG1fYXV0b1Nocmlua1RvRml0RW5hYmxlZCAm JiBtb2RlID09IEFkZFJ1bGVzTW9kZTo6Tm9ybWFsKQorICAgICAgICBzaHJpbmtUb0ZpdCgpOwog fQogCiB2b2lkIFJ1bGVTZXQ6OmFkZFN0eWxlUnVsZShjb25zdCBTdHlsZVJ1bGUmIHJ1bGUsIE1l ZGlhUXVlcnlDb2xsZWN0b3ImIG1lZGlhUXVlcnlDb2xsZWN0b3IpCkBAIC00MTcsNyArNDE1LDYg QEAgc3RkOjpvcHRpb25hbDxEeW5hbWljTWVkaWFRdWVyeUV2YWx1YXRpb25DaGFuZ2VzPiBSdWxl U2V0OjpldmFsdWF0ZUR5bmFtaWNNZWRpYVEKICAgICAgICAgICAgIGZvciAoYXV0byYgZmVhdHVy ZSA6ICpmZWF0dXJlVmVjdG9yKQogICAgICAgICAgICAgICAgIHJ1bGVTZXQtPmFkZFJ1bGUoKmZl YXR1cmUuc3R5bGVSdWxlLCBmZWF0dXJlLnNlbGVjdG9ySW5kZXgsIGZlYXR1cmUuc2VsZWN0b3JM aXN0SW5kZXgpOwogICAgICAgICB9Ci0gICAgICAgIHJ1bGVTZXQtPnNocmlua1RvRml0KCk7CiAg ICAgICAgIHJldHVybiBydWxlU2V0OwogICAgIH0pLml0ZXJhdG9yLT52YWx1ZTsKIApAQCAtNDc1 LDE0ICs0NzIsNiBAQCBzdGF0aWMgaW5saW5lIHZvaWQgc2hyaW5rTWFwVmVjdG9yc1RvRml0KFJ1 bGVTZXQ6OkF0b21SdWxlTWFwJiBtYXApCiAgICAgICAgIHZlY3Rvci0+c2hyaW5rVG9GaXQoKTsK IH0KIAotc3RhdGljIGlubGluZSB2b2lkIHNocmlua0R5bmFtaWNSdWxlcyhWZWN0b3I8UnVsZVNl dDo6RHluYW1pY01lZGlhUXVlcnlSdWxlcz4mIGR5bmFtaWNSdWxlcykKLXsKLSAgICBmb3IgKGF1 dG8mIHJ1bGUgOiBkeW5hbWljUnVsZXMpCi0gICAgICAgIHJ1bGUuc2hyaW5rVG9GaXQoKTsKLQot ICAgIGR5bmFtaWNSdWxlcy5zaHJpbmtUb0ZpdCgpOwotfQotCiB2b2lkIFJ1bGVTZXQ6OnNocmlu a1RvRml0KCkKIHsKICAgICBzaHJpbmtNYXBWZWN0b3JzVG9GaXQobV9pZFJ1bGVzKTsKQEAgLTQ5 MCwyMSArNDc5LDE2IEBAIHZvaWQgUnVsZVNldDo6c2hyaW5rVG9GaXQoKQogICAgIHNocmlua01h cFZlY3RvcnNUb0ZpdChtX3RhZ0xvY2FsTmFtZVJ1bGVzKTsKICAgICBzaHJpbmtNYXBWZWN0b3Jz VG9GaXQobV90YWdMb3dlcmNhc2VMb2NhbE5hbWVSdWxlcyk7CiAgICAgc2hyaW5rTWFwVmVjdG9y c1RvRml0KG1fc2hhZG93UHNldWRvRWxlbWVudFJ1bGVzKTsKLQogICAgIG1fbGlua1BzZXVkb0Ns YXNzUnVsZXMuc2hyaW5rVG9GaXQoKTsKICNpZiBFTkFCTEUoVklERU8pCiAgICAgbV9jdWVQc2V1 ZG9SdWxlcy5zaHJpbmtUb0ZpdCgpOwogI2VuZGlmCiAgICAgbV9ob3N0UHNldWRvQ2xhc3NSdWxl cy5zaHJpbmtUb0ZpdCgpOwogICAgIG1fc2xvdHRlZFBzZXVkb0VsZW1lbnRSdWxlcy5zaHJpbmtU b0ZpdCgpOwotICAgIG1fcGFydFBzZXVkb0VsZW1lbnRSdWxlcy5zaHJpbmtUb0ZpdCgpOwogICAg IG1fZm9jdXNQc2V1ZG9DbGFzc1J1bGVzLnNocmlua1RvRml0KCk7CiAgICAgbV91bml2ZXJzYWxS dWxlcy5zaHJpbmtUb0ZpdCgpOwotCiAgICAgbV9wYWdlUnVsZXMuc2hyaW5rVG9GaXQoKTsKICAg ICBtX2ZlYXR1cmVzLnNocmlua1RvRml0KCk7Ci0KLSAgICBzaHJpbmtEeW5hbWljUnVsZXMobV9k eW5hbWljTWVkaWFRdWVyeVJ1bGVzKTsKIH0KIAogUnVsZVNldDo6TWVkaWFRdWVyeUNvbGxlY3Rv cjo6fk1lZGlhUXVlcnlDb2xsZWN0b3IoKSA9IGRlZmF1bHQ7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9zdHlsZS9SdWxlU2V0LmggYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9SdWxlU2V0LmgK aW5kZXggNmYzNzBhYTZlYTQzNjVhYzliMzQ0MjZlZTI0YTljMTM1YzQ4NDI2ZS4uYzIxYmM2ZDIx Y2NhZjA2NWUyY2JkOWM5OTliYWE3YzE0NTMzZGE5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvc3R5bGUvUnVsZVNldC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1J1bGVTZXQuaApA QCAtNzYsMTMgKzc2LDYgQEAgcHVibGljOgogICAgICAgICBWZWN0b3I8UnVsZUZlYXR1cmU+IHJ1 bGVGZWF0dXJlczsKICAgICAgICAgYm9vbCByZXF1aXJlc0Z1bGxSZXNldCB7IGZhbHNlIH07CiAg ICAgICAgIGJvb2wgcmVzdWx0IHsgdHJ1ZSB9OwotICAgICAgICAKLSAgICAgICAgdm9pZCBzaHJp bmtUb0ZpdCgpCi0gICAgICAgIHsKLSAgICAgICAgICAgIG1lZGlhUXVlcnlTZXRzLnNocmlua1Rv Rml0KCk7Ci0gICAgICAgICAgICBhZmZlY3RlZFJ1bGVQb3NpdGlvbnMuc2hyaW5rVG9GaXQoKTsK LSAgICAgICAgICAgIHJ1bGVGZWF0dXJlcy5zaHJpbmtUb0ZpdCgpOwotICAgICAgICB9CiAgICAg fTsKIAogICAgIHN0cnVjdCBNZWRpYVF1ZXJ5Q29sbGVjdG9yIHsKQEAgLTE2MCw2ICsxNTMsNyBA QCBwcml2YXRlOgogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgRnVuY3Rpb24+IHZvaWQgdHJhdmVy c2VSdWxlRGF0YXMoRnVuY3Rpb24mJik7CiAKKwogICAgIEF0b21SdWxlTWFwIG1faWRSdWxlczsK ICAgICBBdG9tUnVsZU1hcCBtX2NsYXNzUnVsZXM7CiAgICAgQXRvbVJ1bGVNYXAgbV90YWdMb2Nh bE5hbWVSdWxlczsKQEAgLTE3NSwxMyArMTY5LDEzIEBAIHByaXZhdGU6CiAgICAgUnVsZURhdGFW ZWN0b3IgbV9mb2N1c1BzZXVkb0NsYXNzUnVsZXM7CiAgICAgUnVsZURhdGFWZWN0b3IgbV91bml2 ZXJzYWxSdWxlczsKICAgICBWZWN0b3I8U3R5bGVSdWxlUGFnZSo+IG1fcGFnZVJ1bGVzOwotICAg IFJ1bGVGZWF0dXJlU2V0IG1fZmVhdHVyZXM7Ci0gICAgVmVjdG9yPER5bmFtaWNNZWRpYVF1ZXJ5 UnVsZXM+IG1fZHluYW1pY01lZGlhUXVlcnlSdWxlczsKLSAgICBIYXNoTWFwPFZlY3RvcjxzaXpl X3Q+LCBSZWY8Y29uc3QgUnVsZVNldD4+IG1fbWVkaWFRdWVyeUludmFsaWRhdGlvblJ1bGVTZXRD YWNoZTsKICAgICB1bnNpZ25lZCBtX3J1bGVDb3VudCB7IDAgfTsKICAgICBib29sIG1faGFzSG9z dFBzZXVkb0NsYXNzUnVsZXNNYXRjaGluZ0luU2hhZG93VHJlZSB7IGZhbHNlIH07CiAgICAgYm9v bCBtX2F1dG9TaHJpbmtUb0ZpdEVuYWJsZWQgeyB0cnVlIH07CisgICAgUnVsZUZlYXR1cmVTZXQg bV9mZWF0dXJlczsKICAgICBib29sIG1faGFzVmlld3BvcnREZXBlbmRlbnRNZWRpYVF1ZXJpZXMg eyBmYWxzZSB9OworICAgIFZlY3RvcjxEeW5hbWljTWVkaWFRdWVyeVJ1bGVzPiBtX2R5bmFtaWNN ZWRpYVF1ZXJ5UnVsZXM7CisgICAgSGFzaE1hcDxWZWN0b3I8c2l6ZV90PiwgUmVmPGNvbnN0IFJ1 bGVTZXQ+PiBtX21lZGlhUXVlcnlJbnZhbGlkYXRpb25SdWxlU2V0Q2FjaGU7CiB9OwogCiBpbmxp bmUgY29uc3QgUnVsZVNldDo6UnVsZURhdGFWZWN0b3IqIFJ1bGVTZXQ6OnRhZ1J1bGVzKGNvbnN0 IEF0b21TdHJpbmcmIGtleSwgYm9vbCBpc0hUTUxOYW1lKSBjb25zdAo=