227348 2021-06-24 04:49:17 -0700 [GStreamer] Build warnings in AudioFileReader since r279123 2021-06-25 08:13:18 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=227208 InRadar P2 Normal --- 1 pnormand pnormand calvaris eric.carlson ews-watchlist glenn jer.noble philipj sergio vjaquez webkit-bug-importer oldest_to_newest 1772247 0 pnormand 2021-06-24 04:49:17 -0700 [2156/3527] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp.o ../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:351:9: warning: variable 'source' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (m_data) { ^~~~~~ ../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:361:131: note: uninitialized use occurs here gst_bin_add_many(((((GstBin*) g_type_check_instance_cast ((GTypeInstance*) ((m_pipeline.get())), ((gst_bin_get_type ())))))), source, m_decodebin.get(), nullptr); ^~~~~~ ../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:351:5: note: remove the 'if' if its condition is always true if (m_data) { ^~~~~~~~~~~~ ../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:350:23: note: initialize the variable 'source' to silence this warning GstElement* source; ^ = nullptr 1 warning generated. 1772248 1 432150 pnormand 2021-06-24 04:51:41 -0700 Created attachment 432150 Patch 1772249 2 432151 pnormand 2021-06-24 04:55:29 -0700 Created attachment 432151 Patch 1772687 3 ews-feeder 2021-06-25 08:12:36 -0700 Committed r279283 (239162@main): <https://commits.webkit.org/239162@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432151. 1772688 4 webkit-bug-importer 2021-06-25 08:13:18 -0700 <rdar://problem/79778888> 432150 2021-06-24 04:51:41 -0700 2021-06-24 04:55:23 -0700 Patch bug-227348-20210624045139.patch text/plain 2178 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2MyMmE1MDRiMmIzMDVj ODdhOTE5OTcyMDUyOTNhNzI0NGE0YzBjMS4uMjI0NTBlZThjNzkyZTM0MWNkOTk4MDU5YWY2Y2Mz MjliN2RjNTFhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA2LTI0ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBCdWlsZCB3YXJuaW5ncyBpbiBBdWRpb0ZpbGVSZWFkZXIgc2luY2UgcjI3OTEyMworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MzQ4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2ltcGxpZnkgdGhlIGNv ZGUgaGFuZGxpbmcgdGhlIGdpb3N0cmVhbXNyYyBjcmVhdGlvbiwgbm93IHRoYXQgaXQgaXMgdGhl IG9ubHkgb3B0aW9uIHBvc3NpYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0cmVh bWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRp b0ZpbGVSZWFkZXI6OmRlY29kZUF1ZGlvRm9yQnVzQ3JlYXRpb24pOgorCiAyMDIxLTA2LTI0ICBN YXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbY3NzLXNj cm9sbC1zbmFwXSBSZW1vdmUgRU5BQkxFX1NDUk9MTF9TTkFQIGNvbXBpbGUtdGltZSBvcHRpb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRp b0ZpbGVSZWFkZXJHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v Z3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAKaW5kZXggYjM2OTE2YmNlODJm ZDcyZDU3NWNhZTFjZjE0ZGY2NTE3NTZmNzk4My4uYzUzYWRkZjc1ZTQxY2I4NmZkMDgzZDA3Yzhm NDY1YWExOGM0OWIxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v Z3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAK QEAgLTM0NywxMyArMzQ3LDExIEBAIHZvaWQgQXVkaW9GaWxlUmVhZGVyOjpkZWNvZGVBdWRpb0Zv ckJ1c0NyZWF0aW9uKCkKICAgICAgICAgcmV0dXJuIEdTVF9CVVNfRFJPUDsKICAgICB9LCB0aGlz LCBudWxscHRyKTsKIAotICAgIEdzdEVsZW1lbnQqIHNvdXJjZTsKLSAgICBpZiAobV9kYXRhKSB7 Ci0gICAgICAgIEFTU0VSVChtX2RhdGFTaXplKTsKLSAgICAgICAgc291cmNlID0gbWFrZUdTdHJl YW1lckVsZW1lbnQoImdpb3N0cmVhbXNyYyIsIG51bGxwdHIpOwotICAgICAgICBHUmVmUHRyPEdJ bnB1dFN0cmVhbT4gbWVtb3J5U3RyZWFtID0gYWRvcHRHUmVmKGdfbWVtb3J5X2lucHV0X3N0cmVh bV9uZXdfZnJvbV9kYXRhKG1fZGF0YSwgbV9kYXRhU2l6ZSwgbnVsbHB0cikpOwotICAgICAgICBn X29iamVjdF9zZXQoc291cmNlLCAic3RyZWFtIiwgbWVtb3J5U3RyZWFtLmdldCgpLCBudWxscHRy KTsKLSAgICB9CisgICAgQVNTRVJUKG1fZGF0YSk7CisgICAgQVNTRVJUKG1fZGF0YVNpemUpOwor ICAgIGF1dG8qIHNvdXJjZSA9IG1ha2VHU3RyZWFtZXJFbGVtZW50KCJnaW9zdHJlYW1zcmMiLCBu dWxscHRyKTsKKyAgICBhdXRvIG1lbW9yeVN0cmVhbSA9IGFkb3B0R1JlZihnX21lbW9yeV9pbnB1 dF9zdHJlYW1fbmV3X2Zyb21fZGF0YShtX2RhdGEsIG1fZGF0YVNpemUsIG51bGxwdHIpKTsKKyAg ICBnX29iamVjdF9zZXQoc291cmNlLCAic3RyZWFtIiwgbWVtb3J5U3RyZWFtLmdldCgpLCBudWxs cHRyKTsKIAogICAgIG1fZGVjb2RlYmluID0gbWFrZUdTdHJlYW1lckVsZW1lbnQoImRlY29kZWJp biIsICJkZWNvZGViaW4iKTsKICAgICBnX3NpZ25hbF9jb25uZWN0X3N3YXBwZWQobV9kZWNvZGVi aW4uZ2V0KCksICJwYWQtYWRkZWQiLCBHX0NBTExCQUNLKGRlY29kZWJpblBhZEFkZGVkQ2FsbGJh Y2spLCB0aGlzKTsK 432151 2021-06-24 04:55:29 -0700 2021-06-25 08:12:37 -0700 Patch bug-227348-20210624045527.patch text/plain 2657 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2MyMmE1MDRiMmIzMDVj ODdhOTE5OTcyMDUyOTNhNzI0NGE0YzBjMS4uMjI0NTBlZThjNzkyZTM0MWNkOTk4MDU5YWY2Y2Mz MjliN2RjNTFhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA2LTI0ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBCdWlsZCB3YXJuaW5ncyBpbiBBdWRpb0ZpbGVSZWFkZXIgc2luY2UgcjI3OTEyMworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MzQ4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2ltcGxpZnkgdGhlIGNv ZGUgaGFuZGxpbmcgdGhlIGdpb3N0cmVhbXNyYyBjcmVhdGlvbiwgbm93IHRoYXQgaXQgaXMgdGhl IG9ubHkgb3B0aW9uIHBvc3NpYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0cmVh bWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRp b0ZpbGVSZWFkZXI6OmRlY29kZUF1ZGlvRm9yQnVzQ3JlYXRpb24pOgorCiAyMDIxLTA2LTI0ICBN YXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbY3NzLXNj cm9sbC1zbmFwXSBSZW1vdmUgRU5BQkxFX1NDUk9MTF9TTkFQIGNvbXBpbGUtdGltZSBvcHRpb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRp b0ZpbGVSZWFkZXJHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v Z3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAKaW5kZXggYjM2OTE2YmNlODJm ZDcyZDU3NWNhZTFjZjE0ZGY2NTE3NTZmNzk4My4uZWZlZDc0YWFmNWFjODE4YWVmNDU4OTIzYzNj MTljZjA1YTEwZWM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v Z3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAK QEAgLTMyNCw3ICszMjQsNyBAQCB2b2lkIEF1ZGlvRmlsZVJlYWRlcjo6ZGVjb2RlQXVkaW9Gb3JC dXNDcmVhdGlvbigpCiB7CiAgICAgQVNTRVJUKCZtX3J1bkxvb3AgPT0gJlJ1bkxvb3A6OmN1cnJl bnQoKSk7CiAKLSAgICAvLyBCdWlsZCB0aGUgcGlwZWxpbmUgKGdpb3N0cmVhbXNyYyB8IGZpbGVz cmMpICEgZGVjb2RlYmluCisgICAgLy8gQnVpbGQgdGhlIHBpcGVsaW5lIGdpb3N0cmVhbXNyYyAh IGRlY29kZWJpbgogICAgIC8vIEEgZGVpbnRlcmxlYXZlIGVsZW1lbnQgaXMgYWRkZWQgb25jZSBh IHNyYyBwYWQgYmVjb21lcyBhdmFpbGFibGUgaW4gZGVjb2RlYmluLgogICAgIHN0YXRpYyBBdG9t aWM8dWludDMyX3Q+IHBpcGVsaW5lSWQ7CiAgICAgbV9waXBlbGluZSA9IGdzdF9waXBlbGluZV9u ZXcobWFrZVN0cmluZygiYXVkaW8tZmlsZS1yZWFkZXItIiwgcGlwZWxpbmVJZC5leGNoYW5nZUFk ZCgxKSkuYXNjaWkoKS5kYXRhKCkpOwpAQCAtMzQ3LDEzICszNDcsMTEgQEAgdm9pZCBBdWRpb0Zp bGVSZWFkZXI6OmRlY29kZUF1ZGlvRm9yQnVzQ3JlYXRpb24oKQogICAgICAgICByZXR1cm4gR1NU X0JVU19EUk9QOwogICAgIH0sIHRoaXMsIG51bGxwdHIpOwogCi0gICAgR3N0RWxlbWVudCogc291 cmNlOwotICAgIGlmIChtX2RhdGEpIHsKLSAgICAgICAgQVNTRVJUKG1fZGF0YVNpemUpOwotICAg ICAgICBzb3VyY2UgPSBtYWtlR1N0cmVhbWVyRWxlbWVudCgiZ2lvc3RyZWFtc3JjIiwgbnVsbHB0 cik7Ci0gICAgICAgIEdSZWZQdHI8R0lucHV0U3RyZWFtPiBtZW1vcnlTdHJlYW0gPSBhZG9wdEdS ZWYoZ19tZW1vcnlfaW5wdXRfc3RyZWFtX25ld19mcm9tX2RhdGEobV9kYXRhLCBtX2RhdGFTaXpl LCBudWxscHRyKSk7Ci0gICAgICAgIGdfb2JqZWN0X3NldChzb3VyY2UsICJzdHJlYW0iLCBtZW1v cnlTdHJlYW0uZ2V0KCksIG51bGxwdHIpOwotICAgIH0KKyAgICBBU1NFUlQobV9kYXRhKTsKKyAg ICBBU1NFUlQobV9kYXRhU2l6ZSk7CisgICAgYXV0byogc291cmNlID0gbWFrZUdTdHJlYW1lckVs ZW1lbnQoImdpb3N0cmVhbXNyYyIsIG51bGxwdHIpOworICAgIGF1dG8gbWVtb3J5U3RyZWFtID0g YWRvcHRHUmVmKGdfbWVtb3J5X2lucHV0X3N0cmVhbV9uZXdfZnJvbV9kYXRhKG1fZGF0YSwgbV9k YXRhU2l6ZSwgbnVsbHB0cikpOworICAgIGdfb2JqZWN0X3NldChzb3VyY2UsICJzdHJlYW0iLCBt ZW1vcnlTdHJlYW0uZ2V0KCksIG51bGxwdHIpOwogCiAgICAgbV9kZWNvZGViaW4gPSBtYWtlR1N0 cmVhbWVyRWxlbWVudCgiZGVjb2RlYmluIiwgImRlY29kZWJpbiIpOwogICAgIGdfc2lnbmFsX2Nv bm5lY3Rfc3dhcHBlZChtX2RlY29kZWJpbi5nZXQoKSwgInBhZC1hZGRlZCIsIEdfQ0FMTEJBQ0so ZGVjb2RlYmluUGFkQWRkZWRDYWxsYmFjayksIHRoaXMpOwo=