227344 2021-06-24 02:43:53 -0700 [GTK][WPE] Check GApplication has a valid ID before trying to create the flatpack info 2021-06-29 02:12:40 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1772230 0 cgarcia 2021-06-24 02:43:53 -0700 (MiniBrowser:49675): GLib-CRITICAL **: 11:38:50.163: g_key_file_set_string: assertion 'string != NULL' failed 1772231 1 432144 cgarcia 2021-06-24 02:45:22 -0700 Created attachment 432144 Patch 1772232 2 432145 cgarcia 2021-06-24 02:46:10 -0700 Created attachment 432145 Patch 1772437 3 432145 mcatanzaro 2021-06-24 13:40:14 -0700 Comment on attachment 432145 Patch Patrick noticed that this will cause portals to think the application is not sandboxed. We should instead replaced the early return with a g_error() explaining that the sandbox cannot be used without running a GApplication instance with a valid app ID. 1773029 4 432383 cgarcia 2021-06-28 05:09:23 -0700 Created attachment 432383 Patch 1773056 5 432383 mcatanzaro 2021-06-28 07:15:59 -0700 Comment on attachment 432383 Patch OK, but I would remove the 'return -1' lines before landing, because they are now unreachable. 1773355 6 cgarcia 2021-06-29 02:12:40 -0700 Committed r279369 (239235@main): <https://commits.webkit.org/239235@main> 432144 2021-06-24 02:45:22 -0700 2021-06-24 02:46:10 -0700 Patch wk-sandbox-warning.diff text/plain 1769 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTBkZGQ0MjUwMDE1Li5jYzJlYjAzNzdhYTMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjEtMDYtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gQ2hlY2sgR2FwcGxpY2F0aW9uIGhhcyBhIHZh bGlkIElEIGJlZm9yZSB0cnlpbmcgdG8gY3JlYXRlIHRoZSBmbGF0cGFjayBpbmZvCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjczNDQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaG93IGEgd2FybmluZyBp ZiBHQXBwbGljYXRpb24gaXMgdXNlZCBidXQgYXBwIElEIGlzIG51bGxwdHIuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpjcmVhdGVGbGF0cGFrSW5mbyk6CisKIDIwMjEtMDYtMjQgIE1pY2hhZWwgQ2F0 YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjcy ODgyKTogW1dQRV1bR1RLXSB4ZGctZGJ1cy1wcm94eSBtYXkgbm90IGJlIG1vdW50ZWQgaW4gc2Fu ZGJveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9C dWJibGV3cmFwTGF1bmNoZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIv Z2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCmluZGV4IDIyZTNjNGJkNGQ1ZC4uOThlMGI4MTFh NDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1 YmJsZXdyYXBMYXVuY2hlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNo ZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCkBAIC0xNDQsOCArMTQ0LDE0IEBAIHN0YXRp YyBpbnQgY3JlYXRlRmxhdHBha0luZm8oKQogICAgICAgICAgICAgcmV0dXJuIC0xOwogICAgICAg ICB9CiAKKyAgICAgICAgY29uc3QgY2hhciAqYXBwSUQgPSBnX2FwcGxpY2F0aW9uX2dldF9hcHBs aWNhdGlvbl9pZChhcHApOworICAgICAgICBpZiAoIWFwcElEKSB7CisgICAgICAgICAgICBnX3dh cm5pbmcoIkdBcHBsaWNhdGlvbiBtdXN0IGhhdmUgYSB2YWxpZCBJRCBmb3IgeGRnLWRlc2t0b3At cG9ydGFsIGFjY2VzcyBpbiB0aGUgV2ViS2l0IHNhbmRib3guIEFjdGlvbnMgdGhhdCByZXF1aXJl IHhkZy1kZXNrdG9wLXBvcnRhbCB3aWxsIGJlIGJyb2tlbi4iKTsKKyAgICAgICAgICAgIHJldHVy biAtMTsKKyAgICAgICAgfQorCiAgICAgICAgIEdVbmlxdWVQdHI8R0tleUZpbGU+IGtleUZpbGUo Z19rZXlfZmlsZV9uZXcoKSk7Ci0gICAgICAgIGdfa2V5X2ZpbGVfc2V0X3N0cmluZyhrZXlGaWxl LmdldCgpLCAiQXBwbGljYXRpb24iLCAibmFtZSIsIGdfYXBwbGljYXRpb25fZ2V0X2FwcGxpY2F0 aW9uX2lkKGFwcCkpOworICAgICAgICBnX2tleV9maWxlX3NldF9zdHJpbmcoa2V5RmlsZS5nZXQo KSwgIkFwcGxpY2F0aW9uIiwgIm5hbWUiLCBhcHBJRCk7CiAgICAgICAgIGRhdGEtPnJlc2V0KGdf a2V5X2ZpbGVfdG9fZGF0YShrZXlGaWxlLmdldCgpLCAmc2l6ZSwgbnVsbHB0cikpOwogICAgIH0K IAo= 432145 2021-06-24 02:46:10 -0700 2021-06-28 05:09:23 -0700 Patch wk-sandbox-warning.diff text/plain 1769 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTBkZGQ0MjUwMDE1Li5jYzJlYjAzNzdhYTMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjEtMDYtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gQ2hlY2sgR2FwcGxpY2F0aW9uIGhhcyBhIHZh bGlkIElEIGJlZm9yZSB0cnlpbmcgdG8gY3JlYXRlIHRoZSBmbGF0cGFjayBpbmZvCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjczNDQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaG93IGEgd2FybmluZyBp ZiBHQXBwbGljYXRpb24gaXMgdXNlZCBidXQgYXBwIElEIGlzIG51bGxwdHIuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpjcmVhdGVGbGF0cGFrSW5mbyk6CisKIDIwMjEtMDYtMjQgIE1pY2hhZWwgQ2F0 YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjcy ODgyKTogW1dQRV1bR1RLXSB4ZGctZGJ1cy1wcm94eSBtYXkgbm90IGJlIG1vdW50ZWQgaW4gc2Fu ZGJveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9C dWJibGV3cmFwTGF1bmNoZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIv Z2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCmluZGV4IDIyZTNjNGJkNGQ1ZC4uNWIzYjczM2Fi OGVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1 YmJsZXdyYXBMYXVuY2hlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNo ZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCkBAIC0xNDQsOCArMTQ0LDE0IEBAIHN0YXRp YyBpbnQgY3JlYXRlRmxhdHBha0luZm8oKQogICAgICAgICAgICAgcmV0dXJuIC0xOwogICAgICAg ICB9CiAKKyAgICAgICAgY29uc3QgY2hhciogYXBwSUQgPSBnX2FwcGxpY2F0aW9uX2dldF9hcHBs aWNhdGlvbl9pZChhcHApOworICAgICAgICBpZiAoIWFwcElEKSB7CisgICAgICAgICAgICBnX3dh cm5pbmcoIkdBcHBsaWNhdGlvbiBtdXN0IGhhdmUgYSB2YWxpZCBJRCBmb3IgeGRnLWRlc2t0b3At cG9ydGFsIGFjY2VzcyBpbiB0aGUgV2ViS2l0IHNhbmRib3guIEFjdGlvbnMgdGhhdCByZXF1aXJl IHhkZy1kZXNrdG9wLXBvcnRhbCB3aWxsIGJlIGJyb2tlbi4iKTsKKyAgICAgICAgICAgIHJldHVy biAtMTsKKyAgICAgICAgfQorCiAgICAgICAgIEdVbmlxdWVQdHI8R0tleUZpbGU+IGtleUZpbGUo Z19rZXlfZmlsZV9uZXcoKSk7Ci0gICAgICAgIGdfa2V5X2ZpbGVfc2V0X3N0cmluZyhrZXlGaWxl LmdldCgpLCAiQXBwbGljYXRpb24iLCAibmFtZSIsIGdfYXBwbGljYXRpb25fZ2V0X2FwcGxpY2F0 aW9uX2lkKGFwcCkpOworICAgICAgICBnX2tleV9maWxlX3NldF9zdHJpbmcoa2V5RmlsZS5nZXQo KSwgIkFwcGxpY2F0aW9uIiwgIm5hbWUiLCBhcHBJRCk7CiAgICAgICAgIGRhdGEtPnJlc2V0KGdf a2V5X2ZpbGVfdG9fZGF0YShrZXlGaWxlLmdldCgpLCAmc2l6ZSwgbnVsbHB0cikpOwogICAgIH0K IAo= 432383 2021-06-28 05:09:23 -0700 2021-06-28 07:15:59 -0700 Patch wk-sandbox-app-id.diff text/plain 2128 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZjhmMTk4MjBmNDAxLi4zMmE0Yzc3N2IwYWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjEtMDYtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gQ2hlY2sgR0FwcGxpY2F0aW9uIGhhcyBhIHZh bGlkIElEIGJlZm9yZSB0cnlpbmcgdG8gY3JlYXRlIHRoZSBmbGF0cGFjayBpbmZvCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjczNDQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaG93IGEgd2FybmluZyBp ZiBHQXBwbGljYXRpb24gaXMgdXNlZCBidXQgYXBwIElEIGlzIG51bGxwdHIuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpjcmVhdGVGbGF0cGFrSW5mbyk6CisKIDIwMjEtMDYtMjggIEtpbW1vIEtpbm51 bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBQb3NzaWJsZSBidWlsZCBicmVh a2FnZSBhZnRlciByMjc5MjIxIGluIHNvbWUgdW5pZmllZCBidWlsZCBjb25maWd1cmF0aW9ucwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3 cmFwTGF1bmNoZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9C dWJibGV3cmFwTGF1bmNoZXIuY3BwCmluZGV4IDIyZTNjNGJkNGQ1ZC4uOTZlMzFhMDBmMTVjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdy YXBMYXVuY2hlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xp Yi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCkBAIC0xNDAsMTIgKzE0MCwxOCBAQCBzdGF0aWMgaW50 IGNyZWF0ZUZsYXRwYWtJbmZvKCkKICAgICAgICAgLy8gdGhlbSB0byBiZSBhcHBsaWNhdGlvbiB1 bmlxdWUgd2hpY2ggaXMgYmVzdCBkb25lIHZpYSBHQXBwbGljYXRpb24uCiAgICAgICAgIEdBcHBs aWNhdGlvbiogYXBwID0gZ19hcHBsaWNhdGlvbl9nZXRfZGVmYXVsdCgpOwogICAgICAgICBpZiAo IWFwcCkgewotICAgICAgICAgICAgZ193YXJuaW5nKCJHQXBwbGljYXRpb24gaXMgcmVxdWlyZWQg Zm9yIHhkZy1kZXNrdG9wLXBvcnRhbCBhY2Nlc3MgaW4gdGhlIFdlYktpdCBzYW5kYm94LiBBY3Rp b25zIHRoYXQgcmVxdWlyZSB4ZGctZGVza3RvcC1wb3J0YWwgd2lsbCBiZSBicm9rZW4uIik7Cisg ICAgICAgICAgICBnX2Vycm9yKCJHQXBwbGljYXRpb24gaXMgcmVxdWlyZWQgZm9yIHhkZy1kZXNr dG9wLXBvcnRhbCBhY2Nlc3MgaW4gdGhlIFdlYktpdCBzYW5kYm94LiIpOworICAgICAgICAgICAg cmV0dXJuIC0xOworICAgICAgICB9CisKKyAgICAgICAgY29uc3QgY2hhciogYXBwSUQgPSBnX2Fw cGxpY2F0aW9uX2dldF9hcHBsaWNhdGlvbl9pZChhcHApOworICAgICAgICBpZiAoIWFwcElEKSB7 CisgICAgICAgICAgICBnX2Vycm9yKCJHQXBwbGljYXRpb24gbXVzdCBoYXZlIGEgdmFsaWQgSUQg Zm9yIHhkZy1kZXNrdG9wLXBvcnRhbCBhY2Nlc3MgaW4gdGhlIFdlYktpdCBzYW5kYm94LiIpOwog ICAgICAgICAgICAgcmV0dXJuIC0xOwogICAgICAgICB9CiAKICAgICAgICAgR1VuaXF1ZVB0cjxH S2V5RmlsZT4ga2V5RmlsZShnX2tleV9maWxlX25ldygpKTsKLSAgICAgICAgZ19rZXlfZmlsZV9z ZXRfc3RyaW5nKGtleUZpbGUuZ2V0KCksICJBcHBsaWNhdGlvbiIsICJuYW1lIiwgZ19hcHBsaWNh dGlvbl9nZXRfYXBwbGljYXRpb25faWQoYXBwKSk7CisgICAgICAgIGdfa2V5X2ZpbGVfc2V0X3N0 cmluZyhrZXlGaWxlLmdldCgpLCAiQXBwbGljYXRpb24iLCAibmFtZSIsIGFwcElEKTsKICAgICAg ICAgZGF0YS0+cmVzZXQoZ19rZXlfZmlsZV90b19kYXRhKGtleUZpbGUuZ2V0KCksICZzaXplLCBu dWxscHRyKSk7CiAgICAgfQogCg==