22734 2008-12-08 05:29:06 -0800 Debugger crashes when stepping into a function call in a return statement 2008-12-10 22:27:59 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://nerget.com/working/crash.html P1 Normal --- 1 oliver zwarich ggaren mjs sam zwarich oldest_to_newest 101811 0 oliver 2008-12-08 05:29:06 -0800 There's a reproducible crash (assertion failure on debug is attempt to cast an immediate to a cell) when trying to step into a function call in a return statement. Steps to reproduce: 1. goto http://nerget.com/working/crash.html 2. Enable debugging 3. Set a breakpoint at the return statement in the code <script> function x(y){} window.onload = function () { return x(12); // <-- set break point here } </script> 4. Reload the page 5. When you reach the break point, step into the call 6. Crash :-( 101859 1 zwarich 2008-12-08 13:19:28 -0800 I'll take a look at this. 102163 2 zwarich 2008-12-10 15:07:46 -0800 This happens with the bytecode interpreter as well as the JIT, which should make it easier to debug. 102205 3 25940 zwarich 2008-12-10 22:21:11 -0800 Created attachment 25940 Proposed patch 102206 4 25940 oliver 2008-12-10 22:23:34 -0800 Comment on attachment 25940 Proposed patch r=me!!!!! 102207 5 zwarich 2008-12-10 22:27:59 -0800 Landed in r39198. 25940 2008-12-10 22:21:11 -0800 2008-12-10 22:23:34 -0800 Proposed patch debugger.diff text/plain 2071 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5MTk3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMTIt MTAgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjczNDogRGVidWdnZXIgY3Jh c2hlcyB3aGVuIHN0ZXBwaW5nIGludG8gYSBmdW5jdGlvbiBjYWxsIGluIGEgcmV0dXJuIHN0YXRl bWVudAorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy NzM0PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQyNjc5Nj4KKworICAgICAgICAqIGJ5dGVj b21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHA6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlR2Vu ZXJhdG9yOjpCeXRlY29kZUdlbmVyYXRvcik6IFRoZSBEZWJ1Z2dlckNhbGxGcmFtZSB1c2VzCisg ICAgICAgIHRoZSAndGhpcycgdmFsdWUgc3RvcmVkIGluIGEgY2FsbEZyYW1lLCBzbyBvcF9jb252 ZXJ0X3RoaXMgc2hvdWxkIGJlCisgICAgICAgIGVtaXR0ZWQgYXQgdGhlIGJlZ2lubmluZyBvZiBh IGZ1bmN0aW9uIGJvZHkgd2hlbiBnZW5lcmF0aW5nIGJ5dGVjb2RlCisgICAgICAgIHdpdGggZGVi dWcgaG9va3MuCisgICAgICAgICogZGVidWdnZXIvRGVidWdnZXJDYWxsRnJhbWUuY3BwOgorICAg ICAgICAoSlNDOjpEZWJ1Z2dlckNhbGxGcmFtZTo6dGhpc09iamVjdCk6IFRoZSBhc3NlcnRpb24g aW5oZXJlbnQgaW4gdGhlIGNhbGwKKyAgICAgICAgdG8gYXNPYmplY3QoKSBoZXJlIGlzIHZhbGlk LCBiZWNhdXNlIGFueSAndGhpcycgdmFsdWUgc2hvdWxkIGhhdmUgYmVlbgorICAgICAgICBjb252 ZXJ0ZWQgdG8gYSBKU09iamVjdCouCisKIDIwMDgtMTItMTAgIEdhdmluIEJhcnJhY2xvdWdoICA8 YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmIEdhcmVu LgpJbmRleDogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCShyZXZpc2lvbiAzOTE5NikKKysr IGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMz MSw3ICszMzEsNyBAQCBCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IoRnVuCiAg ICAgKyttX25leHRQYXJhbWV0ZXJJbmRleDsKICAgICArK21fY29kZUJsb2NrLT5tX251bVBhcmFt ZXRlcnM7CiAKLSAgICBpZiAoZnVuY3Rpb25Cb2R5LT51c2VzVGhpcygpKSB7CisgICAgaWYgKGZ1 bmN0aW9uQm9keS0+dXNlc1RoaXMoKSB8fCBtX3Nob3VsZEVtaXREZWJ1Z0hvb2tzKSB7CiAgICAg ICAgIGVtaXRPcGNvZGUob3BfY29udmVydF90aGlzKTsKICAgICAgICAgaW5zdHJ1Y3Rpb25zKCku YXBwZW5kKG1fdGhpc1JlZ2lzdGVyLmluZGV4KCkpOwogICAgIH0KSW5kZXg6IGRlYnVnZ2VyL0Rl YnVnZ2VyQ2FsbEZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBkZWJ1Z2dlci9EZWJ1Z2dlckNhbGxG cmFtZS5jcHAJKHJldmlzaW9uIDM5MTk2KQorKysgZGVidWdnZXIvRGVidWdnZXJDYWxsRnJhbWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MCw3ICs2MCw2IEBAIEpTT2JqZWN0KiBEZWJ1Z2dlckNh bGxGcmFtZTo6dGhpc09iamVjdCgKICAgICBpZiAoIW1fY2FsbEZyYW1lLT5jb2RlQmxvY2soKSkK ICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICAvLyBGSVhNRTogV2h5IGlzIGl0IHNhZmUgdG8gYXNz dW1lIHRoaXMgaXMgYW4gb2JqZWN0PwogICAgIHJldHVybiBhc09iamVjdChtX2NhbGxGcmFtZS0+ dGhpc1ZhbHVlKCkpOwogfQogCg==