227318 2021-06-23 14:31:28 -0700 REGRESSION(r278970): A CATransaction commitHandler should not execute a client callback 2021-09-09 00:02:25 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226257 https://bugs.webkit.org/show_bug.cgi?id=230085 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa thorton webkit-bug-importer oldest_to_newest 1772066 0 sabouhallawa 2021-06-23 14:31:28 -0700 Because the client callback may cause directly or indirectly another CATransaction commitHandler to be added which is prohibited by CA. 1772073 1 sabouhallawa 2021-06-23 14:49:48 -0700 <rdar://79625962> 1772075 2 432093 sabouhallawa 2021-06-23 14:55:29 -0700 Created attachment 432093 Patch 1772097 3 432093 thorton 2021-06-23 16:05:44 -0700 Comment on attachment 432093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432093&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1248 > + dispatch_async(dispatch_get_main_queue(), ^{ Likely better to use a lambda, like we do for addCommitHandler; replace the `^{` with `[callSnapshotRect = WTFMove(callSnapshotRect)] {` 1772126 4 432115 sabouhallawa 2021-06-23 17:07:49 -0700 Created attachment 432115 Patch 1772181 5 ews-feeder 2021-06-23 22:27:39 -0700 Committed r279210 (239096@main): <https://commits.webkit.org/239096@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432115. 432093 2021-06-23 14:55:29 -0700 2021-06-23 16:06:54 -0700 Patch bug-227318-20210623145527.patch text/plain 2444 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQyMzU0NTc1YjgzOTYyYzQx MTJlYzIzYmFkOTJmN2VmNDUzYWI0MjguLjFhNzQzNWRkZDNlZjllNzU5YTZhZTMwOWNiOTk4MzYw ZmFjZTYyNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjEtMDYtMjMgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjc4OTcw KTogQSBDQVRyYW5zYWN0aW9uIGNvbW1pdEhhbmRsZXIgc2hvdWxkIG5vdCBleGVjdXRlIGEgY2xp ZW50IGNhbGxiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjczMTgKKyAgICAgICAgPHJkYXI6Ly83OTYyNTk2Mj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiB0YWtlU25hcHNob3RXaXRoQ29uZmln dXJhdGlvbigpIHdlIGNhbGwgY2FsbFNuYXBzaG90UmVjdCgpIGluc2lkZSB0aGUKKyAgICAgICAg Y2FsbGJhY2sgb2YgW0NBVHJhbnNhY3Rpb24gYWRkQ29tbWl0SGFuZGxlcl0uCisKKyAgICAgICAg Y2FsbFNuYXBzaG90UmVjdCgpIGNhbGxzIHRoZSBjbGllbnQgY2FsbGJhY2sgd2hpY2ggbWF5IGNh bGwgZGlyZWN0bHkgb3IKKyAgICAgICAgaW5kaXJlY3RseSBhZGRDb21taXRIYW5kbGVyLiBCdXQg aXQgaXMgcHJvaGliaXRlZCBieSBDQSB0byBhZGQgYSBjb21taXQKKyAgICAgICAgaGFuZGxlciB3 aGlsZSBwcm9jZXNzaW5nIGEgcmVnaXN0ZXJlZCBjb21taXQgaGFuZGxlci4KKworICAgICAgICBU aGUgZml4IGlzIHRvIHBvc3Rwb25lIGNhbGxpbmcgY2FsbFNuYXBzaG90UmVjdCgpIHRpbGwgQ0FU cmFuc2FjdGlvbgorICAgICAgICBwcm9jZXNzZXMgYWxsIGl0cyBjb21taXQgaGFuZGxlciBjYWxs YmFja3MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAg ICAgICAgKC1bV0tXZWJWaWV3IHRha2VTbmFwc2hvdFdpdGhDb25maWd1cmF0aW9uOmNvbXBsZXRp b25IYW5kbGVyOl0pOgorCiAyMDIxLTA2LTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgW21hY09TXSBTdXNwZW5kIFdlYlByb2Nlc3NlcyB0aGF0IGFyZSBpbiB0 aGUgcHJvY2VzcyBjYWNoZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcubW0KaW5kZXggM2U3NmI2YTA1MTk4NTU1NjQxMjFmNzQ5N2M3MTFlYTg4MWNiZTc5 Yi4uZGU1YzQ4MzdkYTE4NjczMzVkODJkZWRhMmExMzQ2MzMyNmZhMjdmNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0xMjQyLDcgKzEy NDIsMTIgQEAgc3RhdGljIFdLTWVkaWFQbGF5YmFja1N0YXRlIHRvV0tNZWRpYVBsYXliYWNrU3Rh dGUoV2ViS2l0OjpNZWRpYVBsYXliYWNrU3RhdGUgbWUKIAogICAgICAgICAvLyBXYWl0IGZvciB0 aGUgbmV4dCBmbHVzaCB0byBlbnN1cmUgdGhlIGxhdGVzdCBJT1N1cmZhY2VzIGFyZSBwdXNoZWQg dG8gYmFja2JvYXJkZCBiZWZvcmUgdGFraW5nIHRoZSBzbmFwc2hvdC4KICAgICAgICAgW0NBVHJh bnNhY3Rpb24gYWRkQ29tbWl0SGFuZGxlcjpbY2FsbFNuYXBzaG90UmVjdCA9IFdURk1vdmUoY2Fs bFNuYXBzaG90UmVjdCldIHsKLSAgICAgICAgICAgIGNhbGxTbmFwc2hvdFJlY3QoKTsKKyAgICAg ICAgICAgIC8vIGNhbGxTbmFwc2hvdFJlY3QoKSBjYWxscyB0aGUgY2xpZW50IGNhbGxiYWNrIHdo aWNoIG1heSBjYWxsIGRpcmVjdGx5IG9yIGluZGlyZWN0bHkgYWRkQ29tbWl0SGFuZGxlci4KKyAg ICAgICAgICAgIC8vIEl0IGlzIHByb2hpYml0ZWQgYnkgQ0EgdG8gYWRkIGEgY29tbWl0IGhhbmRs ZXIgd2hpbGUgcHJvY2Vzc2luZyBhIHJlZ2lzdGVyZWQgY29tbWl0IGhhbmRsZXIuCisgICAgICAg ICAgICAvLyBTbyBwb3N0cG9uZSBjYWxsaW5nIGNhbGxTbmFwc2hvdFJlY3QoKSB0aWxsIENBVHJh bnNhY3Rpb24gcHJvY2Vzc2VzIGl0cyBjb21taXQgaGFuZGxlcnMuCisgICAgICAgICAgICBkaXNw YXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBeeworICAgICAgICAgICAgICAg IGNhbGxTbmFwc2hvdFJlY3QoKTsKKyAgICAgICAgICAgIH0pOwogICAgICAgICB9IGZvclBoYXNl OmtDQVRyYW5zYWN0aW9uUGhhc2VQb3N0Q29tbWl0XTsKICAgICB9KTsKICNlbmRpZgo= 432115 2021-06-23 17:07:49 -0700 2021-06-23 22:27:39 -0700 Patch bug-227318-20210623170748.patch text/plain 2621 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQyMzU0NTc1YjgzOTYyYzQx MTJlYzIzYmFkOTJmN2VmNDUzYWI0MjguLmQwYWE1MTBkYmVmNjRhMmJhZGE2MjQ1Mzg5ZDQyMzJm ZDE4MGZlYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjEtMDYtMjMgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjc4OTcw KTogQSBDQVRyYW5zYWN0aW9uIGNvbW1pdEhhbmRsZXIgc2hvdWxkIG5vdCBleGVjdXRlIGEgY2xp ZW50IGNhbGxiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjczMTgKKyAgICAgICAgPHJkYXI6Ly83OTYyNTk2Mj4KKworICAgICAgICBSZXZpZXdl ZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgIEluIHRha2VTbmFwc2hvdFdpdGhDb25maWd1cmF0 aW9uKCkgd2UgY2FsbCBjYWxsU25hcHNob3RSZWN0KCkgaW5zaWRlIHRoZQorICAgICAgICBjYWxs YmFjayBvZiBbQ0FUcmFuc2FjdGlvbiBhZGRDb21taXRIYW5kbGVyXS4KKworICAgICAgICBjYWxs U25hcHNob3RSZWN0KCkgY2FsbHMgdGhlIGNsaWVudCBjYWxsYmFjayB3aGljaCBtYXkgY2FsbCBk aXJlY3RseSBvcgorICAgICAgICBpbmRpcmVjdGx5IGFkZENvbW1pdEhhbmRsZXIuIEJ1dCBpdCBp cyBwcm9oaWJpdGVkIGJ5IENBIHRvIGFkZCBhIGNvbW1pdAorICAgICAgICBoYW5kbGVyIHdoaWxl IHByb2Nlc3NpbmcgYSByZWdpc3RlcmVkIGNvbW1pdCBoYW5kbGVyLgorCisgICAgICAgIFRoZSBm aXggaXMgdG8gcG9zdHBvbmUgY2FsbGluZyBjYWxsU25hcHNob3RSZWN0KCkgdGlsbCBDQVRyYW5z YWN0aW9uCisgICAgICAgIHByb2Nlc3NlcyBhbGwgaXRzIGNvbW1pdCBoYW5kbGVyIGNhbGxiYWNr cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAg ICAoLVtXS1dlYlZpZXcgdGFrZVNuYXBzaG90V2l0aENvbmZpZ3VyYXRpb246Y29tcGxldGlvbkhh bmRsZXI6XSk6CisKIDIwMjEtMDYtMjIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBbbWFjT1NdIFN1c3BlbmQgV2ViUHJvY2Vzc2VzIHRoYXQgYXJlIGluIHRoZSBw cm9jZXNzIGNhY2hlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlldy5tbQppbmRleCAzZTc2YjZhMDUxOTg1NTU2NDEyMWY3NDk3YzcxMWVhODgxY2JlNzliLi41 OTRiZTFjN2ZhMzRjNmRlNThmNTQ1Yzg2ZmVlZTE3YmMzODMyMWEzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTEyNDEsOCArMTI0MSwx MyBAQCBzdGF0aWMgV0tNZWRpYVBsYXliYWNrU3RhdGUgdG9XS01lZGlhUGxheWJhY2tTdGF0ZShX ZWJLaXQ6Ok1lZGlhUGxheWJhY2tTdGF0ZSBtZQogICAgICAgICBbQ0FUcmFuc2FjdGlvbiBhY3Rp dmF0ZV07CiAKICAgICAgICAgLy8gV2FpdCBmb3IgdGhlIG5leHQgZmx1c2ggdG8gZW5zdXJlIHRo ZSBsYXRlc3QgSU9TdXJmYWNlcyBhcmUgcHVzaGVkIHRvIGJhY2tib2FyZGQgYmVmb3JlIHRha2lu ZyB0aGUgc25hcHNob3QuCi0gICAgICAgIFtDQVRyYW5zYWN0aW9uIGFkZENvbW1pdEhhbmRsZXI6 W2NhbGxTbmFwc2hvdFJlY3QgPSBXVEZNb3ZlKGNhbGxTbmFwc2hvdFJlY3QpXSB7Ci0gICAgICAg ICAgICBjYWxsU25hcHNob3RSZWN0KCk7CisgICAgICAgIFtDQVRyYW5zYWN0aW9uIGFkZENvbW1p dEhhbmRsZXI6W2NhbGxTbmFwc2hvdFJlY3QgPSBXVEZNb3ZlKGNhbGxTbmFwc2hvdFJlY3QpXSgp IG11dGFibGUgeworICAgICAgICAgICAgLy8gY2FsbFNuYXBzaG90UmVjdCgpIGNhbGxzIHRoZSBj bGllbnQgY2FsbGJhY2sgd2hpY2ggbWF5IGNhbGwgZGlyZWN0bHkgb3IgaW5kaXJlY3RseSBhZGRD b21taXRIYW5kbGVyLgorICAgICAgICAgICAgLy8gSXQgaXMgcHJvaGliaXRlZCBieSBDQSB0byBh ZGQgYSBjb21taXQgaGFuZGxlciB3aGlsZSBwcm9jZXNzaW5nIGEgcmVnaXN0ZXJlZCBjb21taXQg aGFuZGxlci4KKyAgICAgICAgICAgIC8vIFNvIHBvc3Rwb25lIGNhbGxpbmcgY2FsbFNuYXBzaG90 UmVjdCgpIHRpbGwgQ0FUcmFuc2FjdGlvbiBwcm9jZXNzZXMgaXRzIGNvbW1pdCBoYW5kbGVycy4K KyAgICAgICAgICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIFtj YWxsU25hcHNob3RSZWN0ID0gV1RGTW92ZShjYWxsU25hcHNob3RSZWN0KV0geworICAgICAgICAg ICAgICAgIGNhbGxTbmFwc2hvdFJlY3QoKTsKKyAgICAgICAgICAgIH0pOwogICAgICAgICB9IGZv clBoYXNlOmtDQVRyYW5zYWN0aW9uUGhhc2VQb3N0Q29tbWl0XTsKICAgICB9KTsKICNlbmRpZgo=