227308 2021-06-23 11:46:55 -0700 add/removeManagedReference:withOwner: should have autoreleasepools 2021-06-23 13:00:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller darin ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1772013 0 keith_miller 2021-06-23 11:46:55 -0700 add/removeManagedReference:withOwner: should have autoreleasepools 1772016 1 432077 keith_miller 2021-06-23 11:49:27 -0700 Created attachment 432077 Patch 1772022 2 keith_miller 2021-06-23 12:05:30 -0700 rdar://79024677 1772031 3 ews-feeder 2021-06-23 12:20:08 -0700 Committed r279179 (239075@main): <https://commits.webkit.org/239075@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432077. 432077 2021-06-23 11:49:27 -0700 2021-06-23 13:00:18 -0700 Patch bug-227308-20210623144926.patch text/plain 6323 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 OWM0MTRjYzdiM2ViZmVkMjFhNGJiMTEzYTAxOTU0MmVhZjkyZGE0Li4yN2VjNWJmOGVjYzE4MzEw M2ZiN2VmMTUwYTNlODRjYzJiY2EwMDA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMS0wNi0yMyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBhZGQvcmVtb3ZlTWFuYWdlZFJlZmVyZW5jZTp3aXRoT3duZXI6IHNo b3VsZCBoYXZlIGF1dG9yZWxlYXNlcG9vbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyNzMwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNpbmNlIHRoZXNlIEFQSXMgY3JlYXRlIGF1dG9yZWxlYXNlZCBv YmplY3RzIGFzIGFuIGltcGxlbWVudGF0aW9uIGRldGFpbAorICAgICAgICBidXQgZG9uJ3QgcmV0 dXJuIGFueSB0byB0aGUgY2FsbGVyIHRoZXJlJ3Mgbm8gaW5kaWNhdGlvbiBzdWNoIGF1dG9yZWxl YXNlZAorICAgICAgICBvYmplY3RzIGNvdWxkIGJlIGFjY3VtdWxhdGluZy4gQWRkaXRpb25hbGx5 LCBpdCdzIGVudGlyZWx5IHJlYXNvbmFibGUgdG8KKyAgICAgICAgY2FsbCB0aGVzZSBtZXRob2Rz IGluIGEgbG9vcCBhbiBhIGxhcmdlIHNldCBvZiBvYmplY3RzLCB3aGljaCBmdXJ0aGVyCisgICAg ICAgIGV4YWNlcmJhdGVzIHRoZSBwcm9ibGVtLgorCisgICAgICAgICogQVBJL0pTVmlydHVhbE1h Y2hpbmUubW06CisgICAgICAgICgtW0pTVmlydHVhbE1hY2hpbmUgYWRkTWFuYWdlZFJlZmVyZW5j ZTp3aXRoT3duZXI6XSk6CisgICAgICAgICgtW0pTVmlydHVhbE1hY2hpbmUgcmVtb3ZlTWFuYWdl ZFJlZmVyZW5jZTp3aXRoT3duZXI6XSk6CisKIDIwMjEtMDYtMjMgIFNhYW0gQmFyYXRpICA8c2Jh cmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUnVuIGxhenkgcHJvcGVydGllcyBpbml0aWFsaXpl cnMgdW5kZXIgYSBEZWZlclRlcm1pbmF0aW9uRm9yQVdoaWxlIHNjb3BlCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0gYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0KaW5kZXggYWQ2ZTUwMGZmMWJlY2Q2 MTBjNDAzMDg4MGYxY2NjNTU1ZmViN2FjYS4uNDNjMmI0ZmViNDM0MDBmYzc0YTgzZjQyODU5ZTcz YWQ2NTI3YjQ3ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1 YWxNYWNoaW5lLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNWaXJ0dWFsTWFj aGluZS5tbQpAQCAtMTYyLDY0ICsxNjIsNjggQEAgc3RhdGljIGlkIGdldEludGVybmFsT2JqY09i amVjdChpZCBvYmplY3QpCiB9CiAKIC0gKHZvaWQpYWRkTWFuYWdlZFJlZmVyZW5jZTooaWQpb2Jq ZWN0IHdpdGhPd25lcjooaWQpb3duZXIKLXsgICAgCi0gICAgaWYgKFtvYmplY3QgaXNLaW5kT2ZD bGFzczpbSlNNYW5hZ2VkVmFsdWUgY2xhc3NdXSkKLSAgICAgICAgW29iamVjdCBkaWRBZGRPd25l cjpvd25lcl07Ci0gICAgICAgIAotICAgIG9iamVjdCA9IGdldEludGVybmFsT2JqY09iamVjdChv YmplY3QpOwotICAgIG93bmVyID0gZ2V0SW50ZXJuYWxPYmpjT2JqZWN0KG93bmVyKTsKLSAgICAK LSAgICBpZiAoIW9iamVjdCB8fCAhb3duZXIpCi0gICAgICAgIHJldHVybjsKLSAgICAKLSAgICBK U0M6OkpTTG9ja0hvbGRlciBsb2NrZXIodG9KUyhtX2dyb3VwKSk7Ci0gICAgaWYgKFtzZWxmIGlz T2xkRXh0ZXJuYWxPYmplY3Q6b3duZXJdICYmICFbc2VsZiBpc09sZEV4dGVybmFsT2JqZWN0Om9i amVjdF0pCi0gICAgICAgIFtzZWxmIGFkZEV4dGVybmFsUmVtZW1iZXJlZE9iamVjdDpvd25lcl07 Ci0gCi0gICAgTG9ja2VyIGV4dGVybmFsRGF0YU11dGV4TG9ja2VyIHsgbV9leHRlcm5hbERhdGFN dXRleCB9OwotICAgIFJldGFpblB0cjxOU01hcFRhYmxlPiBvd25lZE9iamVjdHMgPSBbbV9leHRl cm5hbE9iamVjdEdyYXBoIG9iamVjdEZvcktleTpvd25lcl07Ci0gICAgaWYgKCFvd25lZE9iamVj dHMpIHsKLSAgICAgICAgTlNQb2ludGVyRnVuY3Rpb25zT3B0aW9ucyB3ZWFrSURPcHRpb25zID0g TlNQb2ludGVyRnVuY3Rpb25zV2Vha01lbW9yeSB8IE5TUG9pbnRlckZ1bmN0aW9uc09iamVjdFBl cnNvbmFsaXR5OwotICAgICAgICBOU1BvaW50ZXJGdW5jdGlvbnNPcHRpb25zIGludGVnZXJPcHRp b25zID0gTlNQb2ludGVyRnVuY3Rpb25zT3BhcXVlTWVtb3J5IHwgTlNQb2ludGVyRnVuY3Rpb25z SW50ZWdlclBlcnNvbmFsaXR5OwotICAgICAgICBvd25lZE9iamVjdHMgPSBhZG9wdE5TKFtbTlNN YXBUYWJsZSBhbGxvY10gaW5pdFdpdGhLZXlPcHRpb25zOndlYWtJRE9wdGlvbnMgdmFsdWVPcHRp b25zOmludGVnZXJPcHRpb25zIGNhcGFjaXR5OjFdKTsKLQotICAgICAgICBbbV9leHRlcm5hbE9i amVjdEdyYXBoIHNldE9iamVjdDpvd25lZE9iamVjdHMuZ2V0KCkgZm9yS2V5Om93bmVyXTsKLSAg ICB9Cit7CisgICAgQGF1dG9yZWxlYXNlcG9vbCB7CisgICAgICAgIGlmIChbb2JqZWN0IGlzS2lu ZE9mQ2xhc3M6W0pTTWFuYWdlZFZhbHVlIGNsYXNzXV0pCisgICAgICAgICAgICBbb2JqZWN0IGRp ZEFkZE93bmVyOm93bmVyXTsKKworICAgICAgICBvYmplY3QgPSBnZXRJbnRlcm5hbE9iamNPYmpl Y3Qob2JqZWN0KTsKKyAgICAgICAgb3duZXIgPSBnZXRJbnRlcm5hbE9iamNPYmplY3Qob3duZXIp OworCisgICAgICAgIGlmICghb2JqZWN0IHx8ICFvd25lcikKKyAgICAgICAgICAgIHJldHVybjsK KworICAgICAgICBKU0M6OkpTTG9ja0hvbGRlciBsb2NrZXIodG9KUyhtX2dyb3VwKSk7CisgICAg ICAgIGlmIChbc2VsZiBpc09sZEV4dGVybmFsT2JqZWN0Om93bmVyXSAmJiAhW3NlbGYgaXNPbGRF eHRlcm5hbE9iamVjdDpvYmplY3RdKQorICAgICAgICAgICAgW3NlbGYgYWRkRXh0ZXJuYWxSZW1l bWJlcmVkT2JqZWN0Om93bmVyXTsKKworICAgICAgICBMb2NrZXIgZXh0ZXJuYWxEYXRhTXV0ZXhM b2NrZXIgeyBtX2V4dGVybmFsRGF0YU11dGV4IH07CisgICAgICAgIFJldGFpblB0cjxOU01hcFRh YmxlPiBvd25lZE9iamVjdHMgPSBbbV9leHRlcm5hbE9iamVjdEdyYXBoIG9iamVjdEZvcktleTpv d25lcl07CisgICAgICAgIGlmICghb3duZWRPYmplY3RzKSB7CisgICAgICAgICAgICBOU1BvaW50 ZXJGdW5jdGlvbnNPcHRpb25zIHdlYWtJRE9wdGlvbnMgPSBOU1BvaW50ZXJGdW5jdGlvbnNXZWFr TWVtb3J5IHwgTlNQb2ludGVyRnVuY3Rpb25zT2JqZWN0UGVyc29uYWxpdHk7CisgICAgICAgICAg ICBOU1BvaW50ZXJGdW5jdGlvbnNPcHRpb25zIGludGVnZXJPcHRpb25zID0gTlNQb2ludGVyRnVu Y3Rpb25zT3BhcXVlTWVtb3J5IHwgTlNQb2ludGVyRnVuY3Rpb25zSW50ZWdlclBlcnNvbmFsaXR5 OworICAgICAgICAgICAgb3duZWRPYmplY3RzID0gYWRvcHROUyhbW05TTWFwVGFibGUgYWxsb2Nd IGluaXRXaXRoS2V5T3B0aW9uczp3ZWFrSURPcHRpb25zIHZhbHVlT3B0aW9uczppbnRlZ2VyT3B0 aW9ucyBjYXBhY2l0eToxXSk7CisKKyAgICAgICAgICAgIFttX2V4dGVybmFsT2JqZWN0R3JhcGgg c2V0T2JqZWN0Om93bmVkT2JqZWN0cy5nZXQoKSBmb3JLZXk6b3duZXJdOworICAgICAgICB9CiAK LSAgICBzaXplX3QgY291bnQgPSByZWludGVycHJldF9jYXN0PHNpemVfdD4oTlNNYXBHZXQob3du ZWRPYmplY3RzLmdldCgpLCAoX19icmlkZ2Ugdm9pZCopb2JqZWN0KSk7Ci0gICAgTlNNYXBJbnNl cnQob3duZWRPYmplY3RzLmdldCgpLCAoX19icmlkZ2Ugdm9pZCopb2JqZWN0LCByZWludGVycHJl dF9jYXN0PHZvaWQqPihjb3VudCArIDEpKTsKKyAgICAgICAgc2l6ZV90IGNvdW50ID0gcmVpbnRl cnByZXRfY2FzdDxzaXplX3Q+KE5TTWFwR2V0KG93bmVkT2JqZWN0cy5nZXQoKSwgKF9fYnJpZGdl IHZvaWQqKW9iamVjdCkpOworICAgICAgICBOU01hcEluc2VydChvd25lZE9iamVjdHMuZ2V0KCks IChfX2JyaWRnZSB2b2lkKilvYmplY3QsIHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KGNvdW50ICsg MSkpOworICAgIH0KIH0KIAogLSAodm9pZClyZW1vdmVNYW5hZ2VkUmVmZXJlbmNlOihpZClvYmpl Y3Qgd2l0aE93bmVyOihpZClvd25lcgogewotICAgIGlmIChbb2JqZWN0IGlzS2luZE9mQ2xhc3M6 W0pTTWFuYWdlZFZhbHVlIGNsYXNzXV0pCi0gICAgICAgIFtvYmplY3QgZGlkUmVtb3ZlT3duZXI6 b3duZXJdOworICAgIEBhdXRvcmVsZWFzZXBvb2wgeworICAgICAgICBpZiAoW29iamVjdCBpc0tp bmRPZkNsYXNzOltKU01hbmFnZWRWYWx1ZSBjbGFzc11dKQorICAgICAgICAgICAgW29iamVjdCBk aWRSZW1vdmVPd25lcjpvd25lcl07CiAKLSAgICBvYmplY3QgPSBnZXRJbnRlcm5hbE9iamNPYmpl Y3Qob2JqZWN0KTsKLSAgICBvd25lciA9IGdldEludGVybmFsT2JqY09iamVjdChvd25lcik7Ci0g ICAgCi0gICAgaWYgKCFvYmplY3QgfHwgIW93bmVyKQotICAgICAgICByZXR1cm47Ci0gICAgCi0g ICAgSlNDOjpKU0xvY2tIb2xkZXIgbG9ja2VyKHRvSlMobV9ncm91cCkpOwotICAgIAotICAgIExv Y2tlciBleHRlcm5hbERhdGFNdXRleExvY2tlciB7IG1fZXh0ZXJuYWxEYXRhTXV0ZXggfTsKLSAg ICBOU01hcFRhYmxlICpvd25lZE9iamVjdHMgPSBbbV9leHRlcm5hbE9iamVjdEdyYXBoIG9iamVj dEZvcktleTpvd25lcl07Ci0gICAgaWYgKCFvd25lZE9iamVjdHMpCi0gICAgICAgIHJldHVybjsK LSAgIAotICAgIHNpemVfdCBjb3VudCA9IHJlaW50ZXJwcmV0X2Nhc3Q8c2l6ZV90PihOU01hcEdl dChvd25lZE9iamVjdHMsIChfX2JyaWRnZSB2b2lkKilvYmplY3QpKTsKLSAgICBpZiAoY291bnQg PiAxKSB7Ci0gICAgICAgIE5TTWFwSW5zZXJ0KG93bmVkT2JqZWN0cywgKF9fYnJpZGdlIHZvaWQq KW9iamVjdCwgcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oY291bnQgLSAxKSk7Ci0gICAgICAgIHJl dHVybjsKLSAgICB9Ci0gICAgCi0gICAgaWYgKGNvdW50ID09IDEpCi0gICAgICAgIE5TTWFwUmVt b3ZlKG93bmVkT2JqZWN0cywgKF9fYnJpZGdlIHZvaWQqKW9iamVjdCk7CisgICAgICAgIG9iamVj dCA9IGdldEludGVybmFsT2JqY09iamVjdChvYmplY3QpOworICAgICAgICBvd25lciA9IGdldElu dGVybmFsT2JqY09iamVjdChvd25lcik7CisKKyAgICAgICAgaWYgKCFvYmplY3QgfHwgIW93bmVy KQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIEpTQzo6SlNMb2NrSG9sZGVyIGxvY2tl cih0b0pTKG1fZ3JvdXApKTsKIAotICAgIGlmICghW293bmVkT2JqZWN0cyBjb3VudF0pIHsKLSAg ICAgICAgW21fZXh0ZXJuYWxPYmplY3RHcmFwaCByZW1vdmVPYmplY3RGb3JLZXk6b3duZXJdOwot ICAgICAgICBbbV9leHRlcm5hbFJlbWVtYmVyZWRTZXQgcmVtb3ZlT2JqZWN0Rm9yS2V5Om93bmVy XTsKKyAgICAgICAgTG9ja2VyIGV4dGVybmFsRGF0YU11dGV4TG9ja2VyIHsgbV9leHRlcm5hbERh dGFNdXRleCB9OworICAgICAgICBOU01hcFRhYmxlICpvd25lZE9iamVjdHMgPSBbbV9leHRlcm5h bE9iamVjdEdyYXBoIG9iamVjdEZvcktleTpvd25lcl07CisgICAgICAgIGlmICghb3duZWRPYmpl Y3RzKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHNpemVfdCBjb3VudCA9IHJlaW50 ZXJwcmV0X2Nhc3Q8c2l6ZV90PihOU01hcEdldChvd25lZE9iamVjdHMsIChfX2JyaWRnZSB2b2lk KilvYmplY3QpKTsKKyAgICAgICAgaWYgKGNvdW50ID4gMSkgeworICAgICAgICAgICAgTlNNYXBJ bnNlcnQob3duZWRPYmplY3RzLCAoX19icmlkZ2Ugdm9pZCopb2JqZWN0LCByZWludGVycHJldF9j YXN0PHZvaWQqPihjb3VudCAtIDEpKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQor CisgICAgICAgIGlmIChjb3VudCA9PSAxKQorICAgICAgICAgICAgTlNNYXBSZW1vdmUob3duZWRP YmplY3RzLCAoX19icmlkZ2Ugdm9pZCopb2JqZWN0KTsKKworICAgICAgICBpZiAoIVtvd25lZE9i amVjdHMgY291bnRdKSB7CisgICAgICAgICAgICBbbV9leHRlcm5hbE9iamVjdEdyYXBoIHJlbW92 ZU9iamVjdEZvcktleTpvd25lcl07CisgICAgICAgICAgICBbbV9leHRlcm5hbFJlbWVtYmVyZWRT ZXQgcmVtb3ZlT2JqZWN0Rm9yS2V5Om93bmVyXTsKKyAgICAgICAgfQogICAgIH0KIH0KIAo=