227302 2021-06-23 10:17:20 -0700 Remove unneeded explicit exception checks in ScriptModuleLoader::evaluate(). 2021-06-23 12:13:21 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam cdumez webkit-bug-importer ysuzuki oldest_to_newest 1771985 0 mark.lam 2021-06-23 10:17:20 -0700 Patch coming. 1771988 1 432067 mark.lam 2021-06-23 10:22:55 -0700 Created attachment 432067 proposed patch. 1771989 2 432067 ysuzuki 2021-06-23 10:26:19 -0700 Comment on attachment 432067 proposed patch. r=me 1772027 3 mark.lam 2021-06-23 12:12:43 -0700 Thanks for the review. Landed in r279178: <http://trac.webkit.org/r279178>. 1772028 4 webkit-bug-importer 2021-06-23 12:13:21 -0700 <rdar://problem/79683784> 432067 2021-06-23 10:22:55 -0700 2021-06-23 10:26:19 -0700 proposed patch. bug-227302.patch text/plain 2615 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3OTE3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA2LTIzICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWVkZWQgZXhwbGlj aXQgZXhjZXB0aW9uIGNoZWNrcyBpbiBTY3JpcHRNb2R1bGVMb2FkZXI6OmV2YWx1YXRlKCkuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjczMDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIFJFTEVBU0Vf QU5EX1JFVFVSTiB3aWxsIGRvIGJlY2F1c2Ugd2UncmUganVzdCBwcm9wYWdhdGluZyB0aGUgZXhj ZXB0aW9uIHRvIHRoZQorICAgICAgICBjbGllbnQgaW4gYm90aCBjYXNlcy4KKworICAgICAgICAq IGJpbmRpbmdzL2pzL1NjcmlwdE1vZHVsZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT Y3JpcHRNb2R1bGVMb2FkZXI6OmV2YWx1YXRlKToKKwogMjAyMS0wNi0yMyAgS2ltbW8gS2lubnVu ZW4gIDxra2lubnVuZW5AYXBwbGUuY29tPgogCiAgICAgICAgIHJBRiBkcml2ZW4gV2ViR0wgc3Vi bWl0cyBleGNlc3NpdmUgYW1vdW50IG9mIEdQVSB3b3JrIHdoZW4gZnJhbWVzIGFyZSBzbG93Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRNb2R1bGVMb2FkZXIuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdE1vZHVsZUxvYWRl ci5jcHAJKHJldmlzaW9uIDI3OTE3MCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1Nj cmlwdE1vZHVsZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgot ICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMjEgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkg Zm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHBy b3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0yNDQsMTggKzI0NCwxMiBA QCBKU0M6OkpTVmFsdWUgU2NyaXB0TW9kdWxlTG9hZGVyOjpldmFsdWF0CiAgICAgICAgIHJldHVy biBKU0M6OnRocm93VHlwZUVycm9yKGpzR2xvYmFsT2JqZWN0LCBzY29wZSwgIk1vZHVsZSBrZXkg aXMgYW4gaW52YWxpZCBVUkwuIl9zKTsKIAogICAgIGlmIChtX293bmVyVHlwZSA9PSBPd25lclR5 cGU6OkRvY3VtZW50KSB7Ci0gICAgICAgIGlmIChhdXRvKiBmcmFtZSA9IGRvd25jYXN0PERvY3Vt ZW50PihtX2NvbnRleHQpLmZyYW1lKCkpIHsKLSAgICAgICAgICAgIGF1dG8ganNWYWx1ZSA9IGZy YW1lLT5zY3JpcHQoKS5ldmFsdWF0ZU1vZHVsZShzb3VyY2VVUkwsICptb2R1bGVSZWNvcmQsIGF3 YWl0ZWRWYWx1ZSwgcmVzdW1lTW9kZSk7Ci0gICAgICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9O KHNjb3BlLCBKU0M6OmpzVW5kZWZpbmVkKCkpOwotICAgICAgICAgICAgcmV0dXJuIGpzVmFsdWU7 Ci0gICAgICAgIH0KKyAgICAgICAgaWYgKGF1dG8qIGZyYW1lID0gZG93bmNhc3Q8RG9jdW1lbnQ+ KG1fY29udGV4dCkuZnJhbWUoKSkKKyAgICAgICAgICAgIFJFTEVBU0VfQU5EX1JFVFVSTihzY29w ZSwgZnJhbWUtPnNjcmlwdCgpLmV2YWx1YXRlTW9kdWxlKHNvdXJjZVVSTCwgKm1vZHVsZVJlY29y ZCwgYXdhaXRlZFZhbHVlLCByZXN1bWVNb2RlKSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgQVNT RVJUKGlzPFdvcmtlck9yV29ya2xldEdsb2JhbFNjb3BlPihtX2NvbnRleHQpKTsKLSAgICAgICAg aWYgKGF1dG8qIHNjcmlwdCA9IGRvd25jYXN0PFdvcmtlck9yV29ya2xldEdsb2JhbFNjb3BlPiht X2NvbnRleHQpLnNjcmlwdCgpKSB7Ci0gICAgICAgICAgICBhdXRvIGpzVmFsdWUgPSBzY3JpcHQt PmV2YWx1YXRlTW9kdWxlKCptb2R1bGVSZWNvcmQsIGF3YWl0ZWRWYWx1ZSwgcmVzdW1lTW9kZSk7 Ci0gICAgICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBKU0M6OmpzVW5kZWZpbmVk KCkpOwotICAgICAgICAgICAgcmV0dXJuIGpzVmFsdWU7Ci0gICAgICAgIH0KKyAgICAgICAgaWYg KGF1dG8qIHNjcmlwdCA9IGRvd25jYXN0PFdvcmtlck9yV29ya2xldEdsb2JhbFNjb3BlPihtX2Nv bnRleHQpLnNjcmlwdCgpKQorICAgICAgICAgICAgUkVMRUFTRV9BTkRfUkVUVVJOKHNjb3BlLCBz Y3JpcHQtPmV2YWx1YXRlTW9kdWxlKCptb2R1bGVSZWNvcmQsIGF3YWl0ZWRWYWx1ZSwgcmVzdW1l TW9kZSkpOwogICAgIH0KICAgICByZXR1cm4gSlNDOjpqc1VuZGVmaW5lZCgpOwogfQo=