22730 2008-12-07 18:05:20 -0800 Adding test to verify that an active timer does not cause a mem leak by keeping protected JS objects 2008-12-08 23:49:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dimich webkit-unassigned ap darin oldest_to_newest 101776 0 dimich 2008-12-07 18:05:20 -0800 This is a test for bug 22710. 101778 1 25833 dimich 2008-12-07 18:07:19 -0800 Created attachment 25833 proposed patch 101789 2 ap 2008-12-07 23:18:44 -0800 Tests that use GCController.getJSObjectCount() break when running "run-webkit-tests --threaded", so I'm not sure if they are a gain or a loss. Perhaps we should remove the --threaded option altogether, now that multithreading is tested in fast/workers? 101792 3 ap 2008-12-07 23:46:33 -0800 Now that I think about it more, GCController.getJSObjectCount() will work fine in all tests when I land my patch that makes JSCreateGlobalObject use a unique context group. 101824 4 25833 darin 2008-12-08 10:24:14 -0800 Comment on attachment 25833 proposed patch Test looks good, r=me There is a typo in a comment: "shoudl". 101838 5 25847 dimich 2008-12-08 11:43:36 -0800 Created attachment 25847 Same test, fixed the typo Fixed the typo. 101946 6 ap 2008-12-08 23:49:25 -0800 Committed revision 39131. 25833 2008-12-07 18:07:19 -0800 2008-12-08 10:24:14 -0800 proposed patch test_patch.txt text/plain 3581 dimich SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM5MDg4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTItMDcgIERtaXRyeSBUaXRvdiAgPGRp bWljaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisgICAgICAgIFRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjcxMAorICAgICAgICBWZXJpZmllcyB0aGF0IGFjdGl2ZSB0aW1lb3V0IGRvZXMgbm90IGNh dXNlIG1lbSBsZWFrLgorCisgICAgICAgICogZmFzdC9kb20vV2luZG93L3Jlc291cmNlcy9sb25n X3RpbWVvdXQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vV2luZG93L3RpbWVvdXQt cmVsZWFzZWQtb24tY2xvc2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Rv bS9XaW5kb3cvdGltZW91dC1yZWxlYXNlZC1vbi1jbG9zZS5odG1sOiBBZGRlZC4KKwogMjAwOC0x Mi0wNyAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE9saXZlciBIdW50LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3RpbWVv dXQtcmVsZWFzZWQtb24tY2xvc2UtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvZG9tL1dpbmRvdy90aW1lb3V0LXJlbGVhc2VkLW9uLWNsb3NlLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy90aW1lb3V0LXJl bGVhc2VkLW9uLWNsb3NlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0IEBA CitUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBhbiBhY3RpdmUgdGltZW91dCB0aGF0IGRpZG4ndCB5 ZXQgZmlyZSBkb2VzIG5vdCBwcmV2ZW50IGEgRG9jdW1lbnQgZnJvbSByZWxlYXNpbmcgKGJ1ZyBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MTApLiBUZXN0IGNhbiBv bmx5IHJ1biBpbiBEdW1wUmVuZGVyVHJlZSBzaW5jZSBpdCBuZWVkcyBHQ0NvbnRyb2xsZXIuIFRl c3QgaXMgc3VjY2Vzc2Z1bCBpZiBpdCBwcmludHMgJ1BBU1MnLgorCitQQVNTCisKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy90aW1lb3V0LXJlbGVhc2VkLW9uLWNsb3NlLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3RpbWVvdXQtcmVsZWFz ZWQtb24tY2xvc2UuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1dp bmRvdy90aW1lb3V0LXJlbGVhc2VkLW9uLWNsb3NlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMzEgQEAKKzxzY3JpcHQ+Cit2YXIgb2JqZWN0Q291bnRCZWZvcmU7CisKKy8vIFRoZSB0ZXN0 IHdvcmtzIGJ5IGZpcnN0IG5hdmlnYXRpbmcgaWZyYW1lIHRvIGEgcGFnZSB0aGF0IGFsbG9jYXRl cyBhIGxvdCBvZiBKUyBvYmplY3RzCisvLyBhbmQgdGhlbiBjcmVhdGVzIGEgbG9uZyB0aW1lb3V0 LiBUaGVuIGlmcmFtZSBpcyBuYXZpZ2F0ZWQgdG8gYWJvdXQ6YmxhbmsgYW5kIHRoZSBudW1iZXIg b2YgSlMKKy8vIG9iamVjdHMgaXMgdmVyaWZpZWQgLSB0aGVyZSBzaG91ZGwgYmUgYSBzaWduaWZp Y2FudCBkcm9wIGluIHRoZWlyIG51bWJlci4KK2Z1bmN0aW9uIHN0YXJ0KCkKK3sKKyAgICBpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyICYmIHdpbmRvdy5HQ0NvbnRyb2xsZXIpIHsKKyAg ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgICAgIHdpbmRvdy5HQ0NvbnRyb2xs ZXIuY29sbGVjdCgpOworICAgICAgICBvYmplY3RDb3VudEJlZm9yZSA9IHdpbmRvdy5HQ0NvbnRy b2xsZXIuZ2V0SlNPYmplY3RDb3VudCgpOworICAgICAgICBpZnJhbWVFbGVtZW50ID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoImlmcmFtZSIpOworICAgICAgICBpZnJhbWVFbGVtZW50LnNldEF0 dHJpYnV0ZSgib25sb2FkIiwgInZlcmlmeSgpIik7CisgICAgICAgIGlmcmFtZUVsZW1lbnQuc3Jj ID0gImFib3V0OmJsYW5rIjsKKyAgICB9Cit9CisKK2Z1bmN0aW9uIHZlcmlmeSgpCit7CisgICAg d2luZG93LkdDQ29udHJvbGxlci5jb2xsZWN0KCk7CisgICAgdmFyIGNvbGxlY3RlZE9iamVjdHND b3VudCA9IG9iamVjdENvdW50QmVmb3JlIC0gd2luZG93LkdDQ29udHJvbGxlci5nZXRKU09iamVj dENvdW50KCk7CisgICAgLy8gbG9uZ190aW1lb3V0Lmh0bWwgYWxsb2NhdGVzIDEwMCBKUyBzdHJp bmdzLiBUaGV5IHNob3VsZCBiZSBnb25lLgorICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJy ZXN1bHQiKS5pbm5lclRleHQgPSAoY29sbGVjdGVkT2JqZWN0c0NvdW50ID49IDEwMCA/ICJQQVNT IiA6ICJGQUlMIik7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworfQor PC9zY3JpcHQ+Cis8cD5UaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBhbiBhY3RpdmUgdGltZW91dCB0 aGF0IGRpZG4ndCB5ZXQgZmlyZSBkb2VzIG5vdCBwcmV2ZW50IGEgRG9jdW1lbnQgZnJvbSByZWxl YXNpbmcgKGJ1ZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MTAp LiBUZXN0IGNhbiBvbmx5IHJ1biBpbiBEdW1wUmVuZGVyVHJlZSBzaW5jZSBpdCBuZWVkcyBHQ0Nv bnRyb2xsZXIuIFRlc3QgaXMgc3VjY2Vzc2Z1bCBpZiBpdCBwcmludHMgJ1BBU1MnLjwvcD4KKzxk aXYgaWQ9InJlc3VsdCI+PC9kaXY+Cis8aWZyYW1lIG9ubG9hZD0ic3RhcnQoKSIgaWQ9ImlmcmFt ZSIgc3JjPSJyZXNvdXJjZXMvbG9uZ190aW1lb3V0Lmh0bWwiPjwvaWZyYW1lPgpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3Jlc291cmNlcy9sb25nX3RpbWVvdXQuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvcmVzb3VyY2VzL2xvbmdfdGlt ZW91dC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3Jl c291cmNlcy9sb25nX3RpbWVvdXQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw4IEBACis8 c2NyaXB0Pgord2luZG93LnN0dWZmID0gbmV3IEFycmF5OworZm9yIChpID0gMDsgaSA8IDEwMDsg KytpKQorICB3aW5kb3cuc3R1ZmYucHVzaChuZXcgU3RyaW5nKCJhYmMiKSk7CisKK3dpbmRvdy5z ZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyB9LCAxMDAwMCk7Cis8L3NjcmlwdD4KKwo= 25847 2008-12-08 11:43:36 -0800 2008-12-08 11:43:36 -0800 Same test, fixed the typo test-patch-v2.txt text/plain 3589 dimich SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM5MDkxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTItMDggIERtaXRyeSBUaXRvdiAgPGRp bWljaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisgICAgICAgIFRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjcxMAorICAgICAgICBWZXJpZmllcyB0aGF0IGFjdGl2ZSB0aW1lb3V0IGRvZXMgbm90IGNh dXNlIG1lbSBsZWFrLgorCisgICAgICAgICogZmFzdC9kb20vV2luZG93L3Jlc291cmNlcy9sb25n X3RpbWVvdXQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vV2luZG93L3RpbWVvdXQt cmVsZWFzZWQtb24tY2xvc2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Rv bS9XaW5kb3cvdGltZW91dC1yZWxlYXNlZC1vbi1jbG9zZS5odG1sOiBBZGRlZC4KKwogMjAwOC0x Mi0wNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5k b3cvdGltZW91dC1yZWxlYXNlZC1vbi1jbG9zZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3RpbWVvdXQtcmVsZWFzZWQtb24tY2xvc2UtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3Rp bWVvdXQtcmVsZWFzZWQtb24tY2xvc2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDQgQEAKK1RoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGFuIGFjdGl2ZSB0aW1lb3V0IHRoYXQg ZGlkbid0IHlldCBmaXJlIGRvZXMgbm90IHByZXZlbnQgYSBEb2N1bWVudCBmcm9tIHJlbGVhc2lu ZyAoYnVnIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjcxMCkuIFRl c3QgY2FuIG9ubHkgcnVuIGluIER1bXBSZW5kZXJUcmVlIHNpbmNlIGl0IG5lZWRzIEdDQ29udHJv bGxlci4gVGVzdCBpcyBzdWNjZXNzZnVsIGlmIGl0IHByaW50cyAnUEFTUycuCisKK1BBU1MKKwpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3RpbWVvdXQtcmVsZWFzZWQtb24tY2xv c2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvdGltZW91 dC1yZWxlYXNlZC1vbi1jbG9zZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC9kb20vV2luZG93L3RpbWVvdXQtcmVsZWFzZWQtb24tY2xvc2UuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwzMSBAQAorPHNjcmlwdD4KK3ZhciBvYmplY3RDb3VudEJlZm9yZTsKKworLy8g VGhlIHRlc3Qgd29ya3MgYnkgZmlyc3QgbmF2aWdhdGluZyBpZnJhbWUgdG8gYSBwYWdlIHRoYXQg YWxsb2NhdGVzIGEgbG90IG9mIEpTIG9iamVjdHMKKy8vIGFuZCB0aGVuIGNyZWF0ZXMgYSBsb25n IHRpbWVvdXQuIFRoZW4gaWZyYW1lIGlzIG5hdmlnYXRlZCB0byBhYm91dDpibGFuayBhbmQgdGhl IG51bWJlciBvZiBKUworLy8gb2JqZWN0cyBpcyB2ZXJpZmllZCAtIHRoZXJlIHNob3VsZCBiZSBh IHNpZ25pZmljYW50IGRyb3AgaW4gdGhlaXIgbnVtYmVyLgorZnVuY3Rpb24gc3RhcnQoKQorewor ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIgJiYgd2luZG93LkdDQ29udHJvbGxl cikgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAg IGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgd2luZG93LkdD Q29udHJvbGxlci5jb2xsZWN0KCk7CisgICAgICAgIG9iamVjdENvdW50QmVmb3JlID0gd2luZG93 LkdDQ29udHJvbGxlci5nZXRKU09iamVjdENvdW50KCk7CisgICAgICAgIGlmcmFtZUVsZW1lbnQg PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaWZyYW1lIik7CisgICAgICAgIGlmcmFtZUVsZW1l bnQuc2V0QXR0cmlidXRlKCJvbmxvYWQiLCAidmVyaWZ5KCkiKTsKKyAgICAgICAgaWZyYW1lRWxl bWVudC5zcmMgPSAiYWJvdXQ6YmxhbmsiOworICAgIH0KK30KKworZnVuY3Rpb24gdmVyaWZ5KCkK K3sKKyAgICB3aW5kb3cuR0NDb250cm9sbGVyLmNvbGxlY3QoKTsKKyAgICB2YXIgY29sbGVjdGVk T2JqZWN0c0NvdW50ID0gb2JqZWN0Q291bnRCZWZvcmUgLSB3aW5kb3cuR0NDb250cm9sbGVyLmdl dEpTT2JqZWN0Q291bnQoKTsKKyAgICAvLyBsb25nX3RpbWVvdXQuaHRtbCBhbGxvY2F0ZXMgMTAw IEpTIHN0cmluZ3MuIFRoZXkgc2hvdWxkIGJlIGdvbmUuCisgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInJlc3VsdCIpLmlubmVyVGV4dCA9IChjb2xsZWN0ZWRPYmplY3RzQ291bnQgPj0gMTAw ID8gIlBBU1MiIDogIkZBSUwiKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25l KCk7Cit9Cis8L3NjcmlwdD4KKzxwPlRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGFuIGFjdGl2ZSB0 aW1lb3V0IHRoYXQgZGlkbid0IHlldCBmaXJlIGRvZXMgbm90IHByZXZlbnQgYSBEb2N1bWVudCBm cm9tIHJlbGVhc2luZyAoYnVnIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjcxMCkuIFRlc3QgY2FuIG9ubHkgcnVuIGluIER1bXBSZW5kZXJUcmVlIHNpbmNlIGl0IG5l ZWRzIEdDQ29udHJvbGxlci4gVGVzdCBpcyBzdWNjZXNzZnVsIGlmIGl0IHByaW50cyAnUEFTUycu PC9wPgorPGRpdiBpZD0icmVzdWx0Ij48L2Rpdj4KKzxpZnJhbWUgb25sb2FkPSJzdGFydCgpIiBp ZD0iaWZyYW1lIiBzcmM9InJlc291cmNlcy9sb25nX3RpbWVvdXQuaHRtbCI+PC9pZnJhbWU+Cklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvcmVzb3VyY2VzL2xvbmdfdGltZW91dC5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9yZXNvdXJjZXMv bG9uZ190aW1lb3V0Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9X aW5kb3cvcmVzb3VyY2VzL2xvbmdfdGltZW91dC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDggQEAKKzxzY3JpcHQ+Cit3aW5kb3cuc3R1ZmYgPSBuZXcgQXJyYXk7Citmb3IgKGkgPSAwOyBp IDwgMTAwOyArK2kpCisgIHdpbmRvdy5zdHVmZi5wdXNoKG5ldyBTdHJpbmcoImFiYyIpKTsKKwor d2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7IH0sIDEwMDAwKTsKKzwvc2NyaXB0PgorCg==