227278 2021-06-22 22:02:21 -0700 Message dropped when restoring webpages. 2021-06-22 23:35:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton webkit-bug-importer oldest_to_newest 1771855 0 megan_gardner 2021-06-22 22:02:21 -0700 Message dropped when restoring webpages. 1771856 1 432018 megan_gardner 2021-06-22 22:07:43 -0700 Created attachment 432018 Patch 1771857 2 432018 thorton 2021-06-22 22:12:57 -0700 Comment on attachment 432018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432018&action=review > Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:615 > setAppHighlightsVisibility(isVisible ? WebCore::HighlightVisibility::Visible : WebCore::HighlightVisibility::Hidden); > }; You could shove this block inline instead of in a local, now, if you wanted. But this is fine too. 1771858 3 megan_gardner 2021-06-22 22:35:51 -0700 I liked it and left it on purpose ;P 1771865 4 ews-feeder 2021-06-22 23:34:37 -0700 Committed r279166 (239063@main): <https://commits.webkit.org/239063@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432018. 1771866 5 webkit-bug-importer 2021-06-22 23:35:17 -0700 <rdar://problem/79651855> 432018 2021-06-22 22:07:43 -0700 2021-06-22 23:34:38 -0700 Patch bug-227278-20210622220742.patch text/plain 1763 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQyMzU0NTc1YjgzOTYyYzQx MTJlYzIzYmFkOTJmN2VmNDUzYWI0MjguLmI1Mjc1ODIwYWE0ZWY1ZmNiMDYzYmE2MmVhNTlkNzIw MzAzZGYxYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDYtMjIgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBNZXNzYWdlIGRyb3Bw ZWQgd2hlbiByZXN0b3Jpbmcgd2VicGFnZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjcyNzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgbWVzc2FnZSB0byBpbml0aWFsaXplIHRoZSBzdGF0ZSBv ZiBoaWdobGlnaHRWaXNpYmlsaXR5IGlzIGRyb3BwZWQgc29tZXRpbWVzLCBidXQKKyAgICAgICAg Zm9ydHVuYXRlbHksIHRoZXJlIGlzIG5vIG5lZWQgdG8gcGFzcyB0aGUgY3VycmVudCBzdGF0ZSB3 aGVuIGluaXRpYWxpemluZyB0aGUKKyAgICAgICAgSGlnaGxpZ2h0T2JzZXJ2ZXIsIGFzIFdlYlBh Z2VQcm94eTo6Y3JlYXRpb25QYXJhbWV0ZXJzIHdpbGwgb2J0YWluIHRoZSBjb3JyZWN0CisgICAg ICAgIGhpZ2hsaWdodCBzdGF0ZSBvbiBpbml0aWFsaXphdGlvbiBhZnRlciByMjc5MDc4LgorCisg ICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlBhZ2VQcm94eUNvY29hLm1tOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OnNldFVwSGlnaGxpZ2h0c09ic2VydmVyKToKKwogMjAyMS0w Ni0yMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10g U3VzcGVuZCBXZWJQcm9jZXNzZXMgdGhhdCBhcmUgaW4gdGhlIHByb2Nlc3MgY2FjaGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlBhZ2VQcm94eUNvY29hLm1t IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFnZVByb3h5Q29jb2EubW0KaW5k ZXggZDkxZGMwN2QwN2NkNjBjZmMyNzcxNTM2NzFkMmU2MWUyZjU0MTM4OS4uMmI5Yzc1OTgxOWNm MWNjNjE1NWJkYTc4ZDU2YTNkNjA2MmY4NjY0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQ29jb2EvV2ViUGFnZVByb3h5Q29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQ29jb2EvV2ViUGFnZVByb3h5Q29jb2EubW0KQEAgLTYxNCw3ICs2MTQsNiBAQCB2 b2lkIFdlYlBhZ2VQcm94eTo6c2V0VXBIaWdobGlnaHRzT2JzZXJ2ZXIoKQogICAgICAgICBzZXRB cHBIaWdobGlnaHRzVmlzaWJpbGl0eShpc1Zpc2libGUgPyBXZWJDb3JlOjpIaWdobGlnaHRWaXNp YmlsaXR5OjpWaXNpYmxlIDogV2ViQ29yZTo6SGlnaGxpZ2h0VmlzaWJpbGl0eTo6SGlkZGVuKTsK ICAgICB9OwogICAgIG1fYXBwSGlnaGxpZ2h0c09ic2VydmVyID0gYWRvcHROUyhbYWxsb2NTWU5v dGVzQWN0aXZhdGlvbk9ic2VydmVySW5zdGFuY2UoKSBpbml0V2l0aEhhbmRsZXI6dXBkYXRlQXBw SGlnaGxpZ2h0c1Zpc2liaWxpdHldKTsKLSAgICB1cGRhdGVBcHBIaWdobGlnaHRzVmlzaWJpbGl0 eShbbV9hcHBIaWdobGlnaHRzT2JzZXJ2ZXIgaXNWaXNpYmxlXSk7CiB9CiAKICNlbmRpZgo=