227272 2021-06-22 16:36:47 -0700 [ANGLE Metal] - Set barriers on transform feedback buffers only up to the in use buffer count 2021-06-24 16:12:17 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 johncunningham webkit-unassigned dino ews-watchlist kbr kkinnunen kondapallykalyan simon.fraser webkit-bug-importer oldest_to_newest 1771817 0 johncunningham 2021-06-22 16:36:47 -0700 [ANGLE Metal] - Set barriers on transform feedback buffers only up to the in use buffer count 1771818 1 432006 johncunningham 2021-06-22 16:37:27 -0700 Created attachment 432006 Patch 1771819 2 ews-watchlist 2021-06-22 16:38:38 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1771820 3 johncunningham 2021-06-22 16:40:57 -0700 rdar://79587861 1772087 4 432006 simon.fraser 2021-06-23 15:38:54 -0700 Comment on attachment 432006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432006&action=review > Source/ThirdParty/ANGLE/ChangeLog:5 > + https://bugs.webkit.org/show_bug.cgi?id=227272 > + The radar number should go here. 1772417 5 432203 johncunningham 2021-06-24 12:32:40 -0700 Created attachment 432203 Patch 1772472 6 432219 johncunningham 2021-06-24 15:43:38 -0700 Created attachment 432219 Patch 1772478 7 ews-feeder 2021-06-24 16:11:56 -0700 Committed r279251 (239135@main): <https://commits.webkit.org/239135@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432219. 1772479 8 webkit-bug-importer 2021-06-24 16:12:17 -0700 <rdar://problem/79747048> 432006 2021-06-22 16:37:27 -0700 2021-06-24 12:32:38 -0700 Patch bug-227272-20210622163726.patch text/plain 2329 johncunningham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNTg5MTNmOTQyODQ0YzViYWVhYzY0NWRkNzU5YTkyMTYwMjdmNTk3ZC4uYzQ4OTE0YmY3ZDUy OGNmOTExNTc5YzlkMmZjYjQxN2U5MWYyOGFlOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA2LTIyICBKb2huIEN1bm5pbmdoYW0gIDxqb2huY3Vu bmluZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0FOR0xFIE1ldGFsXSAtIFNldCBiYXJyaWVy cyBvbiB0cmFuc2Zvcm0gZmVlZGJhY2sgYnVmZmVycyBvbmx5IHVwIHRvIHRoZSBpbiB1c2UgYnVm ZmVyIGNvdW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjcyNzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHNyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9Db250ZXh0TXRsLm1tOgorICAgICAgICAo cng6OkNvbnRleHRNdGw6Om9uRW5kVHJhbnNmb3JtRmVlZGJhY2spOgorCiAyMDIxLTA2LTE2ICBL aW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgQU5HTEUgTWV0 YWwgZ2wgc3luYyBvYmplY3RzIGRvIG5vdCB3b3JrIGluIGNhc2Ugb2YgbGlzdGVuZXIgYmVpbmcg bmVlZGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUv cmVuZGVyZXIvbWV0YWwvQ29udGV4dE10bC5tbSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3Ny Yy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9Db250ZXh0TXRsLm1tCmluZGV4IDliNDk2YzI3YTRl NDdiODgzNTdmNjMxNTE3MzIyNmZkMWQyODdiM2YuLmNjOWJiZjE0NmM3NDUzNzgzYTFiZWU3YTIx MjFmYmFlOTAwOWFlZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9s aWJBTkdMRS9yZW5kZXJlci9tZXRhbC9Db250ZXh0TXRsLm1tCisrKyBiL1NvdXJjZS9UaGlyZFBh cnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9Db250ZXh0TXRsLm1tCkBAIC0x NDEyLDkgKzE0MTIsMTYgQEAgdm9pZCBDb250ZXh0TXRsOjpvbkVuZFRyYW5zZm9ybUZlZWRiYWNr KCkKICAgICB9CiAgICAgaWYgKGdldERpc3BsYXkoKS0+Z2V0RmVhdHVyZXMoKS5oYXNFeHBsaWNp dE1lbUJhcnJpZXIuZW5hYmxlZCkKICAgICB7Ci0gICAgICAgIGZvcihhdXRvICYgYnVmZmVyUmVm IDogbUN1cnJlbnRUcmFuc2Zvcm1GZWVkYmFja0J1ZmZlcnMpCisgICAgICAgIGNvbnN0IGdsOjpQ cm9ncmFtRXhlY3V0YWJsZSAqZXhlY3V0YWJsZSA9IG1TdGF0ZS5nZXRQcm9ncmFtRXhlY3V0YWJs ZSgpOworICAgICAgICBBU1NFUlQoZXhlY3V0YWJsZSk7CisgICAgICAgIEFTU0VSVChleGVjdXRh YmxlLT5oYXNUcmFuc2Zvcm1GZWVkYmFja091dHB1dCgpIHx8IG1TdGF0ZS5pc1RyYW5zZm9ybUZl ZWRiYWNrQWN0aXZlKCkpOworICAgICAgICBUcmFuc2Zvcm1GZWVkYmFja010bCAqdHJhbnNmb3Jt RmVlZGJhY2tNdGwgPSBtdGw6OkdldEltcGwobVN0YXRlLmdldEN1cnJlbnRUcmFuc2Zvcm1GZWVk YmFjaygpKTsKKyAgICAgICAgc2l6ZV90IGJ1ZmZlckNvdW50ICAgICAgICAgICAgICAgICAgICAg ICAgID0gZXhlY3V0YWJsZS0+Z2V0VHJhbnNmb3JtRmVlZGJhY2tCdWZmZXJDb3VudCgpOworICAg ICAgICBjb25zdCBnbDo6VHJhbnNmb3JtRmVlZGJhY2tCdWZmZXJzQXJyYXk8QnVmZmVyTXRsICo+ ICZidWZmZXJIYW5kbGVzID0KKyAgICAgICAgICAgIHRyYW5zZm9ybUZlZWRiYWNrTXRsLT5nZXRC dWZmZXJIYW5kbGVzKCk7CisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgYnVmZmVyQ291 bnQ7IGkrKykKICAgICAgICAgewotICAgICAgICAgICAgY29uc3QgbXRsOjpCdWZmZXJSZWYgJiBj b25zdEJ1ZmZlclJlZiA9IGJ1ZmZlclJlZi0+Z2V0Q3VycmVudEJ1ZmZlcigpOworICAgICAgICAg ICAgY29uc3QgbXRsOjpCdWZmZXJSZWYgJiBjb25zdEJ1ZmZlclJlZiA9IGJ1ZmZlckhhbmRsZXNb aV0tPmdldEN1cnJlbnRCdWZmZXIoKTsKICAgICAgICAgICAgIG1SZW5kZXJFbmNvZGVyLm1lbW9y eUJhcnJpZXJXaXRoUmVzb3VyY2UoY29uc3RCdWZmZXJSZWYsIG10bDo6a1JlbmRlclN0YWdlVmVy dGV4LCBtdGw6OmtSZW5kZXJTdGFnZVZlcnRleCk7CiAgICAgICAgIH0KICAgICB9Cg== 432203 2021-06-24 12:32:40 -0700 2021-06-24 15:43:35 -0700 Patch bug-227272-20210624123240.patch text/plain 2356 johncunningham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNTg5MTNmOTQyODQ0YzViYWVhYzY0NWRkNzU5YTkyMTYwMjdmNTk3ZC4uYjQ3NjE3OWNjNDVm ZDJjNzNjYTg5YTA0NDE4N2VmNmY5YjkwYTJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA2LTIyICBKb2huIEN1bm5pbmdoYW0gIDxqb2huY3Vu bmluZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0FOR0xFIE1ldGFsXSAtIFNldCBiYXJyaWVy cyBvbiB0cmFuc2Zvcm0gZmVlZGJhY2sgYnVmZmVycyBvbmx5IHVwIHRvIHRoZSBpbiB1c2UgYnVm ZmVyIGNvdW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjcyNzIKKyAgICAgICAgPHJkYXI6Ly83OTU4Nzg2MT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRh bC9Db250ZXh0TXRsLm1tOgorICAgICAgICAocng6OkNvbnRleHRNdGw6Om9uRW5kVHJhbnNmb3Jt RmVlZGJhY2spOgorCiAyMDIxLTA2LTE2ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBs ZS5jb20+CiAKICAgICAgICAgQU5HTEUgTWV0YWwgZ2wgc3luYyBvYmplY3RzIGRvIG5vdCB3b3Jr IGluIGNhc2Ugb2YgbGlzdGVuZXIgYmVpbmcgbmVlZGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQ29udGV4dE10bC5tbSBi L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9Db250 ZXh0TXRsLm1tCmluZGV4IDliNDk2YzI3YTRlNDdiODgzNTdmNjMxNTE3MzIyNmZkMWQyODdiM2Yu LmNjOWJiZjE0NmM3NDUzNzgzYTFiZWU3YTIxMjFmYmFlOTAwOWFlZTAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9Db250ZXh0 TXRsLm1tCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJl ci9tZXRhbC9Db250ZXh0TXRsLm1tCkBAIC0xNDEyLDkgKzE0MTIsMTYgQEAgdm9pZCBDb250ZXh0 TXRsOjpvbkVuZFRyYW5zZm9ybUZlZWRiYWNrKCkKICAgICB9CiAgICAgaWYgKGdldERpc3BsYXko KS0+Z2V0RmVhdHVyZXMoKS5oYXNFeHBsaWNpdE1lbUJhcnJpZXIuZW5hYmxlZCkKICAgICB7Ci0g ICAgICAgIGZvcihhdXRvICYgYnVmZmVyUmVmIDogbUN1cnJlbnRUcmFuc2Zvcm1GZWVkYmFja0J1 ZmZlcnMpCisgICAgICAgIGNvbnN0IGdsOjpQcm9ncmFtRXhlY3V0YWJsZSAqZXhlY3V0YWJsZSA9 IG1TdGF0ZS5nZXRQcm9ncmFtRXhlY3V0YWJsZSgpOworICAgICAgICBBU1NFUlQoZXhlY3V0YWJs ZSk7CisgICAgICAgIEFTU0VSVChleGVjdXRhYmxlLT5oYXNUcmFuc2Zvcm1GZWVkYmFja091dHB1 dCgpIHx8IG1TdGF0ZS5pc1RyYW5zZm9ybUZlZWRiYWNrQWN0aXZlKCkpOworICAgICAgICBUcmFu c2Zvcm1GZWVkYmFja010bCAqdHJhbnNmb3JtRmVlZGJhY2tNdGwgPSBtdGw6OkdldEltcGwobVN0 YXRlLmdldEN1cnJlbnRUcmFuc2Zvcm1GZWVkYmFjaygpKTsKKyAgICAgICAgc2l6ZV90IGJ1ZmZl ckNvdW50ICAgICAgICAgICAgICAgICAgICAgICAgID0gZXhlY3V0YWJsZS0+Z2V0VHJhbnNmb3Jt RmVlZGJhY2tCdWZmZXJDb3VudCgpOworICAgICAgICBjb25zdCBnbDo6VHJhbnNmb3JtRmVlZGJh Y2tCdWZmZXJzQXJyYXk8QnVmZmVyTXRsICo+ICZidWZmZXJIYW5kbGVzID0KKyAgICAgICAgICAg IHRyYW5zZm9ybUZlZWRiYWNrTXRsLT5nZXRCdWZmZXJIYW5kbGVzKCk7CisgICAgICAgIGZvciAo c2l6ZV90IGkgPSAwOyBpIDwgYnVmZmVyQ291bnQ7IGkrKykKICAgICAgICAgewotICAgICAgICAg ICAgY29uc3QgbXRsOjpCdWZmZXJSZWYgJiBjb25zdEJ1ZmZlclJlZiA9IGJ1ZmZlclJlZi0+Z2V0 Q3VycmVudEJ1ZmZlcigpOworICAgICAgICAgICAgY29uc3QgbXRsOjpCdWZmZXJSZWYgJiBjb25z dEJ1ZmZlclJlZiA9IGJ1ZmZlckhhbmRsZXNbaV0tPmdldEN1cnJlbnRCdWZmZXIoKTsKICAgICAg ICAgICAgIG1SZW5kZXJFbmNvZGVyLm1lbW9yeUJhcnJpZXJXaXRoUmVzb3VyY2UoY29uc3RCdWZm ZXJSZWYsIG10bDo6a1JlbmRlclN0YWdlVmVydGV4LCBtdGw6OmtSZW5kZXJTdGFnZVZlcnRleCk7 CiAgICAgICAgIH0KICAgICB9Cg== 432219 2021-06-24 15:43:38 -0700 2021-06-24 16:11:57 -0700 Patch bug-227272-20210624154337.patch text/plain 2354 johncunningham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNTg5MTNmOTQyODQ0YzViYWVhYzY0NWRkNzU5YTkyMTYwMjdmNTk3ZC4uODNmYjU5ZjUxNWY5 MDlhNzEyYzlkN2NhYTQ2N2Q2YWVlNTA5YThiOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA2LTIyICBKb2huIEN1bm5pbmdoYW0gIDxqb2huY3Vu bmluZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0FOR0xFIE1ldGFsXSAtIFNldCBiYXJyaWVy cyBvbiB0cmFuc2Zvcm0gZmVlZGJhY2sgYnVmZmVycyBvbmx5IHVwIHRvIHRoZSBpbiB1c2UgYnVm ZmVyIGNvdW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjcyNzIKKyAgICAgICAgPHJkYXI6Ly83OTU4Nzg2MT4KKworICAgICAgICBSZXZpZXdlZCBi eSBEZWFuIEphY2tzb24uCisKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwv Q29udGV4dE10bC5tbToKKyAgICAgICAgKHJ4OjpDb250ZXh0TXRsOjpvbkVuZFRyYW5zZm9ybUZl ZWRiYWNrKToKKwogMjAyMS0wNi0xNiAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIEFOR0xFIE1ldGFsIGdsIHN5bmMgb2JqZWN0cyBkbyBub3Qgd29yayBp biBjYXNlIG9mIGxpc3RlbmVyIGJlaW5nIG5lZWRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL0NvbnRleHRNdGwubW0gYi9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQ29udGV4 dE10bC5tbQppbmRleCA5YjQ5NmMyN2E0ZTQ3Yjg4MzU3ZjYzMTUxNzMyMjZmZDFkMjg3YjNmLi5j YzliYmYxNDZjNzQ1Mzc4M2ExYmVlN2EyMTIxZmJhZTkwMDlhZWUwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQ29udGV4dE10 bC5tbQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIv bWV0YWwvQ29udGV4dE10bC5tbQpAQCAtMTQxMiw5ICsxNDEyLDE2IEBAIHZvaWQgQ29udGV4dE10 bDo6b25FbmRUcmFuc2Zvcm1GZWVkYmFjaygpCiAgICAgfQogICAgIGlmIChnZXREaXNwbGF5KCkt PmdldEZlYXR1cmVzKCkuaGFzRXhwbGljaXRNZW1CYXJyaWVyLmVuYWJsZWQpCiAgICAgewotICAg ICAgICBmb3IoYXV0byAmIGJ1ZmZlclJlZiA6IG1DdXJyZW50VHJhbnNmb3JtRmVlZGJhY2tCdWZm ZXJzKQorICAgICAgICBjb25zdCBnbDo6UHJvZ3JhbUV4ZWN1dGFibGUgKmV4ZWN1dGFibGUgPSBt U3RhdGUuZ2V0UHJvZ3JhbUV4ZWN1dGFibGUoKTsKKyAgICAgICAgQVNTRVJUKGV4ZWN1dGFibGUp OworICAgICAgICBBU1NFUlQoZXhlY3V0YWJsZS0+aGFzVHJhbnNmb3JtRmVlZGJhY2tPdXRwdXQo KSB8fCBtU3RhdGUuaXNUcmFuc2Zvcm1GZWVkYmFja0FjdGl2ZSgpKTsKKyAgICAgICAgVHJhbnNm b3JtRmVlZGJhY2tNdGwgKnRyYW5zZm9ybUZlZWRiYWNrTXRsID0gbXRsOjpHZXRJbXBsKG1TdGF0 ZS5nZXRDdXJyZW50VHJhbnNmb3JtRmVlZGJhY2soKSk7CisgICAgICAgIHNpemVfdCBidWZmZXJD b3VudCAgICAgICAgICAgICAgICAgICAgICAgICA9IGV4ZWN1dGFibGUtPmdldFRyYW5zZm9ybUZl ZWRiYWNrQnVmZmVyQ291bnQoKTsKKyAgICAgICAgY29uc3QgZ2w6OlRyYW5zZm9ybUZlZWRiYWNr QnVmZmVyc0FycmF5PEJ1ZmZlck10bCAqPiAmYnVmZmVySGFuZGxlcyA9CisgICAgICAgICAgICB0 cmFuc2Zvcm1GZWVkYmFja010bC0+Z2V0QnVmZmVySGFuZGxlcygpOworICAgICAgICBmb3IgKHNp emVfdCBpID0gMDsgaSA8IGJ1ZmZlckNvdW50OyBpKyspCiAgICAgICAgIHsKLSAgICAgICAgICAg IGNvbnN0IG10bDo6QnVmZmVyUmVmICYgY29uc3RCdWZmZXJSZWYgPSBidWZmZXJSZWYtPmdldEN1 cnJlbnRCdWZmZXIoKTsKKyAgICAgICAgICAgIGNvbnN0IG10bDo6QnVmZmVyUmVmICYgY29uc3RC dWZmZXJSZWYgPSBidWZmZXJIYW5kbGVzW2ldLT5nZXRDdXJyZW50QnVmZmVyKCk7CiAgICAgICAg ICAgICBtUmVuZGVyRW5jb2Rlci5tZW1vcnlCYXJyaWVyV2l0aFJlc291cmNlKGNvbnN0QnVmZmVy UmVmLCBtdGw6OmtSZW5kZXJTdGFnZVZlcnRleCwgbXRsOjprUmVuZGVyU3RhZ2VWZXJ0ZXgpOwog ICAgICAgICB9CiAgICAgfQo=