227271 2021-06-22 14:49:04 -0700 Run lazy properties initializers under a DeferTerminationForAWhile scope 2021-06-23 08:21:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1771800 0 saam 2021-06-22 14:49:04 -0700 ... 1771804 1 431999 saam 2021-06-22 15:07:25 -0700 Created attachment 431999 patch 1771805 2 431999 mark.lam 2021-06-22 15:12:30 -0700 Comment on attachment 431999 patch View in context: https://bugs.webkit.org/attachment.cgi?id=431999&action=review r=me with fix. > Source/JavaScriptCore/runtime/LazyPropertyInlines.h:52 > + static const FuncType theFunc = &callFunc<Func>; > m_pointer = lazyTag | bitwise_cast<uintptr_t>(&theFunc); This looks wrong. Note use of `bitwise_cast<uintptr_t>(&theFunc)`. 1771811 3 mark.lam 2021-06-22 15:32:37 -0700 (In reply to Mark Lam from comment #2) > Comment on attachment 431999 [details] > > Source/JavaScriptCore/runtime/LazyPropertyInlines.h:52 > > + static const FuncType theFunc = &callFunc<Func>; > > m_pointer = lazyTag | bitwise_cast<uintptr_t>(&theFunc); > > This looks wrong. Note use of `bitwise_cast<uintptr_t>(&theFunc)`. I was wrong. The `&` in `bitwise_cast<uintptr_t>(&theFunc)` is deliberate and needed. Saam's addition of `&` before `callFunc<Func>` doesn't matter (at least in C). I'm not sure about C++. If it builds, it is good. 1771823 4 431999 ysuzuki 2021-06-22 16:49:00 -0700 Comment on attachment 431999 patch View in context: https://bugs.webkit.org/attachment.cgi?id=431999&action=review >>> Source/JavaScriptCore/runtime/LazyPropertyInlines.h:52 >>> m_pointer = lazyTag | bitwise_cast<uintptr_t>(&theFunc); >> >> This looks wrong. Note use of `bitwise_cast<uintptr_t>(&theFunc)`. > > I was wrong. The `&` in `bitwise_cast<uintptr_t>(&theFunc)` is deliberate and needed. Saam's addition of `&` before `callFunc<Func>` doesn't matter (at least in C). I'm not sure about C++. If it builds, it is good. Either adding & or not does not matter here. `callFunc<Func>` is function-type. But it is implicitly decayed to function-pointer-type when assigning it to theFunc. So, `&` in `static const FuncType theFunc = &callFunc<Func>;` does not matter. The same thing will happen. 1771927 5 ews-feeder 2021-06-23 08:20:22 -0700 Committed r279167 (239064@main): <https://commits.webkit.org/239064@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431999. 1771930 6 webkit-bug-importer 2021-06-23 08:21:48 -0700 <rdar://problem/79666737> 431999 2021-06-22 15:07:25 -0700 2021-06-23 08:20:22 -0700 patch b-backup.diff text/plain 2828 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc5MTI2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDIxLTA2LTIyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFJ1biBsYXp5IHByb3BlcnRpZXMgaW5pdGlhbGl6ZXJzIHVuZGVyIGEgRGVmZXJUZXJtaW5hdGlv bkZvckFXaGlsZSBzY29wZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI3MjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2UgZG9uJ3QgZXhwZWN0IHRoYXQgZXhjZXB0aW9ucyBjYW4gYmUgdGhyb3duIHdo ZW4gaW5pdGlhbGl6aW5nIAorICAgICAgICBhIGxhenkgcHJvcGVydHkuIFRlcm1pbmF0aW9uIGV4 Y2VwdGlvbnMgd2VyZSBwcmV2ZW50aW5nIHRoaXMgZnJvbQorICAgICAgICBiZWluZyB0cnVlLiBU aGUgbGF0ZXN0IGV4YW1wbGUgZm91bmQgaXMgaW5zaWRlIEpTTW9kdWxlTG9hZGVyIHdoZW4KKyAg ICAgICAgaXQgYXNzZXJ0cyB0aGF0IG5vIGV4Y2VwdGlvbiBpcyB0aHJvd24gd2hlbiBjcmVhdGlu ZyBpdHMgSlNNYXAgZmllbGQuCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgaXQgc28gdGVybWlu YXRpb24gZXhjZXB0aW9ucyBjYW4ndCBiZSB0aHJvd24gd2hlbgorICAgICAgICBydW5uaW5nIGxh enkgcHJvcGVydHkgaW5pdGlhbGl6ZXJzLgorCisgICAgICAgICogcnVudGltZS9MYXp5UHJvcGVy dHlJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkVsZW1lbnRUeXBlPjo6aW5pdExhdGVyKToKKyAg ICAgICAgKEpTQzo6RWxlbWVudFR5cGU+OjpjYWxsRnVuYyk6CisKIDIwMjEtMDYtMjIgIFNhYW0g QmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgaml0Q29tcGlsZUFuZFNldEhl dXJpc3RpY3Mgc2hvdWxkbid0IHJldHVybiB0cnVlIHdoZW4gd2UgZmFpbCB0byBjb21waWxlCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9MYXp5UHJvcGVydHlJbmxpbmVzLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTGF6eVByb3BlcnR5 SW5saW5lcy5oCShyZXZpc2lvbiAyNzkxMjYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9MYXp5UHJvcGVydHlJbmxpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDkg QEAKIAogI3ByYWdtYSBvbmNlCiAKKyNpbmNsdWRlICJEZWZlclRlcm1pbmF0aW9uLmgiCiAjaW5j bHVkZSAiSGVhcC5oIgorI2luY2x1ZGUgIlZNVHJhcHMuaCIKICNpbmNsdWRlIDx3dGYvU3RkTGli RXh0cmFzLmg+CiAKIG5hbWVzcGFjZSBKU0MgewpAQCAtNDYsNyArNDgsNyBAQCB2b2lkIExhenlQ cm9wZXJ0eTxPd25lclR5cGUsIEVsZW1lbnRUeXBlCiAgICAgLy8gbWF5IGJlIHVzZWQgZm9yIHRo aW5ncy4gV2UgYWRkcmVzcyB0aGlzIHByb2JsZW0gYnkgaW5kaXJlY3RpbmcgdGhyb3VnaCBhIGds b2JhbCBjb25zdAogICAgIC8vIHZhcmlhYmxlLiBUaGUgInRoZUZ1bmMiIHZhcmlhYmxlIGlzIGd1 YXJhbnRlZWQgdG8gYmUgbmF0aXZlLWFsaWduZWQsIGkuZS4gYXQgbGVhc3QgYQogICAgIC8vIG11 bHRpcGxlIG9mIDQuCi0gICAgc3RhdGljIGNvbnN0IEZ1bmNUeXBlIHRoZUZ1bmMgPSBjYWxsRnVu YzxGdW5jPjsKKyAgICBzdGF0aWMgY29uc3QgRnVuY1R5cGUgdGhlRnVuYyA9ICZjYWxsRnVuYzxG dW5jPjsKICAgICBtX3BvaW50ZXIgPSBsYXp5VGFnIHwgYml0d2lzZV9jYXN0PHVpbnRwdHJfdD4o JnRoZUZ1bmMpOwogfQogCkBAIC05NSwxNSArOTcsMTIgQEAgRWxlbWVudFR5cGUqIExhenlQcm9w ZXJ0eTxPd25lclR5cGUsIEVsZQogewogICAgIGlmIChpbml0aWFsaXplci5wcm9wZXJ0eS5tX3Bv aW50ZXIgJiBpbml0aWFsaXppbmdUYWcpCiAgICAgICAgIHJldHVybiBudWxscHRyOworCisgICAg RGVmZXJUZXJtaW5hdGlvbkZvckFXaGlsZSBkZWZlclRlcm1pbmF0aW9uRm9yQVdoaWxlIHsgaW5p dGlhbGl6ZXIudm0gfTsKICAgICBpbml0aWFsaXplci5wcm9wZXJ0eS5tX3BvaW50ZXIgfD0gaW5p dGlhbGl6aW5nVGFnOwogICAgIGNhbGxTdGF0ZWxlc3NMYW1iZGE8dm9pZCwgRnVuYz4oaW5pdGlh bGl6ZXIpOwotICAgIGlmIChVTkxJS0VMWShpbml0aWFsaXplci5wcm9wZXJ0eS5tX3BvaW50ZXIg JiBpbml0aWFsaXppbmdUYWcpKSB7Ci0gICAgICAgIFZNJiB2bSA9IGluaXRpYWxpemVyLnZtOwot ICAgICAgICBSRUxFQVNFX0FTU0VSVCh2bS5oYXNQZW5kaW5nVGVybWluYXRpb25FeGNlcHRpb24o KSk7Ci0gICAgICAgIFJFTEVBU0VfQVNTRVJUKGluaXRpYWxpemVyLnByb3BlcnR5Lm1fcG9pbnRl ciAmIGxhenlUYWcpOwotICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICB9CiAgICAgUkVMRUFT RV9BU1NFUlQoIShpbml0aWFsaXplci5wcm9wZXJ0eS5tX3BvaW50ZXIgJiBsYXp5VGFnKSk7Cisg ICAgUkVMRUFTRV9BU1NFUlQoIShpbml0aWFsaXplci5wcm9wZXJ0eS5tX3BvaW50ZXIgJiBpbml0 aWFsaXppbmdUYWcpKTsKICAgICByZXR1cm4gYml0d2lzZV9jYXN0PEVsZW1lbnRUeXBlKj4oaW5p dGlhbGl6ZXIucHJvcGVydHkubV9wb2ludGVyKTsKIH0KIAo=