227266 2021-06-22 12:52:41 -0700 WKWebView loadSimulatedRequest does not set attribution value for url requests within html content 2021-06-24 15:13:01 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham oldest_to_newest 1771759 0 katherine_cheney 2021-06-22 12:52:41 -0700 URL requests within HTML content loaded with loadSimulatedRequest should be marked with the correct attribution 1771760 1 katherine_cheney 2021-06-22 12:53:02 -0700 <rdar://problem/79316911> 1771769 2 431987 katherine_cheney 2021-06-22 13:11:33 -0700 Created attachment 431987 Patch 1772434 3 431987 bfulgham 2021-06-24 13:37:45 -0700 Comment on attachment 431987 Patch r=me 1772465 4 ews-feeder 2021-06-24 15:13:00 -0700 Committed r279247 (239131@main): <https://commits.webkit.org/239131@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431987. 431987 2021-06-22 13:11:33 -0700 2021-06-24 15:13:00 -0700 Patch bug-227266-20210622131132.patch text/plain 5386 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEyZWQ2ODU1NDc0NzUzOWFk M2RkMDM1MDA5MTJhYzRhYzIxNTk5OGQuLmM4ZDU0OWRhNmJjM2JjMzRhMzI0NzM1MDk3NDQ0ZmRm NTNlNjE4MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMDYtMjIgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgV0tXZWJWaWV3IGxv YWRTaW11bGF0ZWRSZXF1ZXN0IGRvZXMgbm90IHNldCBhdHRyaWJ1dGlvbiB2YWx1ZSBmb3IgdXJs IHJlcXVlc3RzIHdpdGhpbiBodG1sIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzI2NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzkz MTY5MTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2UgY3VycmVudGx5IHBhc3MgdGhlIGF0dHJpYnV0aW9uIHZhbHVlIGZyb20gdGhlIG1haW4gTlNV UkxSZXF1ZXN0CisgICAgICAgIHBhc3NlZCBpbnRvIFdlYlBhZ2VQcm94eTo6bG9hZFJlcXVlc3Qg Ynkgc2V0dGluZyBhIHZhbHVlIG9uIHRoZSBXZWJQYWdlCisgICAgICAgIGRvY3VtZW50IGxvYWRl ciB0aGF0IGdldHMgcGFzc2VkIHRvIGFsbCByZXF1ZXN0cyBpbml0aWF0ZWQgYnkgdGhhdCBtYWlu CisgICAgICAgIG5hdmlnYXRpb24uIFRoaXMgcGF0Y2ggYWRkcyB0aGUgc2FtZSBmdW5jdGlvbmFs aXR5IGZvcgorICAgICAgICBXZWJQYWdlUHJveHk6OmxvYWRTaW11bGF0ZWRSZXF1ZXN0LCB3aGlj aCBjb3VsZCBpbml0aWF0ZSBVUkwgcmVxdWVzdHMKKyAgICAgICAgZnJvbSBIVE1MIGNvbnRlbnQu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZVByb3h5Ojpsb2FkU2ltdWxhdGVkUmVxdWVzdCk6CisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpsb2Fk U2ltdWxhdGVkUmVxdWVzdEFuZFJlc3BvbnNlKToKKwogMjAyMS0wNi0yMiAgUGVuZyBMaXUgIDxw ZW5nLmxpdTZAYXBwbGUuY29tPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IHZpZGVvRnVs bHNjcmVlbk1hbmFnZXItPmNsaWVudCgpID09IG51bGxwdHIgaW4gV0tGdWxsU2NyZWVuV2luZG93 Q29udHJvbGxlci5tbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5k ZXggYWZlMmIwODZiM2I5OGIzNDE2YjJlOTE2N2UyNmE1Mjc1MWMxMjRmNi4uYmYxMzBjYzU0ZWRh OTFiZDk1ZjVhZmM0ZGQzN2M0ODY5ZjkyZDI1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwCkBAIC0xNDk0LDYgKzE0OTQsMTAgQEAgUmVmUHRyPEFQSTo6TmF2aWdh dGlvbj4gV2ViUGFnZVByb3h5Ojpsb2FkU2ltdWxhdGVkUmVxdWVzdChXZWJDb3JlOjpSZXNvdXJj ZVJlcXUKIHsKICAgICBXRUJQQUdFUFJPWFlfUkVMRUFTRV9MT0coTG9hZGluZywgImxvYWRTaW11 bGF0ZWRSZXF1ZXN0OiIpOwogCisjaWYgUExBVEZPUk0oQ09DT0EpCisgICAgc2V0TGFzdE5hdmln YXRpb25XYXNBcHBCb3VuZChzaW11bGF0ZWRSZXF1ZXN0KTsKKyNlbmRpZgorCiAjaWYgRU5BQkxF KEFQUF9CT1VORF9ET01BSU5TKQogICAgIGlmIChzaW11bGF0ZWRSZXNwb25zZS5taW1lVHlwZSgp ID09ICJ0ZXh0L2h0bWwiX3MgJiYgIWlzRnVsbFdlYkJyb3dzZXIoKSkKICAgICAgICAgbV9saW1p dHNOYXZpZ2F0aW9uc1RvQXBwQm91bmREb21haW5zID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggMzdiNDNlOWM3YzVmMmQ3YzA5N2Yz OGQwZmQ2MGY5Y2M4YjRlNmQxOC4uZDE2YmJhMDg1OGFlYWVlNzgyOTdjMTA0ZjVhNGNlYmZjNmIy NjYxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAK QEAgLTE3NjksNiArMTc2OSw4IEBAIHZvaWQgV2ViUGFnZTo6bG9hZFNpbXVsYXRlZFJlcXVlc3RB bmRSZXNwb25zZShMb2FkUGFyYW1ldGVycyYmIGxvYWRQYXJhbWV0ZXJzLCBSCiAgICAgQVNTRVJU KHNpbXVsYXRlZFJlc3BvbnNlLnRleHRFbmNvZGluZ05hbWUoKSA9PSBsb2FkUGFyYW1ldGVycy5l bmNvZGluZ05hbWUpOwogICAgIEFTU0VSVChzdGF0aWNfY2FzdDxzaXplX3Q+KHNpbXVsYXRlZFJl c3BvbnNlLmV4cGVjdGVkQ29udGVudExlbmd0aCgpKSA9PSBsb2FkUGFyYW1ldGVycy5kYXRhLnNp emUoKSk7CiAKKyAgICBzZXRMYXN0TmF2aWdhdGlvbldhc0FwcEJvdW5kKGxvYWRQYXJhbWV0ZXJz LnJlcXVlc3QuaXNBcHBCb3VuZCgpKTsKKwogICAgIHBsYXRmb3JtRGlkUmVjZWl2ZUxvYWRQYXJh bWV0ZXJzKGxvYWRQYXJhbWV0ZXJzKTsKIAogICAgIGF1dG8gc2hhcmVkQnVmZmVyID0gU2hhcmVk QnVmZmVyOjpjcmVhdGUobG9hZFBhcmFtZXRlcnMuZGF0YS5kYXRhKCksIGxvYWRQYXJhbWV0ZXJz LmRhdGEuc2l6ZSgpKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCA4NTZkMWFkYzY3NjJhYjg0ZTgwNzc2NmUzODdlZThjNDAzZjYxMzRhLi4zMmRk YTc5YjQxYTUwMDkxNWRkOTY2MTNmOTQzZTUyZWY2MmIyYTI4IDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDYt MjIgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAg V0tXZWJWaWV3IGxvYWRTaW11bGF0ZWRSZXF1ZXN0IGRvZXMgbm90IHNldCBhdHRyaWJ1dGlvbiB2 YWx1ZSBmb3IgdXJsIHJlcXVlc3RzIHdpdGhpbiBodG1sIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzI2NgorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNzkzMTY5MTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQVBJIHRlc3QgY292ZXJhZ2UuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL0luQXBwQnJvd3NlclByaXZhY3kubW06CisKIDIwMjEtMDYtMjIg IFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgaml0Q29tcGlsZUFu ZFNldEhldXJpc3RpY3Mgc2hvdWxkbid0IHJldHVybiB0cnVlIHdoZW4gd2UgZmFpbCB0byBjb21w aWxlCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0lu QXBwQnJvd3NlclByaXZhY3kubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL0luQXBwQnJvd3NlclByaXZhY3kubW0KaW5kZXggMmFlOTU1M2I4MWY1ZDg0NTM5YThkYTcx NDMwZDk3YTVlZjViZTkzMy4uYjhhNGM4M2VmOGM1OTBlOGNhODBjZDRlMmRlMDU3NjFkNzQwZjUx MiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9JbkFw cEJyb3dzZXJQcml2YWN5Lm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Q29jb2EvSW5BcHBCcm93c2VyUHJpdmFjeS5tbQpAQCAtMjAyMiw0ICsyMDIyLDM3IEBAIFRFU1Qo SW5BcHBCcm93c2VyUHJpdmFjeSwgUmVnaXN0ZXJTZXJ2aWNlV29ya2VyQ2xpZW50VXBkYXRlc0Fw cEJvdW5kVmFsdWUpCiAKICNlbmRpZgogCitzdGF0aWMgdm9pZCBsb2FkU2ltdWxhdGVkUmVxdWVz dFRlc3QoYm9vbCBpc0FwcEluaXRpYXRlZCkKK3sKKyAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5T KFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2 MDApXSk7CisKKyAgICBhdXRvIGRlbGVnYXRlID0gYWRvcHROUyhbW1Rlc3ROYXZpZ2F0aW9uRGVs ZWdhdGUgYWxsb2NdIGluaXRdKTsKKyAgICBbd2ViVmlldyBzZXROYXZpZ2F0aW9uRGVsZWdhdGU6 ZGVsZWdhdGUuZ2V0KCldOworCisgICAgTlNNdXRhYmxlVVJMUmVxdWVzdCAqbG9hZFJlcXVlc3Qg PSBbTlNNdXRhYmxlVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmlu ZzpAImh0dHBzOi8vd2Via2l0Lm9yZyJdXTsKKyAgICBsb2FkUmVxdWVzdC5hdHRyaWJ1dGlvbiA9 IGlzQXBwSW5pdGlhdGVkID8gTlNVUkxSZXF1ZXN0QXR0cmlidXRpb25EZXZlbG9wZXIgOiBOU1VS TFJlcXVlc3RBdHRyaWJ1dGlvblVzZXI7CisKKyAgICBOU1N0cmluZyAqSFRNTCA9IEAiPGh0bWw+ PGhlYWQ+PC9oZWFkPjxib2R5PjxpbWcgc3JjPSdodHRwczovL2FwcGxlLmNvbS8nPjwvaW1nPjwv Ym9keT48L2h0bWw+IjsKKyAgICBbd2ViVmlldyBsb2FkU2ltdWxhdGVkUmVxdWVzdDpsb2FkUmVx dWVzdCByZXNwb25zZUhUTUxTdHJpbmc6SFRNTF07CisgICAgW2RlbGVnYXRlIHdhaXRGb3JEaWRG aW5pc2hOYXZpZ2F0aW9uXTsKKworICAgIHN0YXRpYyBib29sIGlzRG9uZSA9IGZhbHNlOworICAg IFt3ZWJWaWV3IF9hcHBCb3VuZE5hdmlnYXRpb25EYXRhOl4oc3RydWN0IFdLQXBwQm91bmROYXZp Z2F0aW9uVGVzdGluZ0RhdGEgZGF0YSkgeworICAgICAgICBFWFBFQ1RfRVEoZGF0YS5oYXNMb2Fk ZWRBcHBCb3VuZFJlcXVlc3RUZXN0aW5nLCBpc0FwcEluaXRpYXRlZCk7CisgICAgICAgIEVYUEVD VF9FUShkYXRhLmhhc0xvYWRlZE5vbkFwcEJvdW5kUmVxdWVzdFRlc3RpbmcsICFpc0FwcEluaXRp YXRlZCk7CisgICAgICAgIGlzRG9uZSA9IHRydWU7CisgICAgfV07CisgICAgVGVzdFdlYktpdEFQ STo6VXRpbDo6cnVuKCZpc0RvbmUpOworfQorCitURVNUKEluQXBwQnJvd3NlclByaXZhY3ksIExv YWRTaW11bGF0ZWRSZXF1ZXN0SXNBcHBJbml0aWF0ZWQpCit7CisgICAgbG9hZFNpbXVsYXRlZFJl cXVlc3RUZXN0KHRydWUpOworfQorCitURVNUKEluQXBwQnJvd3NlclByaXZhY3ksIExvYWRTaW11 bGF0ZWRSZXF1ZXN0SXNOb25BcHBJbml0aWF0ZWQpCit7CisgICAgbG9hZFNpbXVsYXRlZFJlcXVl c3RUZXN0KGZhbHNlKTsKK30KKwogI2VuZGlmCg==