227256 2021-06-22 09:28:38 -0700 REGRESSION: [iOS] ASSERTION FAILED: pixelBuffer->data().length() >= 4 under WebCore::sampleColor 2021-06-22 14:25:10 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi hi hi thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1771686 0 hi 2021-06-22 09:28:38 -0700 failing on internal iOS Simulator EWS ASSERTION FAILED: pixelBuffer->data().length() >= 4 ./page/PageColorSampler.cpp(131) : std::optional<Lab<float>> WebCore::sampleColor(WebCore::Document &, WebCore::IntPoint &&) 1 0x7bab979b9 WTFCrash 2 0x7db40babb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x7dee9ae00 WebCore::sampleColor(WebCore::Document&, WebCore::IntPoint&&) 4 0x7dee91e8b WebCore::PageColorSampler::sampleTop(WebCore::Page&) 5 0x7dee91404 WebCore::Page::doAfterUpdateRendering() 6 0x7dee90c3e WebCore::Page::updateRendering() 7 0x7a4083941 WebKit::WebPage::updateRendering() 8 0x7a27b5cc9 WebKit::RemoteLayerTreeDrawingArea::updateRendering() 9 0x7a27bffee decltype(*(std::__1::forward<WebKit::RemoteLayerTreeDrawingArea*&>(fp0)).*fp()) std::__1::__invoke<void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*&, void>(void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*&) 10 0x7a27bff6d std::__1::__bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<>, __is_valid_bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, 0ul, std::__1::tuple<> >(void (WebKit::RemoteLayerTreeDrawingArea::*&)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&) 11 0x7a27bff20 std::__1::__bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<>, __is_valid_bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*>::operator()<>() 12 0x7a27bfeb9 WTF::Detail::CallableWrapper<std::__1::__bind<void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*>, void>::call() 13 0x7a20d0532 WTF::Function<void ()>::operator()() const 14 0x7a27baed9 WebCore::Timer::fired() 15 0x7df08785f WebCore::ThreadTimers::sharedTimerFiredInternal() 16 0x7df091801 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const 17 0x7df091799 WTF::Detail::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, void>::call() 18 0x7db422942 WTF::Function<void ()>::operator()() const 19 0x7df045501 WebCore::MainThreadSharedTimer::fired() 20 0x7df0fbbe6 WebCore::timerFired(__CFRunLoopTimer*, void*) 21 0x79051a20d __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 22 0x790519d09 __CFRunLoopDoTimer 23 0x7905192c8 __CFRunLoopDoTimers 24 0x7905138f6 __CFRunLoopRun 25 0x790512c39 CFRunLoopRunSpecific 26 0x790e47111 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 27 0x790e4732e -[NSRunLoop(NSRunLoop) run] 28 0x791af90f7 _xpc_objc_main 29 0x791afb0b9 xpc_main 30 0x7a2dc82c5 WebKit::XPCServiceMain(int, char const**) 31 0x7a448fe2b WKXPCServiceMain 1771687 1 hi 2021-06-22 09:28:55 -0700 <rdar://problem/79584286> 1771689 2 431969 hi 2021-06-22 09:31:29 -0700 Created attachment 431969 Patch 1771693 3 431969 ap 2021-06-22 09:50:36 -0700 Comment on attachment 431969 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431969&action=review > Source/WebCore/ChangeLog:7 > + Unreviewed, internal text fix. "text"? Also, is this something that can be tested for in open source? 1771761 4 431969 hi 2021-06-22 12:53:47 -0700 Comment on attachment 431969 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431969&action=review >> Source/WebCore/ChangeLog:7 >> + Unreviewed, internal text fix. > > "text"? Also, is this something that can be tested for in open source? oops will fix typo :P I'm still trying to figure out why exactly this is happening, as it only reproduces when the entire test suite is run. Not really sure what's going on. I put this patch up (and am planning on landing it) so that the internal EWS doesn't have to deal with this anymore. 1771762 5 431985 hi 2021-06-22 12:54:33 -0700 Created attachment 431985 Patch 1771790 6 ews-feeder 2021-06-22 14:25:09 -0700 Committed r279148 (239056@main): <https://commits.webkit.org/239056@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431985. 431969 2021-06-22 09:31:29 -0700 2021-06-22 12:54:33 -0700 Patch bug-227256-20210622103128.patch text/plain 1734 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0NGE2MDQ4Njc5ZGNhZDIwM2IwZjMxODcwY2VmZGZiYTE4Yzk1Y2I1Li5m NmM0M2QyZDdlNTM0ODczMWY3YWYxZTdjMzU5M2E2NGM5NzFkN2Q3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMjEtMDYtMjIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT046IFtpT1NdIEFTU0VSVElPTiBGQUlMRUQ6IHBpeGVsQnVm ZmVyLT5kYXRhKCkubGVuZ3RoKCkgPj0gNCB1bmRlciBXZWJDb3JlOjpzYW1wbGVDb2xvcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MjU2CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS83OTU4NDI4Nj4KKworICAgICAgICBVbnJldmlld2VkLCBpbnRl cm5hbCB0ZXh0IGZpeC4KKworICAgICAgICAqIHBhZ2UvUGFnZUNvbG9yU2FtcGxlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpzYW1wbGVDb2xvcik6CisgICAgICAgIEl0IHNlZW1zIGxpa2Ugc29t ZXRpbWVzIHRoZSBgUGl4ZWxCdWZmZXJgIGNhbiBoYXZlIGEgYGxlbmd0aCgpYCBvZiBgMGAuIElu c3RlYWQgb2Ygb25seQorICAgICAgICBoYXZpbmcgYW4gYEFTU0VSVGAgdGhhdCB0aGVyZSBhcmUg ZW5vdWdoIGl0ZW1zLCBhY3R1YWxseSBlYXJseS1yZXR1cm4uCisKIDIwMjEtMDYtMjEgIEFsYW4g QnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSByZWR1bmRhbnQgSGl0 VGVzdExvY2F0aW9uKGNvbnN0IExheW91dFBvaW50JiBjZW50ZXJQb2ludCwgdW5zaWduZWQgdG9w UGFkZGluZywgdW5zaWduZWQgcmlnaHRQYWRkaW5nLCB1bnNpZ25lZCBib3R0b21QYWRkaW5nLCB1 bnNpZ25lZCBsZWZ0UGFkZGluZykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFn ZUNvbG9yU2FtcGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VDb2xvclNhbXBsZXIu Y3BwCmluZGV4IGJmMzVjMjA5MmM4MDA4OGE5ZDZkZjYyYmNhZTQwYjU5NjFkNjk2YTguLmY1MzYy ZTc2OWI0YjczMjkxMjdiNjc0MWJiMjQzOTM5OGYwZTg2MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUGFnZUNvbG9yU2FtcGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9QYWdlQ29sb3JTYW1wbGVyLmNwcApAQCAtMTI4LDcgKzEyOCw4IEBAIHN0YXRpYyBzdGQ6Om9w dGlvbmFsPExhYjxmbG9hdD4+IHNhbXBsZUNvbG9yKERvY3VtZW50JiBkb2N1bWVudCwgSW50UG9p bnQmJiBsb2NhCiAgICAgaWYgKCFwaXhlbEJ1ZmZlcikKICAgICAgICAgcmV0dXJuIHN0ZDo6bnVs bG9wdDsKIAotICAgIEFTU0VSVChwaXhlbEJ1ZmZlci0+ZGF0YSgpLmxlbmd0aCgpID49IDQpOwor ICAgIGlmIChwaXhlbEJ1ZmZlci0+ZGF0YSgpLmxlbmd0aCgpIDwgNCkKKyAgICAgICAgcmV0dXJu IHN0ZDo6bnVsbG9wdDsKIAogICAgIGF1dG8gc25hcHNob3REYXRhID0gcGl4ZWxCdWZmZXItPmRh dGEoKS5kYXRhKCk7CiAgICAgcmV0dXJuIGNvbnZlcnRDb2xvcjxMYWI8ZmxvYXQ+PihTUkdCQTx1 aW50OF90PiB7IHNuYXBzaG90RGF0YVsyXSwgc25hcHNob3REYXRhWzFdLCBzbmFwc2hvdERhdGFb MF0sIHNuYXBzaG90RGF0YVszXSB9KTsK 431985 2021-06-22 12:54:33 -0700 2021-06-22 14:25:10 -0700 Patch 227256.diff text/plain 1746 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0NGE2MDQ4Njc5ZGNhZDIwM2IwZjMxODcwY2VmZGZiYTE4Yzk1Y2I1Li5m NmM0M2QyZDdlNTM0ODczMWY3YWYxZTdjMzU5M2E2NGM5NzFkN2Q3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMjEtMDYtMjIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT046IFtpT1NdIEFTU0VSVElPTiBGQUlMRUQ6IHBpeGVsQnVm ZmVyLT5kYXRhKCkubGVuZ3RoKCkgPj0gNCB1bmRlciBXZWJDb3JlOjpzYW1wbGVDb2xvcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MjU2CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS83OTU4NDI4Nj4KKworICAgICAgICBVbnJldmlld2VkLCBzcGVj dWxhdGl2ZSBpbnRlcm5hbCB0ZXN0IGZpeC4KKworICAgICAgICAqIHBhZ2UvUGFnZUNvbG9yU2Ft cGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzYW1wbGVDb2xvcik6CisgICAgICAgIEl0IHNl ZW1zIGxpa2Ugc29tZXRpbWVzIHRoZSBgUGl4ZWxCdWZmZXJgIGNhbiBoYXZlIGEgYGxlbmd0aCgp YCBvZiBgMGAuIEluc3RlYWQgb2Ygb25seQorICAgICAgICBoYXZpbmcgYW4gYEFTU0VSVGAgdGhh dCB0aGVyZSBhcmUgZW5vdWdoIGl0ZW1zLCBhY3R1YWxseSBlYXJseS1yZXR1cm4uCisKIDIwMjEt MDYtMjEgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBy ZWR1bmRhbnQgSGl0VGVzdExvY2F0aW9uKGNvbnN0IExheW91dFBvaW50JiBjZW50ZXJQb2ludCwg dW5zaWduZWQgdG9wUGFkZGluZywgdW5zaWduZWQgcmlnaHRQYWRkaW5nLCB1bnNpZ25lZCBib3R0 b21QYWRkaW5nLCB1bnNpZ25lZCBsZWZ0UGFkZGluZykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvUGFnZUNvbG9yU2FtcGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VD b2xvclNhbXBsZXIuY3BwCmluZGV4IGJmMzVjMjA5MmM4MDA4OGE5ZDZkZjYyYmNhZTQwYjU5NjFk Njk2YTguLmY1MzYyZTc2OWI0YjczMjkxMjdiNjc0MWJiMjQzOTM5OGYwZTg2MTUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZUNvbG9yU2FtcGxlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9QYWdlQ29sb3JTYW1wbGVyLmNwcApAQCAtMTI4LDcgKzEyOCw4IEBAIHN0 YXRpYyBzdGQ6Om9wdGlvbmFsPExhYjxmbG9hdD4+IHNhbXBsZUNvbG9yKERvY3VtZW50JiBkb2N1 bWVudCwgSW50UG9pbnQmJiBsb2NhCiAgICAgaWYgKCFwaXhlbEJ1ZmZlcikKICAgICAgICAgcmV0 dXJuIHN0ZDo6bnVsbG9wdDsKIAotICAgIEFTU0VSVChwaXhlbEJ1ZmZlci0+ZGF0YSgpLmxlbmd0 aCgpID49IDQpOworICAgIGlmIChwaXhlbEJ1ZmZlci0+ZGF0YSgpLmxlbmd0aCgpIDwgNCkKKyAg ICAgICAgcmV0dXJuIHN0ZDo6bnVsbG9wdDsKIAogICAgIGF1dG8gc25hcHNob3REYXRhID0gcGl4 ZWxCdWZmZXItPmRhdGEoKS5kYXRhKCk7CiAgICAgcmV0dXJuIGNvbnZlcnRDb2xvcjxMYWI8Zmxv YXQ+PihTUkdCQTx1aW50OF90PiB7IHNuYXBzaG90RGF0YVsyXSwgc25hcHNob3REYXRhWzFdLCBz bmFwc2hvdERhdGFbMF0sIHNuYXBzaG90RGF0YVszXSB9KTsK