227230 2021-06-21 12:06:15 -0700 Shrink sizeof(RegisteredEventListener) 2021-06-25 16:22:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki cdumez esprehn+autocc ews-watchlist ggaren kangil.han webkit-bug-importer oldest_to_newest 1771389 0 ysuzuki 2021-06-21 12:06:15 -0700 Shrink sizeof(RegisteredEventListener) 1771391 1 431892 ysuzuki 2021-06-21 12:07:18 -0700 Created attachment 431892 Patch 1771393 2 431892 cdumez 2021-06-21 12:11:20 -0700 Comment on attachment 431892 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431892&action=review > Source/WebCore/dom/RegisteredEventListener.h:68 > + bool m_useCapture : 1; do we really need the ": 1"? 1771395 3 431892 ysuzuki 2021-06-21 12:18:10 -0700 Comment on attachment 431892 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431892&action=review >> Source/WebCore/dom/RegisteredEventListener.h:68 >> + bool m_useCapture : 1; > > do we really need the ": 1"? I prefer using bit fields for many bool flags since we can easily add more things while maintaining size. 1771404 4 431892 ggaren 2021-06-21 12:35:23 -0700 Comment on attachment 431892 Patch r=me 1771456 5 431910 ysuzuki 2021-06-21 14:29:05 -0700 Created attachment 431910 Patch 1771677 6 ysuzuki 2021-06-22 08:31:15 -0700 Committed r279117 (239034@main): <https://commits.webkit.org/239034@main> 1771678 7 webkit-bug-importer 2021-06-22 08:32:16 -0700 <rdar://problem/79615813> 1772805 8 ysuzuki 2021-06-25 16:22:52 -0700 Use this commit to test webkitbot. Please ignore following messages. 431892 2021-06-21 12:07:18 -0700 2021-06-21 13:53:51 -0700 Patch bug-227230-20210621120717.patch text/plain 2362 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRlY2VjOTBkZDZjYjQy NGM0YjJjYjY0NDA2NzFlZjI0NDk0ODAxMi4uNGI2M2FhZDJkNmVmNWRlZTFhZGE4MjM4NTQ4Yzdh NjhkNDA4MjBlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA2LTIxICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgU2hyaW5rIHNpemVvZihS ZWdpc3RlcmVkRXZlbnRMaXN0ZW5lcikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNzIzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyB0aGUgb3JkZXJpbmcgb2YgbWVtYmVy cyBvZiBSZWdpc3RlcmVkRXZlbnRMaXN0ZW5lciB0byBtYWtlIGl0IHNtYWxsIGZyb20gMjQgdG8g MTYuCisKKyAgICAgICAgKiBkb20vUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXIuaDoKKyAgICAgICAg KFdlYkNvcmU6OlJlZ2lzdGVyZWRFdmVudExpc3RlbmVyOjpSZWdpc3RlcmVkRXZlbnRMaXN0ZW5l cik6CisgICAgICAgICgpOiBEZWxldGVkLgorCiAyMDIxLTA2LTIwICBBbGFuIEJ1anRhcyAgPHph bGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBIaXRUZXN0TG9jYXRpb246Om1fYm91bmRpbmdCb3gg c2hvdWxkIGJlIGFibGUgaG9sZCBzdWJwaXhlbCB2YWx1ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9SZWdpc3RlcmVkRXZlbnRMaXN0ZW5lci5oIGIvU291cmNlL1dlYkNvcmUvZG9t L1JlZ2lzdGVyZWRFdmVudExpc3RlbmVyLmgKaW5kZXggNzk1N2IyZjYxZWYxNzBjZDYwNGFmYjY3 ZDk4MTJlYmFiODZiOWExMy4uOTRlZDhkOGM4MmFjZWQzYmZlYjBhYjZiZTIyNzEwYmU1NjBmMjgw NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1JlZ2lzdGVyZWRFdmVudExpc3RlbmVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1JlZ2lzdGVyZWRFdmVudExpc3RlbmVyLmgKQEAg LTIsNyArMiw3IEBACiAgKiBDb3B5cmlnaHQgKEMpIDIwMDEgUGV0ZXIgS2VsbHkgKHBta0Bwb3N0 LmNvbSkKICAqIENvcHlyaWdodCAoQykgMjAwMSBUb2JpYXMgQW50b24gKGFudG9uQHN0dWQuZmJp LmZoLWRhcm1zdGFkdC5kZSkKICAqIENvcHlyaWdodCAoQykgMjAwNiBTYW11ZWwgV2VpbmlnIChz YW0ud2VpbmlnQGdtYWlsLmNvbSkKLSAqIENvcHlyaWdodCAoQykgMjAwMywgMjAwNCwgMjAwNSwg MjAwNiwgMjAwOCwgMjAwOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5 cmlnaHQgKEMpIDIwMDMtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgog ICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0 IGFuZC9vcgogICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkg R2VuZXJhbCBQdWJsaWMKQEAgLTU4LDE4ICs1OCwxOCBAQCBjbGFzcyBSZWdpc3RlcmVkRXZlbnRM aXN0ZW5lciA6IHB1YmxpYyBSZWZDb3VudGVkPFJlZ2lzdGVyZWRFdmVudExpc3RlbmVyPiB7CiAK IHByaXZhdGU6CiAgICAgUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXIoUmVmPEV2ZW50TGlzdGVuZXI+ JiYgbGlzdGVuZXIsIGNvbnN0IE9wdGlvbnMmIG9wdGlvbnMpCi0gICAgICAgIDogbV9jYWxsYmFj ayhXVEZNb3ZlKGxpc3RlbmVyKSkKLSAgICAgICAgLCBtX3VzZUNhcHR1cmUob3B0aW9ucy5jYXB0 dXJlKQorICAgICAgICA6IG1fdXNlQ2FwdHVyZShvcHRpb25zLmNhcHR1cmUpCiAgICAgICAgICwg bV9pc1Bhc3NpdmUob3B0aW9ucy5wYXNzaXZlKQogICAgICAgICAsIG1faXNPbmNlKG9wdGlvbnMu b25jZSkKKyAgICAgICAgLCBtX2NhbGxiYWNrKFdURk1vdmUobGlzdGVuZXIpKQogICAgIHsKICAg ICB9CiAKKyAgICBib29sIG1fdXNlQ2FwdHVyZSA6IDE7CisgICAgYm9vbCBtX2lzUGFzc2l2ZSA6 IDE7CisgICAgYm9vbCBtX2lzT25jZSA6IDE7CisgICAgYm9vbCBtX3dhc1JlbW92ZWQgOiAxOwog ICAgIFJlZjxFdmVudExpc3RlbmVyPiBtX2NhbGxiYWNrOwotICAgIGJvb2wgbV91c2VDYXB0dXJl IHsgZmFsc2UgfTsKLSAgICBib29sIG1faXNQYXNzaXZlIHsgZmFsc2UgfTsKLSAgICBib29sIG1f aXNPbmNlIHsgZmFsc2UgfTsKLSAgICBib29sIG1fd2FzUmVtb3ZlZCB7IGZhbHNlIH07CiB9Owog CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 431910 2021-06-21 14:29:05 -0700 2021-06-21 14:29:05 -0700 Patch bug-227230-20210621142905.patch text/plain 2370 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzYzMzM2NmNmNGZlZDUw YzBlZWZhYzhjOGQ5ZDE4ZTk4OTA2ZDRmMi4uZWIxYWM4NWFlOWY2ZmZmOTE0OTI5NjZkZjM2MzY2 YzIwY2JmYjBmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA2LTIxICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgU2hyaW5rIHNpemVvZihS ZWdpc3RlcmVkRXZlbnRMaXN0ZW5lcikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNzIzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyB0aGUgb3JkZXJpbmcgb2YgbWVtYmVy cyBvZiBSZWdpc3RlcmVkRXZlbnRMaXN0ZW5lciB0byBtYWtlIGl0IHNtYWxsIGZyb20gMjQgdG8g MTYuCisKKyAgICAgICAgKiBkb20vUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXIuaDoKKyAgICAgICAg KFdlYkNvcmU6OlJlZ2lzdGVyZWRFdmVudExpc3RlbmVyOjpSZWdpc3RlcmVkRXZlbnRMaXN0ZW5l cik6CisgICAgICAgICgpOiBEZWxldGVkLgorCiAyMDIxLTA2LTIxICBSb2IgQnVpcyAgPHJidWlz QGlnYWxpYS5jb20+CiAKICAgICAgICAgQ1NTT00gdGVzdCBmb3Igc2VyaWFsaXppbmcgZm9udC12 YXJpYW50IGZhaWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vUmVnaXN0ZXJlZEV2 ZW50TGlzdGVuZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9SZWdpc3RlcmVkRXZlbnRMaXN0ZW5l ci5oCmluZGV4IDc5NTdiMmY2MWVmMTcwY2Q2MDRhZmI2N2Q5ODEyZWJhYjg2YjlhMTMuLjFiMmY0 OGFmNDk4MDJhNTcxMzE4ZTUwZjZiMTE4MjU5MzUzOTgyNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9SZWdpc3RlcmVkRXZlbnRMaXN0ZW5lci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9SZWdpc3RlcmVkRXZlbnRMaXN0ZW5lci5oCkBAIC0yLDcgKzIsNyBAQAogICogQ29weXJp Z2h0IChDKSAyMDAxIFBldGVyIEtlbGx5IChwbWtAcG9zdC5jb20pCiAgKiBDb3B5cmlnaHQgKEMp IDIwMDEgVG9iaWFzIEFudG9uIChhbnRvbkBzdHVkLmZiaS5maC1kYXJtc3RhZHQuZGUpCiAgKiBD b3B5cmlnaHQgKEMpIDIwMDYgU2FtdWVsIFdlaW5pZyAoc2FtLndlaW5pZ0BnbWFpbC5jb20pCi0g KiBDb3B5cmlnaHQgKEMpIDIwMDMsIDIwMDQsIDIwMDUsIDIwMDYsIDIwMDgsIDIwMDkgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDAzLTIwMjEgQXBw bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFRoaXMgbGlicmFyeSBpcyBmcmVl IHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqIG1vZGlmeSBpdCB1 bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC01OCwx OCArNTgsMTkgQEAgY2xhc3MgUmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXIgOiBwdWJsaWMgUmVmQ291 bnRlZDxSZWdpc3RlcmVkRXZlbnRMaXN0ZW5lcj4gewogCiBwcml2YXRlOgogICAgIFJlZ2lzdGVy ZWRFdmVudExpc3RlbmVyKFJlZjxFdmVudExpc3RlbmVyPiYmIGxpc3RlbmVyLCBjb25zdCBPcHRp b25zJiBvcHRpb25zKQotICAgICAgICA6IG1fY2FsbGJhY2soV1RGTW92ZShsaXN0ZW5lcikpCi0g ICAgICAgICwgbV91c2VDYXB0dXJlKG9wdGlvbnMuY2FwdHVyZSkKKyAgICAgICAgOiBtX3VzZUNh cHR1cmUob3B0aW9ucy5jYXB0dXJlKQogICAgICAgICAsIG1faXNQYXNzaXZlKG9wdGlvbnMucGFz c2l2ZSkKICAgICAgICAgLCBtX2lzT25jZShvcHRpb25zLm9uY2UpCisgICAgICAgICwgbV93YXNS ZW1vdmVkKGZhbHNlKQorICAgICAgICAsIG1fY2FsbGJhY2soV1RGTW92ZShsaXN0ZW5lcikpCiAg ICAgewogICAgIH0KIAorICAgIGJvb2wgbV91c2VDYXB0dXJlIDogMTsKKyAgICBib29sIG1faXNQ YXNzaXZlIDogMTsKKyAgICBib29sIG1faXNPbmNlIDogMTsKKyAgICBib29sIG1fd2FzUmVtb3Zl ZCA6IDE7CiAgICAgUmVmPEV2ZW50TGlzdGVuZXI+IG1fY2FsbGJhY2s7Ci0gICAgYm9vbCBtX3Vz ZUNhcHR1cmUgeyBmYWxzZSB9OwotICAgIGJvb2wgbV9pc1Bhc3NpdmUgeyBmYWxzZSB9OwotICAg IGJvb2wgbV9pc09uY2UgeyBmYWxzZSB9OwotICAgIGJvb2wgbV93YXNSZW1vdmVkIHsgZmFsc2Ug fTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK