227226 2021-06-21 11:05:20 -0700 BabylonJS Under water demo is slower than it should be on Intel 2021-07-07 14:10:18 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build Mac (Intel) macOS 10.15 RESOLVED FIXED https://playground.babylonjs.com/#LPTLZM InRadar P2 Normal --- 223434 227596 1 kkinnunen kpiddington dino ews-watchlist floooh kbr kkinnunen kondapallykalyan kpiddington tsavell webkit-bug-importer oldest_to_newest 1771354 0 kkinnunen 2021-06-21 11:05:20 -0700 BabylonJS Under water demo is slower than it should be on Intel https://playground.babylonjs.com/#LPTLZM MacBookPro19,1 Intel / AMD WebGL on Metal on 10fps WebGL on Metal off 30fps Should be 60fps. 1771356 1 kkinnunen 2021-06-21 11:07:18 -0700 Related to rdar://79216506 but not strictly the same 1773138 2 webkit-bug-importer 2021-06-28 11:06:17 -0700 <rdar://problem/79872484> 1773614 3 432552 kpiddington 2021-06-29 16:22:08 -0700 Created attachment 432552 Patch 1773616 4 ews-watchlist 2021-06-29 16:23:55 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1773617 5 432552 kbr 2021-06-29 16:29:33 -0700 Comment on attachment 432552 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432552&action=review > Source/ThirdParty/ANGLE/ChangeLog:6 > + Remove fastMath restriction on Intel, restore explicit [[invariant]] tag to position, fragcoord Please fix indentation in ChangeLog. > Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:977 > + (decl.isField() ? mInvariants.contains(decl.field()) : mInvariants.contains(decl.variable())) || (qualifier == TQualifier::EvqPosition || qualifier == TQualifier::EvqFragCoord); Making gl_Position and gl_FragCoord implicitly invariant seems like a far-reaching change. If fastMath is re-enabled on Intel, do more applications than just this one need this implicit invariant qualifier on these built-in variables? 1773644 6 432563 kpiddington 2021-06-29 18:00:58 -0700 Created attachment 432563 Patch 1773657 7 432563 kbr 2021-06-29 21:09:08 -0700 Comment on attachment 432563 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432563&action=review Looks good to me. A few minor comments about the commit message. r+ > Source/ThirdParty/ANGLE/ChangeLog:7 > + Removing fastmath in all scenarios leads to unnacceptable performance on integrated graphics Consider adding periods at end of sentences. > Source/ThirdParty/ANGLE/ChangeLog:8 > + Currently, webgl conformance tests and the safrai tests don't have any invariance tests that show issue. safrai -> safari show issue -> "show issues" or "show the issue" 1774142 8 432704 kpiddington 2021-07-01 09:28:01 -0700 Created attachment 432704 Patch for landing 1774147 9 ews-feeder 2021-07-01 10:03:25 -0700 Committed r279466 (239322@main): <https://commits.webkit.org/239322@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432704. 1774255 10 tsavell 2021-07-01 15:02:27 -0700 It looks like the changes in https://trac.webkit.org/changeset/279466/webkit broke 4 Webgl tests tracking in https://bugs.webkit.org/show_bug.cgi?id=227596 1775450 11 kpiddington 2021-07-07 14:10:18 -0700 *** Bug 226841 has been marked as a duplicate of this bug. *** 432552 2021-06-29 16:22:08 -0700 2021-06-29 18:00:56 -0700 Patch bug-227226-20210629162207.patch text/plain 3112 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMGEzZTI1MGQzOGYzMTZkNGY5ZDQwMGE1NmMxODY4NDNkZjAwZTU1OC4uZmFlNTg1OWJlY2Uw MThmODM0ZjM5YTlmMTU1MDZiMWUwOWFlOTljZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA2LTI5ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQmFieWxvbkpTIFVuZGVyIHdhdGVyIGRlbW8gaXMg c2xvd2VyIHRoYW4gaXQgc2hvdWxkIGJlIG9uIEludGVsCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjcyMjYKKwkKKwlSZW1vdmUgZmFzdE1hdGggcmVz dHJpY3Rpb24gb24gSW50ZWwsIHJlc3RvcmUgZXhwbGljaXQgW1tpbnZhcmlhbnRdXSB0YWcgdG8g cG9zaXRpb24sIGZyYWdjb29yZCAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBzcmMvY29tcGlsZXIvdHJhbnNsYXRvci9UcmFuc2xhdG9yTWV0YWxEaXJl Y3QvRW1pdE1ldGFsLmNwcDoKKyAgICAgICAgKEdlbk1ldGFsVHJhdmVyc2VyOjplbWl0UG9zdFF1 YWxpZmllcik6CisgICAgICAgICogc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF91dGls cy5tbToKKyAgICAgICAgKHJ4OjptdGw6OkNyZWF0ZVNoYWRlckxpYnJhcnkpOgorCiAyMDIxLTA2 LTIzICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgckFG IGRyaXZlbiBXZWJHTCBzdWJtaXRzIGV4Y2Vzc2l2ZSBhbW91bnQgb2YgR1BVIHdvcmsgd2hlbiBm cmFtZXMgYXJlIHNsb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9j b21waWxlci90cmFuc2xhdG9yL1RyYW5zbGF0b3JNZXRhbERpcmVjdC9FbWl0TWV0YWwuY3BwIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvVHJhbnNsYXRv ck1ldGFsRGlyZWN0L0VtaXRNZXRhbC5jcHAKaW5kZXggYmQwZDM1NmNjMmRlOWYwN2U4NzhmNGFk YjFjNWIwZGM4ODVjOGQzNi4uYmU3ZDRmOWE4ZGM4NjEwMjNiMWZmMzNiMjQ0YzM3MDdkN2I3Y2U5 ZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5z bGF0b3IvVHJhbnNsYXRvck1ldGFsRGlyZWN0L0VtaXRNZXRhbC5jcHAKKysrIGIvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvVHJhbnNsYXRvck1ldGFsRGly ZWN0L0VtaXRNZXRhbC5jcHAKQEAgLTk3NCw3ICs5NzQsNyBAQCB2b2lkIEdlbk1ldGFsVHJhdmVy c2VyOjplbWl0UG9zdFF1YWxpZmllcihjb25zdCBFbWl0VmFyaWFibGVEZWNsYXJhdGlvbkNvbmZp ZyAmZQogICAgIH0KIAogICAgIGNvbnN0IGJvb2wgaXNJbnZhcmlhbnQgPQotICAgIChkZWNsLmlz RmllbGQoKSA/IG1JbnZhcmlhbnRzLmNvbnRhaW5zKGRlY2wuZmllbGQoKSkgOiBtSW52YXJpYW50 cy5jb250YWlucyhkZWNsLnZhcmlhYmxlKCkpKSAmJiAocXVhbGlmaWVyID09IFRRdWFsaWZpZXI6 OkV2cVBvc2l0aW9uIHx8IHF1YWxpZmllciA9PSBUUXVhbGlmaWVyOjpFdnFGcmFnQ29vcmQpOwor ICAgIChkZWNsLmlzRmllbGQoKSA/IG1JbnZhcmlhbnRzLmNvbnRhaW5zKGRlY2wuZmllbGQoKSkg OiBtSW52YXJpYW50cy5jb250YWlucyhkZWNsLnZhcmlhYmxlKCkpKSB8fCAocXVhbGlmaWVyID09 IFRRdWFsaWZpZXI6OkV2cVBvc2l0aW9uIHx8IHF1YWxpZmllciA9PSBUUXVhbGlmaWVyOjpFdnFG cmFnQ29vcmQpOwogCiAgICAgaWYgKGlzSW52YXJpYW50KQogICAgIHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfdXRp bHMubW0gYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0 YWwvbXRsX3V0aWxzLm1tCmluZGV4IGQ5NGRmM2IzM2Q1MTJkMWUzNjBlZWRlYzg3NDRkYzQ2ZWUy MTI0Y2YuLmUyOTc5MDZiZmY5NzdiOTRkNWEyMzA0NTE3YWYyMmZjNTg0YTVmM2MgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9t dGxfdXRpbHMubW0KKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3Jl bmRlcmVyL21ldGFsL210bF91dGlscy5tbQpAQCAtNTk2LDEyICs1OTYsNiBAQCBBdXRvT2JqQ1B0 cjxpZDxNVExMaWJyYXJ5Pj4gQ3JlYXRlU2hhZGVyTGlicmFyeShpZDxNVExEZXZpY2U+IG1ldGFs RGV2aWNlLAogICAgICAgICBvcHRpb25zLmZhc3RNYXRoRW5hYmxlZCA9IGZhbHNlOwogI2VuZGlm CiAgICAgICAgIG9wdGlvbnMubGFuZ3VhZ2VWZXJzaW9uID0gR2V0VXNlclNldE9ySGlnaGVzdE1T TFZlcnNpb24ob3B0aW9ucy5sYW5ndWFnZVZlcnNpb24pOwotICAgICAgICAvLyBUT0RPKGpjdW5u aW5naGFtKTogd29ya2Fyb3VuZCBmb3IgaW50ZWwgZHJpdmVyIG5vdCBwcmVzZXJ2aW5nIGludmFy aWFuY2Ugb24gYWxsIHNoYWRlcnMKLSAgICAgICAgY29uc3QgdWludDMyX3QgdmVuZG9yX2lkID0g R2V0RGV2aWNlVmVuZG9ySWQobWV0YWxEZXZpY2UpOwotICAgICAgICBpZiAodmVuZG9yX2lkID09 IGFuZ2xlOjprVmVuZG9ySURfSW50ZWwpCi0gICAgICAgIHsKLSAgICAgICAgICAgIG9wdGlvbnMu ZmFzdE1hdGhFbmFibGVkID0gZmFsc2U7Ci0gICAgICAgIH0KICAgICAgICAgb3B0aW9ucy5wcmVw cm9jZXNzb3JNYWNyb3MgPSBzdWJzdGl0dXRpb25NYWNyb3M7CiAgICAgICAgIGF1dG8gbGlicmFy eSA9IFttZXRhbERldmljZSBuZXdMaWJyYXJ5V2l0aFNvdXJjZTpuc1NvdXJjZSBvcHRpb25zOm9w dGlvbnMgZXJyb3I6Jm5zRXJyb3JdOwogICAgICAgICBpZiAoYW5nbGU6OkdldEVudmlyb25tZW50 VmFyKGtBTkdMRVByaW50TVNMRW52KVswXSA9PSAnMScpCg== 432563 2021-06-29 18:00:58 -0700 2021-07-01 09:27:59 -0700 Patch bug-227226-20210629180057.patch text/plain 2420 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMGEzZTI1MGQzOGYzMTZkNGY5ZDQwMGE1NmMxODY4NDNkZjAwZTU1OC4uMzVlNzcwOTQ5ZjIy ZDM0OTM0MzU0NzQ5ZWQxMjRhNThjNDdlYzBhOSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA2LTI5ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQmFieWxvbkpTIFVuZGVyIHdhdGVyIGRlbW8gaXMg c2xvd2VyIHRoYW4gaXQgc2hvdWxkIGJlIG9uIEludGVsCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjcyMjYKKworICAgICAgICBSZW1vdmUgZmFzdE1h dGggcmVzdHJpY3Rpb24gb24gSW50ZWwKKyAgICAgICAgUmVtb3ZpbmcgZmFzdG1hdGggaW4gYWxs IHNjZW5hcmlvcyBsZWFkcyB0byB1bm5hY2NlcHRhYmxlIHBlcmZvcm1hbmNlIG9uIGludGVncmF0 ZWQgZ3JhcGhpY3MKKyAgICAgICAgQ3VycmVudGx5LCB3ZWJnbCBjb25mb3JtYW5jZSB0ZXN0cyBh bmQgdGhlIHNhZnJhaSB0ZXN0cyBkb24ndCBoYXZlIGFueSBpbnZhcmlhbmNlIHRlc3RzIHRoYXQg c2hvdyBpc3N1ZS4gCisgICAgICAgIEhvd2V2ZXIsIG9ubHkgZ2xfcG9zaXRpb24gYW5kIGdsX2Zy YWdjb29yZCBhcmUgdmFsaWQgYXR0cmlidXRlcyB0byBiZSBtYXJrZWQgYXMgaW52YXJpYW50LiBB bGwgb3RoZXJzIHdpbGwgYmUgaWdub3JlZCAvIGRyb3BwZWQuCisgCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3Iv VHJhbnNsYXRvck1ldGFsRGlyZWN0L0VtaXRNZXRhbC5jcHA6CisgICAgICAgIChHZW5NZXRhbFRy YXZlcnNlcjo6ZW1pdFBvc3RRdWFsaWZpZXIpOgorICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5k ZXJlci9tZXRhbC9tdGxfdXRpbHMubW06CisgICAgICAgIChyeDo6bXRsOjpDcmVhdGVTaGFkZXJM aWJyYXJ5KToKKwogMjAyMS0wNi0yMyAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIHJBRiBkcml2ZW4gV2ViR0wgc3VibWl0cyBleGNlc3NpdmUgYW1vdW50 IG9mIEdQVSB3b3JrIHdoZW4gZnJhbWVzIGFyZSBzbG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX3V0aWxzLm1tIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF91 dGlscy5tbQppbmRleCBkOTRkZjNiMzNkNTEyZDFlMzYwZWVkZWM4NzQ0ZGM0NmVlMjEyNGNmLi5l Mjk3OTA2YmZmOTc3Yjk0ZDVhMjMwNDUxN2FmMjJmYzU4NGE1ZjNjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX3V0aWxz Lm1tCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9t ZXRhbC9tdGxfdXRpbHMubW0KQEAgLTU5NiwxMiArNTk2LDYgQEAgQXV0b09iakNQdHI8aWQ8TVRM TGlicmFyeT4+IENyZWF0ZVNoYWRlckxpYnJhcnkoaWQ8TVRMRGV2aWNlPiBtZXRhbERldmljZSwK ICAgICAgICAgb3B0aW9ucy5mYXN0TWF0aEVuYWJsZWQgPSBmYWxzZTsKICNlbmRpZgogICAgICAg ICBvcHRpb25zLmxhbmd1YWdlVmVyc2lvbiA9IEdldFVzZXJTZXRPckhpZ2hlc3RNU0xWZXJzaW9u KG9wdGlvbnMubGFuZ3VhZ2VWZXJzaW9uKTsKLSAgICAgICAgLy8gVE9ETyhqY3VubmluZ2hhbSk6 IHdvcmthcm91bmQgZm9yIGludGVsIGRyaXZlciBub3QgcHJlc2VydmluZyBpbnZhcmlhbmNlIG9u IGFsbCBzaGFkZXJzCi0gICAgICAgIGNvbnN0IHVpbnQzMl90IHZlbmRvcl9pZCA9IEdldERldmlj ZVZlbmRvcklkKG1ldGFsRGV2aWNlKTsKLSAgICAgICAgaWYgKHZlbmRvcl9pZCA9PSBhbmdsZTo6 a1ZlbmRvcklEX0ludGVsKQotICAgICAgICB7Ci0gICAgICAgICAgICBvcHRpb25zLmZhc3RNYXRo RW5hYmxlZCA9IGZhbHNlOwotICAgICAgICB9CiAgICAgICAgIG9wdGlvbnMucHJlcHJvY2Vzc29y TWFjcm9zID0gc3Vic3RpdHV0aW9uTWFjcm9zOwogICAgICAgICBhdXRvIGxpYnJhcnkgPSBbbWV0 YWxEZXZpY2UgbmV3TGlicmFyeVdpdGhTb3VyY2U6bnNTb3VyY2Ugb3B0aW9uczpvcHRpb25zIGVy cm9yOiZuc0Vycm9yXTsKICAgICAgICAgaWYgKGFuZ2xlOjpHZXRFbnZpcm9ubWVudFZhcihrQU5H TEVQcmludE1TTEVudilbMF0gPT0gJzEnKQo= 432704 2021-07-01 09:28:01 -0700 2021-07-01 10:03:26 -0700 Patch for landing bug-227226-20210701092800.patch text/plain 2456 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMGEzZTI1MGQzOGYzMTZkNGY5ZDQwMGE1NmMxODY4NDNkZjAwZTU1OC4uYjRhYjQyZmY0MTgw YzM0NTRmMGVkODFkM2YwZmYzMTViM2RhNWQxYiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA2LTI5ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQmFieWxvbkpTIFVuZGVyIHdhdGVyIGRlbW8gaXMg c2xvd2VyIHRoYW4gaXQgc2hvdWxkIGJlIG9uIEludGVsCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjcyMjYKKworICAgICAgICBSZW1vdmUgZmFzdE1h dGggcmVzdHJpY3Rpb24gb24gSW50ZWwKKyAgICAgICAgUmVtb3ZpbmcgZmFzdG1hdGggaW4gYWxs IHNjZW5hcmlvcyBsZWFkcyB0byB1bmFjY2VwdGFibGUgcGVyZm9ybWFuY2Ugb24gaW50ZWdyYXRl ZCBncmFwaGljcworICAgICAgICBDdXJyZW50bHksIHdlYmdsIGNvbmZvcm1hbmNlIHRlc3RzIGFu ZCB0aGUgU2FmYXJpIHRlc3RzIGRvbid0IGhhdmUgYW55IGludmFyaWFuY2UgdGVzdHMgdGhhdCBz aG93IGludmFyaWFuY2UgaXNzdWVzLiBkZVFQIHRlc3RzIGFyZSBzaW1pbGFybHkgcGFzc2luZy4K KyAgICAgICAgSW4gTWV0YWwtQU5HTEUsIGdsX3Bvc2l0aW9uIGFuZCBnbF9mcmFnY29vcmQgYXJl IHZhbGlkIGF0dHJpYnV0ZXMgdG8gYmUgbWFya2VkIGFzIGludmFyaWFudC4gQWxsIG90aGVycyB3 aWxsIGJlIGlnbm9yZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgor CisgICAgICAgICogc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvVHJhbnNsYXRvck1ldGFsRGlyZWN0 L0VtaXRNZXRhbC5jcHA6CisgICAgICAgIChHZW5NZXRhbFRyYXZlcnNlcjo6ZW1pdFBvc3RRdWFs aWZpZXIpOgorICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfdXRpbHMu bW06CisgICAgICAgIChyeDo6bXRsOjpDcmVhdGVTaGFkZXJMaWJyYXJ5KToKKwogMjAyMS0wNi0y MyAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUuY29tPgogCiAgICAgICAgIHJBRiBk cml2ZW4gV2ViR0wgc3VibWl0cyBleGNlc3NpdmUgYW1vdW50IG9mIEdQVSB3b3JrIHdoZW4gZnJh bWVzIGFyZSBzbG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGli QU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX3V0aWxzLm1tIGIvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF91dGlscy5tbQppbmRleCBkOTRkZjNi MzNkNTEyZDFlMzYwZWVkZWM4NzQ0ZGM0NmVlMjEyNGNmLi5lMjk3OTA2YmZmOTc3Yjk0ZDVhMjMw NDUxN2FmMjJmYzU4NGE1ZjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9z cmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX3V0aWxzLm1tCisrKyBiL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfdXRpbHMubW0KQEAg LTU5NiwxMiArNTk2LDYgQEAgQXV0b09iakNQdHI8aWQ8TVRMTGlicmFyeT4+IENyZWF0ZVNoYWRl ckxpYnJhcnkoaWQ8TVRMRGV2aWNlPiBtZXRhbERldmljZSwKICAgICAgICAgb3B0aW9ucy5mYXN0 TWF0aEVuYWJsZWQgPSBmYWxzZTsKICNlbmRpZgogICAgICAgICBvcHRpb25zLmxhbmd1YWdlVmVy c2lvbiA9IEdldFVzZXJTZXRPckhpZ2hlc3RNU0xWZXJzaW9uKG9wdGlvbnMubGFuZ3VhZ2VWZXJz aW9uKTsKLSAgICAgICAgLy8gVE9ETyhqY3VubmluZ2hhbSk6IHdvcmthcm91bmQgZm9yIGludGVs IGRyaXZlciBub3QgcHJlc2VydmluZyBpbnZhcmlhbmNlIG9uIGFsbCBzaGFkZXJzCi0gICAgICAg IGNvbnN0IHVpbnQzMl90IHZlbmRvcl9pZCA9IEdldERldmljZVZlbmRvcklkKG1ldGFsRGV2aWNl KTsKLSAgICAgICAgaWYgKHZlbmRvcl9pZCA9PSBhbmdsZTo6a1ZlbmRvcklEX0ludGVsKQotICAg ICAgICB7Ci0gICAgICAgICAgICBvcHRpb25zLmZhc3RNYXRoRW5hYmxlZCA9IGZhbHNlOwotICAg ICAgICB9CiAgICAgICAgIG9wdGlvbnMucHJlcHJvY2Vzc29yTWFjcm9zID0gc3Vic3RpdHV0aW9u TWFjcm9zOwogICAgICAgICBhdXRvIGxpYnJhcnkgPSBbbWV0YWxEZXZpY2UgbmV3TGlicmFyeVdp dGhTb3VyY2U6bnNTb3VyY2Ugb3B0aW9uczpvcHRpb25zIGVycm9yOiZuc0Vycm9yXTsKICAgICAg ICAgaWYgKGFuZ2xlOjpHZXRFbnZpcm9ubWVudFZhcihrQU5HTEVQcmludE1TTEVudilbMF0gPT0g JzEnKQo=