227166 2021-06-18 04:52:08 -0700 [LFC][WPE] Build failure with GCC 8.x 2021-06-18 06:38:05 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez bugs-noreply cdumez darin koivisto zalan oldest_to_newest 1770986 0 clopez 2021-06-18 04:52:08 -0700 When building the WPE port with GCC 8.x (shipped by default on distros like Debian 10 or RHEL 8) the following build failure happens if LAYOUT_FORMATTING_CONTEXT is enabled: Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-6.cpp.o [...] In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-6.cpp:6: ../../Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp: In member function ‘void WebCore::LayoutIntegration::LineLayout::prepareLayoutState()’: ../../Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:253:36: error: converting to ‘std::optional<WebCore::Layout::Edges>’ from initializer list would use explicit constructor ‘constexpr std::optional<_Tp>::optional(std::in_place_t, _Args&& ...) [with _Args = {}; typename std::enable_if<is_constructible_v<_Tp, _Args&& ...>, bool>::type <anonymous> = 0; _Tp = WebCore::Layout::Edges]’ rootGeometry.setPadding({ { } }); ^ ../../Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:253:36: error: converting to ‘std::in_place_t’ from initializer list would use explicit constructor ‘constexpr std::in_place_t::in_place_t()’ ninja: build stopped: subcommand failed. 1770989 1 431769 clopez 2021-06-18 04:59:53 -0700 Created attachment 431769 Patch 1770990 2 431770 clopez 2021-06-18 05:01:20 -0700 Created attachment 431770 Patch 1770993 3 431770 zalan 2021-06-18 05:58:55 -0700 Comment on attachment 431770 Patch Thanks for fixing it. 1770999 4 ews-feeder 2021-06-18 06:38:01 -0700 Committed r279036 (238956@main): <https://commits.webkit.org/238956@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431770. 431769 2021-06-18 04:59:53 -0700 2021-06-18 05:01:05 -0700 Patch bug-227166-20210618135952.patch text/plain 1827 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjMxZDg3ZmM2YzU3NzAx YjU0MzcxZGQ0MDQzMzVmOGUzNTJmZWE5NS4uYWFhMmRjNTcwNTQxNTRjNmRiNTZkZjgwM2I0OWVk YWIxMDY0NzBjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTE4ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtM RkNdW1dQRV0gQnVpbGQgZmFpbHVyZSB3aXRoIEdDQyA4LngKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzE2NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWlsZCBmYWlscyB3aXRoIHRoZSBlcnJv cjogY29udmVydGluZyB0byDigJhzdGQ6OmluX3BsYWNlX3TigJkgZnJvbSBpbml0aWFsaXplciBs aXN0CisgICAgICAgIHdvdWxkIHVzZSBleHBsaWNpdCBjb25zdHJ1Y3RvciDigJhjb25zdGV4cHIg c3RkOjppbl9wbGFjZV90Ojppbl9wbGFjZV90KCnigJkKKworICAgICAgICBObyBuZXcgdGVzdHMs IGlzIGEgYnVpbGQgZml4LgorCisgICAgICAgICogbGF5b3V0L2ludGVncmF0aW9uL0xheW91dElu dGVncmF0aW9uTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRJbnRlZ3Jh dGlvbjo6TGluZUxheW91dDo6cHJlcGFyZUxheW91dFN0YXRlKToKKwogMjAyMS0wNi0xOCAgUGhp bGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1l cl0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYWNhcHR1cmUtc3RyZWFtcy9N ZWRpYVN0cmVhbS1NZWRpYUVsZW1lbnQtc3JjT2JqZWN0Lmh0dHBzLmh0bWwgaXMgZmFpbGluZyBz aW5jZSByMjczNjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRp b24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCmluZGV4IDkyYTBi MWQzMDRjY2E5YWIwMTcwZDEzNWU4Yzk1MzdmNjVmNDY5ZGIuLjdmOTM5N2EyYWE3YjhlNjExODg2 YzViZmEyMzAxOWE1NzhjMWYzNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3Bw CkBAIC0yNTAsNyArMjUwLDcgQEAgdm9pZCBMaW5lTGF5b3V0OjpwcmVwYXJlTGF5b3V0U3RhdGUo KQogCiAgICAgYXV0byYgcm9vdEdlb21ldHJ5ID0gbV9sYXlvdXRTdGF0ZS5lbnN1cmVHZW9tZXRy eUZvckJveChyb290TGF5b3V0Qm94KCkpOwogICAgIHJvb3RHZW9tZXRyeS5zZXRDb250ZW50Qm94 V2lkdGgoZmxvdygpLmNvbnRlbnRTaXplKCkud2lkdGgoKSk7Ci0gICAgcm9vdEdlb21ldHJ5LnNl dFBhZGRpbmcoeyB7IH0gfSk7CisgICAgcm9vdEdlb21ldHJ5LnNldFBhZGRpbmcoeyB9KTsKICAg ICByb290R2VvbWV0cnkuc2V0Qm9yZGVyKHsgfSk7CiAgICAgcm9vdEdlb21ldHJ5LnNldEhvcml6 b250YWxNYXJnaW4oeyB9KTsKICAgICByb290R2VvbWV0cnkuc2V0VmVydGljYWxNYXJnaW4oeyB9 KTsK 431770 2021-06-18 05:01:20 -0700 2021-06-18 06:38:03 -0700 Patch bug-227166-20210618140119.patch text/plain 1819 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjMxZDg3ZmM2YzU3NzAx YjU0MzcxZGQ0MDQzMzVmOGUzNTJmZWE5NS4uMWVhOTY3ODdmMDMwODgwNGQ1OGFhYTUwYzZiMmU2 YmY5NDY4MjcyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTE4ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtM RkNdW1dQRV0gQnVpbGQgZmFpbHVyZSB3aXRoIEdDQyA4LngKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzE2NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWlsZCBmYWlscyB3aXRoIHRoZSBlcnJv cjogY29udmVydGluZyB0byAnc3RkOjppbl9wbGFjZV90JyBmcm9tIGluaXRpYWxpemVyIGxpc3QK KyAgICAgICAgd291bGQgdXNlIGV4cGxpY2l0IGNvbnN0cnVjdG9yICdjb25zdGV4cHIgc3RkOjpp bl9wbGFjZV90Ojppbl9wbGFjZV90KCknCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBpcyBhIGJ1 aWxkIGZpeC4KKworICAgICAgICAqIGxheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlv bkxpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246Okxp bmVMYXlvdXQ6OnByZXBhcmVMYXlvdXRTdGF0ZSk6CisKIDIwMjEtMDYtMTggIFBoaWxpcHBlIE5v cm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvbWVkaWFjYXB0dXJlLXN0cmVhbXMvTWVkaWFTdHJl YW0tTWVkaWFFbGVtZW50LXNyY09iamVjdC5odHRwcy5odG1sIGlzIGZhaWxpbmcgc2luY2UgcjI3 MzY0NQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91 dEludGVncmF0aW9uTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdy YXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcAppbmRleCA5MmEwYjFkMzA0Y2Nh OWFiMDE3MGQxMzVlOGM5NTM3ZjY1ZjQ2OWRiLi43ZjkzOTdhMmFhN2I4ZTYxMTg4NmM1YmZhMjMw MTlhNTc4YzFmMzU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRp b24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcApAQCAtMjUw LDcgKzI1MCw3IEBAIHZvaWQgTGluZUxheW91dDo6cHJlcGFyZUxheW91dFN0YXRlKCkKIAogICAg IGF1dG8mIHJvb3RHZW9tZXRyeSA9IG1fbGF5b3V0U3RhdGUuZW5zdXJlR2VvbWV0cnlGb3JCb3go cm9vdExheW91dEJveCgpKTsKICAgICByb290R2VvbWV0cnkuc2V0Q29udGVudEJveFdpZHRoKGZs b3coKS5jb250ZW50U2l6ZSgpLndpZHRoKCkpOwotICAgIHJvb3RHZW9tZXRyeS5zZXRQYWRkaW5n KHsgeyB9IH0pOworICAgIHJvb3RHZW9tZXRyeS5zZXRQYWRkaW5nKHsgfSk7CiAgICAgcm9vdEdl b21ldHJ5LnNldEJvcmRlcih7IH0pOwogICAgIHJvb3RHZW9tZXRyeS5zZXRIb3Jpem9udGFsTWFy Z2luKHsgfSk7CiAgICAgcm9vdEdlb21ldHJ5LnNldFZlcnRpY2FsTWFyZ2luKHsgfSk7Cg==