227156 2021-06-17 18:52:40 -0700 Rename numberOfPACBits to maxNumberOfAllowedPACBits. 2021-06-17 19:08:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1770920 0 mark.lam 2021-06-17 18:52:40 -0700 Just renaming the constant to better describe what it represents. There are no behavior changes. 1770921 1 431748 mark.lam 2021-06-17 18:55:14 -0700 Created attachment 431748 proposed patch. 1770922 2 mark.lam 2021-06-17 19:07:50 -0700 Thanks for the review. Landed in r279029: <http://trac.webkit.org/r279029>. 1770923 3 webkit-bug-importer 2021-06-17 19:08:40 -0700 <rdar://problem/79482756> 431748 2021-06-17 18:55:14 -0700 2021-06-17 18:57:36 -0700 proposed patch. bug-227156.patch text/plain 6931 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc5MDI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDIxLTA2LTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW5hbWUgbnVtYmVyT2ZQQUNCaXRzIHRvIG1heE51bWJlck9mQWxsb3dlZFBBQ0JpdHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjcxNTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKdXN0IHJlbmFtaW5n IHRoZSBjb25zdGFudCB0byBiZXR0ZXIgZGVzY3JpYmUgd2hhdCBpdCByZXByZXNlbnRzLiAgVGhl cmUgYXJlIG5vCisgICAgICAgIGJlaGF2aW9yIGNoYW5nZXMuCisKKyAgICAgICAgKiBhc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJBUk02NEUuaDoKKyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0Iz LmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9CMzo6Y29tcGlsZUNvbXBh cmVTdHJpY3RFcSk6CisgICAgICAgICogaml0L0Fzc2VtYmx5SGVscGVycy5jcHA6CisgICAgICAg IChKU0M6OkFzc2VtYmx5SGVscGVyczo6Y2FnZVdpdGhvdXRVbnRhZ2dpbmcpOgorICAgICAgICAo SlNDOjpBc3NlbWJseUhlbHBlcnM6OmNhZ2VDb25kaXRpb25hbGx5QW5kVW50YWcpOgorICAgICAg ICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc206CisKIDIwMjEtMDYtMTcgIE1hcmsg TGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIERlZmluZSBNYWNyb0Fzc2VtYmxl ckFSTTY0RTo6bnVtYmVyT2ZQQUNCaXRzIGJhc2VkIG9uIE9TX0NPTlNUQU5UKEVGRkVDVElWRV9B RERSRVNTX1dJRFRIKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJBUk02NEUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjRFLmgJKHJldmlzaW9uIDI3OTAyOCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NEUuaAkod29y a2luZyBjb3B5KQpAQCAtNTAsOCArNTAsOCBAQCB1c2luZyBBc3NlbWJsZXIgPSBUQVJHRVRfQVNT RU1CTEVSOwogY2xhc3MgTWFjcm9Bc3NlbWJsZXJBUk02NEUgOiBwdWJsaWMgTWFjcm9Bc3NlbWJs ZXJBUk02NCB7CiBwdWJsaWM6CiAgICAgc3RhdGljIGNvbnN0ZXhwciB1bnNpZ25lZCBudW1iZXJP ZlBvaW50ZXJCaXRzID0gc2l6ZW9mKHZvaWQqKSAqIENIQVJfQklUOwotICAgIHN0YXRpYyBjb25z dGV4cHIgdW5zaWduZWQgbnVtYmVyT2ZQQUNCaXRzID0gbnVtYmVyT2ZQb2ludGVyQml0cyAtIE9T X0NPTlNUQU5UKEVGRkVDVElWRV9BRERSRVNTX1dJRFRIKTsKLSAgICBzdGF0aWMgY29uc3RleHBy IHVpbnRwdHJfdCBub25QQUNCaXRzTWFzayA9ICgxdWxsIDw8IChudW1iZXJPZlBvaW50ZXJCaXRz IC0gbnVtYmVyT2ZQQUNCaXRzKSkgLSAxOworICAgIHN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQg bWF4TnVtYmVyT2ZBbGxvd2VkUEFDQml0cyA9IG51bWJlck9mUG9pbnRlckJpdHMgLSBPU19DT05T VEFOVChFRkZFQ1RJVkVfQUREUkVTU19XSURUSCk7CisgICAgc3RhdGljIGNvbnN0ZXhwciB1aW50 cHRyX3Qgbm9uUEFDQml0c01hc2sgPSAoMXVsbCA8PCAobnVtYmVyT2ZQb2ludGVyQml0cyAtIG1h eE51bWJlck9mQWxsb3dlZFBBQ0JpdHMpKSAtIDE7CiAKICAgICBBTFdBWVNfSU5MSU5FIHZvaWQg dGFnUmV0dXJuQWRkcmVzcygpCiAgICAgewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0 bC9GVExMb3dlckRGR1RvQjMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAkocmV2aXNpb24gMjc5MDI3KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x Njc0Miw3ICsxNjc0Miw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBtZXJnZS0+YXBwZW5kU29t ZVJlZ2lzdGVyKHB0cik7CiAgICAgICAgICAgICBtZXJnZS0+c2V0R2VuZXJhdG9yKFs9XSAoQ0Nh bGxIZWxwZXJzJiBqaXQsIGNvbnN0IFN0YWNrbWFwR2VuZXJhdGlvblBhcmFtcyYgcGFyYW1zKSB7 CiAgICAgICAgICAgICAgICAgaml0Lm1vdmUocGFyYW1zWzJdLmdwcigpLCBwYXJhbXNbMF0uZ3By KCkpOwotICAgICAgICAgICAgICAgIGppdC5iaXRGaWVsZEluc2VydDY0KHBhcmFtc1sxXS5ncHIo KSwgMCwgNjQgLSBNYWNyb0Fzc2VtYmxlcjo6bnVtYmVyT2ZQQUNCaXRzLCBwYXJhbXNbMF0uZ3By KCkpOworICAgICAgICAgICAgICAgIGppdC5iaXRGaWVsZEluc2VydDY0KHBhcmFtc1sxXS5ncHIo KSwgMCwgNjQgLSBNYWNyb0Fzc2VtYmxlcjo6bWF4TnVtYmVyT2ZBbGxvd2VkUEFDQml0cywgcGFy YW1zWzBdLmdwcigpKTsKICAgICAgICAgICAgIH0pOwogCiAgICAgICAgICAgICByZXN1bHQgPSBk b1VudGFnQXJyYXlQdHIobWVyZ2UpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9B c3NlbWJseUhlbHBlcnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvQXNzZW1ibHlIZWxwZXJzLmNwcAkocmV2aXNpb24gMjc5MDI3KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQ1 LDcgKzEwNDUsNyBAQCB2b2lkIEFzc2VtYmx5SGVscGVyczo6Y2FnZVdpdGhvdXRVbnRhZ2dpCiAg ICAgYWRkUHRyKFRydXN0ZWRJbW1QdHIoR2lnYWNhZ2U6OmJhc2VQdHIoa2luZCkpLCBzdG9yYWdl KTsKICNpZiBDUFUoQVJNNjRFKQogICAgIGlmIChraW5kID09IEdpZ2FjYWdlOjpQcmltaXRpdmUp Ci0gICAgICAgIGJpdEZpZWxkSW5zZXJ0NjQoc3RvcmFnZSwgMCwgNjQgLSBudW1iZXJPZlBBQ0Jp dHMsIHRlbXBSZWcpOworICAgICAgICBiaXRGaWVsZEluc2VydDY0KHN0b3JhZ2UsIDAsIDY0IC0g bWF4TnVtYmVyT2ZBbGxvd2VkUEFDQml0cywgdGVtcFJlZyk7CiAgICAgaWYgKHNraXAuaXNTZXQo KSkKICAgICAgICAgc2tpcC5saW5rKHRoaXMpOwogI2VuZGlmCkBAIC0xMDgyLDcgKzEwODIsNyBA QCB2b2lkIEFzc2VtYmx5SGVscGVyczo6Y2FnZUNvbmRpdGlvbmFsbHlBCiAgICAgICAgICAgICBB U1NFUlQoTG9naWNhbEltbWVkaWF0ZTo6Y3JlYXRlNjQoR2lnYWNhZ2U6Om1hc2soa2luZCkpLmlz VmFsaWQoKSk7CiAgICAgICAgICAgICBhbmRQdHIoVHJ1c3RlZEltbVB0cihHaWdhY2FnZTo6bWFz ayhraW5kKSksIHRlbXBSZWcpOwogICAgICAgICAgICAgYWRkUHRyKHNjcmF0Y2gsIHRlbXBSZWcp OwotICAgICAgICAgICAgYml0RmllbGRJbnNlcnQ2NCh0ZW1wUmVnLCAwLCA2NCAtIG51bWJlck9m UEFDQml0cywgc3RvcmFnZSk7CisgICAgICAgICAgICBiaXRGaWVsZEluc2VydDY0KHRlbXBSZWcs IDAsIDY0IC0gbWF4TnVtYmVyT2ZBbGxvd2VkUEFDQml0cywgc3RvcmFnZSk7CiAjZWxzZQogICAg ICAgICAgICAgYW5kUHRyKFRydXN0ZWRJbW1QdHIoR2lnYWNhZ2U6Om1hc2soa2luZCkpLCBzdG9y YWdlKTsKICAgICAgICAgICAgIGFkZFB0cihzY3JhdGNoLCBzdG9yYWdlKTsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQu YXNtCShyZXZpc2lvbiAyNzkwMjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93 TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQkod29ya2luZyBjb3B5KQpAQCAtNDg4LDggKzQ4OCw4IEBA IG1hY3JvIGNhZ2VkUHJpbWl0aXZlKHB0ciwgbGVuZ3RoLCBzY3JhdGMKICAgICBpZiBHSUdBQ0FH RV9FTkFCTEVECiAgICAgICAgIGNhZ2VQcmltaXRpdmUoR2lnYWNhZ2VDb25maWcgKyBHaWdhY2Fn ZTo6Q29uZmlnOjpiYXNlUHRycyArIEdpZ2FjYWdlUHJpbWl0aXZlQmFzZVB0ck9mZnNldCwgY29u c3RleHByIEdpZ2FjYWdlOjpwcmltaXRpdmVHaWdhY2FnZU1hc2ssIHNvdXJjZSwgc2NyYXRjaCkK ICAgICAgICAgaWYgQVJNNjRFCi0gICAgICAgICAgICBjb25zdCBudW1iZXJPZlBBQ0JpdHMgPSBj b25zdGV4cHIgTWFjcm9Bc3NlbWJsZXI6Om51bWJlck9mUEFDQml0cwotICAgICAgICAgICAgYmZp cSBzY3JhdGNoMiwgMCwgNjQgLSBudW1iZXJPZlBBQ0JpdHMsIHB0cgorICAgICAgICAgICAgY29u c3QgbWF4TnVtYmVyT2ZBbGxvd2VkUEFDQml0cyA9IGNvbnN0ZXhwciBNYWNyb0Fzc2VtYmxlcjo6 bWF4TnVtYmVyT2ZBbGxvd2VkUEFDQml0cworICAgICAgICAgICAgYmZpcSBzY3JhdGNoMiwgMCwg NjQgLSBtYXhOdW1iZXJPZkFsbG93ZWRQQUNCaXRzLCBwdHIKICAgICAgICAgZW5kCiAgICAgZW5k CiAgICAgaWYgQVJNNjRFCkBAIC01MTIsOCArNTEyLDggQEAgbWFjcm8gY2FnZWRQcmltaXRpdmVN YXlCZU51bGwocHRyLCBsZW5ndAogICAgIGlmIEdJR0FDQUdFX0VOQUJMRUQKICAgICAgICAgY2Fn ZVByaW1pdGl2ZShHaWdhY2FnZUNvbmZpZyArIEdpZ2FjYWdlOjpDb25maWc6OmJhc2VQdHJzICsg R2lnYWNhZ2VQcmltaXRpdmVCYXNlUHRyT2Zmc2V0LCBjb25zdGV4cHIgR2lnYWNhZ2U6OnByaW1p dGl2ZUdpZ2FjYWdlTWFzaywgc291cmNlLCBzY3JhdGNoKQogICAgICAgICBpZiBBUk02NEUKLSAg ICAgICAgICAgIGNvbnN0IG51bWJlck9mUEFDQml0cyA9IGNvbnN0ZXhwciBNYWNyb0Fzc2VtYmxl cjo6bnVtYmVyT2ZQQUNCaXRzCi0gICAgICAgICAgICBiZmlxIHNjcmF0Y2gyLCAwLCA2NCAtIG51 bWJlck9mUEFDQml0cywgcHRyCisgICAgICAgICAgICBjb25zdCBtYXhOdW1iZXJPZkFsbG93ZWRQ QUNCaXRzID0gY29uc3RleHByIE1hY3JvQXNzZW1ibGVyOjptYXhOdW1iZXJPZkFsbG93ZWRQQUNC aXRzCisgICAgICAgICAgICBiZmlxIHNjcmF0Y2gyLCAwLCA2NCAtIG1heE51bWJlck9mQWxsb3dl ZFBBQ0JpdHMsIHB0cgogICAgICAgICBlbmQKICAgICBlbmQKICAgICBpZiBBUk02NEUKSW5kZXg6 IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzkwMjgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA2LTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KKworICAgICAgICBSZW5hbWUgbnVtYmVyT2ZQQUNCaXRzIHRvIG1heE51bWJlck9mQWxs b3dlZFBBQ0JpdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjcxNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHd0Zi9DYWdlZFB0ci5oOgorCiAyMDIxLTA2LTE3ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBEZWZpbmUgTWFjcm9Bc3NlbWJsZXJBUk02NEU6Om51bWJl ck9mUEFDQml0cyBiYXNlZCBvbiBPU19DT05TVEFOVChFRkZFQ1RJVkVfQUREUkVTU19XSURUSCku CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9DYWdlZFB0ci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X VEYvd3RmL0NhZ2VkUHRyLmgJKHJldmlzaW9uIDI3OTAyOCkKKysrIFNvdXJjZS9XVEYvd3RmL0Nh Z2VkUHRyLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDggKzQ1LDggQEAgY2xhc3MgQ2FnZWRQdHIg ewogcHVibGljOgogICAgIHN0YXRpYyBjb25zdGV4cHIgR2lnYWNhZ2U6OktpbmQga2luZCA9IHBh c3NlZEtpbmQ7CiAgICAgc3RhdGljIGNvbnN0ZXhwciB1bnNpZ25lZCBudW1iZXJPZlBvaW50ZXJC aXRzID0gc2l6ZW9mKFQqKSAqIENIQVJfQklUOwotICAgIHN0YXRpYyBjb25zdGV4cHIgdW5zaWdu ZWQgbnVtYmVyT2ZQQUNCaXRzID0gbnVtYmVyT2ZQb2ludGVyQml0cyAtIE9TX0NPTlNUQU5UKEVG RkVDVElWRV9BRERSRVNTX1dJRFRIKTsKLSAgICBzdGF0aWMgY29uc3RleHByIHVpbnRwdHJfdCBu b25QQUNCaXRzTWFzayA9ICgxdWxsIDw8IChudW1iZXJPZlBvaW50ZXJCaXRzIC0gbnVtYmVyT2ZQ QUNCaXRzKSkgLSAxOworICAgIHN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgbWF4TnVtYmVyT2ZB bGxvd2VkUEFDQml0cyA9IG51bWJlck9mUG9pbnRlckJpdHMgLSBPU19DT05TVEFOVChFRkZFQ1RJ VkVfQUREUkVTU19XSURUSCk7CisgICAgc3RhdGljIGNvbnN0ZXhwciB1aW50cHRyX3Qgbm9uUEFD Qml0c01hc2sgPSAoMXVsbCA8PCAobnVtYmVyT2ZQb2ludGVyQml0cyAtIG1heE51bWJlck9mQWxs b3dlZFBBQ0JpdHMpKSAtIDE7CiAKICAgICBDYWdlZFB0cigpIDogQ2FnZWRQdHIobnVsbHB0cikg eyB9CiAgICAgQ2FnZWRQdHIoc3RkOjpudWxscHRyX3QpCg==