227154 2021-06-17 16:52:08 -0700 Add assertion in RunLoop::dispatch 2021-06-17 17:03:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen benjamin cdumez cmarcelo ews-watchlist ggaren sihui_liu webkit-bug-importer oldest_to_newest 1770891 0 achristensen 2021-06-17 16:52:08 -0700 Add assertion in RunLoop::dispatch 1770892 1 431741 achristensen 2021-06-17 16:53:37 -0700 Created attachment 431741 Patch 1770894 2 431741 ggaren 2021-06-17 16:55:53 -0700 Comment on attachment 431741 Patch r=me 1770898 3 achristensen 2021-06-17 17:01:00 -0700 http://trac.webkit.org/r279025 1770899 4 webkit-bug-importer 2021-06-17 17:02:29 -0700 <rdar://problem/79477948> 1770900 5 cdumez 2021-06-17 17:03:14 -0700 I bet Sihui just fixed it via: commit 9c3f87df21fba60bd607cb2[3a70b6fad5ac56926 Author: sihui_liu@apple.com <sihui_liu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Thu Jun 10 23:55:52 2021 +0000 Regression(r278449): add null check for completionHandler in WebIDBServer::close https://bugs.webkit.org/show_bug.cgi?id=226900 rdar://79160392 Reviewed by Chris Dumez. * NetworkProcess/IndexedDB/WebIDBServer.cpp: (WebKit::WebIDBServer::close): And your assertion wouldn't have caught it I believe? 431741 2021-06-17 16:53:37 -0700 2021-06-17 16:55:53 -0700 Patch bug-227154-20210617165336.patch text/plain 1575 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4OTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVkNGM4MjI5M2ViOTMxY2Y0YWExMmU0 Y2YzZWM3ZjllOTU2NTk1ZDUuLmU2ODA3Njc0NjhiMjRlYTljY2NjMmNlOWZlMjdjNzhlNDg4Y2E2 ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDYtMTcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgYXNzZXJ0aW9uIGluIFJ1bkxv b3A6OmRpc3BhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjcxNTQKKyAgICAgICAgPHJkYXI6Ly83OTI0Mzc2OT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHNob3VsZCBoZWxwIHVzIGZpbmQg d2hhdCBpcyBzY2hlZHVsaW5nIG51bGwgZnVuY3Rpb25zLgorCisgICAgICAgICogd3RmL1J1bkxv b3AuY3BwOgorICAgICAgICAoV1RGOjpSdW5Mb29wOjpkaXNwYXRjaCk6CisgICAgICAgIChXVEY6 OlJ1bkxvb3A6OmRpc3BhdGNoQWZ0ZXIpOgorCiAyMDIxLTA2LTE2ICBBbGljaWEgQm95YSBHYXJj w61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1RGXSBEYXRhTXV0ZXg6IEFzc2Vy dCBvbiBkb3VibGUgbG9ja2luZyBvbiB0aGUgc2FtZSB0aHJlYWQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL1J1bkxvb3AuY3BwIGIvU291cmNlL1dURi93dGYvUnVuTG9vcC5jcHAKaW5kZXgg ODI4ODNkNTU4ZmNhN2U2NDE3ZGI2YmZmNGMzNjQwZWVhNzgyN2IxOC4uODk3MzZlYjZiNDI3Nzk5 Yjc4ZjdkYWU0NWI4MGEyYTQ0NzczOTJjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUnVu TG9vcC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvUnVuTG9vcC5jcHAKQEAgLTE0MSw4ICsxNDEs OSBAQCB2b2lkIFJ1bkxvb3A6OnBlcmZvcm1Xb3JrKCkKICAgICAgICAgd2FrZVVwKCk7CiB9CiAK LXZvaWQgUnVuTG9vcDo6ZGlzcGF0Y2goRnVuY3Rpb248dm9pZCAoKT4mJiBmdW5jdGlvbikKK3Zv aWQgUnVuTG9vcDo6ZGlzcGF0Y2goRnVuY3Rpb248dm9pZCgpPiYmIGZ1bmN0aW9uKQogeworICAg IFJFTEVBU0VfQVNTRVJUKGZ1bmN0aW9uKTsKICAgICBib29sIG5lZWRzV2FrZXVwID0gZmFsc2U7 CiAKICAgICB7CkBAIC0xNTcsNiArMTU4LDcgQEAgdm9pZCBSdW5Mb29wOjpkaXNwYXRjaChGdW5j dGlvbjx2b2lkICgpPiYmIGZ1bmN0aW9uKQogCiB2b2lkIFJ1bkxvb3A6OmRpc3BhdGNoQWZ0ZXIo U2Vjb25kcyBkZWxheSwgRnVuY3Rpb248dm9pZCgpPiYmIGZ1bmN0aW9uKQogeworICAgIFJFTEVB U0VfQVNTRVJUKGZ1bmN0aW9uKTsKICAgICBhdXRvIHRpbWVyID0gbmV3IERpc3BhdGNoVGltZXIo KnRoaXMpOwogICAgIHRpbWVyLT5zZXRGdW5jdGlvbihbdGltZXIsIGZ1bmN0aW9uID0gV1RGTW92 ZShmdW5jdGlvbildIHsKICAgICAgICAgZnVuY3Rpb24oKTsK