22714 2008-12-06 13:11:22 -0800 Clean up some autotools warnings 2014-03-25 15:17:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.4 RESOLVED INVALID P2 Normal --- 0 dmacks webkit-unassigned mrobinson oldest_to_newest 101669 0 dmacks 2008-12-06 13:11:22 -0800 Building r39007 on OS X 10.4 with autoconf-2.63 automake-1.10.2 libtool-2.2.4, autogen.sh whines: libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree. libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am. So okay, let's do that. 101675 1 25820 dmacks 2008-12-06 13:30:58 -0800 Created attachment 25820 Add autotools flags as requested by current autotools versions With this patch, autogen gives: >libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'. >libtoolize: linking file `m4/libtool.m4' >libtoolize: linking file `m4/ltoptions.m4' >libtoolize: linking file `m4/ltsugar.m4' >libtoolize: linking file `m4/ltversion.m4' >libtoolize: linking file `m4/lt~obsolete.m4' >libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am. Looks like libtool is doing a simple grep in Makefile.am, doesn't know WebKit uses GNUmakefile.am instead. Why *does* it use GNUmakefile instead of Makefile? 101688 2 mrowe 2008-12-06 14:57:18 -0800 (In reply to comment #1) > Looks like libtool is doing a simple grep in Makefile.am, doesn't know WebKit > uses GNUmakefile.am instead. Why *does* it use GNUmakefile instead of Makefile? Because Makefile is used for other purposes. 102158 3 25820 darin 2008-12-10 14:48:39 -0800 Comment on attachment 25820 Add autotools flags as requested by current autotools versions r=me tabs in ChangeLog 102294 4 zecke 2008-12-11 16:32:47 -0800 Could you please set a valid email address in future patches? 102298 5 zecke 2008-12-11 16:38:06 -0800 Landed in r39222. 102348 6 zecke 2008-12-12 08:04:15 -0800 Yes, autotools complains about not adding m4. But this directory does not even exist and is breaking the build for others... I will back this patch out and we can look for another solution. 105445 7 25820 mrowe 2009-01-12 23:33:22 -0800 Comment on attachment 25820 Add autotools flags as requested by current autotools versions Clearing review flag since it appears that this patch was rolled out. 105456 8 dmacks 2009-01-13 00:28:10 -0800 Experimenting further, this patch (nor any similar variant I tried) doesn't fully clear the warnings reliably. I talked to a libtool developer who said they only recently became aware of gnumakefile.am as an alternative to makefile.am. I'm (now) not surprised that there are warnings and that trying to fix them creates other problems at this time:( 994369 9 mrobinson 2014-03-25 15:17:33 -0700 Autotools is gone now. 25820 2008-12-06 13:30:58 -0800 2010-06-10 16:31:18 -0700 Add autotools flags as requested by current autotools versions m4.patch text/plain 1244 dmacks SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5MDY5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTIt MDYgIERhbmllbCBNYWNrcyAgPHNldCBFTUFJTF9BRERSRVNTIGVudmlyb25tZW50IHZhcmlhYmxl PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJUHV0IGxpYnRvb2wg bWFjcm8gZmlsZXMgaW4gc3ViZGlyIHRoYXQgaXQgd2FudHMuCisKKwlodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MTQKKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFt OgorICAgICAgICAqIGNvbmZpZ3VyZS5hYzoKKwogMjAwOC0xMi0wMyAgU2ltb24gSGF1c21hbm4g IDxoYXVzbWFubkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZl c3Riw7guCkluZGV4OiBHTlVtYWtlZmlsZS5hbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBHTlVtYWtlZmlsZS5h bQkocmV2aXNpb24gMzkwNjgpCisrKyBHTlVtYWtlZmlsZS5hbQkod29ya2luZyBjb3B5KQpAQCAt NDcsNiArNDcsOCBAQCBsaWJfTElCUkFSSUVTIDo9CiAKIElETF9CSU5ESU5HUyA6PQogCitBQ0xP Q0FMX0FNRkxBR1M9LUkgbTQKKwogIyBHbG9iYWwgZmxhZ3MgdG8gQ1BQCiBnbG9iYWxfY3BwZmxh Z3MgOj0KIApJbmRleDogY29uZmlndXJlLmFjCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNvbmZpZ3VyZS5hYwko cmV2aXNpb24gMzkwNjgpCisrKyBjb25maWd1cmUuYWMJKHdvcmtpbmcgY29weSkKQEAgLTE3LDYg KzE3LDcgQEAgQUNfU1VCU1QoV0VCS0lUX01JTk9SX1ZFUlNJT04pCiBBQ19TVUJTVChXRUJLSVRf TUlDUk9fVkVSU0lPTikKIAogQUNfQ09ORklHX1NSQ0RJUihbV2ViQ29yZS9jb25maWcuaF0pCitB Q19DT05GSUdfTUFDUk9fRElSKFttNF0pCiAKIGRubCAjIExpYnRvb2wgbGlicmFyeSB2ZXJzaW9u LCBub3QgdG8gY29uZnVzZSB3aXRoIEFQSSB2ZXJzaW9uCiBkbmwgIyBzZWUgaHR0cDovL3d3dy5n bnUub3JnL3NvZnR3YXJlL2xpYnRvb2wvbWFudWFsLmh0bWwjVmVyc2lvbmluZwo=