227129 2021-06-17 09:11:03 -0700 REGRESSION (r277067): Incorrect text color for default-button appearance 2021-06-17 11:57:13 -0700 1 1 1 Unclassified WebKit Forms Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 akeerthi akeerthi cdumez changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1770664 0 akeerthi 2021-06-17 09:11:03 -0700 ... 1770666 1 akeerthi 2021-06-17 09:11:17 -0700 <rdar://problem/79032808> 1770668 2 431677 akeerthi 2021-06-17 09:12:50 -0700 Created attachment 431677 Patch 1770747 3 akeerthi 2021-06-17 11:50:40 -0700 Thanks for the review! 1770749 4 ews-feeder 2021-06-17 11:57:10 -0700 Committed r279002 (238927@main): <https://commits.webkit.org/238927@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431677. 431677 2021-06-17 09:12:50 -0700 2021-06-17 11:57:12 -0700 Patch bug-227129-20210617121249.patch text/plain 6562 akeerthi U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjdiODk2MDlmODU4ZDUx ZjZhNjk0MmUyNzZkMmZhZDY0OGEwZWFkOC4uOGI1MjdlMDE1YWY2NDEzMGFiNjIzNzUxYTcwNDVh YjE3OTIzOWMzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDIxLTA2LTE3ICBBZGl0 eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy Mjc3MDY3KTogSW5jb3JyZWN0IHRleHQgY29sb3IgZm9yIGRlZmF1bHQtYnV0dG9uIGFwcGVhcmFu Y2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzEy OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzkwMzI4MDg+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnV0dG9ucyBzdHlsZWQgd2l0aCAnLXdlYmtp dC1hcHBlYXJhbmNlOiBkZWZhdWx0LWJ1dHRvbicgY3VycmVudGx5IHJlbHkKKyAgICAgICAgb24g dGhlIENTUyB2YWx1ZSAnYWN0aXZlYnV0dG9udGV4dCcgZm9yIHRoZWlyIHRleHQgY29sb3IuIHIy NzcwNjcKKyAgICAgICAgdXBkYXRlZCB0aGUgY29sb3IgdG8gdXNlIHN5c3RlbSBjb2xvcnMsIGZv ciBjb25zaXN0ZW5jeSB3aXRoIHRoZSByZXN0CisgICAgICAgIG9mIHRoZSBwbGF0Zm9ybS4KKwor ICAgICAgICBJbiBtYWNPUyBNb250ZXJleSwgdGhlICdhY3RpdmVidXR0b250ZXh0JyBjb2xvciBh bmQgdGhlIGRlZmF1bHQgYnV0dG9uCisgICAgICAgIHRleHQgY29sb3IgYXJlIG5vdCBlcXVpdmFs ZW50LiAnQWN0aXZlJyBidXR0b25zIG5vIGxvbmdlciB1c2UKKyAgICAgICAgTlNCYWNrZ3JvdW5k U3R5bGVFbXBoYXNpemVkLCB3aGlsZSBkZWZhdWx0IGJ1dHRvbnMgc3RpbGwgZG8uCisgICAgICAg IENvbnNlcXVlbnRseSwgZGVmYXVsdCBidXR0b25zIGFyZSByZW5kZXJlZCB3aXRoIGFuIGluY29y cmVjdCB0ZXh0IGNvbG9yLgorCisgICAgICAgIFRvIGZpeCwgdXNlIHRoZSBjb3JyZWN0IHN5c3Rl bSBjb2xvciBmb3IgdGhlIHRleHQgY29sb3Igb2YgZGVmYXVsdAorICAgICAgICBidXR0b25zLiBU byBhdm9pZCBjaGFuZ2luZyB0aGUgYmVoYXZpb3Igb2YgcGxhdGZvcm1zIG90aGVyIHRoYW4KKyAg ICAgICAgbWFjT1MsIHRoZSAnYWN0aXZlYnV0dG9udGV4dCcgY29sb3IgcmVtYWlucyB0aGUgZGVm YXVsdCB0ZXh0IGNvbG9yCisgICAgICAgIHNwZWNpZmllZCBpbiBSZW5kZXJUaGVtZS4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJUaGVtZTo6ZGVmYXVsdEJ1dHRvblRleHRDb2xvciBjb25zdCk6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJUaGVtZTo6cGxhdGZvcm1EZWZhdWx0QnV0dG9uVGV4dENvbG9yIGNvbnN0KToKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWUuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyVGhlbWVNYWMuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW06Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZU1hYzo6cGxhdGZvcm1EZWZhdWx0QnV0dG9uVGV4 dENvbG9yIGNvbnN0KToKKyAgICAgICAgKiByZW5kZXJpbmcvVGV4dFBhaW50U3R5bGUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y29tcHV0ZVRleHRQYWludFN0eWxlKToKKwogMjAyMS0wNi0xMCAg QXJjYWR5IEdvbGRtaW50cy1PcmxvdiAgPGFnb2xkbWludHNAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbQ2Fpcm9dIEZpeCBQYXRoOjpib3VuZGluZ1JlY3RTbG93Q2FzZSB3aGVuIHRoZSBwYXRoIGlz IGEgc2luZ2xlIE1vdmVUbwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRoZW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAK aW5kZXggOGE1ZmMwZWMzYThhMzE4N2I3MGNjZDM4Y2FkNzg3YzgwOGIwMzQ1MS4uYWU0MjY4NmRj NDYzYjdiMTEyNWY5MGQ0N2E4NDA0YjBhNTUxYmU3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWUuY3BwCkBAIC0xNDAwLDYgKzE0MDAsMTkgQEAgQ29sb3IgUmVuZGVyVGhl bWU6OnBsYXRmb3JtQXBwSGlnaGxpZ2h0Q29sb3IoT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlv bnM+KSBjb24KIH0KICNlbmRpZgogCitDb2xvciBSZW5kZXJUaGVtZTo6ZGVmYXVsdEJ1dHRvblRl eHRDb2xvcihPcHRpb25TZXQ8U3R5bGVDb2xvcjo6T3B0aW9ucz4gb3B0aW9ucykgY29uc3QKK3sK KyAgICBhdXRvJiBjYWNoZSA9IGNvbG9yQ2FjaGUob3B0aW9ucyk7CisgICAgaWYgKCFjYWNoZS5k ZWZhdWx0QnV0dG9uVGV4dENvbG9yLmlzVmFsaWQoKSkKKyAgICAgICAgY2FjaGUuZGVmYXVsdEJ1 dHRvblRleHRDb2xvciA9IHBsYXRmb3JtRGVmYXVsdEJ1dHRvblRleHRDb2xvcihvcHRpb25zKTsK KyAgICByZXR1cm4gY2FjaGUuZGVmYXVsdEJ1dHRvblRleHRDb2xvcjsKK30KKworQ29sb3IgUmVu ZGVyVGhlbWU6OnBsYXRmb3JtRGVmYXVsdEJ1dHRvblRleHRDb2xvcihPcHRpb25TZXQ8U3R5bGVD b2xvcjo6T3B0aW9ucz4gb3B0aW9ucykgY29uc3QKK3sKKyAgICByZXR1cm4gc3lzdGVtQ29sb3Io Q1NTVmFsdWVBY3RpdmVidXR0b250ZXh0LCBvcHRpb25zKTsKK30KKwogI2lmIEVOQUJMRShUT1VD SF9FVkVOVFMpCiAKIENvbG9yIFJlbmRlclRoZW1lOjp0YXBIaWdobGlnaHRDb2xvcigpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oCmluZGV4IGJkODU1MmQwMThjODc5YzBlNjFk NmQ5NzMzZTA1ZmMwZTkwYmY5ZDQuLmU3ZTZlYmIxYjlkMWViYjE4ODA3ZmIwYWE4OTE2ZjljODAx Zjc4MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oCkBAIC0xNjYsNiAr MTY2LDggQEAgcHVibGljOgogICAgIENvbG9yIGFwcEhpZ2hsaWdodENvbG9yKE9wdGlvblNldDxT dHlsZUNvbG9yOjpPcHRpb25zPikgY29uc3Q7CiAjZW5kaWYKIAorICAgIENvbG9yIGRlZmF1bHRC dXR0b25UZXh0Q29sb3IoT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlvbnM+KSBjb25zdDsKKwog ICAgIENvbG9yIGRhdGVQbGFjZWhvbGRlclRleHRDb2xvcihjb25zdCBDb2xvciYgdGV4dENvbG9y LCBjb25zdCBDb2xvciYgYmFja2dyb3VuZENvbG9yKSBjb25zdDsKIAogICAgIHZpcnR1YWwgQ29s b3IgZGlzYWJsZWRUZXh0Q29sb3IoY29uc3QgQ29sb3ImIHRleHRDb2xvciwgY29uc3QgQ29sb3Im IGJhY2tncm91bmRDb2xvcikgY29uc3Q7CkBAIC0yODQsNiArMjg2LDkgQEAgcHJvdGVjdGVkOgog I2lmIEVOQUJMRShBUFBfSElHSExJR0hUUykKICAgICB2aXJ0dWFsIENvbG9yIHBsYXRmb3JtQXBw SGlnaGxpZ2h0Q29sb3IoT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlvbnM+KSBjb25zdDsKICNl bmRpZgorCisgICAgdmlydHVhbCBDb2xvciBwbGF0Zm9ybURlZmF1bHRCdXR0b25UZXh0Q29sb3Io T3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlvbnM+KSBjb25zdDsKKwogICAgIHZpcnR1YWwgYm9v bCBzdXBwb3J0c1NlbGVjdGlvbkZvcmVncm91bmRDb2xvcnMoT3B0aW9uU2V0PFN0eWxlQ29sb3I6 Ok9wdGlvbnM+KSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAgICAgdmlydHVhbCBib29sIHN1cHBv cnRzTGlzdEJveFNlbGVjdGlvbkZvcmVncm91bmRDb2xvcnMoT3B0aW9uU2V0PFN0eWxlQ29sb3I6 Ok9wdGlvbnM+KSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKQEAgLTQ0Miw2ICs0NDcsOCBAQCBw cm90ZWN0ZWQ6CiAjaWYgRU5BQkxFKEFQUF9ISUdITElHSFRTKQogICAgICAgICBDb2xvciBhcHBI aWdobGlnaHRDb2xvcjsKICNlbmRpZgorCisgICAgICAgIENvbG9yIGRlZmF1bHRCdXR0b25UZXh0 Q29sb3I7CiAgICAgfTsKIAogICAgIHZpcnR1YWwgQ29sb3JDYWNoZSYgY29sb3JDYWNoZShPcHRp b25TZXQ8U3R5bGVDb2xvcjo6T3B0aW9ucz4pIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVNYWMuaAppbmRleCBjMzBjZTRhNTgzYTVhMDEwOGE5ZDRmNzE4YTc0M2Qy OTQwYTU1ZGU1Li4xZTYxNjg3NjBmMTE3NDc3NjFhOGEzYzNlNWIyZThkNmQyZDFiODhkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMuaApAQCAtNjksNiArNjksNyBA QCBwdWJsaWM6CiAjaWYgRU5BQkxFKEFQUF9ISUdITElHSFRTKQogICAgIENvbG9yIHBsYXRmb3Jt QXBwSGlnaGxpZ2h0Q29sb3IoT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlvbnM+KSBjb25zdCBm aW5hbDsKICNlbmRpZgorICAgIENvbG9yIHBsYXRmb3JtRGVmYXVsdEJ1dHRvblRleHRDb2xvcihP cHRpb25TZXQ8U3R5bGVDb2xvcjo6T3B0aW9ucz4pIGNvbnN0IGZpbmFsOwogCiAgICAgU2Nyb2xs YmFyQ29udHJvbFNpemUgc2Nyb2xsYmFyQ29udHJvbFNpemVGb3JQYXJ0KENvbnRyb2xQYXJ0KSBm aW5hbCB7IHJldHVybiBTY3JvbGxiYXJDb250cm9sU2l6ZTo6U21hbGw7IH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCmluZGV4IDExNjdiOGNmMTg1ZjUzMzFk ZDFiYTRiMTBiMjEwMzVkY2M3YmRlNTYuLjk0YmExNWVkNzA3YTE3MDU0ZWNiMGMyNzRhMTFlZjI2 M2UwNjFlN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0K QEAgLTQwNCw2ICs0MDQsMTIgQEAgQ29sb3IgUmVuZGVyVGhlbWVNYWM6OnBsYXRmb3JtQXBwSGln aGxpZ2h0Q29sb3IoT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlvbnM+KQogfQogI2VuZGlmCiAK K0NvbG9yIFJlbmRlclRoZW1lTWFjOjpwbGF0Zm9ybURlZmF1bHRCdXR0b25UZXh0Q29sb3IoT3B0 aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlvbnM+IG9wdGlvbnMpIGNvbnN0Cit7CisgICAgTG9jYWxE ZWZhdWx0U3lzdGVtQXBwZWFyYW5jZSBsb2NhbEFwcGVhcmFuY2Uob3B0aW9ucy5jb250YWlucyhT dHlsZUNvbG9yOjpPcHRpb25zOjpVc2VEYXJrQXBwZWFyYW5jZSkpOworICAgIHJldHVybiBjb2xv ckZyb21OU0NvbG9yKFtOU0NvbG9yIGFsdGVybmF0ZVNlbGVjdGVkQ29udHJvbFRleHRDb2xvcl0p OworfQorCiBzdGF0aWMgQ29sb3IgYWN0aXZlQnV0dG9uVGV4dENvbG9yKCkKIHsKICAgICAvLyBG SVhNRTogPHJkYXI6Ly9wcm9ibGVtLzc3NTcyNjIyPiBUaGVyZSBpcyBubyBzaW5nbGUgY29ycmVz cG9uZGluZyBOU0NvbG9yIGZvciBBY3RpdmVCdXR0b25UZXh0LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludFN0eWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9UZXh0UGFpbnRTdHlsZS5jcHAKaW5kZXggYTc5NGQ0ZWRmMDJiNDNhMDFlYjc0MGVj NzAxMGNmOTI3MjBjMDE4MC4uMWFlNDJjZTlmMzU1NDYwZjFjNmE2ZWQyODZkYTA0OTQxM2YyMDJi NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludFN0eWxlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dFBhaW50U3R5bGUuY3BwCkBAIC0x MDgsNyArMTA4LDcgQEAgVGV4dFBhaW50U3R5bGUgY29tcHV0ZVRleHRQYWludFN0eWxlKGNvbnN0 IEZyYW1lJiBmcmFtZSwgY29uc3QgUmVuZGVyU3R5bGUmIGxpbmUKICAgICAgICAgICAgIE9wdGlv blNldDxTdHlsZUNvbG9yOjpPcHRpb25zPiBvcHRpb25zOwogICAgICAgICAgICAgaWYgKHBhZ2Ut PnVzZVN5c3RlbUFwcGVhcmFuY2UoKSkKICAgICAgICAgICAgICAgICBvcHRpb25zLmFkZChTdHls ZUNvbG9yOjpPcHRpb25zOjpVc2VTeXN0ZW1BcHBlYXJhbmNlKTsKLSAgICAgICAgICAgIHBhaW50 U3R5bGUuZmlsbENvbG9yID0gUmVuZGVyVGhlbWU6OnNpbmdsZXRvbigpLnN5c3RlbUNvbG9yKENT U1ZhbHVlQWN0aXZlYnV0dG9udGV4dCwgb3B0aW9ucyk7CisgICAgICAgICAgICBwYWludFN0eWxl LmZpbGxDb2xvciA9IFJlbmRlclRoZW1lOjpzaW5nbGV0b24oKS5kZWZhdWx0QnV0dG9uVGV4dENv bG9yKG9wdGlvbnMpOwogICAgICAgICAgICAgcmV0dXJuIHBhaW50U3R5bGU7CiAgICAgICAgIH0K ICAgICB9Cg==