227125 2021-06-17 08:24:07 -0700 [JSC] Work around apparent miscompilation on ARM/GCC >=8.4 2021-06-21 06:26:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 angelos angelos darin ews-watchlist fpizlo fujii ggaren guijemont joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1770639 0 angelos 2021-06-17 08:24:07 -0700 [JSC] Work around apparent miscompilation on ARM/GCC >=8.4 1770641 1 431667 angelos 2021-06-17 08:28:45 -0700 Created attachment 431667 Patch 1770643 2 angelos 2021-06-17 08:31:08 -0700 We get upwards of 1300 failing tests on ARMv7 after https://trac.webkit.org/changeset/278942/webkit. AFAICT the change itself is innocuous, but triggers a bug in GCC, so a revert seems inappropriate. 1770645 3 431669 angelos 2021-06-17 08:41:42 -0700 Created attachment 431669 Patch 1770646 4 431670 angelos 2021-06-17 08:47:56 -0700 Created attachment 431670 Patch 1770647 5 431670 fpizlo 2021-06-17 08:48:28 -0700 Comment on attachment 431670 Patch Yikes! 1770686 6 ews-feeder 2021-06-17 09:36:44 -0700 Committed r278991 (238917@main): <https://commits.webkit.org/238917@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431670. 1770687 7 webkit-bug-importer 2021-06-17 09:37:41 -0700 <rdar://problem/79455660> 1771115 8 431670 darin 2021-06-19 13:15:06 -0700 Comment on attachment 431670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431670&action=review > Source/JavaScriptCore/jit/RegisterSet.h:41 > +#if CPU(ARM) && COMPILER(GCC) > + > +#if GCC_VERSION_AT_LEAST(8, 4, 0) && !GCC_VERSION_AT_LEAST(9, 0, 0) No reason for the nested #if here. Could just be a single string of &&, I think. > Source/JavaScriptCore/jit/RegisterSet.h:46 > +#define REGISTERSET_BITMAP_SLACK 1 This can be a constexpr int; does not need to be a #define. 1771253 9 guijemont 2021-06-21 04:14:02 -0700 (In reply to Darin Adler from comment #8) > Comment on attachment 431670 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431670&action=review > > > Source/JavaScriptCore/jit/RegisterSet.h:41 > > +#if CPU(ARM) && COMPILER(GCC) > > + > > +#if GCC_VERSION_AT_LEAST(8, 4, 0) && !GCC_VERSION_AT_LEAST(9, 0, 0) > > No reason for the nested #if here. Could just be a single string of &&, I > think. The previous version of the patch without nested #ifs did not compile on clang EWS bots, as GCC_VERSION_AT_LEAST is not defined. 1771268 10 angelos 2021-06-21 06:26:22 -0700 Note: apparently this wasn't a miscompilation; it only looked like one because the bug depended on the compiler configuration and we tested with GCC versions that were not configured identically. Submitted what should be a proper fix in bug 227212. 431667 2021-06-17 08:28:45 -0700 2021-06-17 08:44:48 -0700 Patch bug-227125-20210617152844.patch text/plain 1892 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl OTE5NTFiYzUwNjk5ZGZjYmY0ZmVhOTBmODhhYThmYTkxZDk1NWYyLi5jN2Y2ZmMyMDdjMDljZDRm ZmM5MGM3YTIzZjFlOWVkYTY5ZmFkMmE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wNi0xNyAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFuZ2Vsb3NA aWdhbGlhLmNvbT4KKworICAgICAgICBbSlNDXSBXb3JrIGFyb3VuZCBhcHBhcmVudCBtaXNjb21w aWxhdGlvbiBvbiBBUk0vR0NDID49OC40CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjcxMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIHNlZW1zIHRvIGJlIGEgR0NDIG1pc2NvbXBpbGF0aW9uLCBy ZXZlYWxlZCBieQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI3MDc4LiAgSW50cm9kdWNlIGEKKyAgICAgICAgd29ya2Fyb3VuZCBmb3IgdGhlIEdDQyB2 ZXJzaW9ucyB0aGF0IHNlZW0gdG8gYmUgYWZmZWN0ZWQuCisKKyAgICAgICAgKiBqaXQvUmVnaXN0 ZXJTZXQuaDoKKwogMjAyMS0wNi0xNiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgogCiAgICAgICAgIFtKU0NdIE9wdGltaXplIEpTT04ucGFyc2Ugd2l0aCBzbWFsbCBkYXRhIGJ5 IGNoYW5naW5nIElkZW50aWZpZXIgcG9vbCBtZWNoYW5pc20KZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvUmVnaXN0ZXJTZXQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvUmVnaXN0ZXJTZXQuaAppbmRleCBkM2M3YTc3NGNjOTRmOTg3NzE3MWQ1NGQ2ODU3YjQxNGE2 ZDlhY2JhLi5kN2U3OGM4NDUyNDFlZmJlNTZiMWQwYWJmYjU5OTlmYzAyYWM4MDBkIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlZ2lzdGVyU2V0LmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9SZWdpc3RlclNldC5oCkBAIC0zNSw3ICszNSwxNyBAQAogCiBu YW1lc3BhY2UgSlNDIHsKIAotdHlwZWRlZiBCaXRtYXA8TWFjcm9Bc3NlbWJsZXI6Om51bUdQUnMg KyBNYWNyb0Fzc2VtYmxlcjo6bnVtRlBScz4gUmVnaXN0ZXJCaXRtYXA7CisjaWYgQ1BVKEFSTSkg JiYgQ09NUElMRVIoR0NDKSAmJiBHQ0NfVkVSU0lPTl9BVF9MRUFTVCg4LCA0LCAwKSAmJiAhR0ND X1ZFUlNJT05fQVRfTEVBU1QoOSwgMCwgMCkKKy8vIEdDQyA4LjQuMCBhbmQgOC41LjAgc2VlbSB0 byBtaXNjb21waWxlIFdURjpCaXRtYXA6OmNvdW50IGNvZGUgb24KKy8vIEFSTSwgc29tZXRoaW5n IHRoYXQgYXBwYXJlbnRseSB3YXMgY292ZXJlZCB1cCBieSB0aGUgZXh0cmEKKy8vIHdvcmQuIFRo ZSBpc3N1ZSBzZWVtcyB0byBub3QgbWFuaWZlc3Qgd2l0aCBHQ0MgOC4zLjAgYW5kID45LgorLy8g VGVtcG9yYXJpbHkgY292ZXIgdXAgYnkgYWRkaW5nIGJhY2sgdGhlICsgMS4KKyNkZWZpbmUgUkVH SVNURVJTRVRfQklUTUFQX1NMQUNLIDEKKyNlbHNlCisjZGVmaW5lIFJFR0lTVEVSU0VUX0JJVE1B UF9TTEFDSyAwCisjZW5kaWYKKwordHlwZWRlZiBCaXRtYXA8TWFjcm9Bc3NlbWJsZXI6Om51bUdQ UnMgKyBNYWNyb0Fzc2VtYmxlcjo6bnVtRlBScyArIFJFR0lTVEVSU0VUX0JJVE1BUF9TTEFDSz4g UmVnaXN0ZXJCaXRtYXA7CiBjbGFzcyBSZWdpc3RlckF0T2Zmc2V0TGlzdDsKIAogY2xhc3MgUmVn aXN0ZXJTZXQgewo= 431669 2021-06-17 08:41:42 -0700 2021-06-17 08:50:33 -0700 Patch bug-227125-20210617154140.patch text/plain 1993 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl OTE5NTFiYzUwNjk5ZGZjYmY0ZmVhOTBmODhhYThmYTkxZDk1NWYyLi5jN2Y2ZmMyMDdjMDljZDRm ZmM5MGM3YTIzZjFlOWVkYTY5ZmFkMmE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wNi0xNyAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFuZ2Vsb3NA aWdhbGlhLmNvbT4KKworICAgICAgICBbSlNDXSBXb3JrIGFyb3VuZCBhcHBhcmVudCBtaXNjb21w aWxhdGlvbiBvbiBBUk0vR0NDID49OC40CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjcxMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIHNlZW1zIHRvIGJlIGEgR0NDIG1pc2NvbXBpbGF0aW9uLCBy ZXZlYWxlZCBieQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI3MDc4LiAgSW50cm9kdWNlIGEKKyAgICAgICAgd29ya2Fyb3VuZCBmb3IgdGhlIEdDQyB2 ZXJzaW9ucyB0aGF0IHNlZW0gdG8gYmUgYWZmZWN0ZWQuCisKKyAgICAgICAgKiBqaXQvUmVnaXN0 ZXJTZXQuaDoKKwogMjAyMS0wNi0xNiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgogCiAgICAgICAgIFtKU0NdIE9wdGltaXplIEpTT04ucGFyc2Ugd2l0aCBzbWFsbCBkYXRhIGJ5 IGNoYW5naW5nIElkZW50aWZpZXIgcG9vbCBtZWNoYW5pc20KZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvUmVnaXN0ZXJTZXQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvUmVnaXN0ZXJTZXQuaAppbmRleCBkM2M3YTc3NGNjOTRmOTg3NzE3MWQ1NGQ2ODU3YjQxNGE2 ZDlhY2JhLi41MjZlMzUzZDhiODE5MTlhMDk4OWNmZWIwMDc0MDcxNjBhOWEyMGNjIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlZ2lzdGVyU2V0LmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9SZWdpc3RlclNldC5oCkBAIC0zMiwxMCArMzIsMjEgQEAKICNp bmNsdWRlICJSZWcuaCIKICNpbmNsdWRlICJUZW1wUmVnaXN0ZXJTZXQuaCIKICNpbmNsdWRlIDx3 dGYvQml0bWFwLmg+CisjaW5jbHVkZSA8d3RmL0NvbXBpbGVyLmg+CiAKIG5hbWVzcGFjZSBKU0Mg ewogCi10eXBlZGVmIEJpdG1hcDxNYWNyb0Fzc2VtYmxlcjo6bnVtR1BScyArIE1hY3JvQXNzZW1i bGVyOjpudW1GUFJzPiBSZWdpc3RlckJpdG1hcDsKKyNpZiBDUFUoQVJNKSAmJiBDT01QSUxFUihH Q0MpICYmIEdDQ19WRVJTSU9OX0FUX0xFQVNUKDgsIDQsIDApICYmICFHQ0NfVkVSU0lPTl9BVF9M RUFTVCg5LCAwLCAwKQorLy8gR0NDIDguNC4wIGFuZCA4LjUuMCBzZWVtIHRvIG1pc2NvbXBpbGUg V1RGOkJpdG1hcDo6Y291bnQgY29kZSBvbgorLy8gQVJNLCBzb21ldGhpbmcgdGhhdCBhcHBhcmVu dGx5IHdhcyBjb3ZlcmVkIHVwIGJ5IHRoZSBleHRyYQorLy8gd29yZC4gVGhlIGlzc3VlIHNlZW1z IHRvIG5vdCBtYW5pZmVzdCB3aXRoIEdDQyA4LjMuMCBhbmQgPjkuCisvLyBUZW1wb3JhcmlseSBj b3ZlciB1cCBieSBhZGRpbmcgYmFjayB0aGUgKyAxLgorI2RlZmluZSBSRUdJU1RFUlNFVF9CSVRN QVBfU0xBQ0sgMQorI2Vsc2UKKyNkZWZpbmUgUkVHSVNURVJTRVRfQklUTUFQX1NMQUNLIDAKKyNl bmRpZgorCit0eXBlZGVmIEJpdG1hcDxNYWNyb0Fzc2VtYmxlcjo6bnVtR1BScyArIE1hY3JvQXNz ZW1ibGVyOjpudW1GUFJzICsgUkVHSVNURVJTRVRfQklUTUFQX1NMQUNLPiBSZWdpc3RlckJpdG1h cDsKIGNsYXNzIFJlZ2lzdGVyQXRPZmZzZXRMaXN0OwogCiBjbGFzcyBSZWdpc3RlclNldCB7Cg== 431670 2021-06-17 08:47:56 -0700 2021-06-17 09:36:46 -0700 Patch bug-227125-20210617154754.patch text/plain 2050 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl OTE5NTFiYzUwNjk5ZGZjYmY0ZmVhOTBmODhhYThmYTkxZDk1NWYyLi5jN2Y2ZmMyMDdjMDljZDRm ZmM5MGM3YTIzZjFlOWVkYTY5ZmFkMmE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wNi0xNyAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFuZ2Vsb3NA aWdhbGlhLmNvbT4KKworICAgICAgICBbSlNDXSBXb3JrIGFyb3VuZCBhcHBhcmVudCBtaXNjb21w aWxhdGlvbiBvbiBBUk0vR0NDID49OC40CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjcxMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIHNlZW1zIHRvIGJlIGEgR0NDIG1pc2NvbXBpbGF0aW9uLCBy ZXZlYWxlZCBieQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI3MDc4LiAgSW50cm9kdWNlIGEKKyAgICAgICAgd29ya2Fyb3VuZCBmb3IgdGhlIEdDQyB2 ZXJzaW9ucyB0aGF0IHNlZW0gdG8gYmUgYWZmZWN0ZWQuCisKKyAgICAgICAgKiBqaXQvUmVnaXN0 ZXJTZXQuaDoKKwogMjAyMS0wNi0xNiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgogCiAgICAgICAgIFtKU0NdIE9wdGltaXplIEpTT04ucGFyc2Ugd2l0aCBzbWFsbCBkYXRhIGJ5 IGNoYW5naW5nIElkZW50aWZpZXIgcG9vbCBtZWNoYW5pc20KZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvUmVnaXN0ZXJTZXQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvUmVnaXN0ZXJTZXQuaAppbmRleCBkM2M3YTc3NGNjOTRmOTg3NzE3MWQ1NGQ2ODU3YjQxNGE2 ZDlhY2JhLi4wNmFjOTliNDI0OGY2OGE0YzE0YTdkNDA4Y2YyMzI0OWY4OGM1NjVjIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlZ2lzdGVyU2V0LmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9SZWdpc3RlclNldC5oCkBAIC0zMiwxMCArMzIsMjcgQEAKICNp bmNsdWRlICJSZWcuaCIKICNpbmNsdWRlICJUZW1wUmVnaXN0ZXJTZXQuaCIKICNpbmNsdWRlIDx3 dGYvQml0bWFwLmg+CisjaW5jbHVkZSA8d3RmL0NvbXBpbGVyLmg+CiAKIG5hbWVzcGFjZSBKU0Mg ewogCi10eXBlZGVmIEJpdG1hcDxNYWNyb0Fzc2VtYmxlcjo6bnVtR1BScyArIE1hY3JvQXNzZW1i bGVyOjpudW1GUFJzPiBSZWdpc3RlckJpdG1hcDsKKyNpZiBDUFUoQVJNKSAmJiBDT01QSUxFUihH Q0MpCisKKyNpZiBHQ0NfVkVSU0lPTl9BVF9MRUFTVCg4LCA0LCAwKSAmJiAhR0NDX1ZFUlNJT05f QVRfTEVBU1QoOSwgMCwgMCkKKy8vIEdDQyA4LjQuMCBhbmQgOC41LjAgc2VlbSB0byBtaXNjb21w aWxlIFdURjpCaXRtYXA6OmNvdW50IGNvZGUgb24KKy8vIEFSTSwgc29tZXRoaW5nIHRoYXQgYXBw YXJlbnRseSB3YXMgY292ZXJlZCB1cCBieSB0aGUgZXh0cmEKKy8vIHdvcmQuIFRoZSBpc3N1ZSBz ZWVtcyB0byBub3QgbWFuaWZlc3Qgd2l0aCBHQ0MgOC4zLjAgYW5kID45LgorLy8gVGVtcG9yYXJp bHkgY292ZXIgdXAgYnkgYWRkaW5nIGJhY2sgdGhlICsgMS4KKyNkZWZpbmUgUkVHSVNURVJTRVRf QklUTUFQX1NMQUNLIDEKKyNlbHNlCisjZGVmaW5lIFJFR0lTVEVSU0VUX0JJVE1BUF9TTEFDSyAw CisjZW5kaWYKKworI2Vsc2UKKyNkZWZpbmUgUkVHSVNURVJTRVRfQklUTUFQX1NMQUNLIDAKKyNl bmRpZgorCit0eXBlZGVmIEJpdG1hcDxNYWNyb0Fzc2VtYmxlcjo6bnVtR1BScyArIE1hY3JvQXNz ZW1ibGVyOjpudW1GUFJzICsgUkVHSVNURVJTRVRfQklUTUFQX1NMQUNLPiBSZWdpc3RlckJpdG1h cDsKIGNsYXNzIFJlZ2lzdGVyQXRPZmZzZXRMaXN0OwogCiBjbGFzcyBSZWdpc3RlclNldCB7Cg==