227114 2021-06-17 02:13:30 -0700 [Win] Exception running layout tests 2021-06-17 11:25:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan jbedard webkit-bug-importer oldest_to_newest 1770555 0 pvollan 2021-06-17 02:13:30 -0700 From https://ews-build.webkit.org/#/builders/10/builds/96013: OSError raised: [Errno 3] No such process Traceback (most recent call last): File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 92, in main run_details = run(port, options, args, stderr) File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 487, in run run_details = manager.run(args) File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 408, in run temp_initial_results, temp_retry_results, temp_enabled_pixel_tests_in_retry = self._run_test_subset(test_inputs, device_type=device_type) File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 482, in _run_test_subset initial_results = self._run_tests(test_inputs, self._options.repeat_each, self._options.iterations, int(self._options.child_processes), retrying=False, device_type=device_type) File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 561, in _run_tests return self._runner.run_tests(self._expectations[device_type], new_test_inputs, num_workers, retrying, device_type) File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 179, in run_tests pool.wait() File "/home/buildbot/worker/Windows-EWS/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 462, in __exit__ os.kill(worker.pid, signal.SIGKILL) OSError: [Errno 3] No such process 1770559 1 431640 pvollan 2021-06-17 02:21:30 -0700 Created attachment 431640 Patch 1770659 2 431640 jbedard 2021-06-17 09:01:18 -0700 Comment on attachment 431640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431640&action=review > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:464 > + except Exception: I think we should catch an OSError explicitly (in Python, Exception rather annoyingly includes things like syntax errors since it's an interpreted language), and probably log the PID of worker, since we have multiple workers. 1770676 3 431681 pvollan 2021-06-17 09:21:55 -0700 Created attachment 431681 Patch 1770677 4 pvollan 2021-06-17 09:22:26 -0700 (In reply to Jonathan Bedard from comment #2) > Comment on attachment 431640 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431640&action=review > > > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:464 > > + except Exception: > > I think we should catch an OSError explicitly (in Python, Exception rather > annoyingly includes things like syntax errors since it's an interpreted > language), and probably log the PID of worker, since we have multiple > workers. Done! Thanks for reviewing! 1770727 5 ews-feeder 2021-06-17 11:25:00 -0700 Committed r278998 (238923@main): <https://commits.webkit.org/238923@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431681. 1770728 6 webkit-bug-importer 2021-06-17 11:25:21 -0700 <rdar://problem/79461864> 431640 2021-06-17 02:21:30 -0700 2021-06-17 09:21:51 -0700 Patch bug-227114-20210617112128.patch text/plain 1445 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3ODk3OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA2LTE3ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBFeGNlcHRpb24gcnVubmluZyBsYXlvdXQgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzExNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhdGNoIGV4Y2VwdGlv biBhbmQgcHJpbnQgd2FybmluZyBtZXNzYWdlLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJp ZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS90YXNrX3Bvb2wucHk6CisgICAgICAgIChUYXNr UG9vbC5fX2V4aXRfXyk6CisKIDIwMjEtMDYtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHTElCXSBQYXNzIGEgR1Rsc0NlcnRpZmljYXRl IHRvIHNvdXBfc2VydmVyX25ldygpCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rhc2tfcG9vbC5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rhc2tfcG9vbC5weQko cmV2aXNpb24gMjc4ODAwKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5 L3dlYmtpdGNvcmVweS90YXNrX3Bvb2wucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ1OSw3ICs0NTks MTAgQEAgY2xhc3MgVGFza1Bvb2wob2JqZWN0KToKICAgICAgICAgICAgICAgICBpZiBzeXMudmVy c2lvbl9pbmZvID49ICgzLCA3KToKICAgICAgICAgICAgICAgICAgICAgd29ya2VyLmtpbGwoKQog ICAgICAgICAgICAgICAgIGVsaWYgaGFzYXR0cihzaWduYWwsICdTSUdLSUxMJyk6Ci0gICAgICAg ICAgICAgICAgICAgIG9zLmtpbGwod29ya2VyLnBpZCwgc2lnbmFsLlNJR0tJTEwpCisgICAgICAg ICAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICAgICAgICAgIG9zLmtpbGwod29ya2Vy LnBpZCwgc2lnbmFsLlNJR0tJTEwpCisgICAgICAgICAgICAgICAgICAgIGV4Y2VwdCBFeGNlcHRp b246CisgICAgICAgICAgICAgICAgICAgICAgICBsb2cud2FybignRmFpbGVkIHRvIHRlcm1pbmF0 ZSB3b3JrZXIuJykKICAgICAgICAgICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgICAgICB3 b3JrZXIudGVybWluYXRlKCkKIAo= 431681 2021-06-17 09:21:55 -0700 2021-06-17 11:25:00 -0700 Patch bug-227114-20210617182153.patch text/plain 1492 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3ODk3OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA2LTE3ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBFeGNlcHRpb24gcnVubmluZyBsYXlvdXQgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzExNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhdGNoIGV4Y2VwdGlv biBhbmQgcHJpbnQgd2FybmluZyBtZXNzYWdlLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJp ZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS90YXNrX3Bvb2wucHk6CisgICAgICAgIChUYXNr UG9vbC5fX2V4aXRfXyk6CisKIDIwMjEtMDYtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHTElCXSBQYXNzIGEgR1Rsc0NlcnRpZmljYXRl IHRvIHNvdXBfc2VydmVyX25ldygpCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rhc2tfcG9vbC5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rhc2tfcG9vbC5weQko cmV2aXNpb24gMjc4ODAwKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5 L3dlYmtpdGNvcmVweS90YXNrX3Bvb2wucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ1OSw3ICs0NTks MTAgQEAgY2xhc3MgVGFza1Bvb2wob2JqZWN0KToKICAgICAgICAgICAgICAgICBpZiBzeXMudmVy c2lvbl9pbmZvID49ICgzLCA3KToKICAgICAgICAgICAgICAgICAgICAgd29ya2VyLmtpbGwoKQog ICAgICAgICAgICAgICAgIGVsaWYgaGFzYXR0cihzaWduYWwsICdTSUdLSUxMJyk6Ci0gICAgICAg ICAgICAgICAgICAgIG9zLmtpbGwod29ya2VyLnBpZCwgc2lnbmFsLlNJR0tJTEwpCisgICAgICAg ICAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICAgICAgICAgIG9zLmtpbGwod29ya2Vy LnBpZCwgc2lnbmFsLlNJR0tJTEwpCisgICAgICAgICAgICAgICAgICAgIGV4Y2VwdCBPU0Vycm9y IGFzIGU6CisgICAgICAgICAgICAgICAgICAgICAgICBsb2cud2FybignRmFpbGVkIHRvIHRlcm1p bmF0ZSB3b3JrZXIgJyArIHN0cih3b3JrZXIucGlkKSArICcgd2l0aCBlcnJvciAnICsgc3RyKGUp KQogICAgICAgICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAgICAgICAgIHdvcmtlci50ZXJt aW5hdGUoKQogCg==