227102 2021-06-16 17:06:53 -0700 [Win] TestWTF.WTF_WeakPtr.WeakHashMapIterators is crashing 2021-06-17 00:02:04 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii fujii pvollan rniwa webkit-bug-importer oldest_to_newest 1770476 0 fujii 2021-06-16 17:06:53 -0700 [Win] TestWTF.WTF_WeakPtr.WeakHashMapIterators is crashing https://build.webkit.org/#/builders/50/builds/1808 worker/0 TestWTF.WTF_WeakPtr.WeakHashMapAmortizedCleanup Crashed worker/0 TestWTF.WTF_WeakPtr.WeakHashMapIterators Crashed Those tests were added by r278803 (238760@main, Bug 226872). 1770477 1 fujii 2021-06-16 17:07:20 -0700 Callstack: > ntdll.dll!RtlReportCriticalFailure() Unknown > ntdll.dll!RtlpHeapHandleError() Unknown > ntdll.dll!RtlpHpHeapHandleError() Unknown > ntdll.dll!RtlpLogHeapFailure() Unknown > ntdll.dll!RtlpFreeHeapInternal() Unknown > ntdll.dll!RtlFreeHeap() Unknown > ucrtbase.dll!00007ffd3a6df05b() Unknown > WTF.dll!WTF::fastFree(void * p) Line 260 C++ > TestWTFLib.dll!TestWebKitAPI::Base::operator delete(void * p) Line 55 C++ > [External Code] > TestWTFLib.dll!TestWebKitAPI::WTF_WeakPtr_WeakHashMapIterators_Test::TestBody() Line 1455 C++ > TestWTFLib.dll!testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,void>(testing::Test * object, void(testing::Test::*)() method, const char * location) Line 2592 C++ > TestWTFLib.dll!testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>(testing::Test * object, void(testing::Test::*)() method, const char * location) Line 2662 C++ > TestWTFLib.dll!testing::Test::Run() Line 2689 C++ > TestWTFLib.dll!testing::TestInfo::Run() Line 2864 C++ > TestWTFLib.dll!testing::TestSuite::Run() Line 3016 C++ > TestWTFLib.dll!testing::internal::UnitTestImpl::RunAllTests() Line 5852 C++ > TestWTFLib.dll!testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>(testing::internal::UnitTestImpl * object, bool(testing::internal::UnitTestImpl::*)() method, const char * location) Line 2592 C++ > TestWTFLib.dll!testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>(testing::internal::UnitTestImpl * object, bool(testing::internal::UnitTestImpl::*)() method, const char * location) Line 2662 C++ > TestWTFLib.dll!testing::UnitTest::Run() Line 5434 C++ > TestWTFLib.dll!RUN_ALL_TESTS() Line 2472 C++ > TestWTFLib.dll!TestWebKitAPI::TestsController::run(int argc, char * * argv) Line 90 C++ > TestWTFLib.dll!main(int argc, char * * argv) Line 41 C++ > TestWTFLib.dll!dllLauncherEntryPoint(int argc, char * * argv) Line 49 C++ > TestWTF.exe!main(int argc, const char * * argv) Line 223 C++ > [External Code] 1770490 2 431627 fujii 2021-06-16 17:56:20 -0700 Created attachment 431627 Patch 1770520 3 431627 rniwa 2021-06-16 21:28:29 -0700 Comment on attachment 431627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431627&action=review > Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:59 > + virtual ~Base() { } Oh, makes sense. Do use ~Base() = default; though. 1770523 4 431632 fujii 2021-06-16 21:51:48 -0700 Created attachment 431632 Patch for landing 1770535 5 431632 fujii 2021-06-17 00:01:13 -0700 Comment on attachment 431632 Patch for landing Clearing flags on attachment: 431632 Committed r278976 (238902@main): <https://commits.webkit.org/238902@main> 1770536 6 fujii 2021-06-17 00:01:17 -0700 All reviewed patches have been landed. Closing bug. 431627 2021-06-16 17:56:20 -0700 2021-06-16 21:51:39 -0700 Patch bug-227102-20210617095619.patch text/plain 1583 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4OTIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjFjZjdjN2E5YWE1YWVkMmNkNDE3MzE4MWFlMWE0MmNm MDA1YzEwYS4uZjM4YzEyMjY3ZjA3ODdlOGJlMmRkNzljMTZkNDhlYTc4NTNhMjg2MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTA2LTE2ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIFRlc3RXVEYuV1RGX1dlYWtQdHIuV2Vha0hhc2hNYXBJdGVyYXRv cnMgaXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNzEwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEEgaGVhcCBjb3JydXB0aW9uIHdhcyBkZXRlY3RlZCB3aGlsZSBhIERlcml2ZWQgY2xh c3Mgb2JqZWN0IHdhcworICAgICAgICBkZXN0cm95ZWQgYXMgYSBCYXNlIGNsYXNzIG9iamVjdC4K KworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dlYWtQdHIuY3BwOgorICAgICAg ICAoVGVzdFdlYktpdEFQSTo6QmFzZTo6fkJhc2UpOiBNYWRlIEJhc2UgY2xhc3MgZHRvciB2aXJ0 dWFsLgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6RGVyaXZlZDo6fkRlcml2ZWQpOgorCiAyMDIx LTA2LTE1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQWxsb3cgbGVnYWN5IFNlY3VyaXR5T3JpZ2luIGJlaGF2aW9yIGZvciB4LWFwcGxlLXFs LWlkMiBzY2hlbWUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dl YWtQdHIuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV2Vha1B0ci5jcHAKaW5k ZXggOWU2ZDdlNDQ0Yzc3MmNjMmJiODIyMTYzNTlkOGQ0NWJjZDIxNTViYi4uNmU4YzYzMmRkYzUy ZjI2YjNmN2Y1YThmZDA0MjJkYzVlOWEzZjNkMSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvV2Vha1B0ci5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XVEYvV2Vha1B0ci5jcHAKQEAgLTU2LDYgKzU2LDggQEAgY2xhc3MgQmFzZSA6IHB1YmxpYyBD YW5NYWtlV2Vha1B0cjxCYXNlPiB7CiBwdWJsaWM6CiAgICAgQmFzZSgpIHsgfQogCisgICAgdmly dHVhbCB+QmFzZSgpIHsgfQorCiAgICAgaW50IGZvbygpCiAgICAgewogICAgICAgICByZXR1cm4g MDsKQEAgLTY4LDcgKzcwLDcgQEAgY2xhc3MgRGVyaXZlZCA6IHB1YmxpYyBCYXNlIHsKIHB1Ymxp YzoKICAgICBEZXJpdmVkKCkgeyB9CiAKLSAgICB2aXJ0dWFsIH5EZXJpdmVkKCkgeyB9IC8vIEZv cmNlIGEgcG9pbnRlciBmaXh1cCB3aGVuIGNhc3RpbmcgQmFzZSA8LT4gRGVyaXZlZAorICAgIH5E ZXJpdmVkKCkgb3ZlcnJpZGUgeyB9IC8vIEZvcmNlIGEgcG9pbnRlciBmaXh1cCB3aGVuIGNhc3Rp bmcgQmFzZSA8LT4gRGVyaXZlZAogCiAgICAgaW50IGZvbygpCiAgICAgewo= 431632 2021-06-16 21:51:48 -0700 2021-06-16 21:51:48 -0700 Patch for landing bug-227102-20210617135147.patch text/plain 1590 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4OTczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzliMzZiY2UwOWYwNWZhMDk2MDVhNTFmMzczZTRhODYy YWMxMzA3Mi4uZjgxNDg2MDYyZmJhYTg4Yjc2ZWY3MTExMjQ2YzBkODMyODQ3MTEzMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTA2LTE2ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIFRlc3RXVEYuV1RGX1dlYWtQdHIuV2Vha0hhc2hNYXBJdGVyYXRv cnMgaXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNzEwMgorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAg ICAgICBBIGhlYXAgY29ycnVwdGlvbiB3YXMgZGV0ZWN0ZWQgd2hpbGUgYSBEZXJpdmVkIGNsYXNz IG9iamVjdCB3YXMKKyAgICAgICAgZGVzdHJveWVkIGFzIGEgQmFzZSBjbGFzcyBvYmplY3QuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9XZWFrUHRyLmNwcDoKKyAgICAgICAg KFRlc3RXZWJLaXRBUEk6OkJhc2U6On5CYXNlKTogTWFkZSBCYXNlIGNsYXNzIGR0b3IgdmlydHVh bC4KKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OkRlcml2ZWQ6On5EZXJpdmVkKToKKwogMjAyMS0w Ni0xNiAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xl YW4gdXAgaG93IHBsYXRmb3JtIGltYWdlcyBhcmUgaGFuZGxlZCBpbiB0aGUgYm90IHdhdGNoZXJz JyBkYXNoYm9hcmQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dl YWtQdHIuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV2Vha1B0ci5jcHAKaW5k ZXggOWU2ZDdlNDQ0Yzc3MmNjMmJiODIyMTYzNTlkOGQ0NWJjZDIxNTViYi4uOGFlNDBmYTdhYjgz MmZiZjgxYjM1NDA2NjBmZWRiMWRkYmMyN2ZlMiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvV2Vha1B0ci5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XVEYvV2Vha1B0ci5jcHAKQEAgLTU2LDYgKzU2LDggQEAgY2xhc3MgQmFzZSA6IHB1YmxpYyBD YW5NYWtlV2Vha1B0cjxCYXNlPiB7CiBwdWJsaWM6CiAgICAgQmFzZSgpIHsgfQogCisgICAgdmly dHVhbCB+QmFzZSgpID0gZGVmYXVsdDsKKwogICAgIGludCBmb28oKQogICAgIHsKICAgICAgICAg cmV0dXJuIDA7CkBAIC02OCw3ICs3MCw3IEBAIGNsYXNzIERlcml2ZWQgOiBwdWJsaWMgQmFzZSB7 CiBwdWJsaWM6CiAgICAgRGVyaXZlZCgpIHsgfQogCi0gICAgdmlydHVhbCB+RGVyaXZlZCgpIHsg fSAvLyBGb3JjZSBhIHBvaW50ZXIgZml4dXAgd2hlbiBjYXN0aW5nIEJhc2UgPC0+IERlcml2ZWQK KyAgICB+RGVyaXZlZCgpIG92ZXJyaWRlIHsgfSAvLyBGb3JjZSBhIHBvaW50ZXIgZml4dXAgd2hl biBjYXN0aW5nIEJhc2UgPC0+IERlcml2ZWQKIAogICAgIGludCBmb28oKQogICAgIHsK