227095 2021-06-16 14:33:54 -0700 Don't look at the (non-existent) child2 of DelById 2021-06-16 15:27:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 226556 1 rmorisset rmorisset ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1770400 0 rmorisset 2021-06-16 14:33:54 -0700 When I rebased my patch for bug 226556, I introduced a bug for DelById, since it now shares code with DelByVal, and I access its second child early to avoid accessing it in the lambda (after the graph is freed). The solution is a trivial branch. 1770406 1 431605 rmorisset 2021-06-16 14:36:31 -0700 Created attachment 431605 Patch 1770408 2 431605 mark.lam 2021-06-16 14:41:45 -0700 Comment on attachment 431605 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431605&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5921 > + UseKind child2UseKind; Should this be given some initial value to placate over-zealous compilers? 1770412 3 431607 rmorisset 2021-06-16 14:57:59 -0700 Created attachment 431607 Patch for landing I applied Mark's suggestion and gave a default of UntypedUse to child2UseKind in case GCC or MSVC are overzealous. 1770436 4 ews-feeder 2021-06-16 15:26:38 -0700 Committed r278959 (238887@main): <https://commits.webkit.org/238887@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431607. 1770437 5 webkit-bug-importer 2021-06-16 15:27:20 -0700 <rdar://problem/79419113> 431605 2021-06-16 14:36:31 -0700 2021-06-16 14:57:59 -0700 Patch patch227095 text/plain 1818 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGZkNjI0YzVjZTA3Yy4uNWNlOWE3Nzc2NjFmIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0wNi0xNiAgUm9i aW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IGxvb2sg YXQgdGhlIChub24tZXhpc3RlbnQpIGNoaWxkMiBvZiBEZWxCeUlkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjcwOTUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcml2aWFsIGZpeCB0byBhIGJyb2tlbiBy ZWJhc2U6IHdoaWxlIGl0IGlzIG9rIHRvIHNoYXJlIG1vc3QgY29kZSBiZXR3ZWVuIERlbEJ5SWQg YW5kIERlbEJ5VmFsLCBvbmx5IHRoZSBsYXR0ZXIgaGFzIGEgY2hpbGQyKCksIHNvIGl0IHNob3Vs ZCBub3QgYmUgYWNjZXNzZWQgaWYgd2UgYXJlIGNvbXBpbGluZyB0aGUgZm9ybWVyLgorICAgICAg ICBObyBuZXcgdGVzdCwgYXMgaXQgd2FzIGNhdWdodCBieSBvbmUgb2Ygb3VyIGV4aXN0aW5nIHRl c3RzLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5jcHA6CisgICAgICAgIChKU0M6 OkZUTDo6REZHOjpMb3dlckRGR1RvQjM6OmNvbXBpbGVEZWxCeSk6CisKIDIwMjEtMDYtMTYgIFlp amlhIEh1YW5nICA8eWlqaWFfaHVhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBBaXIgb3Bj b2RlIHN1YjMyLzY0KFJlZywgSW1tLCBSZWcpIGZvcm0gZm9yIEFSTTY0IGFuZCBzZWxlY3QgdGhp cyBpbnN0cnVjdGlvbiBpbiBBaXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMTG93ZXJERkdUb0IzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93 ZXJERkdUb0IzLmNwcAppbmRleCAwYWQ0ZTg5OGY2ZDIuLjMyN2JkMWRjYmFlZSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcApAQCAtNTkxNyw4ICs1 OTE3LDEwIEBAIHByaXZhdGU6CiAgICAgICAgIFN0YXRlKiBzdGF0ZSA9ICZtX2Z0bFN0YXRlOwog ICAgICAgICBOb2RlKiBub2RlID0gbV9ub2RlOwogICAgICAgICBDb2RlT3JpZ2luIG5vZGVTZW1h bnRpY09yaWdpbiA9IG5vZGUtPm9yaWdpbi5zZW1hbnRpYzsKLSAgICAgICAgYXV0byBjaGlsZDFV c2VLaW5kID0gbm9kZS0+Y2hpbGQxKCkudXNlS2luZCgpOwotICAgICAgICBhdXRvIGNoaWxkMlVz ZUtpbmQgPSBub2RlLT5jaGlsZDIoKS51c2VLaW5kKCk7CisgICAgICAgIFVzZUtpbmQgY2hpbGQx VXNlS2luZCA9IG5vZGUtPmNoaWxkMSgpLnVzZUtpbmQoKTsKKyAgICAgICAgVXNlS2luZCBjaGls ZDJVc2VLaW5kOworICAgICAgICBpZiBjb25zdGV4cHIgKGtpbmQgIT0gRGVsQnlLaW5kOjpCeUlk KQorICAgICAgICAgICAgY2hpbGQyVXNlS2luZCA9IG5vZGUtPmNoaWxkMigpLnVzZUtpbmQoKTsK ICAgICAgICAgYXV0byBlY21hTW9kZSA9IG5vZGUtPmVjbWFNb2RlKCkudmFsdWUoKTsKICAgICAg ICAgcGF0Y2hwb2ludC0+c2V0R2VuZXJhdG9yKAogICAgICAgICAgICAgWz1dIChDQ2FsbEhlbHBl cnMmIGppdCwgY29uc3QgU3RhY2ttYXBHZW5lcmF0aW9uUGFyYW1zJiBwYXJhbXMpIHsK 431607 2021-06-16 14:57:59 -0700 2021-06-16 15:26:39 -0700 Patch for landing patch227095 text/plain 1825 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGZkNjI0YzVjZTA3Yy4uMjBiODM3MTkyODBmIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0wNi0xNiAgUm9i aW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IGxvb2sg YXQgdGhlIChub24tZXhpc3RlbnQpIGNoaWxkMiBvZiBEZWxCeUlkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjcwOTUKKworICAgICAgICBSZXZpZXdl ZCBieSBNYXJrIExhbS4KKworICAgICAgICBUcml2aWFsIGZpeCB0byBhIGJyb2tlbiByZWJhc2U6 IHdoaWxlIGl0IGlzIG9rIHRvIHNoYXJlIG1vc3QgY29kZSBiZXR3ZWVuIERlbEJ5SWQgYW5kIERl bEJ5VmFsLCBvbmx5IHRoZSBsYXR0ZXIgaGFzIGEgY2hpbGQyKCksIHNvIGl0IHNob3VsZCBub3Qg YmUgYWNjZXNzZWQgaWYgd2UgYXJlIGNvbXBpbGluZyB0aGUgZm9ybWVyLgorICAgICAgICBObyBu ZXcgdGVzdCwgYXMgaXQgd2FzIGNhdWdodCBieSBvbmUgb2Ygb3VyIGV4aXN0aW5nIHRlc3RzLgor CisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6 REZHOjpMb3dlckRGR1RvQjM6OmNvbXBpbGVEZWxCeSk6CisKIDIwMjEtMDYtMTYgIFlpamlhIEh1 YW5nICA8eWlqaWFfaHVhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBBaXIgb3Bjb2RlIHN1 YjMyLzY0KFJlZywgSW1tLCBSZWcpIGZvcm0gZm9yIEFSTTY0IGFuZCBzZWxlY3QgdGhpcyBpbnN0 cnVjdGlvbiBpbiBBaXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRM TG93ZXJERkdUb0IzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdU b0IzLmNwcAppbmRleCAwYWQ0ZTg5OGY2ZDIuLmNjNzRlYmI0YjNlYyAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcApAQCAtNTkxNyw4ICs1OTE3LDEw IEBAIHByaXZhdGU6CiAgICAgICAgIFN0YXRlKiBzdGF0ZSA9ICZtX2Z0bFN0YXRlOwogICAgICAg ICBOb2RlKiBub2RlID0gbV9ub2RlOwogICAgICAgICBDb2RlT3JpZ2luIG5vZGVTZW1hbnRpY09y aWdpbiA9IG5vZGUtPm9yaWdpbi5zZW1hbnRpYzsKLSAgICAgICAgYXV0byBjaGlsZDFVc2VLaW5k ID0gbm9kZS0+Y2hpbGQxKCkudXNlS2luZCgpOwotICAgICAgICBhdXRvIGNoaWxkMlVzZUtpbmQg PSBub2RlLT5jaGlsZDIoKS51c2VLaW5kKCk7CisgICAgICAgIFVzZUtpbmQgY2hpbGQxVXNlS2lu ZCA9IG5vZGUtPmNoaWxkMSgpLnVzZUtpbmQoKTsKKyAgICAgICAgVXNlS2luZCBjaGlsZDJVc2VL aW5kID0gVW50eXBlZFVzZTsKKyAgICAgICAgaWYgY29uc3RleHByIChraW5kICE9IERlbEJ5S2lu ZDo6QnlJZCkKKyAgICAgICAgICAgIGNoaWxkMlVzZUtpbmQgPSBub2RlLT5jaGlsZDIoKS51c2VL aW5kKCk7CiAgICAgICAgIGF1dG8gZWNtYU1vZGUgPSBub2RlLT5lY21hTW9kZSgpLnZhbHVlKCk7 CiAgICAgICAgIHBhdGNocG9pbnQtPnNldEdlbmVyYXRvcigKICAgICAgICAgICAgIFs9XSAoQ0Nh bGxIZWxwZXJzJiBqaXQsIGNvbnN0IFN0YWNrbWFwR2VuZXJhdGlvblBhcmFtcyYgcGFyYW1zKSB7 Cg==