227090 2021-06-16 13:19:54 -0700 [Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing 2021-06-17 18:29:30 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii benjamin cdumez cmarcelo don.olmstead ews-watchlist mark.lam pvollan webkit-bug-importer ysuzuki oldest_to_newest 1770353 0 fujii 2021-06-16 13:19:54 -0700 [Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing PS C:\home\webkit\gb> .\WebKitBuild\Debug\bin64\TestWTF.exe --gtest_filter=WTF.ParseInteger* **FAIL** WTF.ParseInteger ..\..\Tools\TestWebKitAPI\Tests\WTF\StringToIntegerConversion.cpp:43 Expected equality of these values: -2147483647 - 1 Which is: -2147483648 parseInteger<int>("-2147483648") Which is: 8-byte object <CC-CC CC-CC 00-CC CC-CC> **FAIL** WTF.ParseIntegerAllowingTrailingJunk ..\..\Tools\TestWebKitAPI\Tests\WTF\StringToIntegerConversion.cpp:70 Expected equality of these values: -2147483647 - 1 Which is: -2147483648 parseIntegerAllowingTrailingJunk<int>("-2147483648") Which is: 8-byte object <CC-CC CC-CC 00-CC CC-CC> 1770373 1 431596 fujii 2021-06-16 13:51:52 -0700 Created attachment 431596 WIP patch 1770403 2 431604 fujii 2021-06-16 14:34:45 -0700 Created attachment 431604 Patch 1770914 3 431604 ysuzuki 2021-06-17 17:53:28 -0700 Comment on attachment 431604 Patch r=me 1770915 4 ews-feeder 2021-06-17 18:28:02 -0700 Committed r279027 (238947@main): <https://commits.webkit.org/238947@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431604. 1770916 5 webkit-bug-importer 2021-06-17 18:29:30 -0700 <rdar://problem/79481414> 431596 2021-06-16 13:51:52 -0700 2021-06-16 14:34:33 -0700 WIP patch a.diff text/plain 697 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0NoZWNrZWRBcml0aG1ldGljLmggYi9Tb3VyY2Uv V1RGL3d0Zi9DaGVja2VkQXJpdGhtZXRpYy5oCmluZGV4IDE4NWQ1MWIyYjZkOS4uZmYxNTY1ZjEx ZGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9DaGVja2VkQXJpdGhtZXRpYy5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL0NoZWNrZWRBcml0aG1ldGljLmgKQEAgLTMyNiw3ICszMjYsNyBAQCB0 ZW1wbGF0ZSA8dHlwZW5hbWUgTEhTLCB0eXBlbmFtZSBSSFMsIHR5cGVuYW1lIFJlc3VsdFR5cGU+ IHN0cnVjdCBBcml0aG1ldGljT3BlcgogICAgICAgICAgICAgICAgIGlmIChsaHMgPiBzdGQ6Om51 bWVyaWNfbGltaXRzPFJlc3VsdFR5cGU+OjptYXgoKSArIHJocykKICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICBp ZiAocmhzID4gc3RkOjpudW1lcmljX2xpbWl0czxSZXN1bHRUeXBlPjo6bWF4KCkgKyBsaHMpCisg ICAgICAgICAgICAgICAgaWYgKGxocyA8IHN0ZDo6bnVtZXJpY19saW1pdHM8UmVzdWx0VHlwZT46 Om1pbigpICsgcmhzKQogICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0gLy8gaWYgdGhlIHNpZ25zIG1hdGNoIHRoaXMgb3BlcmF0aW9uIGNh bid0IG92ZXJmbG93Cg== 431604 2021-06-16 14:34:45 -0700 2021-06-17 18:28:04 -0700 Patch bug-227090-20210617063444.patch text/plain 3444 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGFmNjk5MjcxYjFiZWRiMzZjZGYwNGYy YWRiNzAzNWNmODBkMWY0ZGEuLjVlYzQ3NDFmYmZjMDRkOTYyZDEyYmE0NGY1YjI0ZWI5OGQ1NGVm NzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDYtMTYgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gV1RGLlBhcnNlSW50ZWdlciBh bmQgV1RGLlBhcnNlSW50ZWdlckFsbG93aW5nVHJhaWxpbmdKdW5rIGFyZSBmYWlsaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjcwOTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcml0aG1ldGljT3Bl cmF0aW9uczo6c3ViIHVuZXhwZWN0ZWRseSByZXBvcnRlZCBhbiBvdmVyZmxvdyBmb3IKKyAgICAg ICAgdGhlIHJlc3VsdCBvZiBzdGQ6Om51bWVyaWNfbGltaXRzPFJlc3VsdFR5cGU+OjptaW4oKSBp biBNU1ZDIGNvZGUgcGF0aC4KKyAgICAgICAgRm9yIGV4YW1wbGUsIENoZWNrZWQ8aW50LCBSZWNv cmRPdmVyZmxvdz4oSU5UX01JTiArIDEpIC0gMSB3YXMgcmVwb3J0ZWQgYW4gb3ZlcmZsb3cuCisK KyAgICAgICAgSW4gdGhlIGNhc2Ugb2YgY2FsY3VsYXRpbmcgKGxocyAtIHJocyksIGFuZCBsaHMg PCAwIGFuZCByaHMgPiAwLAorICAgICAgICB0aGUgb3JpZ2luYWwgY29kZSByZXBvcnRlZCBhbiBv dmVyZmxvdyBpZiAocmhzID4gbWF4KCkgKyBsaHMpLgorICAgICAgICBNYXRoZW1hdGljYWxseSwg dGhpcyBjb25kaXRpb24gY2hlY2tzIChsaHMgLSByaHMgPCAtbWF4KCkpLgorICAgICAgICBJdCBz aG91bGQgdXNlIG1pbigpIGluc3RlYWQgb2YgbWF4KCkgaW4gdGhpcyBjYXNlLiBJdCBzaG91bGQg YmUKKyAgICAgICAgKGxocyAtIHJocyA8IG1pbigpKSBtYXRoZW1hdGljYWxseS4KKworICAgICAg ICAqIHd0Zi9DaGVja2VkQXJpdGhtZXRpYy5oOgorCiAyMDIxLTA2LTA2ICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBEZWxldGUgc29tZSByZWNlbnRseS1vYnNvbGV0 ZWQgZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0NoZWNrZWRBcml0aG1ldGljLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9DaGVja2VkQXJpdGhtZXRpYy5oCmluZGV4IDE4NWQ1MWIyYjZkOWNj NDAzMWRhZmM1Y2E2ZjU2NjdiNzQyM2IwNzguLmZmMTU2NWYxMWRlZDRlOThkNGMzOWY3ZTk3NzJh ODBlYzhiZmVmN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NoZWNrZWRBcml0aG1ldGlj LmgKKysrIGIvU291cmNlL1dURi93dGYvQ2hlY2tlZEFyaXRobWV0aWMuaApAQCAtMzI2LDcgKzMy Niw3IEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBMSFMsIHR5cGVuYW1lIFJIUywgdHlwZW5hbWUgUmVz dWx0VHlwZT4gc3RydWN0IEFyaXRobWV0aWNPcGVyCiAgICAgICAgICAgICAgICAgaWYgKGxocyA+ IHN0ZDo6bnVtZXJpY19saW1pdHM8UmVzdWx0VHlwZT46Om1heCgpICsgcmhzKQogICAgICAgICAg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAg ICAgICAgIGlmIChyaHMgPiBzdGQ6Om51bWVyaWNfbGltaXRzPFJlc3VsdFR5cGU+OjptYXgoKSAr IGxocykKKyAgICAgICAgICAgICAgICBpZiAobGhzIDwgc3RkOjpudW1lcmljX2xpbWl0czxSZXN1 bHRUeXBlPjo6bWluKCkgKyByaHMpCiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICAgICAgICAgIH0KICAgICAgICAgfSAvLyBpZiB0aGUgc2lnbnMgbWF0Y2ggdGhpcyBvcGVy YXRpb24gY2FuJ3Qgb3ZlcmZsb3cKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCBiMWNmN2M3YTlhYTVhZWQyY2Q0MTczMTgxYWUxYTQyY2YwMDVjMTBh Li5mZDJiYWRiODZkMjZkMDU5YjEyYTI3NTRjZTQ0N2UxMTA1NTJjYjk4IDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MjEtMDYtMTYgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAg ICAgICAgW1dpbl0gV1RGLlBhcnNlSW50ZWdlciBhbmQgV1RGLlBhcnNlSW50ZWdlckFsbG93aW5n VHJhaWxpbmdKdW5rIGFyZSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjcwOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0NoZWNrZWRBcml0aG1l dGljT3BlcmF0aW9ucy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpBbGxvd01peGVkU2ln bmVkbmVzc1Rlc3Q6OnJ1bik6CisKIDIwMjEtMDYtMTUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBBbGxvdyBsZWdhY3kgU2VjdXJpdHlPcmln aW4gYmVoYXZpb3IgZm9yIHgtYXBwbGUtcWwtaWQyIHNjaGVtZQpkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvQ2hlY2tlZEFyaXRobWV0aWNPcGVyYXRpb25zLmNwcCBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0NoZWNrZWRBcml0aG1ldGljT3BlcmF0aW9u cy5jcHAKaW5kZXggNjg4YmE4MmE4MjRkMzI3NzgzYmM0NWQ2YzFkZjc3ZmJlOTY4Y2FlMi4uY2Y3 NGNmZjM0ZTRjMjk1NjM5MWJhMzcwYTM4ZjBhMmNkNTU5NWQ2YiAxMDA2NDQKLS0tIGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvQ2hlY2tlZEFyaXRobWV0aWNPcGVyYXRpb25zLmNwcAor KysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9DaGVja2VkQXJpdGhtZXRpY09wZXJh dGlvbnMuY3BwCkBAIC0zODcsNiArMzg3LDEwIEBAIHB1YmxpYzoKICAgICAgICAgdmFsdWUgPSBz dGQ6Om51bWVyaWNfbGltaXRzPHR5cGU+OjptYXgoKTsKICAgICAgICAgRVhQRUNUX0VRKHRydWUs ICh2YWx1ZSArPSAxVSkuaGFzT3ZlcmZsb3dlZCgpKTsKICAgICAgICAgRVhQRUNUX0VRKHRydWUs IHZhbHVlLmhhc092ZXJmbG93ZWQoKSk7CisgICAgICAgIHZhbHVlID0gc3RkOjpudW1lcmljX2xp bWl0czx0eXBlPjo6bWF4KCkgLSAxOworICAgICAgICBFWFBFQ1RfRkFMU0UoKHZhbHVlICsgMSku aGFzT3ZlcmZsb3dlZCgpKTsKKyAgICAgICAgdmFsdWUgPSBzdGQ6Om51bWVyaWNfbGltaXRzPHR5 cGU+OjptaW4oKSArIDE7CisgICAgICAgIEVYUEVDVF9GQUxTRSgodmFsdWUgLSAxKS5oYXNPdmVy Zmxvd2VkKCkpOwogICAgIH0KIH07CiAK