227076 2021-06-16 09:29:00 -0700 Passkeys don't work in Simulator 2021-06-16 20:45:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 garrett_davidson webkit-unassigned bfulgham ews-watchlist jiewen_tan katherine_cheney webkit-bug-importer oldest_to_newest 1770224 0 garrett_davidson 2021-06-16 09:29:00 -0700 Passkeys don't work in Simulator 1770226 1 431554 garrett_davidson 2021-06-16 09:30:28 -0700 Created attachment 431554 Patch 1770227 2 garrett_davidson 2021-06-16 09:30:30 -0700 <rdar://problem/79366832> 1770395 3 431554 katherine_cheney 2021-06-16 14:24:00 -0700 Comment on attachment 431554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431554&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:156 > +#if defined(TARGET_OS_SIMULATOR) && TARGET_OS_SIMULATOR I am not familiar with TARGET_OS_SIMULATOR, I see PLATFORM(IOS_FAMILY_SIMULATOR) used more often. Is there a reason you chose this instead? 1770399 4 431554 bfulgham 2021-06-16 14:30:12 -0700 Comment on attachment 431554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431554&action=review r- to change the macro to PLATFORM(IOS_FAMILY_SIMULATOR), but otherwise looks great. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:156 >> +#if defined(TARGET_OS_SIMULATOR) && TARGET_OS_SIMULATOR > > I am not familiar with TARGET_OS_SIMULATOR, I see PLATFORM(IOS_FAMILY_SIMULATOR) used more often. Is there a reason you chose this instead? Right -- we don't use these TARGET macros in WebKit. We have PLATFORM macros that serve this purpose (and handle the defined/not defined state properly). As Kate suggests, you just want: #if PLATFORM(IOS_FAMILY_SIMULATOR) 1770423 5 431609 garrett_davidson 2021-06-16 15:09:11 -0700 Created attachment 431609 Patch 1770427 6 431609 bfulgham 2021-06-16 15:12:19 -0700 Comment on attachment 431609 Patch r=me 1770519 7 ews-feeder 2021-06-16 20:45:25 -0700 Committed r278973 (238899@main): <https://commits.webkit.org/238899@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431609. 431554 2021-06-16 09:30:28 -0700 2021-06-16 15:09:09 -0700 Patch bug-227076-20210616093027.patch text/plain 2071 garrett_davidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI1NmUxYjRhYTJmZWE5ZmIx M2I0NjExMWI4MGNlMWRmOGIzNTg5NjAuLmUwMGE4ZmQ2YmM5YTA4ODI4MGRlYjIxZjI3Y2JkOGNk ODEyOThhOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDYtMTYgIEdhcnJldHQg RGF2aWRzb24gIDxnYXJyZXR0X2Rhdmlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBQYXNza2V5 cyBkb24ndCB3b3JrIGluIFNpbXVsYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MDc2CisgICAgICAgIDxyZGFyOi8vNzkzNjY4MzI+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2ltdWxhdG9yIGRv ZXMgbm90IHN1cHBvcnQgTEFBY2Nlc3NDb250cm9sT3BlcmF0aW9uVXNlS2V5U2lnbiwgc28KKyAg ICAgICAgLWV2YWx1YXRlQWNjZXNzQ29udHJvbDouLi4gcmV0dXJucyBhbiBlcnJvci4gSG93ZXZl ciwgdGhpcyBjaGVjayBpc24ndCBhY3R1YWxseSBuZWNlc3NhcnkgaW4KKyAgICAgICAgdGhlIHNp bXVsYXRvciB3aGVuIHVzaW5nIHBhc3NrZXlzLCBzbyBqdXN0IHNraXAgaXQuCisKKyAgICAgICAg VGVzdGVkIHJlZ2lzdHJhdGlvbiBhbmQgYXNzZXJ0aW9uIGluIGFuIGFwcCBpbiBTaW11bGF0b3Iu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvTG9jYWxDb25u ZWN0aW9uLm1tOgorICAgICAgICAoV2ViS2l0OjpMb2NhbENvbm5lY3Rpb246OnZlcmlmeVVzZXIp OgorCiAyMDIxLTA2LTE0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg ICAgICBBY2Nlc3NpbmcgbmF2aWdhdG9yLm1lZGlhRGV2aWNlcy5lbnVtZXJhdGVEZXZpY2VzIGFm dGVyIGdyYW50aW5nIHBlcm1pc3Npb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQ29ubmVjdGlvbi5tbSBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQ29ubmVjdGlvbi5t bQppbmRleCA4Mzg0Nzk2YTM3MWM1NDg3YTg1YzVjNjg1ZDliM2RlZTc1ODVmMzYxLi4xOWU4OTlm ZDQ2MzRmNThlMmIyNjU3ZjI3OGZhYzYyM2ZjMGNmOWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbENvbm5lY3Rpb24ubW0K KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvTG9j YWxDb25uZWN0aW9uLm1tCkBAIC0xNTIsNyArMTUyLDE1IEBAIHZvaWQgTG9jYWxDb25uZWN0aW9u Ojp2ZXJpZnlVc2VyKFNlY0FjY2Vzc0NvbnRyb2xSZWYgYWNjZXNzQ29udHJvbCwgTEFDb250ZXh0 ICpjCiAgICAgICAgIHJlcGx5KEB7IEAiVXNlclByZXNlbmNlIjogQFlFUyB9LCBudWxscHRyKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KKworI2lmIGRlZmluZWQoVEFSR0VUX09TX1NJTVVMQVRP UikgJiYgVEFSR0VUX09TX1NJTVVMQVRPUgorICAgIC8vIFNpbXVsYXRvciBkb2Vzbid0IHN1cHBv cnQgTEFBY2Nlc3NDb250cm9sT3BlcmF0aW9uVXNlS2V5U2lnbiwgYnV0IGRvZXMgc3VwcG9ydCBh bHRlcm5hdGUgYXR0cmlidXRlcy4KKyAgICBpZiAoc2hvdWxkVXNlQWx0ZXJuYXRlQXR0cmlidXRl cygpKSB7CisgICAgICAgIHJlcGx5KEB7IH0sIG51bGxwdHIpOworICAgICAgICByZXR1cm47Cisg ICAgfQogI2VuZGlmCisjZW5kaWYgLy8gVVNFKEFQUExFX0lOVEVSTkFMX1NESykKIAogICAgIFtj b250ZXh0IGV2YWx1YXRlQWNjZXNzQ29udHJvbDphY2Nlc3NDb250cm9sIG9wZXJhdGlvbjpMQUFj Y2Vzc0NvbnRyb2xPcGVyYXRpb25Vc2VLZXlTaWduIG9wdGlvbnM6b3B0aW9ucy5nZXQoKSByZXBs eTpyZXBseS5nZXQoKV07CiB9Cg== 431609 2021-06-16 15:09:11 -0700 2021-06-16 20:45:25 -0700 Patch bug-227076-20210616150910.patch text/plain 2050 garrett_davidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI1NmUxYjRhYTJmZWE5ZmIx M2I0NjExMWI4MGNlMWRmOGIzNTg5NjAuLmUwMGE4ZmQ2YmM5YTA4ODI4MGRlYjIxZjI3Y2JkOGNk ODEyOThhOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDYtMTYgIEdhcnJldHQg RGF2aWRzb24gIDxnYXJyZXR0X2Rhdmlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBQYXNza2V5 cyBkb24ndCB3b3JrIGluIFNpbXVsYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MDc2CisgICAgICAgIDxyZGFyOi8vNzkzNjY4MzI+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2ltdWxhdG9yIGRv ZXMgbm90IHN1cHBvcnQgTEFBY2Nlc3NDb250cm9sT3BlcmF0aW9uVXNlS2V5U2lnbiwgc28KKyAg ICAgICAgLWV2YWx1YXRlQWNjZXNzQ29udHJvbDouLi4gcmV0dXJucyBhbiBlcnJvci4gSG93ZXZl ciwgdGhpcyBjaGVjayBpc24ndCBhY3R1YWxseSBuZWNlc3NhcnkgaW4KKyAgICAgICAgdGhlIHNp bXVsYXRvciB3aGVuIHVzaW5nIHBhc3NrZXlzLCBzbyBqdXN0IHNraXAgaXQuCisKKyAgICAgICAg VGVzdGVkIHJlZ2lzdHJhdGlvbiBhbmQgYXNzZXJ0aW9uIGluIGFuIGFwcCBpbiBTaW11bGF0b3Iu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvTG9jYWxDb25u ZWN0aW9uLm1tOgorICAgICAgICAoV2ViS2l0OjpMb2NhbENvbm5lY3Rpb246OnZlcmlmeVVzZXIp OgorCiAyMDIxLTA2LTE0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg ICAgICBBY2Nlc3NpbmcgbmF2aWdhdG9yLm1lZGlhRGV2aWNlcy5lbnVtZXJhdGVEZXZpY2VzIGFm dGVyIGdyYW50aW5nIHBlcm1pc3Npb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQ29ubmVjdGlvbi5tbSBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQ29ubmVjdGlvbi5t bQppbmRleCA4Mzg0Nzk2YTM3MWM1NDg3YTg1YzVjNjg1ZDliM2RlZTc1ODVmMzYxLi4zNThmMTE2 ZmE1N2EzNGNkOTBhZWMzYjUwNTk1OTIxODU1ZWIxYjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbENvbm5lY3Rpb24ubW0K KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvTG9j YWxDb25uZWN0aW9uLm1tCkBAIC0xNTIsNyArMTUyLDE1IEBAIHZvaWQgTG9jYWxDb25uZWN0aW9u Ojp2ZXJpZnlVc2VyKFNlY0FjY2Vzc0NvbnRyb2xSZWYgYWNjZXNzQ29udHJvbCwgTEFDb250ZXh0 ICpjCiAgICAgICAgIHJlcGx5KEB7IEAiVXNlclByZXNlbmNlIjogQFlFUyB9LCBudWxscHRyKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KKworI2lmIFBMQVRGT1JNKElPU19GQU1JTFlfU0lNVUxB VE9SKQorICAgIC8vIFNpbXVsYXRvciBkb2Vzbid0IHN1cHBvcnQgTEFBY2Nlc3NDb250cm9sT3Bl cmF0aW9uVXNlS2V5U2lnbiwgYnV0IGRvZXMgc3VwcG9ydCBhbHRlcm5hdGUgYXR0cmlidXRlcy4K KyAgICBpZiAoc2hvdWxkVXNlQWx0ZXJuYXRlQXR0cmlidXRlcygpKSB7CisgICAgICAgIHJlcGx5 KEB7IH0sIG51bGxwdHIpOworICAgICAgICByZXR1cm47CisgICAgfQogI2VuZGlmCisjZW5kaWYg Ly8gVVNFKEFQUExFX0lOVEVSTkFMX1NESykKIAogICAgIFtjb250ZXh0IGV2YWx1YXRlQWNjZXNz Q29udHJvbDphY2Nlc3NDb250cm9sIG9wZXJhdGlvbjpMQUFjY2Vzc0NvbnRyb2xPcGVyYXRpb25V c2VLZXlTaWduIG9wdGlvbnM6b3B0aW9ucy5nZXQoKSByZXBseTpyZXBseS5nZXQoKV07CiB9Cg==