227026 2021-06-15 07:19:26 -0700 ANGLE Metal AutoObjCPtr == nullptr comparison is inverted 2021-06-16 01:41:25 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kkinnunen kkinnunen andersca dino ews-watchlist kbr kkinnunen kondapallykalyan kpiddington webkit-bug-importer oldest_to_newest 1769788 0 kkinnunen 2021-06-15 07:19:26 -0700 ANGLE Metal AutoObjCPtr == comparison is inverted 1769790 1 431436 kkinnunen 2021-06-15 07:25:33 -0700 Created attachment 431436 Patch 1769791 2 ews-watchlist 2021-06-15 07:26:34 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1769794 3 431436 andersca 2021-06-15 07:39:22 -0700 Comment on attachment 431436 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431436&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:276 > + bool operator==(const std::nullptr_t &) const { return this->get() == nullptr; } I think this can/should just be bool operator==(std::nullptr_t) const; > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:284 > + bool operator!=(const std::nullptr_t &) const { return this->get() != nullptr; } bool operator!=(std::nullptr_t) const; 1769796 4 431438 kkinnunen 2021-06-15 07:47:08 -0700 Created attachment 431438 Patch for landing 1770114 5 ews-feeder 2021-06-16 01:40:52 -0700 Committed r278926 (238857@main): <https://commits.webkit.org/238857@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431438. 1770116 6 webkit-bug-importer 2021-06-16 01:41:25 -0700 <rdar://problem/79385866> 431436 2021-06-15 07:25:33 -0700 2021-06-15 07:47:04 -0700 Patch bug-227026-20210615172531.patch text/plain 1909 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNjlmOWY3YTJlOTJjZDdkMmM5YWUzNzRmOWZlM2I5M2ZlZWIyMTU3Yy4uMzMzOWQyYWNmN2Ji Y2I2MDRiZDZiMGJhNzJiZjdkMjRhOTFlZmYxYyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA2LTE1ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgTWV0YWwgQXV0b09iakNQdHIgPT0gbnVsbHB0 ciBjb21wYXJpc29uIGlzIGludmVydGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjcwMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNYWtlIGl0IG1vcmUgY29ycmVjdCBhbmQgYWRkICE9IG51bGxwdHIg dmFyaWFudCBmb3IKKyAgICAgICAgY29uc2lzdGVuY3kuCisKKyAgICAgICAgKiBzcmMvbGliQU5H TEUvcmVuZGVyZXIvbWV0YWwvbXRsX2NvbW1vbi5oOgorICAgICAgICAocng6Om10bDo6QXV0b09i akNQdHI6Om9wZXJhdG9yPT0gY29uc3QpOgorICAgICAgICAocng6Om10bDo6QXV0b09iakNQdHI6 Om9wZXJhdG9yIT0gY29uc3QpOgorCiAyMDIxLTA2LTE1ICBLaW1tbyBLaW5udW5lbiAgPGtraW5u dW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgU2VyaW91cyBXZWJHTC9NZXRhbCBwZXJmb3JtYW5j ZSByZWdyZXNzaW9uIGluIFNhZmFyaSBUZWNobm9sb2d5IFByZXZpZXcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfY29t bW9uLmggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0 YWwvbXRsX2NvbW1vbi5oCmluZGV4IDg1N2I2MjZjMzY3Mzc2NWQ5YzMxNWFiNzgxMzRjNGI0MjNm N2JjNzMuLjdhZDQ2YTM5ZDU0Yzg4ZGExZmUyODkxMDAxMzQ2MWM2NzJkODMwN2MgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9t dGxfY29tbW9uLmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3Jl bmRlcmVyL21ldGFsL210bF9jb21tb24uaApAQCAtMjczLDcgKzI3Myw3IEBAIGNsYXNzIEF1dG9P YmpDUHRyIDogcHVibGljIFdyYXBwZWRPYmplY3Q8VD4KIAogICAgIGJvb2wgb3BlcmF0b3I9PShU IHJocykgY29uc3QgeyByZXR1cm4gdGhpcy0+Z2V0KCkgPT0gcmhzOyB9CiAKLSAgICBib29sIG9w ZXJhdG9yPT0oY29uc3Qgc3RkOjpudWxscHRyX3QgJnRoZU51bGwpIGNvbnN0IHsgcmV0dXJuIHRo aXMtPmdldCgpOyB9CisgICAgYm9vbCBvcGVyYXRvcj09KGNvbnN0IHN0ZDo6bnVsbHB0cl90ICYp IGNvbnN0IHsgcmV0dXJuIHRoaXMtPmdldCgpID09IG51bGxwdHI7IH0KIAogICAgIGlubGluZSBv cGVyYXRvciBib29sKCkgeyByZXR1cm4gdGhpcy0+Z2V0KCk7IH0KIApAQCAtMjgxLDYgKzI4MSw4 IEBAIGNsYXNzIEF1dG9PYmpDUHRyIDogcHVibGljIFdyYXBwZWRPYmplY3Q8VD4KIAogICAgIGJv b2wgb3BlcmF0b3IhPShUIHJocykgY29uc3QgeyByZXR1cm4gdGhpcy0+Z2V0KCkgIT0gcmhzOyB9 CiAKKyAgICBib29sIG9wZXJhdG9yIT0oY29uc3Qgc3RkOjpudWxscHRyX3QgJikgY29uc3QgeyBy ZXR1cm4gdGhpcy0+Z2V0KCkgIT0gbnVsbHB0cjsgfQorCiAgICAgdXNpbmcgUGFyZW50VHlwZTo6 cmV0YWluQXNzaWduOwogCiAgIHByaXZhdGU6Cg== 431438 2021-06-15 07:47:08 -0700 2021-06-16 01:40:52 -0700 Patch for landing bug-227026-20210615174707.patch text/plain 2493 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMjg1MTNkN2JhNTE5Y2JhMzc0ZDlhNDYyMDkzYTM0Y2Y1NjcwNmE2My4uOTE2MWE5OTMyYjIz MDIxZTA1NTU2MGMwZjY0MjZkMDdhNzc4ODRkNCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA2LTE1ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgTWV0YWwgQXV0b09iakNQdHIgPT0gbnVsbHB0 ciBjb21wYXJpc29uIGlzIGludmVydGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjcwMjYKKworICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2Fy bHNzb24uCisKKyAgICAgICAgTWFrZSBpdCBtb3JlIGNvcnJlY3QgYW5kIGFkZCAhPSBudWxscHRy IHZhcmlhbnQgZm9yCisgICAgICAgIGNvbnNpc3RlbmN5LgorCisgICAgICAgIFVzZSBzdGQ6Om51 bGxwdHJfdCBpbnN0ZWFkIG9mIGNvbnN0IHN0ZDo6bnVsbHB0cl90ICYKKyAgICAgICAgaW4gYWxs IGZ1bmN0aW9ucyBmb3IgY29uc2lzdGVuY3kuCisKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVu ZGVyZXIvbWV0YWwvbXRsX2NvbW1vbi5oOgorICAgICAgICAocng6Om10bDo6QXV0b09iakNQdHI6 Om9wZXJhdG9yPT0gY29uc3QpOgorICAgICAgICAocng6Om10bDo6QXV0b09iakNQdHI6Om9wZXJh dG9yIT0gY29uc3QpOgorCiAyMDIxLTA2LTExICBFbGVuaSBNYXJpYSBTdGVhICA8ZXN0ZWFAaWdh bGlhLmNvbT4KIAogICAgICAgICBBTkdMRSBFR0wgYW5kIEdMRVMgbGlicmFyaWVzIHNob3VsZCBs aW5rIHdpdGggbGliIGRsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF9jb21tb24uaCBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfY29tbW9uLmgKaW5kZXggODU3 YjYyNmMzNjczNzY1ZDljMzE1YWI3ODEzNGM0YjQyM2Y3YmM3My4uOWRhNTM2YmFlNGU2YjM2M2E1 MGY5OWQ4ZTlhODVkNWEwNjNkZWVmMCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF9jb21tb24uaAorKysgYi9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2NvbW1vbi5o CkBAIC0yMzAsNyArMjMwLDcgQEAgY2xhc3MgQXV0b09iakNQdHIgOiBwdWJsaWMgV3JhcHBlZE9i amVjdDxUPgogCiAgICAgQXV0b09iakNQdHIoKSB7fQogCi0gICAgQXV0b09iakNQdHIoY29uc3Qg c3RkOjpudWxscHRyX3QgJnRoZU51bGwpIHt9CisgICAgQXV0b09iakNQdHIoc3RkOjpudWxscHRy X3QpIHt9CiAKICAgICBBdXRvT2JqQ1B0cihjb25zdCBBdXRvT2JqQ1B0ciAmc3JjKSB7IHRoaXMt PnJldGFpbkFzc2lnbihzcmMuZ2V0KCkpOyB9CiAKQEAgLTI2Myw3ICsyNjMsNyBAQCBjbGFzcyBB dXRvT2JqQ1B0ciA6IHB1YmxpYyBXcmFwcGVkT2JqZWN0PFQ+CiAgICAgICAgIHJldHVybiAqdGhp czsKICAgICB9CiAKLSAgICBBdXRvT2JqQ1B0ciAmb3BlcmF0b3I9KGNvbnN0IHN0ZDo6bnVsbHB0 cl90ICZ0aGVOdWxsKQorICAgIEF1dG9PYmpDUHRyICZvcGVyYXRvcj0oc3RkOjpudWxscHRyX3Qp CiAgICAgewogICAgICAgICB0aGlzLT5zZXQobmlsKTsKICAgICAgICAgcmV0dXJuICp0aGlzOwpA QCAtMjczLDcgKzI3Myw3IEBAIGNsYXNzIEF1dG9PYmpDUHRyIDogcHVibGljIFdyYXBwZWRPYmpl Y3Q8VD4KIAogICAgIGJvb2wgb3BlcmF0b3I9PShUIHJocykgY29uc3QgeyByZXR1cm4gdGhpcy0+ Z2V0KCkgPT0gcmhzOyB9CiAKLSAgICBib29sIG9wZXJhdG9yPT0oY29uc3Qgc3RkOjpudWxscHRy X3QgJnRoZU51bGwpIGNvbnN0IHsgcmV0dXJuIHRoaXMtPmdldCgpOyB9CisgICAgYm9vbCBvcGVy YXRvcj09KHN0ZDo6bnVsbHB0cl90KSBjb25zdCB7IHJldHVybiB0aGlzLT5nZXQoKSA9PSBudWxs cHRyOyB9CiAKICAgICBpbmxpbmUgb3BlcmF0b3IgYm9vbCgpIHsgcmV0dXJuIHRoaXMtPmdldCgp OyB9CiAKQEAgLTI4MSw2ICsyODEsOCBAQCBjbGFzcyBBdXRvT2JqQ1B0ciA6IHB1YmxpYyBXcmFw cGVkT2JqZWN0PFQ+CiAKICAgICBib29sIG9wZXJhdG9yIT0oVCByaHMpIGNvbnN0IHsgcmV0dXJu IHRoaXMtPmdldCgpICE9IHJoczsgfQogCisgICAgYm9vbCBvcGVyYXRvciE9KHN0ZDo6bnVsbHB0 cl90KSBjb25zdCB7IHJldHVybiB0aGlzLT5nZXQoKSAhPSBudWxscHRyOyB9CisKICAgICB1c2lu ZyBQYXJlbnRUeXBlOjpyZXRhaW5Bc3NpZ247CiAKICAgcHJpdmF0ZToK