227015 2021-06-14 23:01:26 -0700 GraphicsContext::apply{Fill,Stroke}Pattern needs to do nothing if there is no fill/stroke pattern set 2021-07-08 15:09:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield koivisto rniwa sabouhallawa simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1769704 0 mmaxfield 2021-06-14 23:01:26 -0700 GraphicsContext::apply{Fill,Stroke}Pattern needs to do nothing if there is no fill/stroke pattern set 1769705 1 431406 mmaxfield 2021-06-14 23:02:59 -0700 Created attachment 431406 Patch 1769881 2 ews-feeder 2021-06-15 11:19:04 -0700 Committed r278885 (238827@main): <https://commits.webkit.org/238827@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431406. 1769882 3 webkit-bug-importer 2021-06-15 11:20:21 -0700 <rdar://problem/79352245> 1775818 4 431406 sabouhallawa 2021-07-08 15:09:19 -0700 Comment on attachment 431406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431406&action=review > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:547 > + if (!m_state.strokePattern) > + return; This check is not needed for GraphicsContextCG because all the callers check if (m_state.strokePattern) before calling this function. But it is needed for DisplayList::Recorder and RenderSVGResourcePattern::applyResource() because the callers do not check if (m_state.strokePattern) before calling this function. So I think we should either 1. Remove the check if (m_state.strokePattern) form GraphicsContextCG functions. 2. Remove this check and make DisplayList::Recorder and RenderSVGResourcePattern::applyResource() check if (m_state.strokePattern) before calling this function. > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:566 > + if (!m_state.fillPattern) > + return; Ditto. 431406 2021-06-14 23:02:59 -0700 2021-06-15 11:19:05 -0700 Patch bug-227015-20210614230258.patch text/plain 3219 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmZjMDlmZWI5NzZiMjE0 N2FiZTAwNjdkYmQxYzk2ODkyNmNmNmUzZC4uMGJmNGNkYWZlMGM5MTBlOTc0M2VlNmM1ZDA1ODdl OWZkMWE3OTRhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA2LTE0ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgR3JhcGhpY3ND b250ZXh0OjphcHBseXtGaWxsLFN0cm9rZX1QYXR0ZXJuIG5lZWRzIHRvIGRvIG5vdGhpbmcgaWYg dGhlcmUgaXMgbm8gZmlsbC9zdHJva2UgcGF0dGVybiBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzAxNQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNzkzMDExNzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm93IHRoYXQgd2UgaGF2ZSBhIEdQVSBQcm9jZXNzLCB3ZSBjYW4ndCB0cnVzdCBpbmNv bWluZyBJUEMuIFNvLCB0aGlzIHBhdGNoIHByb3RlY3RzCisgICAgICAgIGFnYWluc3QgdHJ5aW5n IHRvIGFwcGx5IHRoZSBjdXJyZXRuIGZpbGwvc3Ryb2tlIHBhdHRlcm4gd2hlbiB0aGVyZSBpc24n dCBvbmUgc2V0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250 ZXh0Q0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Q0c6OmFwcGx5U3Ry b2tlUGF0dGVybik6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRDRzo6YXBwbHlG aWxsUGF0dGVybik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29u dGV4dERpcmVjdDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dERpcmVj dDJEOjphcHBseVN0cm9rZVBhdHRlcm4pOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250 ZXh0RGlyZWN0MkQ6OmFwcGx5RmlsbFBhdHRlcm4pOgorCiAyMDIxLTA2LTE0ICBNeWxlcyBDLiBN YXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgRm9udDo6YXBwbHlUcmFu c2Zvcm1zKCkgY2FuIHJlZGlyZWN0IEdseXBoQnVmZmVyJ3MgaW50ZXJuYWwgcG9pbnRlcnMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29u dGV4dENHLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNz Q29udGV4dENHLmNwcAppbmRleCA2NzgzMmMyZDg1ZGRmZjk3YzA0NGUxYTJlNDExNmIwMzBhOTYz ZGM1Li5hYjMwMzIxYzRmYmM2Zjc0ZDBkZDFiYTc4ZDU1MmQzYWQ0MDQxYTI4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250 ZXh0Q0cuY3BwCkBAIC01NDMsNiArNTQzLDkgQEAgdm9pZCBHcmFwaGljc0NvbnRleHRDRzo6ZHJh d0VsbGlwc2UoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dENH OjphcHBseVN0cm9rZVBhdHRlcm4oKQogeworICAgIGlmICghbV9zdGF0ZS5zdHJva2VQYXR0ZXJu KQorICAgICAgICByZXR1cm47CisKICAgICBDR0NvbnRleHRSZWYgY2dDb250ZXh0ID0gcGxhdGZv cm1Db250ZXh0KCk7CiAgICAgQWZmaW5lVHJhbnNmb3JtIHVzZXJUb0Jhc2VDVE0gPSBBZmZpbmVU cmFuc2Zvcm0oZ2V0VXNlclRvQmFzZUNUTShjZ0NvbnRleHQpKTsKIApAQCAtNTU5LDYgKzU2Miw5 IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0Q0c6OmFwcGx5U3Ryb2tlUGF0dGVybigpCiAKIHZvaWQg R3JhcGhpY3NDb250ZXh0Q0c6OmFwcGx5RmlsbFBhdHRlcm4oKQogeworICAgIGlmICghbV9zdGF0 ZS5maWxsUGF0dGVybikKKyAgICAgICAgcmV0dXJuOworCiAgICAgQ0dDb250ZXh0UmVmIGNnQ29u dGV4dCA9IHBsYXRmb3JtQ29udGV4dCgpOwogICAgIEFmZmluZVRyYW5zZm9ybSB1c2VyVG9CYXNl Q1RNID0gQWZmaW5lVHJhbnNmb3JtKGdldFVzZXJUb0Jhc2VDVE0oY2dDb250ZXh0KSk7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0Nv bnRleHREaXJlY3QyRC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4v R3JhcGhpY3NDb250ZXh0RGlyZWN0MkQuY3BwCmluZGV4IDZmNzVmZjFhNzJkNGM0Yzk4OTkwYmQw M2RlNTY1NmVkODA4MDQ5ZmYuLjE0ODg4OWM0ZGFlNjRiOWQ4Yjg1MzE2ZTVhZGY1MDUwNjk4OWI3 YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFw aGljc0NvbnRleHREaXJlY3QyRC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dERpcmVjdDJELmNwcApAQCAtNDg4LDYgKzQ4OCw5IEBA IHZvaWQgR3JhcGhpY3NDb250ZXh0RGlyZWN0MkQ6OmRyYXdFbGxpcHNlKGNvbnN0IEZsb2F0UmVj dCYgcmVjdCkKIAogdm9pZCBHcmFwaGljc0NvbnRleHREaXJlY3QyRDo6YXBwbHlTdHJva2VQYXR0 ZXJuKCkKIHsKKyAgICBpZiAoIW1fc3RhdGUuc3Ryb2tlUGF0dGVybikKKyAgICAgICAgcmV0dXJu OworCiAgICAgYXV0byBjb250ZXh0ID0gcGxhdGZvcm1Db250ZXh0KCk7CiAgICAgQWZmaW5lVHJh bnNmb3JtIHVzZXJUb0Jhc2VDVE07IC8vIEZJWE1FOiBUaGlzIGlzbid0IHJlYWxseSBuZWVkZWQg b24gV2luZG93cwogCkBAIC00OTcsNiArNTAwLDkgQEAgdm9pZCBHcmFwaGljc0NvbnRleHREaXJl Y3QyRDo6YXBwbHlTdHJva2VQYXR0ZXJuKCkKIAogdm9pZCBHcmFwaGljc0NvbnRleHREaXJlY3Qy RDo6YXBwbHlGaWxsUGF0dGVybigpCiB7CisgICAgaWYgKCFtX3N0YXRlLmZpbGxQYXR0ZXJuKQor ICAgICAgICByZXR1cm47CisKICAgICBhdXRvIGNvbnRleHQgPSBwbGF0Zm9ybUNvbnRleHQoKTsK ICAgICBBZmZpbmVUcmFuc2Zvcm0gdXNlclRvQmFzZUNUTTsgLy8gRklYTUU6IFRoaXMgaXNuJ3Qg cmVhbGx5IG5lZWRlZCBvbiBXaW5kb3dzCiAK