226995 2021-06-14 15:56:54 -0700 [REGRESSION: r276616] Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._setupCodeMirror.getValue') 2021-06-14 17:46:31 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://webkit.org/ InRadar P2 Normal --- 1 pangle pangle ews-watchlist hi inspector-bugzilla-changes pangle webkit-bug-importer oldest_to_newest 1769585 0 pangle 2021-06-14 15:56:54 -0700 Uncaught Exception in Web Inspector. Steps to Reproduce: 1. Go to the Audits tab. 2. Enter edit mode. 3. Create a new audit group with any name. 4. Add some code to the single test case and to the setup. 5. Select a different audit group. 6. Encounter this exception and have your data thrown away. Uncaught Exceptions: ----------------------- - TypeError: undefined is not an object (evaluating 'this._setupCodeMirror.getValue') (at AuditTestContentView.js:320:61) saveEditedData @ AuditTestContentView.js:320:61 saveEditedData @ AuditTestCaseContentView.js:326:29 detached @ AuditTestContentView.js:291:36 _didMoveToWindow @ View.js:266:26 _didMoveToParent @ View.js:238:30 removeAllSubviews @ View.js:138:37 detached @ AuditTestGroupContentView.js:228:43 _didMoveToWindow @ View.js:266:26 _didMoveToParent @ View.js:238:30 removeSubview @ View.js:129:30 _hideEntry @ ContentViewContainer.js:464:31 showBackForwardEntryForIndex @ ContentViewContainer.js:161:28 showContentView @ ContentViewContainer.js:141:42 showRepresentedObject @ ContentBrowserTabContentView.js:218:64 ? @ Main.js:1426:41 _treeSelectionDidChange @ AuditNavigationSidebarPanel.js:375:37 dispatch @ Object.js:134:35 dispatchEventToListeners @ Object.js:142:17 _dispatchSelectionDidChangeEvent @ TreeOutline.js:1083:38 selectionControllerSelectionDidChange @ TreeOutline.js:755:46 _updateSelectedItems @ SelectionController.js:458:65 selectItem @ SelectionController.js:155:34 handleItemMouseDown @ SelectionController.js:322:28 _handleMouseDown @ TreeOutline.js:1067:54 _handleMouseDown @ [native code] ----------------------- Notes: Inspected URL: https://webkit.org/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) 1769586 1 webkit-bug-importer 2021-06-14 15:57:21 -0700 <rdar://problem/79312323> 1769594 2 431379 pangle 2021-06-14 16:23:24 -0700 Created attachment 431379 Patch v1.0 1769612 3 431379 hi 2021-06-14 16:40:53 -0700 Comment on attachment 431379 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=431379&action=review r=me > Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js:319 > + if (!this._setupCodeMirror) NIT: I'd not have this be an early return just so that if more fields are added in the future it makes the diff cleaner :) 1769617 4 431379 pangle 2021-06-14 16:45:44 -0700 Comment on attachment 431379 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=431379&action=review >> Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js:319 >> + if (!this._setupCodeMirror) > > NIT: I'd not have this be an early return just so that if more fields are added in the future it makes the diff cleaner :) Fair enough. 1769619 5 431386 pangle 2021-06-14 16:48:19 -0700 Created attachment 431386 Patch v1.1 - Review nit 1769650 6 ews-feeder 2021-06-14 17:46:28 -0700 Committed r278853 (238799@main): <https://commits.webkit.org/238799@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431386. 431379 2021-06-14 16:23:24 -0700 2021-06-14 16:48:17 -0700 Patch v1.0 bug-226995-20210614162323.patch text/plain 1959 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YWZkNDM3OTY2NDY4ZGMzODc3MjU4YzFhMWQ2YjAyZjBjMWJiYzliLi42ZWViNTA1MDEzNTdhYjRh ODg0MjI3MDNmNWU0NmZhNGIxNTY4NWMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMS0wNi0xNCAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgW1JFR1JFU1NJT046IHIyNzY2MTZdIFVuY2F1Z2h0IEV4Y2VwdGlvbjogVHlw ZUVycm9yOiB1bmRlZmluZWQgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAndGhpcy5fc2V0 dXBDb2RlTWlycm9yLmdldFZhbHVlJykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNjk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEF1ZGl0IHRlc3QgZ3JvdXBzIHNoYXJlIGEgc2luZ2xlIHNldHVwIGVk aXRvciBmb3IgYWxsIHRoZWlyIHRlc3QgY2FzZXMsIGxlYXZpbmcgaW5kaXZpZHVhbCB0ZXN0IGNh c2VzIHdpdGhvdXQKKyAgICAgICAgdGhlaXIgb3duIHNldHVwIGVkaXRvci4gSW4gdGhpcyBjYXNl LCB3ZSBzaG91bGQgbm90IGF0dGVtcHQgdG8gc2F2ZSB0aGUgc2V0dXAgc2NyaXB0IGZvciBldmVy eSB0ZXN0LCBhbmQgaW5zdGVhZAorICAgICAgICBhbGxvdyB0aGUgaW5zdGFuY2Ugb2YgYEF1ZGl0 VGVzdEdyb3VwQ29udGVudFZpZXdgIHRoYXQgZG9lcyBoYXZlIGEgc2V0dXAgZWRpdG9yIHRvIHNh dmUgdGhlIHNjcmlwdC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0 Q29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5BdWRpdFRlc3RDb250ZW50Vmlldy5wcm90b3R5 cGUuc2F2ZUVkaXRlZERhdGEpOgorCiAyMDIxLTA2LTA4ICBSYXp2YW4gQ2FsaW1hbiAgPHJjYWxp bWFuQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdHlsZXMgcGFuZWwgc2xv dyB0byByZW5kZXIgd2hlbiBpbnNwZWN0aW5nIG5vZGUgd2l0aCBtYW55IGluaGVyaXRlZCBDU1Mg dmFyaWFibGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9BdWRpdFRlc3RDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdENvbnRlbnRWaWV3LmpzCmluZGV4IDA3OTFlZjg5 OGZlNjhlMzZjYjhlOTg0YzE2YzdmZDUwNjU2NzY3NDMuLjFjY2QwNTBhZDMxZDg2Y2U1NGUyNjZl NDA2NGRkMzY2ZWQ1NjZmZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdENvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdENvbnRlbnRWaWV3LmpzCkBA IC0zMTYsNiArMzE2LDkgQEAgV0kuQXVkaXRUZXN0Q29udGVudFZpZXcgPSBjbGFzcyBBdWRpdFRl c3RDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWV3CiAKICAgICBzYXZlRWRpdGVkRGF0 YSgpCiAgICAgeworICAgICAgICBpZiAoIXRoaXMuX3NldHVwQ29kZU1pcnJvcikKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgCiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMucmVwcmVz ZW50ZWRPYmplY3QuZWRpdGFibGUsIHRoaXMucmVwcmVzZW50ZWRPYmplY3QpOwogICAgICAgICB0 aGlzLnJlcHJlc2VudGVkT2JqZWN0LnNldHVwID0gdGhpcy5fc2V0dXBDb2RlTWlycm9yLmdldFZh bHVlKCkudHJpbSgpOwogICAgIH0K 431386 2021-06-14 16:48:19 -0700 2021-06-14 17:46:29 -0700 Patch v1.1 - Review nit bug-226995-20210614164818.patch text/plain 2040 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YWZkNDM3OTY2NDY4ZGMzODc3MjU4YzFhMWQ2YjAyZjBjMWJiYzliLi43ZDY1OTRlNDVlZGIwNzBi YzNmNmU2NjgwYTE5MTZiMzExZGJlNDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMS0wNi0xNCAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgW1JFR1JFU1NJT046IHIyNzY2MTZdIFVuY2F1Z2h0IEV4Y2VwdGlvbjogVHlw ZUVycm9yOiB1bmRlZmluZWQgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAndGhpcy5fc2V0 dXBDb2RlTWlycm9yLmdldFZhbHVlJykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNjk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IERldmluIFJvdXNz by4KKworICAgICAgICBBdWRpdCB0ZXN0IGdyb3VwcyBzaGFyZSBhIHNpbmdsZSBzZXR1cCBlZGl0 b3IgZm9yIGFsbCB0aGVpciB0ZXN0IGNhc2VzLCBsZWF2aW5nIGluZGl2aWR1YWwgdGVzdCBjYXNl cyB3aXRob3V0CisgICAgICAgIHRoZWlyIG93biBzZXR1cCBlZGl0b3IuIEluIHRoaXMgY2FzZSwg d2Ugc2hvdWxkIG5vdCBhdHRlbXB0IHRvIHNhdmUgdGhlIHNldHVwIHNjcmlwdCBmb3IgZXZlcnkg dGVzdCwgYW5kIGluc3RlYWQKKyAgICAgICAgYWxsb3cgdGhlIGluc3RhbmNlIG9mIGBBdWRpdFRl c3RHcm91cENvbnRlbnRWaWV3YCB0aGF0IGRvZXMgaGF2ZSBhIHNldHVwIGVkaXRvciB0byBzYXZl IHRoZSBzY3JpcHQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdENv bnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuQXVkaXRUZXN0Q29udGVudFZpZXcucHJvdG90eXBl LnNhdmVFZGl0ZWREYXRhKToKKwogMjAyMS0wNi0wOCAgUmF6dmFuIENhbGltYW4gIDxyY2FsaW1h bkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU3R5bGVzIHBhbmVsIHNsb3cg dG8gcmVuZGVyIHdoZW4gaW5zcGVjdGluZyBub2RlIHdpdGggbWFueSBpbmhlcml0ZWQgQ1NTIHZh cmlhYmxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvQXVkaXRUZXN0Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9BdWRpdFRlc3RDb250ZW50Vmlldy5qcwppbmRleCAwNzkxZWY4OThm ZTY4ZTM2Y2I4ZTk4NGMxNmM3ZmQ1MDY1Njc2NzQzLi5lZmZiZjFiNDFkNjM5N2MxYjllNmM4YTg4 ZDRlNWY4NmExYjQ0YWUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9BdWRpdFRlc3RDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdFRlc3RDb250ZW50Vmlldy5qcwpAQCAt MzE3LDcgKzMxNyw4IEBAIFdJLkF1ZGl0VGVzdENvbnRlbnRWaWV3ID0gY2xhc3MgQXVkaXRUZXN0 Q29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogICAgIHNhdmVFZGl0ZWREYXRhKCkK ICAgICB7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMucmVwcmVzZW50ZWRPYmplY3QuZWRp dGFibGUsIHRoaXMucmVwcmVzZW50ZWRPYmplY3QpOwotICAgICAgICB0aGlzLnJlcHJlc2VudGVk T2JqZWN0LnNldHVwID0gdGhpcy5fc2V0dXBDb2RlTWlycm9yLmdldFZhbHVlKCkudHJpbSgpOwor ICAgICAgICBpZiAodGhpcy5fc2V0dXBDb2RlTWlycm9yKQorICAgICAgICAgICAgdGhpcy5yZXBy ZXNlbnRlZE9iamVjdC5zZXR1cCA9IHRoaXMuX3NldHVwQ29kZU1pcnJvci5nZXRWYWx1ZSgpLnRy aW0oKTsKICAgICB9CiAKICAgICBzaG93UnVubmluZ1BsYWNlaG9sZGVyKCkK