226985 2021-06-14 12:49:51 -0700 run-javascriptcore-tests should print output when a test binary fails by default 2021-06-15 18:37:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller darin mark.lam webkit-bug-importer oldest_to_newest 1769507 0 keith_miller 2021-06-14 12:49:51 -0700 run-javascriptcore-tests should print output when a test binary fails by default 1769508 1 431354 keith_miller 2021-06-14 12:51:17 -0700 Created attachment 431354 Patch 1769509 2 431355 keith_miller 2021-06-14 12:53:38 -0700 Created attachment 431355 Patch 1769511 3 431355 mark.lam 2021-06-14 12:56:14 -0700 Comment on attachment 431355 Patch rs=me 1769652 4 ews-feeder 2021-06-14 17:54:15 -0700 Committed r278854 (238800@main): <https://commits.webkit.org/238800@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431355. 1769653 5 webkit-bug-importer 2021-06-14 17:55:20 -0700 <rdar://problem/79317069> 1770052 6 431355 darin 2021-06-15 18:37:24 -0700 Comment on attachment 431355 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431355&action=review > Tools/Scripts/run-javascriptcore-tests:642 > + print "$testOutput" if ($verbose or $testResult); Those quote marks don’t do anything useful. 431354 2021-06-14 12:51:17 -0700 2021-06-14 12:53:37 -0700 Patch bug-226985-20210614155116.patch text/plain 1568 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2IwNDdjMzUzYmIwMWYxYzc4Mjc4MGNkZjk3ZmFiYTg1 NzY2NjY3OS4uOTg5MzkzM2U2OTVjZWRhYWEwMmMzMGQzYzJkMzkzNGFlYTAxMDU0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTA2LTE0ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBzaG91bGQgcHJpbnQgb3V0cHV0IHdo ZW4gYSB0ZXN0IGJpbmFyeSBmYWlscyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5ODUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRl c3RzOgorICAgICAgICAocnVuVGVzdCk6CisKIDIwMjEtMDYtMTEgIEZ1amlpIEhpcm9ub3JpICA8 SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dpbl1bRHVtcFJlbmRlclRyZWVd IC0tbm8tdGltZW91dCBzd2l0Y2ggZG9lc24ndCB3b3JrCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3Jp cHRjb3JlLXRlc3RzCmluZGV4IDBjZTMzYmI1ZmU1YjM2MzI2Y2YwYTFmYjNhMGUxZWFkZDE5ZTY4 OTkuLmIxNzExN2MxMGRlMzc4MTE5ZjkyNmNkODNiNDk2NTc1NzYzOWYzZGIgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCisrKyBiL1Rvb2xzL1Njcmlw dHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCkBAIC02MzAsMTMgKzYzMCwxNyBAQCBzdWIgcnVu VGVzdCB7CiAgICAgbXkgJGxhc3RPcHRpbWl6ZUxldmVsOwogCiAgICAgb3BlbihURVNULCAiLXwi LCAiQGNvbW1hbmQgMj4mMSIpIG9yIGRpZSAiRmFpbGVkIHRvIHJ1biBAY29tbWFuZCI7CisgICAg bXkgJHRlc3RPdXRwdXQgPSAiIjsKICAgICB3aGlsZSAoIG15ICRsaW5lID0gPFRFU1Q+ICkgewot ICAgICAgICBwcmludCAkbGluZSBpZiAoJHZlcmJvc2UpOworIyAgICAgICAgcHJpbnQgIiRsaW5l IjsKKyAgICAgICAgJHRlc3RPdXRwdXQgLj0gJGxpbmU7CiAgICAgfQogICAgICR0ZXN0UmVzdWx0 ID0gY2xvc2UoVEVTVCkgPyAwIDogJD87CiAgICAgJHJlcG9ydERhdGF7JHRlc3ROYW1lfSA9ICR0 ZXN0UmVzdWx0ID8ge2FjdHVhbCA9PiAiRkFJTCJ9IDoge2FjdHVhbCA9PiAiUEFTUyJ9OwogCiAg ICAgbXkgJGV4aXRTdGF0dXMgPSBleGl0U3RhdHVzKCR0ZXN0UmVzdWx0KTsKKworICAgIHByaW50 ICIkdGVzdE91dHB1dCIgaWYgKCR2ZXJib3NlIG9yICR0ZXN0UmVzdWx0KTsKICAgICBwcmludCAi JHRlc3ROYW1lIGNvbXBsZXRlZCB3aXRoIHJjPSR0ZXN0UmVzdWx0ICgkZXhpdFN0YXR1cylcblxu IjsKIAogICAgIGlmICgkdGVzdFJlc3VsdCkgewo= 431355 2021-06-14 12:53:38 -0700 2021-06-14 17:54:15 -0700 Patch bug-226985-20210614155337.patch text/plain 1543 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2IwNDdjMzUzYmIwMWYxYzc4Mjc4MGNkZjk3ZmFiYTg1 NzY2NjY3OS4uOTg5MzkzM2U2OTVjZWRhYWEwMmMzMGQzYzJkMzkzNGFlYTAxMDU0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTA2LTE0ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBzaG91bGQgcHJpbnQgb3V0cHV0IHdo ZW4gYSB0ZXN0IGJpbmFyeSBmYWlscyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5ODUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRl c3RzOgorICAgICAgICAocnVuVGVzdCk6CisKIDIwMjEtMDYtMTEgIEZ1amlpIEhpcm9ub3JpICA8 SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dpbl1bRHVtcFJlbmRlclRyZWVd IC0tbm8tdGltZW91dCBzd2l0Y2ggZG9lc24ndCB3b3JrCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3Jp cHRjb3JlLXRlc3RzCmluZGV4IDBjZTMzYmI1ZmU1YjM2MzI2Y2YwYTFmYjNhMGUxZWFkZDE5ZTY4 OTkuLmRkNjgxMjViOWI4YjAxNGM2MzI0NTc2ZmJkNDNjOTc1ZjM0ZjNjYzIgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCisrKyBiL1Rvb2xzL1Njcmlw dHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCkBAIC02MzAsMTMgKzYzMCwxNiBAQCBzdWIgcnVu VGVzdCB7CiAgICAgbXkgJGxhc3RPcHRpbWl6ZUxldmVsOwogCiAgICAgb3BlbihURVNULCAiLXwi LCAiQGNvbW1hbmQgMj4mMSIpIG9yIGRpZSAiRmFpbGVkIHRvIHJ1biBAY29tbWFuZCI7CisgICAg bXkgJHRlc3RPdXRwdXQgPSAiIjsKICAgICB3aGlsZSAoIG15ICRsaW5lID0gPFRFU1Q+ICkgewot ICAgICAgICBwcmludCAkbGluZSBpZiAoJHZlcmJvc2UpOworICAgICAgICAkdGVzdE91dHB1dCAu PSAkbGluZTsKICAgICB9CiAgICAgJHRlc3RSZXN1bHQgPSBjbG9zZShURVNUKSA/IDAgOiAkPzsK ICAgICAkcmVwb3J0RGF0YXskdGVzdE5hbWV9ID0gJHRlc3RSZXN1bHQgPyB7YWN0dWFsID0+ICJG QUlMIn0gOiB7YWN0dWFsID0+ICJQQVNTIn07CiAKICAgICBteSAkZXhpdFN0YXR1cyA9IGV4aXRT dGF0dXMoJHRlc3RSZXN1bHQpOworCisgICAgcHJpbnQgIiR0ZXN0T3V0cHV0IiBpZiAoJHZlcmJv c2Ugb3IgJHRlc3RSZXN1bHQpOwogICAgIHByaW50ICIkdGVzdE5hbWUgY29tcGxldGVkIHdpdGgg cmM9JHRlc3RSZXN1bHQgKCRleGl0U3RhdHVzKVxuXG4iOwogCiAgICAgaWYgKCR0ZXN0UmVzdWx0 KSB7Cg==