226977 2021-06-14 09:15:07 -0700 Micro-optimize ResourceResponseBase::sanitizeHTTPHeaderFields() 2021-06-14 10:32:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren sam webkit-bug-importer youennf oldest_to_newest 1769420 0 cdumez 2021-06-14 09:15:07 -0700 Micro-optimize ResourceResponseBase::sanitizeHTTPHeaderFields() as it is not as efficient as it could be and it shows on profiles. 1769424 1 431333 cdumez 2021-06-14 09:23:38 -0700 Created attachment 431333 Patch 1769448 2 431333 ggaren 2021-06-14 10:25:24 -0700 Comment on attachment 431333 Patch r=me 1769453 3 ews-feeder 2021-06-14 10:31:08 -0700 Committed r278833 (238784@main): <https://commits.webkit.org/238784@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431333. 1769455 4 webkit-bug-importer 2021-06-14 10:32:24 -0700 <rdar://problem/79295925> 431333 2021-06-14 09:23:38 -0700 2021-06-14 10:31:09 -0700 Patch bug-226977-20210614092337.patch text/plain 4490 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmZmNDNiNmExMWU1ZGYx YWNiOWI5ZmM0OTBlNGJhNmE2ZGFiOWRkYS4uOWIzMzBhZWQzMTZjMzYzZWJhZDc3NDI3ZGRmNDcz MGZlYmQ2YjcxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTE0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWljcm8tb3B0aW1pemUgUmVz b3VyY2VSZXNwb25zZUJhc2U6OnNhbml0aXplSFRUUEhlYWRlckZpZWxkcygpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5NzcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNaWNyby1vcHRpbWl6ZSBSZXNv dXJjZVJlc3BvbnNlQmFzZTo6c2FuaXRpemVIVFRQSGVhZGVyRmllbGRzKCkgYXMgaXQgaXMgbm90 IGFzIGVmZmljaWVudCBhcyBpdCBjb3VsZCBiZSBhbmQgaXQKKyAgICAgICAgc2hvd3Mgb24gcHJv ZmlsZXMuIEluIHBhcnRpY3VsYXIsIHJlbHkgb24gVmVjdG9yOjpyZW1vdmVBbGxNYXRjaGluZygp IG1vcmUgaW5zdGVhZCBvZiByZWNvbnN0cnVjdGluZyBIVFRQSGVhZGVyTWFwcworICAgICAgICAm IFZlY3RvcnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VC YXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2VCYXNlOjpzYW5pdGl6 ZUhUVFBIZWFkZXJGaWVsZHNBY2NvcmRpbmdUb1RhaW50aW5nKToKKyAgICAgICAgKFdlYkNvcmU6 OlJlc291cmNlUmVzcG9uc2VCYXNlOjpzYW5pdGl6ZUhUVFBIZWFkZXJGaWVsZHMpOgorCiAyMDIx LTA2LTE0ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11b VEZDXSBBZGQgc3VwcG9ydCBmb3IgZmxleGluZyBjb2x1bW5zIHdoZW4gdGhlIGNvbnRlbnQgaXMg YWxzbyBmbGV4aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuY3BwCmluZGV4IDE5ZjI0MGEyZTAwZTk4ZDMzOTA2MDI4 ZjdiNWYzZDE3MGNiNGM0ZGYuLmEwY2I4MjVlMGY1YzQ2MTJhNDAwZGFiMTk3NmJkNDM0OThhZTE3 ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VS ZXNwb25zZUJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVz b3VyY2VSZXNwb25zZUJhc2UuY3BwCkBAIC00NTIsMzcgKzQ1MiwyMyBAQCB2b2lkIFJlc291cmNl UmVzcG9uc2VCYXNlOjpzYW5pdGl6ZUhUVFBIZWFkZXJGaWVsZHNBY2NvcmRpbmdUb1RhaW50aW5n KCkKIHsKICAgICBzd2l0Y2ggKG1fdGFpbnRpbmcpIHsKICAgICBjYXNlIFJlc291cmNlUmVzcG9u c2U6OlRhaW50aW5nOjpCYXNpYzoKLSAgICAgICAgcmV0dXJuOworICAgICAgICBicmVhazsKICAg ICBjYXNlIFJlc291cmNlUmVzcG9uc2U6OlRhaW50aW5nOjpDb3JzOiB7CiAgICAgICAgIGF1dG8g Y29yc1NhZmVIZWFkZXJTZXQgPSBwYXJzZUFjY2Vzc0NvbnRyb2xBbGxvd0xpc3Q8QVNDSUlDYXNl SW5zZW5zaXRpdmVIYXNoPihodHRwSGVhZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6OkFjY2Vzc0Nv bnRyb2xFeHBvc2VIZWFkZXJzKSkudmFsdWVfb3IoSGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2FzZUlu c2Vuc2l0aXZlSGFzaD4geyB9KTsKLSAgICAgICAgaWYgKGNvcnNTYWZlSGVhZGVyU2V0LmNvbnRh aW5zKCIqIikpCisgICAgICAgIGlmIChjb3JzU2FmZUhlYWRlclNldC5jb250YWlucygiKiJfc3Ry KSkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBIVFRQSGVhZGVyTWFwIGZpbHRlcmVk SGVhZGVyczsKLSAgICAgICAgZm9yIChhdXRvJiBoZWFkZXIgOiBtX2h0dHBIZWFkZXJGaWVsZHMu Y29tbW9uSGVhZGVycygpKSB7Ci0gICAgICAgICAgICBpZiAoaXNTYWZlQ3Jvc3NPcmlnaW5SZXNw b25zZUhlYWRlcihoZWFkZXIua2V5KSkKLSAgICAgICAgICAgICAgICBmaWx0ZXJlZEhlYWRlcnMu YWRkKGhlYWRlci5rZXksIFdURk1vdmUoaGVhZGVyLnZhbHVlKSk7Ci0gICAgICAgIH0KLSAgICAg ICAgZm9yIChhdXRvJiBoZWFkZXJOYW1lIDogY29yc1NhZmVIZWFkZXJTZXQpIHsKLSAgICAgICAg ICAgIGlmICghZmlsdGVyZWRIZWFkZXJzLmNvbnRhaW5zKGhlYWRlck5hbWUpKSB7Ci0gICAgICAg ICAgICAgICAgYXV0byB2YWx1ZSA9IG1faHR0cEhlYWRlckZpZWxkcy5nZXQoaGVhZGVyTmFtZSk7 Ci0gICAgICAgICAgICAgICAgaWYgKCF2YWx1ZS5pc051bGwoKSkKLSAgICAgICAgICAgICAgICAg ICAgZmlsdGVyZWRIZWFkZXJzLmFkZChoZWFkZXJOYW1lLCB2YWx1ZSk7Ci0gICAgICAgICAgICB9 Ci0gICAgICAgIH0KLSAgICAgICAgbV9odHRwSGVhZGVyRmllbGRzID0gV1RGTW92ZShmaWx0ZXJl ZEhlYWRlcnMpOwotICAgICAgICByZXR1cm47CisgICAgICAgIG1faHR0cEhlYWRlckZpZWxkcy5j b21tb25IZWFkZXJzKCkucmVtb3ZlQWxsTWF0Y2hpbmcoWyZjb3JzU2FmZUhlYWRlclNldF0oYXV0 byYgaGVhZGVyKSB7CisgICAgICAgICAgICByZXR1cm4gIWlzU2FmZUNyb3NzT3JpZ2luUmVzcG9u c2VIZWFkZXIoaGVhZGVyLmtleSkgJiYgIWNvcnNTYWZlSGVhZGVyU2V0LmNvbnRhaW5zKGh0dHBI ZWFkZXJOYW1lU3RyaW5nKGhlYWRlci5rZXkpLnRvU3RyaW5nV2l0aG91dENvcHlpbmcoKSk7Cisg ICAgICAgIH0pOworICAgICAgICBtX2h0dHBIZWFkZXJGaWVsZHMudW5jb21tb25IZWFkZXJzKCku cmVtb3ZlQWxsTWF0Y2hpbmcoWyZjb3JzU2FmZUhlYWRlclNldF0oYXV0byYgaGVhZGVyKSB7IHJl dHVybiAhY29yc1NhZmVIZWFkZXJTZXQuY29udGFpbnMoaGVhZGVyLmtleSk7IH0pOworICAgICAg ICBicmVhazsKICAgICB9CiAgICAgY2FzZSBSZXNvdXJjZVJlc3BvbnNlOjpUYWludGluZzo6T3Bh cXVlOgotICAgIGNhc2UgUmVzb3VyY2VSZXNwb25zZTo6VGFpbnRpbmc6Ok9wYXF1ZXJlZGlyZWN0 OiB7Ci0gICAgICAgIEhUVFBIZWFkZXJNYXAgZmlsdGVyZWRIZWFkZXJzOwotICAgICAgICBmb3Ig KGF1dG8mIGhlYWRlciA6IG1faHR0cEhlYWRlckZpZWxkcy5jb21tb25IZWFkZXJzKCkpIHsKLSAg ICAgICAgICAgIGlmIChpc1NhZmVDcm9zc09yaWdpblJlc3BvbnNlSGVhZGVyKGhlYWRlci5rZXkp KQotICAgICAgICAgICAgICAgIGZpbHRlcmVkSGVhZGVycy5hZGQoaGVhZGVyLmtleSwgV1RGTW92 ZShoZWFkZXIudmFsdWUpKTsKLSAgICAgICAgfQotICAgICAgICBtX2h0dHBIZWFkZXJGaWVsZHMg PSBXVEZNb3ZlKGZpbHRlcmVkSGVhZGVycyk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9CisgICAg Y2FzZSBSZXNvdXJjZVJlc3BvbnNlOjpUYWludGluZzo6T3BhcXVlcmVkaXJlY3Q6CisgICAgICAg IG1faHR0cEhlYWRlckZpZWxkcy5jb21tb25IZWFkZXJzKCkucmVtb3ZlQWxsTWF0Y2hpbmcoW10o YXV0byYgaGVhZGVyKSB7IHJldHVybiAhaXNTYWZlQ3Jvc3NPcmlnaW5SZXNwb25zZUhlYWRlciho ZWFkZXIua2V5KTsgfSk7CisgICAgICAgIG1faHR0cEhlYWRlckZpZWxkcy51bmNvbW1vbkhlYWRl cnMoKS5jbGVhcigpOworICAgICAgICBicmVhazsKICAgICB9CiB9CiAKQEAgLTQ5NywxMSArNDgz LDcgQEAgdm9pZCBSZXNvdXJjZVJlc3BvbnNlQmFzZTo6c2FuaXRpemVIVFRQSGVhZGVyRmllbGRz KFNhbml0aXphdGlvblR5cGUgdHlwZSkKICAgICBjYXNlIFNhbml0aXphdGlvblR5cGU6OlJlbW92 ZUNvb2tpZXM6CiAgICAgICAgIHJldHVybjsKICAgICBjYXNlIFNhbml0aXphdGlvblR5cGU6OlJl ZGlyZWN0aW9uOiB7Ci0gICAgICAgIGF1dG8gY29tbW9uSGVhZGVycyA9IFdURk1vdmUobV9odHRw SGVhZGVyRmllbGRzLmNvbW1vbkhlYWRlcnMoKSk7Ci0gICAgICAgIGZvciAoYXV0byYgaGVhZGVy IDogY29tbW9uSGVhZGVycykgewotICAgICAgICAgICAgaWYgKGlzU2FmZVJlZGlyZWN0aW9uUmVz cG9uc2VIZWFkZXIoaGVhZGVyLmtleSkpCi0gICAgICAgICAgICAgICAgbV9odHRwSGVhZGVyRmll bGRzLmFkZChoZWFkZXIua2V5LCBXVEZNb3ZlKGhlYWRlci52YWx1ZSkpOwotICAgICAgICB9Cisg ICAgICAgIG1faHR0cEhlYWRlckZpZWxkcy5jb21tb25IZWFkZXJzKCkucmVtb3ZlQWxsTWF0Y2hp bmcoW10oYXV0byYgaGVhZGVyKSB7IHJldHVybiAhaXNTYWZlUmVkaXJlY3Rpb25SZXNwb25zZUhl YWRlcihoZWFkZXIua2V5KTsgfSk7CiAgICAgICAgIG1faHR0cEhlYWRlckZpZWxkcy51bmNvbW1v bkhlYWRlcnMoKS5jbGVhcigpOwogICAgICAgICByZXR1cm47CiAgICAgfQo=