226958 2021-06-13 15:43:39 -0700 [watchOS] Quickboard UI for focused select elements should not allow the user to change the input language 2021-06-13 18:24:17 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin cdumez hi megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1769305 0 wenson_hsieh 2021-06-13 15:43:39 -0700 There's no point to showing this UI for single/multiple select elements. 1769309 1 431295 wenson_hsieh 2021-06-13 16:37:53 -0700 Created attachment 431295 For EWS 1769311 2 431295 wenson_hsieh 2021-06-13 18:18:49 -0700 Comment on attachment 431295 For EWS Thanks for the review! 1769312 3 ews-feeder 2021-06-13 18:23:06 -0700 Committed r278823 (238776@main): <https://commits.webkit.org/238776@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431295. 1769313 4 webkit-bug-importer 2021-06-13 18:24:17 -0700 <rdar://problem/79269752> 431295 2021-06-13 16:37:53 -0700 2021-06-13 18:23:07 -0700 For EWS bug-226958-20210613163753.patch text/plain 6709 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk5YWEwOTdmNTg5Y2E5YWNk NGE3OTUwMzc0NjU5YjY0ZGNlNWQxMGUuLmYyNmM5ODcxMmUwZTNjZDJkMGNiYTRhZDFmMTY0NTI3 NWIxMmViODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDYgQEAKKzIwMjEtMDYtMTMgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW3dhdGNoT1NdIFF1aWNr Ym9hcmQgVUkgZm9yIGZvY3VzZWQgc2VsZWN0IGVsZW1lbnRzIHNob3VsZCBub3QgYWxsb3cgdGhl IHVzZXIgdG8gY2hhbmdlIHRoZSBpbnB1dCBsYW5ndWFnZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2OTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGEgY291cGxlIG9mIGJ1Z3MgYXJvdW5kIGZv Y3VzZWQgc2VsZWN0IGVsZW1lbnQgVUkgdGhhdCB3ZXJlIGludHJvZHVjZWQgaW4gd2F0Y2hPUyA3 LCBkdWUgdG8gY2hhbmdlcyBpbgorICAgICAgICBQZXBwZXJVSUNvcmUuIFNlZSBiZWxvdyBmb3Ig ZGV0YWlscy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tRdWlja2JvYXJkTGlz dFZpZXdDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS1F1aWNrYm9hcmRMaXN0Vmlld0NvbnRy b2xsZXIgaW5pdFdpdGhEZWxlZ2F0ZTpdKToKKworICAgICAgICBEcml2ZS1ieSBmaXg6IHJlbW92 ZSBhIGBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKWAgZ3VhcmQgdGhhdCB3YXMgKHNlZW1pbmdseSkg dW5pbnRlbnRpb25hbGx5IGFkZGVkIGluIHIyNjI4NTQuCisKKyAgICAgICAgKC1bV0tRdWlja2Jv YXJkTGlzdFZpZXdDb250cm9sbGVyIHZpZXdEaWRMb2FkXSk6IERlbGV0ZWQuCisKKyAgICAgICAg QXZvaWQgaGlkaW5nIHRoZSBsaXN0IHZpZXcgY29udHJvbGxlcidzIGAtaGVhZGVyVmlld2Agd2hl biBmb2N1c2luZyBzZWxlY3QgZWxlbWVudHMuIEluIHdhdGNoT1MgNywgdGhlIGFjY2VwdAorICAg ICAgICBhbmQgY2FuY2VsIGJ1dHRvbnMgYXJlIHBvc2l0aW9uZWQgaW5zaWRlIHRoZSBgLWhlYWRl clZpZXdgLCBzbyBoYXZpbmcgdGhpcyBsb2dpYyBpbiB0aGUgYmFzZSBjbGFzcworICAgICAgICAo V0tRdWlja2JvYXJkTGlzdFZpZXdDb250cm9sbGVyKSBtZWFucyB0aGF0IHRoZSBEb25lIGJ1dHRv biBpbiBzZWxlY3QgbWVudXMgZG9lcyBub3Qgc2hvdyB1cC4gSW4gdHVybiwgdGhpcworICAgICAg ICBtZWFucyB0aGF0IGN1cnJlbnRseSwgdXNlcnMgd2hvIGZvY3VzIHNlbGVjdCBlbGVtZW50cyBt dXN0IGtub3cgdG8gdXNlIHRoZSBjcm93biBidXR0b24gdG8gZGlzbWlzcyB0aGUgc2VsZWN0Cisg ICAgICAgIG1lbnUuCisKKyAgICAgICAgRm9yIG5vdywgd2UgbW92ZSBsb2dpYyB0byB0aGUgb25s eSBvdGhlciBzdWJjbGFzcyBvZiBXS1F1aWNrYm9hcmRMaXN0Vmlld0NvbnRyb2xsZXIsCisgICAg ICAgIFdLVGV4dElucHV0TGlzdFZpZXdDb250cm9sbGVyLiBIb3dldmVyLCBub3RlIHRoYXQgdGhp cyB0b28gaXMgZ29pbmcgYXdheSBpbiBhbiB1cGNvbWluZyBwYXRjaCB0aGF0IHJlZmFjdG9ycwor ICAgICAgICBXS1RleHRJbnB1dExpc3RWaWV3Q29udHJvbGxlciBzbyB0aGF0IGl0IGRpcmVjdGx5 IHN1YmNsYXNzZXMgUFVJQ1F1aWNrYm9hcmRNZXNzYWdlVmlld0NvbnRyb2xsZXIKKyAgICAgICAg aW5zdGVhZCBvZiBQVUlDUXVpY2tib2FyZExpc3RWaWV3Q29udHJvbGxlci4KKworICAgICAgICAq IFBsYXRmb3JtL3NwaS93YXRjaG9zL1BlcHBlclVJQ29yZVNQSS5oOgorCisgICAgICAgIE1vdmUg YSBkZWNsYXJhdGlvbiBvZiBgLWluaXRXaXRoRGVsZWdhdGU6ZGljdGF0aW9uTW9kZTpgIGZyb20g UFVJQ0RpY3RhdGlvblZpZXdDb250cm9sbGVyIHRvCisgICAgICAgIFBVSUNRdWlja2JvYXJkTGlz dFZpZXdDb250cm9sbGVyIChzZWUgdGhlIGNoYW5nZSBpbiBgLVtXS1F1aWNrYm9hcmRMaXN0Vmll d0NvbnRyb2xsZXIgaW5pdFdpdGhEZWxlZ2F0ZTpdYCBhYm92ZSkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL2Zvcm1zL1dLU2VsZWN0TWVudUxpc3RWaWV3Q29udHJvbGxlci5tbToKKyAgICAg ICAgKC1bV0tTZWxlY3RNZW51TGlzdFZpZXdDb250cm9sbGVyIHNob3VsZFNob3dMYW5ndWFnZUJ1 dHRvbl0pOgorCisgICAgICAgIFNpbmNlIHdhdGNoT1MgNywgdGhlIGxhbmd1YWdlIGJ1dHRvbiBp cyBub3cgYWx3YXlzIHNob3duIGJ5IGRlZmF1bHQgaW4gUFVJQ1F1aWNrYm9hcmRMaXN0Vmlld0Nv bnRyb2xsZXIsIHdpdGggYQorICAgICAgICBuZXcgc3ViY2xhc3NpbmcgaG9vayB0byBhdm9pZCBz aG93aW5nIGl0LiBJdCBkb2Vzbid0IG1ha2Ugc2Vuc2UgdG8gYWxsb3cgdGhlIHVzZXIgdG8gY2hh bmdlIGlucHV0IGxhbmd1YWdlcyB3aGVuCisgICAgICAgIGNob29zaW5nIG9wdGlvbnMgaW4gYSBz ZWxlY3QgbWVudSwgc28gd2UgaW1wbGVtZW50IHRoaXMgYW5kIGFsd2F5cyByZXR1cm4gYE5PYCBo ZXJlLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS1RleHRJbnB1dExpc3RWaWV3 Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tUZXh0SW5wdXRMaXN0Vmlld0NvbnRyb2xsZXIg dmlld0RpZExvYWRdKToKKwogMjAyMS0wNi0xMiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVo QGFwcGxlLmNvbT4KIAogICAgICAgICBOdW1iZXIgcGFkIGJ1dHRvbiBpcyBtaXNzaW5nIGl0cyBp bWFnZSB3aGVuIHRhcHBpbmcgb24gPGlucHV0IHR5cGU9dGVsPiBpbiB3YXRjaE9TIDgKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL3dhdGNob3MvUGVwcGVyVUlDb3JlU1BJ LmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS93YXRjaG9zL1BlcHBlclVJQ29yZVNQSS5o CmluZGV4IGZlZWJlYTk2YTdjNWI5Yzg0MTIzZjVkMTgxZjY5YWU3ZWVhYzFkMzMuLjZhMzE3NTE1 NWU1YjM5NzJlMjU1NDZmNjE0NTc1MmQ5YTk2YzJkOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvUGxhdGZvcm0vc3BpL3dhdGNob3MvUGVwcGVyVUlDb3JlU1BJLmgKKysrIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9zcGkvd2F0Y2hvcy9QZXBwZXJVSUNvcmVTUEkuaApAQCAtMjE5LDYgKzIx OSw3IEBAIGV4dGVybiBVSUJ1dHRvblR5cGUgY29uc3QgUFVJQ0J1dHRvblR5cGVQaWxsOwogQHBy b3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBQVUlDVGFibGVWaWV3ICpsaXN0VmlldzsKIEBw cm9wZXJ0eSAoc3Ryb25nLCBub25hdG9taWMsIHJlYWRvbmx5KSBQVUlDUXVpY2tib2FyZExpc3RW aWV3U3BlY3MgKnNwZWNzOwogQHByb3BlcnR5IChub25hdG9taWMsIGNvcHkpIFVJVGV4dENvbnRl bnRUeXBlIHRleHRDb250ZW50VHlwZTsKKy0gKGluc3RhbmNldHlwZSlpbml0V2l0aERlbGVnYXRl OihpZCA8UFVJQ1F1aWNrYm9hcmRWaWV3Q29udHJvbGxlckRlbGVnYXRlPilkZWxlZ2F0ZSBkaWN0 YXRpb25Nb2RlOihQVUlDRGljdGF0aW9uTW9kZSlkaWN0YXRpb25Nb2RlIE5TX0RFU0lHTkFURURf SU5JVElBTElaRVI7CiAtICh2b2lkKXJlbG9hZExpc3RJdGVtczsKIC0gKHZvaWQpcmVsb2FkSGVh ZGVyQ29udGVudFZpZXc7CiBAZW5kCkBAIC0yNDgsMTIgKzI0OSw2IEBAIHR5cGVkZWYgTlNfRU5V TShOU0ludGVnZXIsIFBVSUNQaWNrZXJWaWV3U3R5bGUpIHsKIC0gKHZvaWQpcmVsb2FkRGF0YTsK IEBlbmQKIAotQHByb3RvY29sIFBVSUNEaWN0YXRpb25WaWV3Q29udHJvbGxlckRlbGVnYXRlIDxO U09iamVjdD4KLUBlbmQKLUBpbnRlcmZhY2UgUFVJQ0RpY3RhdGlvblZpZXdDb250cm9sbGVyIDog UFVJQ1F1aWNrYm9hcmRWaWV3Q29udHJvbGxlcgotLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoRGVs ZWdhdGU6KGlkPFBVSUNRdWlja2JvYXJkVmlld0NvbnRyb2xsZXJEZWxlZ2F0ZT4pZGVsZWdhdGUg ZGljdGF0aW9uTW9kZTooUFVJQ0RpY3RhdGlvbk1vZGUpZGljdGF0aW9uTW9kZSBOU19ERVNJR05B VEVEX0lOSVRJQUxJWkVSOwotQGVuZAotCiBAaW50ZXJmYWNlIFBVSUNRdWlja2JvYXJkVmlld0Nv bnRyb2xsZXIgKEV4cG9zZUhlYWRlcikKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkg VUlWaWV3ICpoZWFkZXJWaWV3OwogQGVuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL2Zvcm1zL1dLUXVpY2tib2FyZExpc3RWaWV3Q29udHJvbGxlci5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS1F1aWNrYm9hcmRMaXN0Vmlld0NvbnRyb2xs ZXIubW0KaW5kZXggYjNlMjBmZmQxMGEyNDQ5ZjIwZDA1YzJjYzdiZjJjZDI0ZjQ0NDU4OC4uZjM4 ZDc3OTNmMjNjMjQ3MGFlODY5YmVhMDU3YzcyMmE5NWUxY2JjNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLUXVpY2tib2FyZExpc3RWaWV3Q29udHJvbGxl ci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tRdWlja2JvYXJk TGlzdFZpZXdDb250cm9sbGVyLm1tCkBAIC03OCwxMyArNzgsOCBAQCBAZHluYW1pYyBkZWxlZ2F0 ZTsKIAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoRGVsZWdhdGU6KGlkIDxXS1F1aWNrYm9hcmRW aWV3Q29udHJvbGxlckRlbGVnYXRlPilkZWxlZ2F0ZQogewotI2lmIFVTRShBUFBMRV9JTlRFUk5B TF9TREspCiAgICAgaWYgKHNlbGYgPSBbc3VwZXIgaW5pdFdpdGhEZWxlZ2F0ZTpkZWxlZ2F0ZSBk aWN0YXRpb25Nb2RlOlBVSUNEaWN0YXRpb25Nb2RlVGV4dF0pCiAgICAgICAgIF9jb250ZXh0Vmll d05lZWRzVXBkYXRlID0gWUVTOwotI2Vsc2UKLSAgICBpZiAoc2VsZiA9IFtzdXBlciBpbml0V2l0 aERlbGVnYXRlOmRlbGVnYXRlXSkKLSAgICAgICAgX2NvbnRleHRWaWV3TmVlZHNVcGRhdGUgPSBZ RVM7Ci0jZW5kaWYKIAogICAgIHJldHVybiBzZWxmOwogfQpAQCAtMTA4LDEzICsxMDMsNiBAQCAt IChCT09MKXByZWZlcnNTdGF0dXNCYXJIaWRkZW4KICAgICByZXR1cm4gTk87CiB9CiAKLS0gKHZv aWQpdmlld0RpZExvYWQKLXsKLSAgICBbc3VwZXIgdmlld0RpZExvYWRdOwotCi0gICAgc2VsZi5o ZWFkZXJWaWV3LmhpZGRlbiA9IFlFUzsKLX0KLQogLSAodm9pZCl2aWV3V2lsbEFwcGVhcjooQk9P TClhbmltYXRlZAogewogICAgIFtzdXBlciB2aWV3V2lsbEFwcGVhcjphbmltYXRlZF07CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tTZWxlY3RNZW51TGlz dFZpZXdDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dL U2VsZWN0TWVudUxpc3RWaWV3Q29udHJvbGxlci5tbQppbmRleCAwMWExMGU4MTcyNjI3YTQ2ODIw ZDZiNjM1OGUwOWU3YjIxYmU5NWNkLi4yZDMwMTlmZDc0M2FiZTUzMDk2NzEyNjM3OWVjMWU4ZWJj ODJjNWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tT ZWxlY3RNZW51TGlzdFZpZXdDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9mb3Jtcy9XS1NlbGVjdE1lbnVMaXN0Vmlld0NvbnRyb2xsZXIubW0KQEAgLTIzMCw2 ICsyMzAsMTEgQEAgLSAoTlNTdHJpbmcgKilsaXN0SXRlbUNlbGxSZXVzZUlkZW50aWZpZXIKICAg ICByZXR1cm4gc2VsZWN0TWVudUNlbGxSZXVzZUlkZW50aWZpZXI7CiB9CiAKKy0gKEJPT0wpc2hv dWxkU2hvd0xhbmd1YWdlQnV0dG9uCit7CisgICAgcmV0dXJuIE5POworfQorCiAjaWYgSEFWRShR VUlDS0JPQVJEX0NPTExFQ1RJT05fVklFV1MpCiAKIC0gKENsYXNzKWxpc3RJdGVtQ2VsbENsYXNz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tUZXh0SW5w dXRMaXN0Vmlld0NvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9y bXMvV0tUZXh0SW5wdXRMaXN0Vmlld0NvbnRyb2xsZXIubW0KaW5kZXggYzAyYmVhM2ZiMjZmZjEz MjQzODUzYjFmMjhjZjY3NjQ2MDVjZGE1ZS4uMWJiMTIzYjliMWJjNmQxMDczZTAyZmU2OGU4Y2Ix MzlhOTEzN2FmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1z L1dLVGV4dElucHV0TGlzdFZpZXdDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9mb3Jtcy9XS1RleHRJbnB1dExpc3RWaWV3Q29udHJvbGxlci5tbQpAQCAtNTAs NiArNTAsMTMgQEAgLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoRGVsZWdhdGU6KGlkIDxXS1RleHRJ bnB1dExpc3RWaWV3Q29udHJvbGxlckRlbGVnYXRlPilkZWwKICAgICByZXR1cm4gc2VsZjsKIH0K IAorLSAodm9pZCl2aWV3RGlkTG9hZAoreworICAgIFtzdXBlciB2aWV3RGlkTG9hZF07CisKKyAg ICBzZWxmLmhlYWRlclZpZXcuaGlkZGVuID0gWUVTOworfQorCiAtICh2b2lkKXdpbGxQcmVzZW50 QXJvdWV0Vmlld0NvbnRyb2xsZXI6KFBVSUNRdWlja2JvYXJkQXJvdWV0Vmlld0NvbnRyb2xsZXIg KilxdWlja2JvYXJkCiB7CiAgICAgTlNTdHJpbmcgKmluaXRpYWxUZXh0ID0gW3NlbGYuZGVsZWdh dGUgaW5pdGlhbFZhbHVlRm9yVmlld0NvbnRyb2xsZXI6c2VsZl07Cg==