226948 2021-06-11 18:27:46 -0700 [JSC] Add ValueOf fast path in toPrimitive 2021-06-25 21:15:04 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 227416 227418 227419 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1769147 0 ysuzuki 2021-06-11 18:27:46 -0700 [JSC] Add ValueOf fast path in toPrimitive 1769148 1 431248 ysuzuki 2021-06-11 18:28:16 -0700 Created attachment 431248 Patch 1771069 2 webkit-bug-importer 2021-06-18 18:28:26 -0700 <rdar://problem/79515947> 1771072 3 431789 ysuzuki 2021-06-18 23:57:57 -0700 Created attachment 431789 Patch 1771128 4 431789 ross.kirsling 2021-06-19 14:15:02 -0700 Comment on attachment 431789 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431789&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + value-of-call 65.7169+-0.6192 ^ 45.0986+-0.0830 ^ definitely 1.4572x faster The name of benchmark should probably indicate that it's not just valueOf but rather "valueOf via toPrimitive". 1771156 5 ysuzuki 2021-06-20 02:45:08 -0700 (In reply to Ross Kirsling from comment #4) > Comment on attachment 431789 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431789&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:13 > > + value-of-call 65.7169+-0.6192 ^ 45.0986+-0.0830 ^ definitely 1.4572x faster > > The name of benchmark should probably indicate that it's not just valueOf > but rather "valueOf via toPrimitive". Thanks, changed. 1771157 6 ysuzuki 2021-06-20 02:48:13 -0700 Committed r279053 (238973@main): <https://commits.webkit.org/238973@main> 1772841 7 ysuzuki 2021-06-25 17:50:38 -0700 Will use this patch for webkitbot test. Please ignore following messages. 1772844 8 commit-queue 2021-06-25 17:55:43 -0700 Re-opened since this is blocked by bug 227416 1772857 9 commit-queue 2021-06-25 21:14:17 -0700 Re-opened since this is blocked by bug 227419 431248 2021-06-11 18:28:16 -0700 2021-06-18 23:57:55 -0700 Patch bug-226948-20210611182815.patch text/plain 2494 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Nzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YjQ4NzhlODk3OGZhZGQ3YWU2YzdiMDIzMjI1NzU5OTZiZjQzZGU1Li4zZWMzNTUwZjdkZGNmMDcx NjFlOGUzMTRjMmJhMDk5ZWRiZGQ0YTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMS0wNi0xMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCBWYWx1ZU9mIGZhc3QgcGF0aCBpbiB0b1ByaW1pdGl2ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2OTQ4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1l L0pTQ0pTVmFsdWUuY3BwOgorICAgICAgICAoSlNDOjpKU1ZhbHVlOjp0b1N0cmluZ1Nsb3dDYXNl IGNvbnN0KToKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6 Y2FsbFRvUHJpbWl0aXZlRnVuY3Rpb24pOgorCiAyMDIxLTA2LTExICBQYXRyaWNrIEFuZ2xlICA8 cGFuZ2xlQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgaW5zdHJ1bWVu dGF0aW9uIHRvIG5vZGUgZGVzdHJ1Y3Rpb24gZm9yIEluc3BlY3RvckRPTUFnZW50CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NKU1ZhbHVlLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWUuY3BwCmluZGV4IDc5YjU1YzQ4ZTNh ZjdkOTlhMjg2MGQyZGQyZWNlMDUwOWVhZDQyMDMuLjc2N2I1NzE4MWU3ZGFlOGYyYmI4MTg4YTBi MTlkYzNlNDM2ZTI5MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTQ0pTVmFsdWUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pT VmFsdWUuY3BwCkBAIC00MzQsOCArNDM0LDggQEAgSlNTdHJpbmcqIEpTVmFsdWU6OnRvU3RyaW5n U2xvd0Nhc2UoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgYm9vbCByZXR1cm5FbXAKICAg ICAgICAgcmV0dXJuIGVycm9yVmFsdWUoKTsKICAgICB9CiAKLSAgICBBU1NFUlQoaXNDZWxsKCkp OwotICAgIEpTVmFsdWUgdmFsdWUgPSBhc0NlbGwoKS0+dG9QcmltaXRpdmUoZ2xvYmFsT2JqZWN0 LCBQcmVmZXJTdHJpbmcpOworICAgIEFTU0VSVChpc09iamVjdCgpKTsgLy8gU3RyaW5nLCBTeW1i b2wsIGFuZCBIZWFwQmlnSW50IGFyZSBhbHJlYWR5IGZpbHRlcmVkIG91dC4KKyAgICBKU1ZhbHVl IHZhbHVlID0gYXNPYmplY3QoYXNDZWxsKCkpLT50b1ByaW1pdGl2ZShnbG9iYWxPYmplY3QsIFBy ZWZlclN0cmluZyk7CiAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZXJyb3JWYWx1ZSgp KTsKICAgICBBU1NFUlQoIXZhbHVlLmlzT2JqZWN0KCkpOwogICAgIEpTU3RyaW5nKiByZXN1bHQg PSB2YWx1ZS50b1N0cmluZyhnbG9iYWxPYmplY3QpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNPYmplY3QuY3BwCmluZGV4IGE0MjU2YmUyMGNjNGU5MDkyNTJkNTFmZDEzYzRiZTYw NzI4OWM0NTEuLjU2NGE4ZTc3YjcyNjU4ZDY1ZmZkNzM4OWRhYzA5YTAwMGJkMjZhMmEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKQEAgLTQ0LDYgKzQ0LDcg QEAKICNpbmNsdWRlICJWTUlubGluZXMuaCIKICNpbmNsdWRlICJWTVRyYXBzSW5saW5lcy5oIgog I2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisjaW5jbHVkZSA8d3RmL1N0YWNrVHJhY2UuaD4K IAogbmFtZXNwYWNlIEpTQyB7CiAKQEAgLTIyMzMsNiArMjIzNCwxMCBAQCBzdGF0aWMgQUxXQVlT X0lOTElORSBKU1ZhbHVlIGNhbGxUb1ByaW1pdGl2ZUZ1bmN0aW9uKEpTR2xvYmFsT2JqZWN0KiBn bG9iYWxPYmplYwogICAgICAgICAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgICAgIH0KICAg ICB9CisgICAgaWYgY29uc3RleHByIChrZXkgPT0gQ2FjaGVkU3BlY2lhbFByb3BlcnR5S2V5OjpW YWx1ZU9mKSB7CisgICAgICAgIGlmIChmdW5jdGlvbiA9PSBnbG9iYWxPYmplY3QtPm9iamVjdFBy b3RvVmFsdWVPZkZ1bmN0aW9uKCkpCisgICAgICAgICAgICByZXR1cm4gb2JqZWN0OworICAgIH0K IAogICAgIGF1dG8gY2FsbERhdGEgPSBnZXRDYWxsRGF0YSh2bSwgZnVuY3Rpb24pOwogICAgIGlm IChjYWxsRGF0YS50eXBlID09IENhbGxEYXRhOjpUeXBlOjpOb25lKSB7Cg== 431789 2021-06-18 23:57:57 -0700 2021-06-19 14:15:02 -0700 Patch bug-226948-20210618235756.patch text/plain 3762 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZTE5ZTFjZTQ1NGVhYjdhNDBkM2JjMTkzYjNhMmI4NWFhMjMzMDYyLi5jMWM1MTljMjhkNTAxZTNh NjZlMTBiMDIzNjUzMzQxZTVmMWU2NDA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMS0wNi0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCBWYWx1ZU9mIGZhc3QgcGF0aCBpbiB0b1ByaW1pdGl2ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2OTQ4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGZhc3Qg cGF0aCBmb3IgT2JqZWN0LnByb3RvdHlwZS52YWx1ZU9mIGZ1bmN0aW9uIGNhbGwgc2luY2Ugd2UK KyAgICAgICAgc29tZXRpbWVzIGVuY291bnRlciB0aGlzIGNhc2UgaW4gU3BlZWRvbWV0ZXIyL0Vt YmVySlMtRGVidWctVG9kb01WQy4KKworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgVG9UICAgICAgICAgICAgICAgICAgICAgUGF0Y2hlZAorCisgICAgICAgICAgICB2YWx1 ZS1vZi1jYWxsICAgICAgICA2NS43MTY5Ky0wLjYxOTIgICAgIF4gICAgIDQ1LjA5ODYrLTAuMDgz MCAgICAgICAgXiBkZWZpbml0ZWx5IDEuNDU3MnggZmFzdGVyCisKKyAgICAgICAgKiBydW50aW1l L0pTQ0pTVmFsdWUuY3BwOgorICAgICAgICAoSlNDOjpKU1ZhbHVlOjp0b1N0cmluZ1Nsb3dDYXNl IGNvbnN0KToKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6 Y2FsbFRvUHJpbWl0aXZlRnVuY3Rpb24pOgorCiAyMDIxLTA2LTE3ICBGdWppaSBIaXJvbm9yaSAg PEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFJlaW1wbGVtZW50IEpTQzo6Q2Fj aGVQYXlsb2FkIHdpdGhvdXQgRmlsZVN5c3RlbTo6dW5tYXBWaWV3T2ZGaWxlIGFuZCBGaWxlU3lz dGVtOjpNYXBwZWRGaWxlRGF0YTo6bGVha0hhbmRsZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0NKU1ZhbHVlLmNwcAppbmRleCA3OWI1NWM0OGUzYWY3ZDk5YTI4NjBkMmRkMmVj ZTA1MDllYWQ0MjAzLi5iMjk0YTM2M2EyYzBlNTNiZjc3N2NmODRiYTgxMzIzODRmYzc2NjFlIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NKU1ZhbHVlLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NKU1ZhbHVlLmNwcApAQCAtNDM0 LDggKzQzNCw4IEBAIEpTU3RyaW5nKiBKU1ZhbHVlOjp0b1N0cmluZ1Nsb3dDYXNlKEpTR2xvYmFs T2JqZWN0KiBnbG9iYWxPYmplY3QsIGJvb2wgcmV0dXJuRW1wCiAgICAgICAgIHJldHVybiBlcnJv clZhbHVlKCk7CiAgICAgfQogCi0gICAgQVNTRVJUKGlzQ2VsbCgpKTsKLSAgICBKU1ZhbHVlIHZh bHVlID0gYXNDZWxsKCktPnRvUHJpbWl0aXZlKGdsb2JhbE9iamVjdCwgUHJlZmVyU3RyaW5nKTsK KyAgICBBU1NFUlQoaXNPYmplY3QoKSk7IC8vIFN0cmluZywgU3ltYm9sLCBhbmQgSGVhcEJpZ0lu dCBhcmUgYWxyZWFkeSBoYW5kbGVkLgorICAgIEpTVmFsdWUgdmFsdWUgPSBhc09iamVjdChhc0Nl bGwoKSktPnRvUHJpbWl0aXZlKGdsb2JhbE9iamVjdCwgUHJlZmVyU3RyaW5nKTsKICAgICBSRVRV Uk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlcnJvclZhbHVlKCkpOwogICAgIEFTU0VSVCghdmFsdWUu aXNPYmplY3QoKSk7CiAgICAgSlNTdHJpbmcqIHJlc3VsdCA9IHZhbHVlLnRvU3RyaW5nKGdsb2Jh bE9iamVjdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09i amVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKaW5k ZXggYTQyNTZiZTIwY2M0ZTkwOTI1MmQ1MWZkMTNjNGJlNjA3Mjg5YzQ1MS4uMGIxOWNjYjY0NzA5 N2U3NGEyYjA1YTc4NGE4N2M1OWExOTgxMzQzYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTT2JqZWN0LmNwcApAQCAtMjIzNCw2ICsyMjM0LDExIEBAIHN0YXRpYyBBTFdBWVNf SU5MSU5FIEpTVmFsdWUgY2FsbFRvUHJpbWl0aXZlRnVuY3Rpb24oSlNHbG9iYWxPYmplY3QqIGds b2JhbE9iamVjCiAgICAgICAgIH0KICAgICB9CiAKKyAgICBpZiBjb25zdGV4cHIgKGtleSA9PSBD YWNoZWRTcGVjaWFsUHJvcGVydHlLZXk6OlZhbHVlT2YpIHsKKyAgICAgICAgaWYgKGZ1bmN0aW9u ID09IGdsb2JhbE9iamVjdC0+b2JqZWN0UHJvdG9WYWx1ZU9mRnVuY3Rpb24oKSkKKyAgICAgICAg ICAgIHJldHVybiBKU1ZhbHVlKCk7CisgICAgfQorCiAgICAgYXV0byBjYWxsRGF0YSA9IGdldENh bGxEYXRhKHZtLCBmdW5jdGlvbik7CiAgICAgaWYgKGNhbGxEYXRhLnR5cGUgPT0gQ2FsbERhdGE6 OlR5cGU6Ok5vbmUpIHsKICAgICAgICAgaWYgY29uc3RleHByIChrZXkgPT0gQ2FjaGVkU3BlY2lh bFByb3BlcnR5S2V5OjpUb1ByaW1pdGl2ZSkKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9n IGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjgwNDY2ZGM0ZDRmYTEwNDlmZWUwY2U5MjQ3Y2I2 NjA0ZmRlOTUwNy4uZGQwZDI4ZjQ2MzYwOTU5NjRkZmEwNzM0OTMzN2M2YmZiNGEzYWVlZCAxMDA2 NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAyMS0wNi0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCBWYWx1ZU9mIGZhc3QgcGF0aCBpbiB0b1ByaW1pdGl2ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2OTQ4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtaWNyb2Jl bmNobWFya3MvdmFsdWUtb2YtY2FsbC5qczogQWRkZWQuCisKIDIwMjEtMDYtMTYgIFRhZGV1IFph Z2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQXNzZW1ibHlIZWxwZXJzIHNo b3VsZCBzYXZlL3Jlc3RvcmUgY2FsbGVlIHNhdmUgRlBScwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9t aWNyb2JlbmNobWFya3MvdmFsdWUtb2YtY2FsbC5qcyBiL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtz L3ZhbHVlLW9mLWNhbGwuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTJlY2NkYzc3MGVlNGRiMTMyYmQ5NDVhMzYw YjcwNDViYmM1YzAzOQotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtz L3ZhbHVlLW9mLWNhbGwuanMKQEAgLTAsMCArMSw4IEBACit2YXIgYXJyYXkgPSBbXTsKK2Z1bmN0 aW9uIHRlc3QoZGF0YSkgeworICAgIHJldHVybiBOdW1iZXIoZGF0YSk7Cit9Citub0lubGluZSh0 ZXN0KTsKKworZm9yICh2YXIgaSA9IDA7IGkgPCAxZTY7ICsraSkKKyAgICB0ZXN0KGFycmF5KTsK