226947 2021-06-11 18:07:53 -0700 WebXR tests often fail due to running out of GraphicsContextGLs 2021-06-13 11:43:19 -0700 1 1 1 Unclassified WebKit WebXR Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam dino ifernandez webkit-bug-importer oldest_to_newest 1769141 0 sam 2021-06-11 18:07:53 -0700 SimulatedXRDevice::shutDownTrackingAndRendering() should clear its GraphicsContextGL to ensure the resource is cleaned up quickly, and doesn't wait for GC to be reclaimed. Without this, we can run out of GraphicsContextGLs (e.g. GraphicsContextGLOpenGLManager::hasTooManyContexts()) and fail tests if GC happens to be running a bit behind. 1769142 1 431247 sam 2021-06-11 18:09:29 -0700 Created attachment 431247 Patch 1769143 2 sam 2021-06-11 18:15:16 -0700 The test I used for this was: `run-webkit-tests imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_immersive.https.html --repeat=40` Prior to this change it would fail periodically, now it passes 100%. 1769286 3 ews-feeder 2021-06-13 11:42:52 -0700 Committed r278820 (238773@main): <https://commits.webkit.org/238773@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431247. 1769287 4 webkit-bug-importer 2021-06-13 11:43:19 -0700 <rdar://problem/79263505> 431247 2021-06-11 18:09:29 -0700 2021-06-13 11:42:53 -0700 Patch bug-226947-20210611180928.patch text/plain 1511 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODgwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTExICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBTaW11bGF0ZWRYUkRldmljZTo6c2h1 dERvd25UcmFja2luZ0FuZFJlbmRlcmluZygpIHNob3VsZCBjbGVhciBpdCdzIEdyYXBoaWNzQ29u dGV4dEdMIHRvIGVuc3VyZSB0aGUgcmVzb3VyY2UgaXMgY2xlYW5lZCB1cCBxdWlja2x5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5NDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW11bGF0ZWRYUkRl dmljZTo6c2h1dERvd25UcmFja2luZ0FuZFJlbmRlcmluZygpIG5lZWRzIHRvIGNsZWFyIGl0cyBH cmFwaGljc0NvbnRleHRHTAorICAgICAgICB0byBlbnN1cmUgdGhlIHJlc291cmNlIGlzIGNsZWFu ZWQgdXAgcXVpY2tseSwgYW5kIGRvZXNuJ3Qgd2FpdCBmb3IgR0MgdG8gYmUgcmVjbGFpbWVkLiAK KyAgICAgICAgV2l0aG91dCB0aGlzLCB3ZSBjYW4gcnVuIG91dCBvZiBHcmFwaGljc0NvbnRleHRH THMgYW5kIGZhaWwgdGVzdHMgaWYgR0MgaGFwcGVucyB0byBiZQorICAgICAgICBydW5uaW5nIGEg Yml0IGJlaGluZC4KKworICAgICAgICAqIHRlc3RpbmcvV2ViRmFrZVhSRGV2aWNlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNpbXVsYXRlZFhSRGV2aWNlOjpzaHV0RG93blRyYWNraW5nQW5kUmVu ZGVyaW5nKToKKwogMjAyMS0wNi0xMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIFBhcnRpdGlvbiBDcm9zc09yaWdpblByZWZsaWdodFJlc3Vs dENhY2hlIGJ5IFNlc3Npb25JRApJbmRleDogU291cmNlL1dlYkNvcmUvdGVzdGluZy9XZWJGYWtl WFJEZXZpY2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvV2ViRmFr ZVhSRGV2aWNlLmNwcAkocmV2aXNpb24gMjc4NzYzKQorKysgU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9XZWJGYWtlWFJEZXZpY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMsNiArMTMzLDcgQEAg dm9pZCBTaW11bGF0ZWRYUkRldmljZTo6c2h1dERvd25UcmFja2luZwogICAgIGlmIChtX2dsKSB7 CiAgICAgICAgIGZvciAoYXV0byBsYXllciA6IG1fbGF5ZXJzKQogICAgICAgICAgICAgbV9nbC0+ ZGVsZXRlVGV4dHVyZShsYXllci52YWx1ZSk7CisgICAgICAgIG1fZ2wgPSBudWxscHRyOwogICAg IH0KICAgICBtX2xheWVycy5jbGVhcigpOwogfQo=