226943 2021-06-11 15:27:44 -0700 Use SharedBuffer!=() in CachedResource::tryReplaceEncodedData() 2021-06-11 16:37:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ews-watchlist ggaren japhet koivisto sam webkit-bug-importer oldest_to_newest 1769091 0 cdumez 2021-06-11 15:27:44 -0700 Use SharedBuffer!=() in CachedResource::tryReplaceEncodedData() instead of duplicating its logic. SharedBuffer==() is also potentially more efficient since it doesn't requires combining the SharedBuffers' data segments. 1769092 1 431235 cdumez 2021-06-11 15:29:14 -0700 Created attachment 431235 Patch 1769093 2 431235 ggaren 2021-06-11 15:32:06 -0700 Comment on attachment 431235 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431235&action=review r=me > Source/WebCore/loader/cache/CachedResource.cpp:917 > + // We have to do the compare the buffers because we can't tell if the replacement file backed data is for the to do the compare the buffers => compare the buffers 1769097 3 431236 cdumez 2021-06-11 15:33:30 -0700 Created attachment 431236 Patch 1769120 4 ews-feeder 2021-06-11 16:36:40 -0700 Committed r278793 (238750@main): <https://commits.webkit.org/238750@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431236. 1769121 5 webkit-bug-importer 2021-06-11 16:37:19 -0700 <rdar://problem/79222229> 431235 2021-06-11 15:29:14 -0700 2021-06-11 15:33:29 -0700 Patch bug-226943-20210611152914.patch text/plain 2138 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE4ODdiNGI3OGQ4YWM1 YmM3MWRhMTgwMTVmYjgyM2NmMGIwYjZhYS4uZmY0YzlmOTJlZGQ4NGJhMjIxY2EzYWM5NDVjNjM1 Njk3MmU2N2UyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA2LTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFNoYXJlZEJ1ZmZlciE9 KCkgaW4gQ2FjaGVkUmVzb3VyY2U6OnRyeVJlcGxhY2VFbmNvZGVkRGF0YSgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5NDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgU2hhcmVkQnVmZmVyIT0o KSBpbiBDYWNoZWRSZXNvdXJjZTo6dHJ5UmVwbGFjZUVuY29kZWREYXRhKCkgaW5zdGVhZCBvZiBk dXBsaWNhdGluZyBpdHMgbG9naWMuCisgICAgICAgIFNoYXJlZEJ1ZmZlciE9KCkgaXMgYWxzbyBw b3RlbnRpYWxseSBtb3JlIGVmZmljaWVudCBzaW5jZSBpdCBkb2Vzbid0IHJlcXVpcmVzIGNvbWJp bmluZyB0aGUKKyAgICAgICAgU2hhcmVkQnVmZmVycycgZGF0YSBzZWdtZW50cy4KKworICAgICAg ICAqIGxvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD YWNoZWRSZXNvdXJjZTo6dHJ5UmVwbGFjZUVuY29kZWREYXRhKToKKwogMjAyMS0wNi0xMSAgWXVz dWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBmYXN0LXBhdGgg Zm9yIGJpbmRpbmcgc2VjdXJpdHkgY2hlY2sgb2YgRE9NV2luZG93CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAppbmRleCBiZWY5ZTdkYzViMTZlODUw MTY1MGRkZWU2ZWQwYmQyZjhjMWJhNzFjLi42NzE3NzE0ZmEwODY4N2ZlOGZhNTM1MDU4YTY4ZWJm MTYyYzk0YzAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVk UmVzb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNv dXJjZS5jcHAKQEAgLTkxNCwxMCArOTE0LDEwIEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2U6OnRyeVJl cGxhY2VFbmNvZGVkRGF0YShTaGFyZWRCdWZmZXImIG5ld0J1ZmZlcikKICAgICBpZiAoIW1heVRy eVJlcGxhY2VFbmNvZGVkRGF0YSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICAvLyBXZSBoYXZl IHRvIGRvIHRoZSBtZW1jbXAgYmVjYXVzZSB3ZSBjYW4ndCB0ZWxsIGlmIHRoZSByZXBsYWNlbWVu dCBmaWxlIGJhY2tlZCBkYXRhIGlzIGZvciB0aGUKLSAgICAvLyBzYW1lIHJlc291cmNlIG9yIGlm IHdlIG1hZGUgYSBzZWNvbmQgcmVxdWVzdCB3aXRoIHRoZSBzYW1lIFVSTCB3aGljaCBnYXZlIHVz IGEgZGlmZmVyZW50Ci0gICAgLy8gcmVzb3VyY2UuIFdlIGhhdmUgc2VlbiB0aGlzIGhhcHBlbiBm b3IgY2FjaGVkIFBPU1QgcmVzb3VyY2VzLgotICAgIGlmIChtX2RhdGEtPnNpemUoKSAhPSBuZXdC dWZmZXIuc2l6ZSgpIHx8IG1lbWNtcChtX2RhdGEtPmRhdGEoKSwgbmV3QnVmZmVyLmRhdGEoKSwg bV9kYXRhLT5zaXplKCkpKQorICAgIC8vIFdlIGhhdmUgdG8gZG8gdGhlIGNvbXBhcmUgdGhlIGJ1 ZmZlcnMgYmVjYXVzZSB3ZSBjYW4ndCB0ZWxsIGlmIHRoZSByZXBsYWNlbWVudCBmaWxlIGJhY2tl ZCBkYXRhIGlzIGZvciB0aGUKKyAgICAvLyBzYW1lIHJlc291cmNlIG9yIGlmIHdlIG1hZGUgYSBz ZWNvbmQgcmVxdWVzdCB3aXRoIHRoZSBzYW1lIFVSTCB3aGljaCBnYXZlIHVzIGEgZGlmZmVyZW50 IHJlc291cmNlLiBXZSBoYXZlCisgICAgLy8gc2VlbiB0aGlzIGhhcHBlbiBmb3IgY2FjaGVkIFBP U1QgcmVzb3VyY2VzLgorICAgIGlmICgqbV9kYXRhICE9IG5ld0J1ZmZlcikKICAgICAgICAgcmV0 dXJuOwogCiAgICAgbV9kYXRhLT5jbGVhcigpOwo= 431236 2021-06-11 15:33:30 -0700 2021-06-11 16:36:42 -0700 Patch bug-226943-20210611153330.patch text/plain 2128 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE4ODdiNGI3OGQ4YWM1 YmM3MWRhMTgwMTVmYjgyM2NmMGIwYjZhYS4uZGYzNGI5MmM0YmMwMWFkYmUyNTYwODFkMjE3Y2Zh M2IzYzllYWUxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA2LTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFNoYXJlZEJ1ZmZlciE9 KCkgaW4gQ2FjaGVkUmVzb3VyY2U6OnRyeVJlcGxhY2VFbmNvZGVkRGF0YSgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5NDMKKworICAgICAgICBS ZXZpZXdlZCBieSBHZW9mZiBHYXJlbi4KKworICAgICAgICBVc2UgU2hhcmVkQnVmZmVyIT0oKSBp biBDYWNoZWRSZXNvdXJjZTo6dHJ5UmVwbGFjZUVuY29kZWREYXRhKCkgaW5zdGVhZCBvZiBkdXBs aWNhdGluZyBpdHMgbG9naWMuCisgICAgICAgIFNoYXJlZEJ1ZmZlciE9KCkgaXMgYWxzbyBwb3Rl bnRpYWxseSBtb3JlIGVmZmljaWVudCBzaW5jZSBpdCBkb2Vzbid0IHJlcXVpcmVzIGNvbWJpbmlu ZyB0aGUKKyAgICAgICAgU2hhcmVkQnVmZmVycycgZGF0YSBzZWdtZW50cy4KKworICAgICAgICAq IGxvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWNo ZWRSZXNvdXJjZTo6dHJ5UmVwbGFjZUVuY29kZWREYXRhKToKKwogMjAyMS0wNi0xMSAgWXVzdWtl IFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBmYXN0LXBhdGggZm9y IGJpbmRpbmcgc2VjdXJpdHkgY2hlY2sgb2YgRE9NV2luZG93CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAppbmRleCBiZWY5ZTdkYzViMTZlODUwMTY1 MGRkZWU2ZWQwYmQyZjhjMWJhNzFjLi4yMDM4OWUxODA0ODJlNGNlY2QzOWFmNzFkNmFhZTcwYmIw Nzc3OTIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVz b3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJj ZS5jcHAKQEAgLTkxNCwxMCArOTE0LDEwIEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2U6OnRyeVJlcGxh Y2VFbmNvZGVkRGF0YShTaGFyZWRCdWZmZXImIG5ld0J1ZmZlcikKICAgICBpZiAoIW1heVRyeVJl cGxhY2VFbmNvZGVkRGF0YSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICAvLyBXZSBoYXZlIHRv IGRvIHRoZSBtZW1jbXAgYmVjYXVzZSB3ZSBjYW4ndCB0ZWxsIGlmIHRoZSByZXBsYWNlbWVudCBm aWxlIGJhY2tlZCBkYXRhIGlzIGZvciB0aGUKLSAgICAvLyBzYW1lIHJlc291cmNlIG9yIGlmIHdl IG1hZGUgYSBzZWNvbmQgcmVxdWVzdCB3aXRoIHRoZSBzYW1lIFVSTCB3aGljaCBnYXZlIHVzIGEg ZGlmZmVyZW50Ci0gICAgLy8gcmVzb3VyY2UuIFdlIGhhdmUgc2VlbiB0aGlzIGhhcHBlbiBmb3Ig Y2FjaGVkIFBPU1QgcmVzb3VyY2VzLgotICAgIGlmIChtX2RhdGEtPnNpemUoKSAhPSBuZXdCdWZm ZXIuc2l6ZSgpIHx8IG1lbWNtcChtX2RhdGEtPmRhdGEoKSwgbmV3QnVmZmVyLmRhdGEoKSwgbV9k YXRhLT5zaXplKCkpKQorICAgIC8vIFdlIGhhdmUgdG8gY29tcGFyZSB0aGUgYnVmZmVycyBiZWNh dXNlIHdlIGNhbid0IHRlbGwgaWYgdGhlIHJlcGxhY2VtZW50IGZpbGUgYmFja2VkIGRhdGEgaXMg Zm9yIHRoZQorICAgIC8vIHNhbWUgcmVzb3VyY2Ugb3IgaWYgd2UgbWFkZSBhIHNlY29uZCByZXF1 ZXN0IHdpdGggdGhlIHNhbWUgVVJMIHdoaWNoIGdhdmUgdXMgYSBkaWZmZXJlbnQgcmVzb3VyY2Uu CisgICAgLy8gV2UgaGF2ZSBzZWVuIHRoaXMgaGFwcGVuIGZvciBjYWNoZWQgUE9TVCByZXNvdXJj ZXMuCisgICAgaWYgKCptX2RhdGEgIT0gbmV3QnVmZmVyKQogICAgICAgICByZXR1cm47CiAKICAg ICBtX2RhdGEtPmNsZWFyKCk7Cg==