22694 2008-12-05 13:58:51 -0800 [GTK] Back / Forward history menus are flipped 2009-02-23 02:01:04 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 0 elle.uca jmalonzo jmalonzo reinouts oldest_to_newest 101555 0 elle.uca 2008-12-05 13:58:51 -0800 Using epiphany-webkit, in Back toolbutton menu lists the previous visited pages are in reverse order, i.e. the previous one is the last enty of the list Example: * go to google.com * go to yahoo.com * go to gnome.org * go to kde.org Expected result: The menu obtained clicking on Back toolbutton arrow should be 1) gnome.org 2) yahoo.com 3) google.com Current results The menu is instead: 1) google.com 2) yahoo.com 3) gnome.org Origianally reported here http://bugzilla.gnome.org/show_bug.cgi?id=562553 101558 1 jmalonzo 2008-12-05 14:02:13 -0800 Thanks Luca. I'll work on this. 110459 2 27848 jmalonzo 2009-02-20 20:13:08 -0800 Created attachment 27848 don't call g_list_reverse when returning the back or forward list 110557 3 jmalonzo 2009-02-23 02:01:04 -0800 Thanks Mark. Landed in r41137 27848 2009-02-20 20:13:08 -0800 2009-02-23 01:14:49 -0800 don't call g_list_reverse when returning the back or forward list 22694.patch text/plain 6902 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggM2FkMWE0My4uYTI2ODFlZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wMi0yMCAg SmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBCYWNrIC8gRm9yd2FyZCBo aXN0b3J5IG1lbnVzIGFyZSBmbGlwcGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjY5NAorCisgICAgICAgIERvbid0IGNhbGwgZ19saXN0X3JldmVy c2Ugd2hlbiByZXR1cm5pbmcgdGhlIGJhY2sgb3IgZm9yd2FyZCBsaXN0LgorCisgICAgICAgICog dGVzdHMvbWFpbi5jOgorICAgICAgICAodGVzdF93ZWJraXRfd2ViX2JhY2tfZm9yd2FyZF9saXN0 X29yZGVyKToKKyAgICAgICAgKG1haW4pOgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJiYWNr Zm9yd2FyZGxpc3QuY3BwOgorICAgICAgICAoX1dlYktpdFdlYkJhY2tGb3J3YXJkTGlzdFByaXZh dGU6OndlYmtpdF93ZWJfYmFja19mb3J3YXJkX2xpc3RfZ2V0X2ZvcndhcmRfbGlzdF93aXRoX2xp bWl0KToKKyAgICAgICAgKF9XZWJLaXRXZWJCYWNrRm9yd2FyZExpc3RQcml2YXRlOjp3ZWJraXRf d2ViX2JhY2tfZm9yd2FyZF9saXN0X2dldF9iYWNrX2xpc3Rfd2l0aF9saW1pdCk6CisKIDIwMDkt MDItMTcgIFhhbiBMb3BleiAgPHhhbkBnbm9tZS5vcmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1w ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvdGVzdHMv bWFpbi5jIGIvV2ViS2l0L2d0ay90ZXN0cy9tYWluLmMKaW5kZXggZTE1MTY1OS4uNWNkZWQ4ZSAx MDA2NDQKLS0tIGEvV2ViS2l0L2d0ay90ZXN0cy9tYWluLmMKKysrIGIvV2ViS2l0L2d0ay90ZXN0 cy9tYWluLmMKQEAgLTYzLDYgKzYzLDk4IEBAIHN0YXRpYyB2b2lkIHRlc3Rfd2Via2l0X3dlYl9m cmFtZV9saWZldGltZSh2b2lkKQogfQogCiBzdGF0aWMgdm9pZAordGVzdF93ZWJraXRfd2ViX2Jh Y2tfZm9yd2FyZF9saXN0X29yZGVyKHZvaWQpCit7CisgICAgV2ViS2l0V2ViVmlldyogd2ViVmll dzsKKyAgICBXZWJLaXRXZWJCYWNrRm9yd2FyZExpc3QqIHdlYkJhY2tGb3J3YXJkTGlzdDsKKyAg ICBXZWJLaXRXZWJIaXN0b3J5SXRlbSogaXRlbTE7CisgICAgV2ViS2l0V2ViSGlzdG9yeUl0ZW0q IGl0ZW0yOworICAgIFdlYktpdFdlYkhpc3RvcnlJdGVtKiBpdGVtMzsKKyAgICBXZWJLaXRXZWJI aXN0b3J5SXRlbSogaXRlbTQ7CisgICAgV2ViS2l0V2ViSGlzdG9yeUl0ZW0qIGN1cnJlbnRJdGVt OworICAgIEdMaXN0KiBiYWNrTGlzdCA9IE5VTEw7CisgICAgR0xpc3QqIGZvcndhcmRMaXN0ID0g TlVMTDsKKyAgICBnX3Rlc3RfYnVnKCIyMjY5NCIpOworCisgICAgd2ViVmlldyA9IFdFQktJVF9X RUJfVklFVyh3ZWJraXRfd2ViX3ZpZXdfbmV3KCkpOworICAgIGdfb2JqZWN0X3JlZl9zaW5rKHdl YlZpZXcpOworCisgICAgd2Via2l0X3dlYl92aWV3X3NldF9tYWludGFpbnNfYmFja19mb3J3YXJk X2xpc3Qod2ViVmlldywgVFJVRSk7CisgICAgd2ViQmFja0ZvcndhcmRMaXN0ID0gd2Via2l0X3dl Yl92aWV3X2dldF9iYWNrX2ZvcndhcmRfbGlzdCh3ZWJWaWV3KTsKKyAgICBnX2Fzc2VydCh3ZWJC YWNrRm9yd2FyZExpc3QpOworCisgICAgLy8gQ2hlY2sgdGhhdCB0aGVyZSBpcyBubyBpdGVtLgor ICAgIGdfYXNzZXJ0KCF3ZWJraXRfd2ViX2JhY2tfZm9yd2FyZF9saXN0X2dldF9jdXJyZW50X2l0 ZW0od2ViQmFja0ZvcndhcmRMaXN0KSk7CisgICAgZ19hc3NlcnRfY21waW50KHdlYmtpdF93ZWJf YmFja19mb3J3YXJkX2xpc3RfZ2V0X2ZvcndhcmRfbGVuZ3RoKHdlYkJhY2tGb3J3YXJkTGlzdCks ID09LCAwKTsKKyAgICBnX2Fzc2VydF9jbXBpbnQod2Via2l0X3dlYl9iYWNrX2ZvcndhcmRfbGlz dF9nZXRfYmFja19sZW5ndGgod2ViQmFja0ZvcndhcmRMaXN0KSwgPT0sIDApOworICAgIGdfYXNz ZXJ0KCF3ZWJraXRfd2ViX3ZpZXdfY2FuX2dvX2ZvcndhcmQod2ViVmlldykpOworICAgIGdfYXNz ZXJ0KCF3ZWJraXRfd2ViX3ZpZXdfY2FuX2dvX2JhY2sod2ViVmlldykpOworCisgICAgLy8gQWRk IGEgbmV3IGl0ZW1zCisgICAgaXRlbTEgPSB3ZWJraXRfd2ViX2hpc3RvcnlfaXRlbV9uZXdfd2l0 aF9kYXRhKCJodHRwOi8vZXhhbXBsZS5jb20vMS8iLCAiU2l0ZSAxIik7CisgICAgd2Via2l0X3dl Yl9iYWNrX2ZvcndhcmRfbGlzdF9hZGRfaXRlbSh3ZWJCYWNrRm9yd2FyZExpc3QsIGl0ZW0xKTsK KyAgICBnX2Fzc2VydCh3ZWJraXRfd2ViX2JhY2tfZm9yd2FyZF9saXN0X2NvbnRhaW5zX2l0ZW0o d2ViQmFja0ZvcndhcmRMaXN0LCBpdGVtMSkpOworCisgICAgaXRlbTIgPSB3ZWJraXRfd2ViX2hp c3RvcnlfaXRlbV9uZXdfd2l0aF9kYXRhKCJodHRwOi8vZXhhbXBsZS5jb20vMi8iLCAiU2l0ZSAy Iik7CisgICAgd2Via2l0X3dlYl9iYWNrX2ZvcndhcmRfbGlzdF9hZGRfaXRlbSh3ZWJCYWNrRm9y d2FyZExpc3QsIGl0ZW0yKTsKKyAgICBnX2Fzc2VydCh3ZWJraXRfd2ViX2JhY2tfZm9yd2FyZF9s aXN0X2NvbnRhaW5zX2l0ZW0od2ViQmFja0ZvcndhcmRMaXN0LCBpdGVtMikpOworCisgICAgaXRl bTMgPSB3ZWJraXRfd2ViX2hpc3RvcnlfaXRlbV9uZXdfd2l0aF9kYXRhKCJodHRwOi8vZXhhbXBs ZS5jb20vMy8iLCAiU2l0ZSAzIik7CisgICAgd2Via2l0X3dlYl9iYWNrX2ZvcndhcmRfbGlzdF9h ZGRfaXRlbSh3ZWJCYWNrRm9yd2FyZExpc3QsIGl0ZW0zKTsKKyAgICBnX2Fzc2VydCh3ZWJraXRf d2ViX2JhY2tfZm9yd2FyZF9saXN0X2NvbnRhaW5zX2l0ZW0od2ViQmFja0ZvcndhcmRMaXN0LCBp dGVtMykpOworCisgICAgaXRlbTQgPSB3ZWJraXRfd2ViX2hpc3RvcnlfaXRlbV9uZXdfd2l0aF9k YXRhKCJodHRwOi8vZXhhbXBsZS5jb20vNC8iLCAiU2l0ZSA0Iik7CisgICAgd2Via2l0X3dlYl9i YWNrX2ZvcndhcmRfbGlzdF9hZGRfaXRlbSh3ZWJCYWNrRm9yd2FyZExpc3QsIGl0ZW00KTsKKyAg ICBnX2Fzc2VydCh3ZWJraXRfd2ViX2JhY2tfZm9yd2FyZF9saXN0X2NvbnRhaW5zX2l0ZW0od2Vi QmFja0ZvcndhcmRMaXN0LCBpdGVtNCkpOworCisgICAgLy8gY2hlY2sgdGhlIGJhY2sgbGlzdCBv cmRlcgorICAgIGJhY2tMaXN0ID0gd2Via2l0X3dlYl9iYWNrX2ZvcndhcmRfbGlzdF9nZXRfYmFj a19saXN0X3dpdGhfbGltaXQod2ViQmFja0ZvcndhcmRMaXN0LCA1KTsKKyAgICBnX2Fzc2VydChi YWNrTGlzdCk7CisKKyAgICBjdXJyZW50SXRlbSA9IFdFQktJVF9XRUJfSElTVE9SWV9JVEVNKGJh Y2tMaXN0LT5kYXRhKTsKKyAgICBnX2Fzc2VydF9jbXBzdHIod2Via2l0X3dlYl9oaXN0b3J5X2l0 ZW1fZ2V0X3VyaShjdXJyZW50SXRlbSksID09LCAiaHR0cDovL2V4YW1wbGUuY29tLzMvIik7Cisg ICAgZ19hc3NlcnRfY21wc3RyKHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX2dldF90aXRsZShjdXJy ZW50SXRlbSksID09LCAiU2l0ZSAzIik7CisgICAgYmFja0xpc3QgPSBiYWNrTGlzdC0+bmV4dDsK KworICAgIGN1cnJlbnRJdGVtID0gV0VCS0lUX1dFQl9ISVNUT1JZX0lURU0oYmFja0xpc3QtPmRh dGEpOworICAgIGdfYXNzZXJ0X2NtcHN0cih3ZWJraXRfd2ViX2hpc3RvcnlfaXRlbV9nZXRfdXJp KGN1cnJlbnRJdGVtKSwgPT0sICJodHRwOi8vZXhhbXBsZS5jb20vMi8iKTsKKyAgICBnX2Fzc2Vy dF9jbXBzdHIod2Via2l0X3dlYl9oaXN0b3J5X2l0ZW1fZ2V0X3RpdGxlKGN1cnJlbnRJdGVtKSwg PT0sICJTaXRlIDIiKTsKKyAgICBiYWNrTGlzdCA9IGJhY2tMaXN0LT5uZXh0OworCisgICAgY3Vy cmVudEl0ZW0gPSBXRUJLSVRfV0VCX0hJU1RPUllfSVRFTShiYWNrTGlzdC0+ZGF0YSk7CisgICAg Z19hc3NlcnRfY21wc3RyKHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX2dldF91cmkoY3VycmVudEl0 ZW0pLCA9PSwgImh0dHA6Ly9leGFtcGxlLmNvbS8xLyIpOworICAgIGdfYXNzZXJ0X2NtcHN0cih3 ZWJraXRfd2ViX2hpc3RvcnlfaXRlbV9nZXRfdGl0bGUoY3VycmVudEl0ZW0pLCA9PSwgIlNpdGUg MSIpOworICAgIGdfbGlzdF9mcmVlKGJhY2tMaXN0KTsKKworICAgIC8vIGNoZWNrIHRoZSBmb3J3 YXJkIGxpc3Qgb3JkZXIKKyAgICBnX2Fzc2VydCh3ZWJraXRfd2ViX3ZpZXdfZ29fdG9fYmFja19m b3J3YXJkX2l0ZW0od2ViVmlldywgaXRlbTEpKTsKKyAgICBmb3J3YXJkTGlzdCA9IHdlYmtpdF93 ZWJfYmFja19mb3J3YXJkX2xpc3RfZ2V0X2ZvcndhcmRfbGlzdF93aXRoX2xpbWl0KHdlYkJhY2tG b3J3YXJkTGlzdCw1KTsKKyAgICBnX2Fzc2VydChmb3J3YXJkTGlzdCk7CisKKyAgICBjdXJyZW50 SXRlbSA9IFdFQktJVF9XRUJfSElTVE9SWV9JVEVNKGZvcndhcmRMaXN0LT5kYXRhKTsKKyAgICBn X2Fzc2VydF9jbXBzdHIod2Via2l0X3dlYl9oaXN0b3J5X2l0ZW1fZ2V0X3VyaShjdXJyZW50SXRl bSksID09LCAiaHR0cDovL2V4YW1wbGUuY29tLzQvIik7CisgICAgZ19hc3NlcnRfY21wc3RyKHdl YmtpdF93ZWJfaGlzdG9yeV9pdGVtX2dldF90aXRsZShjdXJyZW50SXRlbSksID09LCAiU2l0ZSA0 Iik7CisgICAgZm9yd2FyZExpc3QgPSBmb3J3YXJkTGlzdC0+bmV4dDsKKworICAgIGN1cnJlbnRJ dGVtID0gV0VCS0lUX1dFQl9ISVNUT1JZX0lURU0oZm9yd2FyZExpc3QtPmRhdGEpOworICAgIGdf YXNzZXJ0X2NtcHN0cih3ZWJraXRfd2ViX2hpc3RvcnlfaXRlbV9nZXRfdXJpKGN1cnJlbnRJdGVt KSwgPT0sICJodHRwOi8vZXhhbXBsZS5jb20vMy8iKTsKKyAgICBnX2Fzc2VydF9jbXBzdHIod2Vi a2l0X3dlYl9oaXN0b3J5X2l0ZW1fZ2V0X3RpdGxlKGN1cnJlbnRJdGVtKSwgPT0sICJTaXRlIDMi KTsKKyAgICBmb3J3YXJkTGlzdCA9IGZvcndhcmRMaXN0LT5uZXh0OworCisgICAgY3VycmVudEl0 ZW0gPSBXRUJLSVRfV0VCX0hJU1RPUllfSVRFTShmb3J3YXJkTGlzdC0+ZGF0YSk7CisgICAgZ19h c3NlcnRfY21wc3RyKHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX2dldF91cmkoY3VycmVudEl0ZW0p LCA9PSwgImh0dHA6Ly9leGFtcGxlLmNvbS8yLyIpOworICAgIGdfYXNzZXJ0X2NtcHN0cih3ZWJr aXRfd2ViX2hpc3RvcnlfaXRlbV9nZXRfdGl0bGUoY3VycmVudEl0ZW0pLCA9PSwgIlNpdGUgMiIp OworCisgICAgZ19vYmplY3RfdW5yZWYoY3VycmVudEl0ZW0pOworICAgIGdfb2JqZWN0X3VucmVm KGl0ZW0xKTsKKyAgICBnX29iamVjdF91bnJlZihpdGVtMik7CisgICAgZ19vYmplY3RfdW5yZWYo aXRlbTMpOworICAgIGdfb2JqZWN0X3VucmVmKGl0ZW00KTsKKyAgICBnX2xpc3RfZnJlZShmb3J3 YXJkTGlzdCk7CisgICAgZ19vYmplY3RfdW5yZWYod2ViVmlldyk7Cit9CisKK3N0YXRpYyB2b2lk CiB0ZXN0X3dlYmtpdF93ZWJfYmFja19mb3J3YXJkX2xpc3RfYWRkX2l0ZW0odm9pZCkKIHsKICAg ICBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3OwpAQCAtMTQzLDcgKzIzNSw3IEBAIGludCBtYWluKGlu dCBhcmdjLCBjaGFyKiogYXJndikKICAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvd2Vidmll dy9jcmVhdGVfZGVzdHJveSIsIHRlc3Rfd2Via2l0X3dlYl9mcmFtZV9jcmVhdGVfZGVzdHJveSk7 CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dlYmZyYW1lL2xpZmV0aW1lIiwgdGVzdF93 ZWJraXRfd2ViX2ZyYW1lX2xpZmV0aW1lKTsKICAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQv d2ViYmFja2ZvcndhcmRsaXN0L2FkZF9pdGVtIiwgdGVzdF93ZWJraXRfd2ViX2JhY2tfZm9yd2Fy ZF9saXN0X2FkZF9pdGVtKTsKLQorICAgIGdfdGVzdF9hZGRfZnVuYygiL3dlYmtpdC93ZWJiYWNr Zm9yd2FyZGxpc3QvbGlzdF9vcmRlciIsIHRlc3Rfd2Via2l0X3dlYl9iYWNrX2ZvcndhcmRfbGlz dF9vcmRlcik7CiAgICAgcmV0dXJuIGdfdGVzdF9ydW4gKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmJhY2tmb3J3YXJkbGlzdC5jcHAgYi9XZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXR3ZWJiYWNrZm9yd2FyZGxpc3QuY3BwCmluZGV4IDI2OGIxNjEuLmNiZWI3 MGQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmJhY2tmb3J3YXJkbGlz dC5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViYmFja2ZvcndhcmRsaXN0LmNw cApAQCAtMTkzLDcgKzE5Myw3IEBAIEdMaXN0KiB3ZWJraXRfd2ViX2JhY2tfZm9yd2FyZF9saXN0 X2dldF9mb3J3YXJkX2xpc3Rfd2l0aF9saW1pdChXZWJLaXRXZWJCYWNrRm9yCiAgICAgICAgIGZv cndhcmRJdGVtcyA9IGdfbGlzdF9wcmVwZW5kKGZvcndhcmRJdGVtcywgZ19vYmplY3RfcmVmKHdl Ykhpc3RvcnlJdGVtKSk7CiAgICAgfQogCi0gICAgcmV0dXJuIGdfbGlzdF9yZXZlcnNlKGZvcndh cmRJdGVtcyk7CisgICAgcmV0dXJuIGZvcndhcmRJdGVtczsKIH0KIAogLyoqCkBAIC0yMjMsOCAr MjIzLDkgQEAgR0xpc3QqIHdlYmtpdF93ZWJfYmFja19mb3J3YXJkX2xpc3RfZ2V0X2JhY2tfbGlz dF93aXRoX2xpbWl0KFdlYktpdFdlYkJhY2tGb3J3YXIKICAgICAgICAgYmFja0l0ZW1zID0gZ19s aXN0X3ByZXBlbmQoYmFja0l0ZW1zLCBnX29iamVjdF9yZWYod2ViSGlzdG9yeUl0ZW0pKTsKICAg ICB9CiAKLSAgICByZXR1cm4gZ19saXN0X3JldmVyc2UoYmFja0l0ZW1zKTsKKyAgICByZXR1cm4g YmFja0l0ZW1zOwogfQorCiAvKioKICAqIHdlYmtpdF93ZWJfYmFja19mb3J3YXJkX2xpc3RfZ2V0 X2JhY2tfaXRlbToKICAqIEB3ZWJfYmFja19mb3J3YXJkX2xpc3Q6IGEgI1dlYkJhY2tGb3J3YXJk TGlzdAo=