226933 2021-06-11 12:04:41 -0700 Add an option to Copy WebKit Permalink that automatically opens the URL in the default browser for Sublime Text 2021-06-11 13:03:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi hi dbates hi joepeck keith_miller thorton webkit-bug-importer oldest_to_newest 1769014 0 hi 2021-06-11 12:04:41 -0700 99% of the time I copy a permalink/blame the next step is to open it in my browser it'd be awesome if the plugin would do that for me 1769018 1 431216 hi 2021-06-11 12:05:49 -0700 Created attachment 431216 Patch 1769025 2 431217 hi 2021-06-11 12:21:09 -0700 Created attachment 431217 Patch 1769041 3 ews-feeder 2021-06-11 13:02:13 -0700 Committed r278776 (238733@main): <https://commits.webkit.org/238733@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431217. 1769043 4 webkit-bug-importer 2021-06-11 13:03:28 -0700 <rdar://problem/79212285> 431216 2021-06-11 12:05:49 -0700 2021-06-11 12:21:09 -0700 Patch 226933.diff text/plain 3475 hi ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYTc3 NmYxY2E5YTAuLmY0YjZjNjg0OTk1ZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA2LTExICBEZXZpbiBSb3Vz c28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYW4gb3B0aW9uIHRvIENvcHkg V2ViS2l0IFBlcm1hbGluayB0aGF0IGF1dG9tYXRpY2FsbHkgb3BlbnMgdGhlIFVSTCBpbiB0aGUg ZGVmYXVsdCBicm93c2VyIGZvciBTdWJsaW1lIFRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjkzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzdWFsbHkgdGhlIHN0ZXAgcmlnaHQgYWZ0ZXIgY29w eWluZyB0aGUgcGVybWFsaW5rIGlzIHRvIG9wZW4gYSBicm93c2VyIGFuZCBlbnRlciBpdC4gSGF2 aW5nCisgICAgICAgIGEgc2V0dGluZyB0aGF0IGNhdXNlcyB0aGUgcGx1Z2luIHRvIGRvIHRoYXQg YXV0b21hdGljYWxseSB3b3VsZCBzYXZlIHNvbWUgdGltZSBhbmQgZWZmb3J0LgorCisgICAgICAg ICogQ29weVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGluay9Db3B5V2Vi S2l0UGVybWFsaW5rLnB5OgorICAgICAgICAoU2V0dGluZ3MpOgorICAgICAgICAoU2V0dGluZ3Mu YXV0b21hdGljYWxseV9vcGVuX2luX2Jyb3dzZXIpOiBBZGRlZC4KKyAgICAgICAgKENvcHlXZWJL aXRQZXJtYWxpbmtDb21tYW5kLnJ1bik6CisgICAgICAgICogQ29weVBlcm1hbGluay9TdWJsaW1l IFRleHQvQ29weVdlYktpdFBlcm1hbGluay9Db3B5V2ViS2l0UGVybWFsaW5rLnN1YmxpbWUtc2V0 dGluZ3M6CisKIDIwMjEtMDYtMTAgIFRydWl0dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4K IAogICAgICAgICBSZW1vdmUgRXdzMTc5IGFuZCBib3QyNzkgZnJvbSBjb25maWdzCmRpZmYgLS1n aXQgYS9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5r L0NvcHlXZWJLaXRQZXJtYWxpbmsucHkgYi9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4 dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvcHlXZWJLaXRQZXJtYWxpbmsucHkKaW5kZXggY2RhNDdh YjE3NzIxLi43MzE5YWViNzFiZDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3Vi bGltZSBUZXh0L0NvcHlXZWJLaXRQZXJtYWxpbmsvQ29weVdlYktpdFBlcm1hbGluay5weQkKKysr IGIvVG9vbHMvQ29weVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGluay9D b3B5V2ViS2l0UGVybWFsaW5rLnB5CQpAQCAtMjUsNiArMjUsNyBAQCBpbXBvcnQgcmUKIGltcG9y dCBzdWJsaW1lCiBpbXBvcnQgc3VibGltZV9wbHVnaW4KIGltcG9ydCBzdWJwcm9jZXNzCitpbXBv cnQgd2ViYnJvd3NlcgogCiBnbG9iYWwgc19zZXR0aW5ncwogCkBAIC01Miw2ICs1MywxNCBAQCBj bGFzcyBTZXR0aW5ncyhvYmplY3QpOgogICAgIGRlZiBpbmNsdWRlX3JldmlzaW9uKHNlbGYsIHZh bHVlKToKICAgICAgICAgc2VsZi5fc2V0KCdpbmNsdWRlX3JldmlzaW9uJywgdmFsdWUpCiAKKyAg ICBAcHJvcGVydHkKKyAgICBkZWYgYXV0b21hdGljYWxseV9vcGVuX2luX2Jyb3dzZXIoc2VsZik6 CisgICAgICAgIHJldHVybiBzZWxmLl9nZXQoJ2F1dG9tYXRpY2FsbHlfb3Blbl9pbl9icm93c2Vy JywgZGVmYXVsdD1UcnVlKQorCisgICAgQGF1dG9tYXRpY2FsbHlfb3Blbl9pbl9icm93c2VyLnNl dHRlcgorICAgIGRlZiBhdXRvbWF0aWNhbGx5X29wZW5faW5fYnJvd3NlcihzZWxmLCB2YWx1ZSk6 CisgICAgICAgIHNlbGYuX3NldCgnYXV0b21hdGljYWxseV9vcGVuX2luX2Jyb3dzZXInLCB2YWx1 ZSkKKwogICAgIGRlZiBfZ2V0KHNlbGYsIGtleSwgZGVmYXVsdD1Ob25lKToKICAgICAgICAgaWYg a2V5IG5vdCBpbiBzZWxmLl9jYWNoZToKICAgICAgICAgICAgIHNlbGYuX3NldHRpbmdzLmFkZF9v bl9jaGFuZ2Uoa2V5LCBsYW1iZGEgOiBzZWxmLl9jYWNoZS5wb3Aoa2V5LCBOb25lKSkKQEAgLTgz LDcgKzkyLDEwIEBAIGNsYXNzIENvcHlXZWJLaXRQZXJtYWxpbmtDb21tYW5kKHN1YmxpbWVfcGx1 Z2luLlRleHRDb21tYW5kKToKIAogICAgICAgICBwYXRoID0gc2VsZi5wYXRoX3JlbGF0aXZlX3Rv X3JlcG9zaXRvcnlfcm9vdF9mb3JfcGF0aChkb2N1bWVudF9wYXRoKQogICAgICAgICByZXZpc2lv bl9pbmZvID0gc2VsZi5yZXZpc2lvbl9pbmZvX2Zvcl9wYXRoKGRvY3VtZW50X3BhdGgpCi0gICAg ICAgIHN1YmxpbWUuc2V0X2NsaXBib2FyZChzZWxmLnBlcm1hbGlua19mb3JfcGF0aChwYXRoLCBs aW5lX251bWJlciwgcmV2aXNpb25faW5mbywgYW5ub3RhdGVfYmxhbWUpKQorICAgICAgICBwZXJt YWxpbmsgPSBzZWxmLnBlcm1hbGlua19mb3JfcGF0aChwYXRoLCBsaW5lX251bWJlciwgcmV2aXNp b25faW5mbywgYW5ub3RhdGVfYmxhbWUpCisgICAgICAgIHN1YmxpbWUuc2V0X2NsaXBib2FyZChw ZXJtYWxpbmspCisgICAgICAgIGlmIHNfc2V0dGluZ3MuYXV0b21hdGljYWxseV9vcGVuX2luX2Jy b3dzZXI6CisgICAgICAgICAgICB3ZWJicm93c2VyLm9wZW4ocGVybWFsaW5rKQogCiAgICAgZGVm IGlzX2VuYWJsZWQoc2VsZik6CiAgICAgICAgIHJldHVybiBsZW4oc2VsZi52aWV3LnNlbCgpKSA+ IDAgYW5kIGJvb2woc2VsZi52aWV3LmZpbGVfbmFtZSgpKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ29w eVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGluay9Db3B5V2ViS2l0UGVy bWFsaW5rLnN1YmxpbWUtc2V0dGluZ3MgYi9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4 dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvcHlXZWJLaXRQZXJtYWxpbmsuc3VibGltZS1zZXR0aW5n cwppbmRleCA3ODczYTMxMThmNzUuLjJkZjlmODMxNzM1MyAxMDA2NDQKLS0tIGEvVG9vbHMvQ29w eVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGluay9Db3B5V2ViS2l0UGVy bWFsaW5rLnN1YmxpbWUtc2V0dGluZ3MJCisrKyBiL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGlt ZSBUZXh0L0NvcHlXZWJLaXRQZXJtYWxpbmsvQ29weVdlYktpdFBlcm1hbGluay5zdWJsaW1lLXNl dHRpbmdzCQpAQCAtMSw0ICsxLDcgQEAKIHsKICAgICAvLyBDb250cm9scyB3aGV0aGVyIHRoZSBT Vk4gcmV2aXNpb24gaXMgaW5jbHVkZWQgaW4gdGhlIFVSTC4KICAgICAiaW5jbHVkZV9yZXZpc2lv biI6IHRydWUsCisKKyAgICAvLyBDb250cm9scyB3aGV0aGVyIHRoZSBVUkwgaXMgYXV0b21hdGlj YWxseSBvcGVuZWQgaW4gdGhlIGRlZmF1bHQgYnJvd3Nlci4KKyAgICAiYXV0b21hdGljYWxseV9v cGVuX2luX2Jyb3dzZXIiOiBmYWxzZSwKIH0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg== 431217 2021-06-11 12:21:09 -0700 2021-06-11 13:02:14 -0700 Patch 226933.diff text/plain 3455 hi ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYTc3 NmYxY2E5YTAuLmY0YjZjNjg0OTk1ZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTExICBEZXZpbiBSb3Vz c28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYW4gb3B0aW9uIHRvIENvcHkg V2ViS2l0IFBlcm1hbGluayB0aGF0IGF1dG9tYXRpY2FsbHkgb3BlbnMgdGhlIFVSTCBpbiB0aGUg ZGVmYXVsdCBicm93c2VyIGZvciBTdWJsaW1lIFRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjkzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzdWFsbHkgdGhlIHN0ZXAgcmlnaHQgYWZ0ZXIgY29w eWluZyB0aGUgcGVybWFsaW5rIGlzIHRvIG9wZW4gYSBicm93c2VyIGFuZCBlbnRlciBpdC4gSGF2 aW5nCisgICAgICAgIGEgc2V0dGluZyB0aGF0IGNhdXNlcyB0aGUgcGx1Z2luIHRvIGRvIHRoYXQg YXV0b21hdGljYWxseSB3b3VsZCBzYXZlIHNvbWUgdGltZSBhbmQgZWZmb3J0LgorCisgICAgICAg ICogQ29weVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGluay9Db3B5V2Vi S2l0UGVybWFsaW5rLnB5OgorICAgICAgICAoU2V0dGluZ3MuYXV0b21hdGljYWxseV9vcGVuX2lu X2Jyb3dzZXIpOiBBZGRlZC4KKyAgICAgICAgKENvcHlXZWJLaXRQZXJtYWxpbmtDb21tYW5kLnJ1 bik6CisgICAgICAgICogQ29weVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1h bGluay9Db3B5V2ViS2l0UGVybWFsaW5rLnN1YmxpbWUtc2V0dGluZ3M6CisKIDIwMjEtMDYtMTAg IFRydWl0dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRXdz MTc5IGFuZCBib3QyNzkgZnJvbSBjb25maWdzCmRpZmYgLS1naXQgYS9Ub29scy9Db3B5UGVybWFs aW5rL1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvcHlXZWJLaXRQZXJtYWxpbmsu cHkgYi9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5r L0NvcHlXZWJLaXRQZXJtYWxpbmsucHkKaW5kZXggY2RhNDdhYjE3NzIxLi43MzE5YWViNzFiZDQg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBUZXh0L0NvcHlXZWJLaXRQ ZXJtYWxpbmsvQ29weVdlYktpdFBlcm1hbGluay5weQkKKysrIGIvVG9vbHMvQ29weVBlcm1hbGlu ay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGluay9Db3B5V2ViS2l0UGVybWFsaW5rLnB5 CQpAQCAtMjUsNiArMjUsNyBAQCBpbXBvcnQgcmUKIGltcG9ydCBzdWJsaW1lCiBpbXBvcnQgc3Vi bGltZV9wbHVnaW4KIGltcG9ydCBzdWJwcm9jZXNzCitpbXBvcnQgd2ViYnJvd3NlcgogCiBnbG9i YWwgc19zZXR0aW5ncwogCkBAIC01Miw2ICs1MywxNCBAQCBjbGFzcyBTZXR0aW5ncyhvYmplY3Qp OgogICAgIGRlZiBpbmNsdWRlX3JldmlzaW9uKHNlbGYsIHZhbHVlKToKICAgICAgICAgc2VsZi5f c2V0KCdpbmNsdWRlX3JldmlzaW9uJywgdmFsdWUpCiAKKyAgICBAcHJvcGVydHkKKyAgICBkZWYg YXV0b21hdGljYWxseV9vcGVuX2luX2Jyb3dzZXIoc2VsZik6CisgICAgICAgIHJldHVybiBzZWxm Ll9nZXQoJ2F1dG9tYXRpY2FsbHlfb3Blbl9pbl9icm93c2VyJywgZGVmYXVsdD1GYWxzZSkKKwor ICAgIEBhdXRvbWF0aWNhbGx5X29wZW5faW5fYnJvd3Nlci5zZXR0ZXIKKyAgICBkZWYgYXV0b21h dGljYWxseV9vcGVuX2luX2Jyb3dzZXIoc2VsZiwgdmFsdWUpOgorICAgICAgICBzZWxmLl9zZXQo J2F1dG9tYXRpY2FsbHlfb3Blbl9pbl9icm93c2VyJywgdmFsdWUpCisKICAgICBkZWYgX2dldChz ZWxmLCBrZXksIGRlZmF1bHQ9Tm9uZSk6CiAgICAgICAgIGlmIGtleSBub3QgaW4gc2VsZi5fY2Fj aGU6CiAgICAgICAgICAgICBzZWxmLl9zZXR0aW5ncy5hZGRfb25fY2hhbmdlKGtleSwgbGFtYmRh IDogc2VsZi5fY2FjaGUucG9wKGtleSwgTm9uZSkpCkBAIC04Myw3ICs5MiwxMCBAQCBjbGFzcyBD b3B5V2ViS2l0UGVybWFsaW5rQ29tbWFuZChzdWJsaW1lX3BsdWdpbi5UZXh0Q29tbWFuZCk6CiAK ICAgICAgICAgcGF0aCA9IHNlbGYucGF0aF9yZWxhdGl2ZV90b19yZXBvc2l0b3J5X3Jvb3RfZm9y X3BhdGgoZG9jdW1lbnRfcGF0aCkKICAgICAgICAgcmV2aXNpb25faW5mbyA9IHNlbGYucmV2aXNp b25faW5mb19mb3JfcGF0aChkb2N1bWVudF9wYXRoKQotICAgICAgICBzdWJsaW1lLnNldF9jbGlw Ym9hcmQoc2VsZi5wZXJtYWxpbmtfZm9yX3BhdGgocGF0aCwgbGluZV9udW1iZXIsIHJldmlzaW9u X2luZm8sIGFubm90YXRlX2JsYW1lKSkKKyAgICAgICAgcGVybWFsaW5rID0gc2VsZi5wZXJtYWxp bmtfZm9yX3BhdGgocGF0aCwgbGluZV9udW1iZXIsIHJldmlzaW9uX2luZm8sIGFubm90YXRlX2Js YW1lKQorICAgICAgICBzdWJsaW1lLnNldF9jbGlwYm9hcmQocGVybWFsaW5rKQorICAgICAgICBp ZiBzX3NldHRpbmdzLmF1dG9tYXRpY2FsbHlfb3Blbl9pbl9icm93c2VyOgorICAgICAgICAgICAg d2ViYnJvd3Nlci5vcGVuKHBlcm1hbGluaykKIAogICAgIGRlZiBpc19lbmFibGVkKHNlbGYpOgog ICAgICAgICByZXR1cm4gbGVuKHNlbGYudmlldy5zZWwoKSkgPiAwIGFuZCBib29sKHNlbGYudmll dy5maWxlX25hbWUoKSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBU ZXh0L0NvcHlXZWJLaXRQZXJtYWxpbmsvQ29weVdlYktpdFBlcm1hbGluay5zdWJsaW1lLXNldHRp bmdzIGIvVG9vbHMvQ29weVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGlu ay9Db3B5V2ViS2l0UGVybWFsaW5rLnN1YmxpbWUtc2V0dGluZ3MKaW5kZXggNzg3M2EzMTE4Zjc1 Li4yZGY5ZjgzMTczNTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBU ZXh0L0NvcHlXZWJLaXRQZXJtYWxpbmsvQ29weVdlYktpdFBlcm1hbGluay5zdWJsaW1lLXNldHRp bmdzCQorKysgYi9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVy bWFsaW5rL0NvcHlXZWJLaXRQZXJtYWxpbmsuc3VibGltZS1zZXR0aW5ncwkKQEAgLTEsNCArMSw3 IEBACiB7CiAgICAgLy8gQ29udHJvbHMgd2hldGhlciB0aGUgU1ZOIHJldmlzaW9uIGlzIGluY2x1 ZGVkIGluIHRoZSBVUkwuCiAgICAgImluY2x1ZGVfcmV2aXNpb24iOiB0cnVlLAorCisgICAgLy8g Q29udHJvbHMgd2hldGhlciB0aGUgVVJMIGlzIGF1dG9tYXRpY2FsbHkgb3BlbmVkIGluIHRoZSBk ZWZhdWx0IGJyb3dzZXIuCisgICAgImF1dG9tYXRpY2FsbHlfb3Blbl9pbl9icm93c2VyIjogZmFs c2UsCiB9ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=