226930 2021-06-11 10:53:38 -0700 Add fast-path for binding security check of DOMWindow 2021-06-11 14:22:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki cdumez fpizlo ggaren webkit-bug-importer oldest_to_newest 1768987 0 ysuzuki 2021-06-11 10:53:38 -0700 Add fast-path for binding security check of DOMWindow 1768990 1 431211 ysuzuki 2021-06-11 10:56:55 -0700 Created attachment 431211 Patch 1768995 2 431211 ggaren 2021-06-11 11:09:17 -0700 Comment on attachment 431211 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431211&action=review r=me > Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:111 > +bool BindingSecurity::shouldAllowAccessToDOMWindow(JSC::JSGlobalObject* lexicalGlobalObject, JSDOMWindow& target, SecurityReportingOption reportingOption) Since this is a fast path, and just a pointer comparison, should we put it inline in the header? 1768997 3 431211 ysuzuki 2021-06-11 11:11:36 -0700 Comment on attachment 431211 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431211&action=review >> Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:111 >> +bool BindingSecurity::shouldAllowAccessToDOMWindow(JSC::JSGlobalObject* lexicalGlobalObject, JSDOMWindow& target, SecurityReportingOption reportingOption) > > Since this is a fast path, and just a pointer comparison, should we put it inline in the header? Right! I'll move it to that. 1769071 4 ysuzuki 2021-06-11 14:21:43 -0700 Committed r278782 (238739@main): <https://commits.webkit.org/238739@main> 1769072 5 webkit-bug-importer 2021-06-11 14:22:19 -0700 <rdar://problem/79215873> 431211 2021-06-11 10:56:55 -0700 2021-06-11 12:35:00 -0700 Patch bug-226930-20210611105655.patch text/plain 6331 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWViOWMxM2Y3N2NjNDM4 NTI2MzA4ZDVkNGRjMzZkOWQ4MDAzMWFhMC4uZDk2OTVjNjRmN2YyNmZjYTZiNTdhZTA3YWU2YjM1 YzY4YTdkNjVkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTA2LTExICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGZhc3QtcGF0aCBm b3IgYmluZGluZyBzZWN1cml0eSBjaGVjayBvZiBET01XaW5kb3cKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjkzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBzZWN1cml0eSBjaGVja1sxXSBtdXN0 IHBhc3MgaWYgdGhlIGN1cnJlbnQgSlNET01HbG9iYWxPYmplY3QgaXMgdGhlIHNhbWUgdG8gdGhl IGFjY2Vzc2VkIEpTRE9NV2luZG93LgorICAgICAgICBUaGlzIGNsYXJpZmljYXRpb24gcGF2ZXMg dGhlIHdheSB0byBlbWl0IEpJVCBjb2RlIHdoaWNoIHJlbW92ZXMgdGhpcyBzZWN1cml0eSBjaGVj ayB3aGVuIHRoZSBsZXhpY2FsIGFuZAorICAgICAgICBhY2Nlc3NlZCBKU0dsb2JhbE9iamVjdHMg YXJlIHRoZSBzYW1lLgorCisgICAgICAgIFsxXTogaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9y Zy9tdWx0aXBhZ2UvYnJvd3NlcnMuaHRtbCNpbnRlZ3JhdGlvbi13aXRoLWlkbAorCisgICAgICAg ICogYmluZGluZ3MvanMvSlNET01CaW5kaW5nU2VjdXJpdHkuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6QmluZGluZ1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93KToKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmdTZWN1cml0eS5oOgorICAgICAgICAqIGJpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVBdHRyaWJ1 dGVHZXR0ZXJCb2R5RGVmaW5pdGlvbik6CisgICAgICAgIChHZW5lcmF0ZUF0dHJpYnV0ZVNldHRl ckJvZHlEZWZpbml0aW9uKToKKyAgICAgICAgKEdlbmVyYXRlT3BlcmF0aW9uQm9keURlZmluaXRp b24pOgorCiAyMDIxLTA2LTA5ICBDYW1lcm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+ CiAKICAgICAgICAgQWRkIHdpbmRvdy5pbnRlcm5hbHMubG9nKCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZ1NlY3VyaXR5LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZ1NlY3VyaXR5LmNwcAppbmRleCA0ZDkwMmVh NDBiMjU0MzRmMmYxNjJiYzg1NmEyYjY5YzQ2ZWM2NTgwLi5hYTI2YzFhZjIyYTljNTQ1NWQ1Y2I4 OWE1NzliOGQzYTQ2ODIzNDAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RPTUJpbmRpbmdTZWN1cml0eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNET01CaW5kaW5nU2VjdXJpdHkuY3BwCkBAIC0xMDgsNiArMTA4LDEzIEBAIGJvb2wgQmlu ZGluZ1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93KEpTQzo6SlNHbG9iYWxP YmplY3QqIGxleGljYWxHCiAgICAgcmV0dXJuIHRhcmdldCAmJiBzaG91bGRBbGxvd0FjY2Vzc1Rv RE9NV2luZG93KGxleGljYWxHbG9iYWxPYmplY3QsICp0YXJnZXQsIHJlcG9ydGluZ09wdGlvbik7 CiB9CiAKK2Jvb2wgQmluZGluZ1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93 KEpTQzo6SlNHbG9iYWxPYmplY3QqIGxleGljYWxHbG9iYWxPYmplY3QsIEpTRE9NV2luZG93JiB0 YXJnZXQsIFNlY3VyaXR5UmVwb3J0aW5nT3B0aW9uIHJlcG9ydGluZ09wdGlvbikKK3sKKyAgICBp ZiAoTElLRUxZKGxleGljYWxHbG9iYWxPYmplY3QgPT0gJnRhcmdldCkpCisgICAgICAgIHJldHVy biB0cnVlOworICAgIHJldHVybiBzaG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93KGxleGljYWxH bG9iYWxPYmplY3QsIHRhcmdldC53cmFwcGVkKCksIHJlcG9ydGluZ09wdGlvbik7Cit9CisKIGJv b2wgQmluZGluZ1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvRnJhbWUoSlNDOjpKU0dsb2Jh bE9iamVjdCogbGV4aWNhbEdsb2JhbE9iamVjdCwgRnJhbWUqIHRhcmdldCwgU2VjdXJpdHlSZXBv cnRpbmdPcHRpb24gcmVwb3J0aW5nT3B0aW9uKQogewogICAgIHJldHVybiB0YXJnZXQgJiYgY2Fu QWNjZXNzRG9jdW1lbnQobGV4aWNhbEdsb2JhbE9iamVjdCwgdGFyZ2V0LT5kb2N1bWVudCgpLCBy ZXBvcnRpbmdPcHRpb24pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMv SlNET01CaW5kaW5nU2VjdXJpdHkuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9N QmluZGluZ1NlY3VyaXR5LmgKaW5kZXggYjE0ODg1Nzg0NzY2MGYzZjM5MWE2ZmNhNzE5ZjlhYjQ2 ZjU2OTg0ZC4uNTZiZmY3YjkxNjVlYWExZGIwY2UyMzZlNTU4M2QzZTM5M2I2MzZiOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nU2VjdXJpdHkuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmdTZWN1cml0eS5oCkBA IC0zNSw2ICszNSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgRE9NV2luZG93Owog Y2xhc3MgRnJhbWU7CitjbGFzcyBKU0RPTVdpbmRvdzsKIGNsYXNzIE5vZGU7CiAKIHZvaWQgcHJp bnRFcnJvck1lc3NhZ2VGb3JGcmFtZShGcmFtZSosIGNvbnN0IFN0cmluZyYgbWVzc2FnZSk7CkBA IC01Miw2ICs1Myw3IEBAIGJvb2wgc2hvdWxkQWxsb3dBY2Nlc3NUb0RPTVdpbmRvdyhKU0M6OkpT R2xvYmFsT2JqZWN0KiwgRE9NV2luZG93JiwgU2VjdXJpdHlSZXBvCiBib29sIHNob3VsZEFsbG93 QWNjZXNzVG9ET01XaW5kb3coSlNDOjpKU0dsb2JhbE9iamVjdCYsIERPTVdpbmRvdyYsIFN0cmlu ZyYgbWVzc2FnZSk7CiBib29sIHNob3VsZEFsbG93QWNjZXNzVG9ET01XaW5kb3coSlNDOjpKU0ds b2JhbE9iamVjdCosIERPTVdpbmRvdyosIFNlY3VyaXR5UmVwb3J0aW5nT3B0aW9uID0gTG9nU2Vj dXJpdHlFcnJvcik7CiBib29sIHNob3VsZEFsbG93QWNjZXNzVG9ET01XaW5kb3coSlNDOjpKU0ds b2JhbE9iamVjdCYsIERPTVdpbmRvdyosIFN0cmluZyYgbWVzc2FnZSk7Citib29sIHNob3VsZEFs bG93QWNjZXNzVG9ET01XaW5kb3coSlNDOjpKU0dsb2JhbE9iamVjdCosIEpTRE9NV2luZG93Jiwg U2VjdXJpdHlSZXBvcnRpbmdPcHRpb24gPSBMb2dTZWN1cml0eUVycm9yKTsKIGJvb2wgc2hvdWxk QWxsb3dBY2Nlc3NUb0ZyYW1lKEpTQzo6SlNHbG9iYWxPYmplY3QqLCBGcmFtZSosIFNlY3VyaXR5 UmVwb3J0aW5nT3B0aW9uID0gTG9nU2VjdXJpdHlFcnJvcik7CiBib29sIHNob3VsZEFsbG93QWNj ZXNzVG9GcmFtZShKU0M6OkpTR2xvYmFsT2JqZWN0JiwgRnJhbWUmLCBTdHJpbmcmIG1lc3NhZ2Up OwogYm9vbCBzaG91bGRBbGxvd0FjY2Vzc1RvTm9kZShKU0M6OkpTR2xvYmFsT2JqZWN0JiwgTm9k ZSopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JKUy5wbQppbmRleCBkMjVlM2ZmNDRiNmI2NGM5ZjkzOTNmOTZhYjkzOGU0ODY5ODg4N2I2Li4w ZTc4NTg2MjNiMzRjYWRhMzU2YzU0Yjg1ODhkNzFmNjFhNjY3MzhhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpAQCAtNTIxMiw3 ICs1MjEyLDcgQEAgc3ViIEdlbmVyYXRlQXR0cmlidXRlR2V0dGVyQm9keURlZmluaXRpb24KICAg ICBpZiAoJG5lZWRTZWN1cml0eUNoZWNrKSB7CiAgICAgICAgIEFkZFRvSW1wbEluY2x1ZGVzKCJK U0RPTUJpbmRpbmdTZWN1cml0eS5oIiwgJGNvbmRpdGlvbmFsKTsKICAgICAgICAgaWYgKCRpbnRl cmZhY2UtPnR5cGUtPm5hbWUgZXEgIkRPTVdpbmRvdyIpIHsKLSAgICAgICAgICAgIHB1c2goQCRv dXRwdXRBcnJheSwgIiAgICBib29sIHNob3VsZEFsbG93QWNjZXNzID0gQmluZGluZ1NlY3VyaXR5 OjpzaG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93KCZsZXhpY2FsR2xvYmFsT2JqZWN0LCB0aGlz T2JqZWN0LndyYXBwZWQoKSwgVGhyb3dTZWN1cml0eUVycm9yKTtcbiIpOworICAgICAgICAgICAg cHVzaChAJG91dHB1dEFycmF5LCAiICAgIGJvb2wgc2hvdWxkQWxsb3dBY2Nlc3MgPSBCaW5kaW5n U2VjdXJpdHk6OnNob3VsZEFsbG93QWNjZXNzVG9ET01XaW5kb3coJmxleGljYWxHbG9iYWxPYmpl Y3QsIHRoaXNPYmplY3QsIFRocm93U2VjdXJpdHlFcnJvcik7XG4iKTsKICAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgIHB1c2goQCRvdXRwdXRBcnJheSwgIiAgICBib29sIHNob3VsZEFsbG93 QWNjZXNzID0gQmluZGluZ1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93KCZs ZXhpY2FsR2xvYmFsT2JqZWN0LCB0aGlzT2JqZWN0LndyYXBwZWQoKS53aW5kb3coKSwgVGhyb3dT ZWN1cml0eUVycm9yKTtcbiIpOwogICAgICAgICB9CkBAIC01MzY5LDcgKzUzNjksNyBAQCBzdWIg R2VuZXJhdGVBdHRyaWJ1dGVTZXR0ZXJCb2R5RGVmaW5pdGlvbgogICAgIGlmICgkbmVlZFNlY3Vy aXR5Q2hlY2spIHsKICAgICAgICAgQWRkVG9JbXBsSW5jbHVkZXMoIkpTRE9NQmluZGluZ1NlY3Vy aXR5LmgiLCAkY29uZGl0aW9uYWwpOwogICAgICAgICBpZiAoJGludGVyZmFjZS0+dHlwZS0+bmFt ZSBlcSAiRE9NV2luZG93IikgewotICAgICAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAg IGJvb2wgc2hvdWxkQWxsb3dBY2Nlc3MgPSBCaW5kaW5nU2VjdXJpdHk6OnNob3VsZEFsbG93QWNj ZXNzVG9ET01XaW5kb3coJmxleGljYWxHbG9iYWxPYmplY3QsIHRoaXNPYmplY3Qud3JhcHBlZCgp LCBUaHJvd1NlY3VyaXR5RXJyb3IpO1xuIik7CisgICAgICAgICAgICBwdXNoKEAkb3V0cHV0QXJy YXksICIgICAgYm9vbCBzaG91bGRBbGxvd0FjY2VzcyA9IEJpbmRpbmdTZWN1cml0eTo6c2hvdWxk QWxsb3dBY2Nlc3NUb0RPTVdpbmRvdygmbGV4aWNhbEdsb2JhbE9iamVjdCwgdGhpc09iamVjdCwg VGhyb3dTZWN1cml0eUVycm9yKTtcbiIpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAg cHVzaChAJG91dHB1dEFycmF5LCAiICAgIGJvb2wgc2hvdWxkQWxsb3dBY2Nlc3MgPSBCaW5kaW5n U2VjdXJpdHk6OnNob3VsZEFsbG93QWNjZXNzVG9ET01XaW5kb3coJmxleGljYWxHbG9iYWxPYmpl Y3QsIHRoaXNPYmplY3Qud3JhcHBlZCgpLndpbmRvdygpLCBUaHJvd1NlY3VyaXR5RXJyb3IpO1xu Iik7CiAgICAgICAgIH0KQEAgLTU1ODEsNyArNTU4MSw3IEBAIHN1YiBHZW5lcmF0ZU9wZXJhdGlv bkJvZHlEZWZpbml0aW9uCiAgICAgICAgICAgICAKICAgICAgICAgICAgIEFkZFRvSW1wbEluY2x1 ZGVzKCJKU0RPTUJpbmRpbmdTZWN1cml0eS5oIiwgJGNvbmRpdGlvbmFsKTsKICAgICAgICAgICAg IGlmICgkaW50ZXJmYWNlLT50eXBlLT5uYW1lIGVxICJET01XaW5kb3ciKSB7Ci0gICAgICAgICAg ICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgIGJvb2wgc2hvdWxkQWxsb3dBY2Nlc3MgPSBC aW5kaW5nU2VjdXJpdHk6OnNob3VsZEFsbG93QWNjZXNzVG9ET01XaW5kb3cobGV4aWNhbEdsb2Jh bE9iamVjdCwgY2FzdGVkVGhpcy0+d3JhcHBlZCgpLCBUaHJvd1NlY3VyaXR5RXJyb3IpO1xuIik7 CisgICAgICAgICAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgIGJvb2wgc2hvdWxkQWxs b3dBY2Nlc3MgPSBCaW5kaW5nU2VjdXJpdHk6OnNob3VsZEFsbG93QWNjZXNzVG9ET01XaW5kb3co bGV4aWNhbEdsb2JhbE9iamVjdCwgKmNhc3RlZFRoaXMsIFRocm93U2VjdXJpdHlFcnJvcik7XG4i KTsKICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgcHVzaChAJG91dHB1dEFy cmF5LCAiICAgIGJvb2wgc2hvdWxkQWxsb3dBY2Nlc3MgPSBCaW5kaW5nU2VjdXJpdHk6OnNob3Vs ZEFsbG93QWNjZXNzVG9ET01XaW5kb3cobGV4aWNhbEdsb2JhbE9iamVjdCwgY2FzdGVkVGhpcy0+ d3JhcHBlZCgpLndpbmRvdygpLCBUaHJvd1NlY3VyaXR5RXJyb3IpO1xuIik7CiAgICAgICAgICAg ICB9Cg==