226928 2021-06-11 10:37:30 -0700 REGRESSION: [ BigSur iOS wk1 Debug ] imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https.html is flaky crashing 2021-06-15 14:03:48 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell youennf achristensen cdumez eric.carlson webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1768978 0 tsavell 2021-06-11 10:37:30 -0700 imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https.html this test began crashing recently around r278704 on BigSur Debug wk1 queues and at least once on iOS debug History: https://results.webkit.org/?suite=layout-tests&test=imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https.html log: (audio_processing_impl.cc:278): Injected APM submodules: Echo control factory: 0 Echo detector: 0 Capture analyzer: 0 Capture post processor: 0 Render pre processor: 0 (webrtc_voice_engine.cc:268): WebRtcVoiceEngine::WebRtcVoiceEngine (webrtc_video_engine.cc:628): WebRtcVideoEngine::WebRtcVideoEngine() (webrtc_voice_engine.cc:290): WebRtcVoiceEngine::Init 1768979 1 webkit-bug-importer 2021-06-11 10:37:50 -0700 <rdar://problem/79205526> 1769023 2 tsavell 2021-06-11 12:16:48 -0700 I have not been able to reproduce this failure locally yet 1769077 3 cdumez 2021-06-11 14:27:42 -0700 Thread 35 Crashed:: rtc-low-prio 0 libwebrtc.dylib 0x00000001234887c1 webrtc::(anonymous namespace)::TaskQueueStdlib::GetNextTask() + 257 (task_queue_stdlib.cc:193) 1 libwebrtc.dylib 0x0000000123488583 webrtc::(anonymous namespace)::TaskQueueStdlib::ProcessTasks() + 51 (task_queue_stdlib.cc:226) 2 libwebrtc.dylib 0x000000012348853f webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1::operator()() const + 47 (task_queue_stdlib.cc:127) 3 libwebrtc.dylib 0x00000001234884ed decltype(std::__1::forward<webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1&>(fp)()) std::__1::__invoke<webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1&>(webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1&) + 29 (type_traits:3747) 4 libwebrtc.dylib 0x000000012348849d void std::__1::__invoke_void_return_wrapper<void>::__call<webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1&>(webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1&) + 29 (__functional_base:348) 5 libwebrtc.dylib 0x000000012348846d std::__1::__function::__alloc_func<webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1, std::__1::allocator<webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1>, void ()>::operator()() + 29 (functional:1553) 6 libwebrtc.dylib 0x000000012348717e std::__1::__function::__func<webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1, std::__1::allocator<webrtc::(anonymous namespace)::TaskQueueStdlib::TaskQueueStdlib(std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadPriority)::$_1>, void ()>::operator()() + 30 (functional:1727) 7 libwebrtc.dylib 0x00000001223753f5 std::__1::__function::__value_func<void ()>::operator()() const + 53 (functional:1880) 8 libwebrtc.dylib 0x0000000122375395 std::__1::function<void ()>::operator()() const + 21 (functional:2555) 9 libwebrtc.dylib 0x0000000122cd0f26 rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1::operator()() const + 70 (platform_thread.cc:185) 10 libwebrtc.dylib 0x0000000122cd0ebd decltype(std::__1::forward<rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1&>(fp)()) std::__1::__invoke<rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1&>(rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1&) + 29 (type_traits:3747) 11 libwebrtc.dylib 0x0000000122cd0e6d void std::__1::__invoke_void_return_wrapper<void>::__call<rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1&>(rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1&) + 29 (__functional_base:348) 12 libwebrtc.dylib 0x0000000122cd0e3d std::__1::__function::__alloc_func<rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1, std::__1::allocator<rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1>, void ()>::operator()() + 29 (functional:1553) 13 libwebrtc.dylib 0x0000000122ccf9fe std::__1::__function::__func<rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1, std::__1::allocator<rtc::PlatformThread::SpawnThread(std::__1::function<void ()>, std::__1::basic_string_view<char, std::__1::char_traits<char> >, rtc::ThreadAttributes, bool)::$_1>, void ()>::operator()() + 30 (functional:1727) 14 libwebrtc.dylib 0x00000001223753f5 std::__1::__function::__value_func<void ()>::operator()() const + 53 (functional:1880) 15 libwebrtc.dylib 0x0000000122375395 std::__1::function<void ()>::operator()() const + 21 (functional:2555) 16 libwebrtc.dylib 0x0000000122cceb8d rtc::(anonymous namespace)::RunPlatformThread(void*) + 29 (platform_thread.cc:101) 17 libsystem_pthread.dylib 0x00007fff205db8fc 0x7fff205d5000 + 26876 18 libsystem_pthread.dylib 0x00007fff205d7443 0x7fff205d5000 + 9283 1769078 4 cdumez 2021-06-11 14:28:42 -0700 Potential regression from the WebRTC update in r278701. 1769761 5 431427 youennf 2021-06-15 05:52:10 -0700 Created attachment 431427 Patch 1769764 6 youennf 2021-06-15 05:53:49 -0700 (In reply to Chris Dumez from comment #4) > Potential regression from the WebRTC update in r278701. It seems so. From what I can see, it seems that we create a thread that will start before all the thread owner members are initialised. 1769803 7 431427 eric.carlson 2021-06-15 08:25:55 -0700 Comment on attachment 431427 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431427&action=review > Source/ThirdParty/libwebrtc/ChangeLog:12 > + Update to create thread_ before all other members. Don't you mean *after* all other members? 1769883 8 ews-feeder 2021-06-15 11:22:05 -0700 Committed r278886 (238828@main): <https://commits.webkit.org/238828@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431427. 1769953 9 youennf 2021-06-15 14:03:48 -0700 (In reply to Eric Carlson from comment #7) > Comment on attachment 431427 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431427&action=review > > > Source/ThirdParty/libwebrtc/ChangeLog:12 > > + Update to create thread_ before all other members. > > Don't you mean *after* all other members? Right, will fix the changelog, thanks for the review and the cq+ 431427 2021-06-15 05:52:10 -0700 2021-06-15 11:22:06 -0700 Patch bug-226928-20210615145208.patch text/plain 2430 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBhZjM5ODMyMTM3ZDIyM2E3ZmJkNzc1M2UzNmFhNmVkZTY1MTZiOTEzLi4wNjlj NWY0NzIwZTBkMmJjZjBmY2JkYWI5ZjIwYjE1YTA4YTRjNzAxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0wNi0xNSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogWyBCaWdTdXIg aU9TIHdrMSBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20v dXN2c3RyaW5nLXJlZmxlY3Rpb24uaHR0cHMuaHRtbCBpcyBmbGFreSBjcmFzaGluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2OTI4CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS83OTIwNTUyNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS93ZWJydGMvcnRjX2Jhc2UvdGFza19xdWV1ZV9z dGRsaWIuY2M6CisgICAgICAgIHRocmVhZF8gaXMgY3JlYXRlZCBpbiBUYXNrUXVldWVTdGRsaWIg Y29uc3RydWN0b3IgYmVmb3JlIG90aGVyIG1lbWJlcnMgcGVuZGluZ19xdWV1ZV8gb3IgZGVsYXll ZF9xdWV1ZV8uCisgICAgICAgIEl0IG1pZ2h0IGhhcHBlbiB0aGF0IHRocmVhZF8gd2lsbCBzdGFy dCBleGVjdXRpbmcgaXRzIGNhbGxiYWNrIHdoaWNoIHdpbGwgcmVhZCBkZWxheWVkX3F1ZXVlXyBi ZWZvcmUgaXQgaXMgaW5pdGlhbGl6ZWQgYnkgVGFza1F1ZXVlU3RkbGliIGNvbnN0cnVjdG9yLgor ICAgICAgICBVcGRhdGUgdG8gY3JlYXRlIHRocmVhZF8gYmVmb3JlIGFsbCBvdGhlciBtZW1iZXJz LgorCiAyMDIxLTA2LTEwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4gYW5kIFZp Y3RvciBNLiBKYXF1ZXogTC4gPHZqYXF1ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBVcGRhdGUg bGlid2VicnRjIHRvIE05MgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L1NvdXJjZS93ZWJydGMvcnRjX2Jhc2UvdGFza19xdWV1ZV9zdGRsaWIuY2MgYi9Tb3VyY2UvVGhp cmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9ydGNfYmFzZS90YXNrX3F1ZXVlX3N0ZGxp Yi5jYwppbmRleCA1NDhmN2VmNjlhZGQ3MmI1MDg2YzQ3M2VmYzlkYWE0YjM3ZTZhMDU0Li5mZGUx MjU4ZjYxYzMwNGRjZjFkZWQyYWNjMWE5OTBlNmQ3ZWVhZTFhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9ydGNfYmFzZS90YXNrX3F1ZXVlX3N0 ZGxpYi5jYworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9y dGNfYmFzZS90YXNrX3F1ZXVlX3N0ZGxpYi5jYwpAQCAtODgsOSArODgsMTEgQEAgY2xhc3MgVGFz a1F1ZXVlU3RkbGliIGZpbmFsIDogcHVibGljIFRhc2tRdWV1ZUJhc2UgewogICAvLyBTaWduYWxl ZCB3aGVuZXZlciBhIG5ldyB0YXNrIGlzIHBlbmRpbmcuCiAgIHJ0Yzo6RXZlbnQgZmxhZ19ub3Rp ZnlfOwogCisjaWYgIWRlZmluZWQoV0VCUlRDX1dFQktJVF9CVUlMRCkKICAgLy8gQ29udGFpbnMg dGhlIGFjdGl2ZSB3b3JrZXIgdGhyZWFkIGFzc2lnbmVkIHRvIHByb2Nlc3NpbmcKICAgLy8gdGFz a3MgKGluY2x1ZGluZyBkZWxheWVkIHRhc2tzKS4KICAgcnRjOjpQbGF0Zm9ybVRocmVhZCB0aHJl YWRfOworI2VuZGlmCiAKICAgTXV0ZXggcGVuZGluZ19sb2NrXzsKIApAQCAtMTE0LDYgKzExNiwx MiBAQCBjbGFzcyBUYXNrUXVldWVTdGRsaWIgZmluYWwgOiBwdWJsaWMgVGFza1F1ZXVlQmFzZSB7 CiAgIC8vIHN0ZDo6dW5pcXVlX3B0ciBvdXQgb2YgdGhlIHF1ZXVlIHdpdGhvdXQgdGhlIHByZXNl bmNlIG9mIGEgaGFjay4KICAgc3RkOjptYXA8RGVsYXllZEVudHJ5VGltZW91dCwgc3RkOjp1bmlx dWVfcHRyPFF1ZXVlZFRhc2s+PiBkZWxheWVkX3F1ZXVlXwogICAgICAgUlRDX0dVQVJERURfQlko cGVuZGluZ19sb2NrXyk7CisKKyNpZiBkZWZpbmVkKFdFQlJUQ19XRUJLSVRfQlVJTEQpCisgIC8v IENvbnRhaW5zIHRoZSBhY3RpdmUgd29ya2VyIHRocmVhZCBhc3NpZ25lZCB0byBwcm9jZXNzaW5n CisgIC8vIHRhc2tzIChpbmNsdWRpbmcgZGVsYXllZCB0YXNrcykuCisgIHJ0Yzo6UGxhdGZvcm1U aHJlYWQgdGhyZWFkXzsKKyNlbmRpZgogfTsKIAogVGFza1F1ZXVlU3RkbGliOjpUYXNrUXVldWVT dGRsaWIoYWJzbDo6c3RyaW5nX3ZpZXcgcXVldWVfbmFtZSwK