226925 2021-06-11 09:12:07 -0700 [check-webkit-style] failing in JS checker due to python byte string 2021-06-11 20:08:34 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain dewei_zhu ews-watchlist glenn hi repstein ryanhaddad webkit-bug-importer oldest_to_newest 1768954 0 jbedard 2021-06-11 09:12:07 -0700 We read JS files in as binary, but then run string regexes against the binary content, which doesn't work. 1768955 1 jbedard 2021-06-11 09:12:30 -0700 <rdar://problem/79166108> 1768961 2 431204 jbedard 2021-06-11 09:16:09 -0700 Created attachment 431204 Patch 1768963 3 431205 jbedard 2021-06-11 09:20:55 -0700 Created attachment 431205 Patch 1768971 4 repstein 2021-06-11 10:18:41 -0700 r=me 1768976 5 jbedard 2021-06-11 10:34:45 -0700 Russell isn't a reviewer, so that "r+" is really an "unofficial r+" 1769009 6 ews-feeder 2021-06-11 11:37:34 -0700 Committed r278771 (238730@main): <https://commits.webkit.org/238730@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431205. 1769174 7 ryanhaddad 2021-06-11 20:08:34 -0700 *** Bug 226904 has been marked as a duplicate of this bug. *** 431204 2021-06-11 09:16:09 -0700 2021-06-11 09:20:53 -0700 Patch bug-226925-20210611091606.patch text/plain 3195 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3ODc2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIxLTA2LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbY2hlY2std2Via2l0LXN0eWxlXSBmYWlsaW5nIGluIEpTIGNoZWNrZXIg ZHVlIHRvIHB5dGhvbiBieXRlIHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI2OTI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTE2NjEw OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvanN0ZXN0LnB5OgorICAgICAgICAobWFwX2Z1 bmN0aW9uc190b19kaWN0KTogVXNlIGJ5dGUgcmVnZXhlcy4KKyAgICAgICAgKHN0cmlwX3RyYWls aW5nX2JsYW5rX2xpbmVzX2FuZF9jb21tZW50cyk6IERpdHRvLgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvanN0ZXN0X3VuaXR0ZXN0LnB5OgorICAgICAgICAoSlNU ZXN0Q2hlY2tlclRlc3RDYXNlLnRlc3RfbWFwX2Z1bmN0aW9uc190b19kaWN0KTogVGVzdCBjb250 ZW50IHNob3VsZCBiZSBieXRlcy4KKwogMjAyMS0wNi0xMSAgSm9uYXRoYW4gQmVkYXJkICA8amJl ZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI3ODQ1NCk6IFtydW4td2Vi a2l0LXRlc3RzXSB3b3JrZXIgaXMgcHJpbnRlZCB0d2ljZSBmb3IgZWFjaCB0ZXN0IGluIGRlYnVn IGxvZ2dpbmcKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvanN0 ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvanN0ZXN0LnB5CShyZXZpc2lvbiAyNzg3NjIpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2pzdGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNjAsOCArNjAsOCBA QCBkZWYgbWFwX2Z1bmN0aW9uc190b19kaWN0KGNvbnRlbnQpOgogICAgIEFyZ3M6CiAgICAgICBj b250ZW50OiBBIG11bHRpLWxpbmUgc3RyaW5nIGNvbnRhaW5pbmcgSmF2YVNjcmlwdCBzb3VyY2Ug dG8gYmUgc3BsaXQgaW50byBpbmRpdmlkdWFsIGZ1bmN0aW9uIGRlZmluaXRpb25zLgogICAgICIi IgotICAgIGZ1bmN0aW9ucyA9IHJlLnNwbGl0KHInXmZ1bmN0aW9uXHMrJywgY29udGVudCwgZmxh Z3M9cmUuTVVMVElMSU5FKQotICAgIGZ1bmN0aW9uX25hbWVfcmVnZXggPSByZS5jb21waWxlKHIn Xig/UDxuYW1lPlx3KylccypcKCcsIGZsYWdzPXJlLk1VTFRJTElORSkKKyAgICBmdW5jdGlvbnMg PSByZS5zcGxpdChicideZnVuY3Rpb25ccysnLCBjb250ZW50LCBmbGFncz1yZS5NVUxUSUxJTkUp CisgICAgZnVuY3Rpb25fbmFtZV9yZWdleCA9IHJlLmNvbXBpbGUoYnInXig/UDxuYW1lPlx3Kylc cypcKCcsIGZsYWdzPXJlLk1VTFRJTElORSkKICAgICByZXN1bHQgPSB7fQogICAgIGZvciBmIGlu IGZ1bmN0aW9uczoKICAgICAgICAgbWF0Y2ggPSBmdW5jdGlvbl9uYW1lX3JlZ2V4Lm1hdGNoKGYp CkBAIC03NywxMSArNzcsMTEgQEAgZGVmIHN0cmlwX3RyYWlsaW5nX2JsYW5rX2xpbmVzX2FuZF9j b21tZQogICAgICAgICBmdW5jdGlvbjogQSBtdWx0aS1saW5lIHN0cmluZyByZXByZXNlbnRpbmcg dGhlIHNvdXJjZSBmb3Igb25lIEphdmFTY3JpcHQgZnVuY3Rpb24sIGxlc3MgdGhlICJmdW5jdGlv biIga2V5d29yZC4KICAgICAiIiIKICAgICBsaW5lcyA9IGZ1bmN0aW9uLnNwbGl0bGluZXMoVHJ1 ZSkKLSAgICBibGFua19saW5lX3JlZ2V4ID0gcmUuY29tcGlsZShyJ15ccyokJykKLSAgICBjb21t ZW50X2xpbmVfcmVnZXggPSByZS5jb21waWxlKHInXlxzKi8vLiokJykKKyAgICBibGFua19saW5l X3JlZ2V4ID0gcmUuY29tcGlsZShicideXHMqJCcpCisgICAgY29tbWVudF9saW5lX3JlZ2V4ID0g cmUuY29tcGlsZShicideXHMqLy8uKiQnKQogICAgIHdoaWxlIGJsYW5rX2xpbmVfcmVnZXguc2Vh cmNoKGxpbmVzWy0xXSkgb3IgY29tbWVudF9saW5lX3JlZ2V4LnNlYXJjaChsaW5lc1stMV0pOgog ICAgICAgICBkZWwgbGluZXNbLTFdCi0gICAgcmV0dXJuICcnLmpvaW4obGluZXMpCisgICAgcmV0 dXJuIGInJy5qb2luKGxpbmVzKQogCiAKIGNsYXNzIEpTVGVzdENoZWNrZXIob2JqZWN0KToKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvanN0ZXN0X3VuaXR0ZXN0 LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv anN0ZXN0X3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNzg3NjIpCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2pzdGVzdF91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpA QCAtMzYsNyArMzYsNyBAQCBjbGFzcyBKU1Rlc3RDaGVja2VyVGVzdENhc2UodW5pdHRlc3QuVGVz CiAKICAgICAgICAgVGhpcyBhbHNvIGltcGxpY2l0bHkgdGVzdHMgc3RyaXBfdHJhaWxpbmdfYmxh bmtfbGluZXNfYW5kX2NvbW1lbnRzKCkuCiAgICAgICAgICIiIgotICAgICAgICBmaWxlMSA9ICIi IgorICAgICAgICBmaWxlMSA9IGIiIiIKIGZ1bmN0aW9uIHNob3VsZEJlKCkge30KIAogLy8gU2Ft ZSBhcyAhc2hvdWxkQmUoKSwgYnV0IG91dHB1dCBtYWtlcyBtb3JlIHNlbnNlLgpAQCAtNTMsNyAr NTMsNyBAQCBmdW5jdGlvbiBzaG91bGRUaHJvdygpIHsKICIiIgogICAgICAgICByZXN1bHQxID0g bWFwX2Z1bmN0aW9uc190b19kaWN0KGZpbGUxKQogCi0gICAgICAgIGZpbGUyID0gIiIiZnVuY3Rp b24gc2hvdWxkQmUoKSB7fQorICAgICAgICBmaWxlMiA9IGIiIiJmdW5jdGlvbiBzaG91bGRCZSgp IHt9CiBmdW5jdGlvbiBzaG91bGROb3RCZSgpIHt9CiBmdW5jdGlvbiBzaG91bGRUaHJvdygpIHsK IH0K 431205 2021-06-11 09:20:55 -0700 2021-06-11 11:37:35 -0700 Patch bug-226925-20210611092054.patch text/plain 3949 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3ODc2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIxLTA2LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbY2hlY2std2Via2l0LXN0eWxlXSBmYWlsaW5nIGluIEpTIGNoZWNrZXIg ZHVlIHRvIHB5dGhvbiBieXRlIHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI2OTI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTE2NjEw OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvanN0ZXN0LnB5OgorICAgICAgICAobWFwX2Z1 bmN0aW9uc190b19kaWN0KTogVXNlIGJ5dGUgcmVnZXhlcy4KKyAgICAgICAgKHN0cmlwX3RyYWls aW5nX2JsYW5rX2xpbmVzX2FuZF9jb21tZW50cyk6IERpdHRvLgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvanN0ZXN0X3VuaXR0ZXN0LnB5OgorICAgICAgICAoSlNU ZXN0Q2hlY2tlclRlc3RDYXNlLnRlc3RfbWFwX2Z1bmN0aW9uc190b19kaWN0KTogVGVzdCBjb250 ZW50IHNob3VsZCBiZSBieXRlcy4KKwogMjAyMS0wNi0xMSAgSm9uYXRoYW4gQmVkYXJkICA8amJl ZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI3ODQ1NCk6IFtydW4td2Vi a2l0LXRlc3RzXSB3b3JrZXIgaXMgcHJpbnRlZCB0d2ljZSBmb3IgZWFjaCB0ZXN0IGluIGRlYnVn IGxvZ2dpbmcKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvanN0 ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvanN0ZXN0LnB5CShyZXZpc2lvbiAyNzg3NjIpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2pzdGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjUsNiArMjUsNyBA QAogCiBpbXBvcnQgcmUKIAorZnJvbSB3ZWJraXRjb3JlcHkgaW1wb3J0IHN0cmluZ191dGlscwog ZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLnN5c3RlbWhvc3QgaW1wb3J0IFN5c3RlbUhvc3QK IAogQUxMX0pTX1RFU1RfRlVOQ1RJT05fRklMRVMgPSBbCkBAIC02MCw4ICs2MSw4IEBAIGRlZiBt YXBfZnVuY3Rpb25zX3RvX2RpY3QoY29udGVudCk6CiAgICAgQXJnczoKICAgICAgIGNvbnRlbnQ6 IEEgbXVsdGktbGluZSBzdHJpbmcgY29udGFpbmluZyBKYXZhU2NyaXB0IHNvdXJjZSB0byBiZSBz cGxpdCBpbnRvIGluZGl2aWR1YWwgZnVuY3Rpb24gZGVmaW5pdGlvbnMuCiAgICAgIiIiCi0gICAg ZnVuY3Rpb25zID0gcmUuc3BsaXQocideZnVuY3Rpb25ccysnLCBjb250ZW50LCBmbGFncz1yZS5N VUxUSUxJTkUpCi0gICAgZnVuY3Rpb25fbmFtZV9yZWdleCA9IHJlLmNvbXBpbGUocideKD9QPG5h bWU+XHcrKVxzKlwoJywgZmxhZ3M9cmUuTVVMVElMSU5FKQorICAgIGZ1bmN0aW9ucyA9IHJlLnNw bGl0KGJyJ15mdW5jdGlvblxzKycsIGNvbnRlbnQsIGZsYWdzPXJlLk1VTFRJTElORSkKKyAgICBm dW5jdGlvbl9uYW1lX3JlZ2V4ID0gcmUuY29tcGlsZShicideKD9QPG5hbWU+XHcrKVxzKlwoJywg ZmxhZ3M9cmUuTVVMVElMSU5FKQogICAgIHJlc3VsdCA9IHt9CiAgICAgZm9yIGYgaW4gZnVuY3Rp b25zOgogICAgICAgICBtYXRjaCA9IGZ1bmN0aW9uX25hbWVfcmVnZXgubWF0Y2goZikKQEAgLTc3 LDExICs3OCwxMSBAQCBkZWYgc3RyaXBfdHJhaWxpbmdfYmxhbmtfbGluZXNfYW5kX2NvbW1lCiAg ICAgICAgIGZ1bmN0aW9uOiBBIG11bHRpLWxpbmUgc3RyaW5nIHJlcHJlc2VudGluZyB0aGUgc291 cmNlIGZvciBvbmUgSmF2YVNjcmlwdCBmdW5jdGlvbiwgbGVzcyB0aGUgImZ1bmN0aW9uIiBrZXl3 b3JkLgogICAgICIiIgogICAgIGxpbmVzID0gZnVuY3Rpb24uc3BsaXRsaW5lcyhUcnVlKQotICAg IGJsYW5rX2xpbmVfcmVnZXggPSByZS5jb21waWxlKHInXlxzKiQnKQotICAgIGNvbW1lbnRfbGlu ZV9yZWdleCA9IHJlLmNvbXBpbGUocideXHMqLy8uKiQnKQorICAgIGJsYW5rX2xpbmVfcmVnZXgg PSByZS5jb21waWxlKGJyJ15ccyokJykKKyAgICBjb21tZW50X2xpbmVfcmVnZXggPSByZS5jb21w aWxlKGJyJ15ccyovLy4qJCcpCiAgICAgd2hpbGUgYmxhbmtfbGluZV9yZWdleC5zZWFyY2gobGlu ZXNbLTFdKSBvciBjb21tZW50X2xpbmVfcmVnZXguc2VhcmNoKGxpbmVzWy0xXSk6CiAgICAgICAg IGRlbCBsaW5lc1stMV0KLSAgICByZXR1cm4gJycuam9pbihsaW5lcykKKyAgICByZXR1cm4gYicn LmpvaW4obGluZXMpCiAKIAogY2xhc3MgSlNUZXN0Q2hlY2tlcihvYmplY3QpOgpAQCAtMTM2LDUg KzEzNyw1IEBAIGNsYXNzIEpTVGVzdENoZWNrZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICBp ZiBmdW5jdGlvbl9uYW1lIGluIGJhc2VsaW5lX2Z1bmN0aW9uX21hcC5rZXlzKCkgYW5kIGZ1bmN0 aW9uX25hbWUgaW4gdGVzdF9mdW5jdGlvbl9tYXAua2V5cygpOgogICAgICAgICAgICAgICAgICAg ICBpZiBiYXNlbGluZV9mdW5jdGlvbl9tYXBbZnVuY3Rpb25fbmFtZV0gIT0gdGVzdF9mdW5jdGlv bl9tYXBbZnVuY3Rpb25fbmFtZV06CiAgICAgICAgICAgICAgICAgICAgICAgICBlcnJvcl9tZXNz YWdlID0gIkNoYW5nZXMgdG8gZnVuY3Rpb24gezB9KCkgc2hvdWxkIGJlIGtlcHQgaW4gc3luYyB3 aXRoIHsxfS4iLmZvcm1hdCgKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBmdW5jdGlvbl9u YW1lLCBwYXRoKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cmluZ191dGlscy5kZWNv ZGUoZnVuY3Rpb25fbmFtZSksIHBhdGgpCiAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLl9o YW5kbGVfc3R5bGVfZXJyb3IoMCwgJ2pzdGVzdC9mdW5jdGlvbl9lcXVhbGl0eScsIDUsIGVycm9y X21lc3NhZ2UpCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2pz dGVzdF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2pzdGVzdF91bml0dGVzdC5weQkocmV2aXNpb24gMjc4NzYyKQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9qc3Rlc3RfdW5pdHRlc3QucHkJKHdv cmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDcgQEAgY2xhc3MgSlNUZXN0Q2hlY2tlclRlc3RDYXNl KHVuaXR0ZXN0LlRlcwogCiAgICAgICAgIFRoaXMgYWxzbyBpbXBsaWNpdGx5IHRlc3RzIHN0cmlw X3RyYWlsaW5nX2JsYW5rX2xpbmVzX2FuZF9jb21tZW50cygpLgogICAgICAgICAiIiIKLSAgICAg ICAgZmlsZTEgPSAiIiIKKyAgICAgICAgZmlsZTEgPSBiIiIiCiBmdW5jdGlvbiBzaG91bGRCZSgp IHt9CiAKIC8vIFNhbWUgYXMgIXNob3VsZEJlKCksIGJ1dCBvdXRwdXQgbWFrZXMgbW9yZSBzZW5z ZS4KQEAgLTUzLDcgKzUzLDcgQEAgZnVuY3Rpb24gc2hvdWxkVGhyb3coKSB7CiAiIiIKICAgICAg ICAgcmVzdWx0MSA9IG1hcF9mdW5jdGlvbnNfdG9fZGljdChmaWxlMSkKIAotICAgICAgICBmaWxl MiA9ICIiImZ1bmN0aW9uIHNob3VsZEJlKCkge30KKyAgICAgICAgZmlsZTIgPSBiIiIiZnVuY3Rp b24gc2hvdWxkQmUoKSB7fQogZnVuY3Rpb24gc2hvdWxkTm90QmUoKSB7fQogZnVuY3Rpb24gc2hv dWxkVGhyb3coKSB7CiB9Cg==