226922 2021-06-11 08:32:47 -0700 Safari 15 breaks all Web Audio content using WebM Opus 2022-05-14 13:11:46 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=227110 https://bugs.webkit.org/show_bug.cgi?id=227111 https://bugs.webkit.org/show_bug.cgi?id=227198 https://bugs.webkit.org/show_bug.cgi?id=229799 https://bugs.webkit.org/show_bug.cgi?id=238546 InRadar P2 Critical --- 1 ashley jean-yves.avenard brad calvaris cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim james jean-yves.avenard jer.noble jonlee peng.liu6 philipj sam sergio webkit-bug-importer youennf oldest_to_newest 1768941 0 ashley 2021-06-11 08:32:47 -0700 Thanks for adding WebM Opus support in Safari 15! We've been waiting for this for a long time. However currently it is supported only for the HTML <audio> element. Web Audio's decodeAudioData() still fails to decode WebM Opus. This breaks all existing web content using Web Audio with support for WebM Opus, which includes all content published with Construct 3 (www.construct.net) since 2017. The reason for this is there is no API to feature detect which audio formats are supported by Web Audio specifically. So in practice all web content uses HTMLMediaElement.canPlayType() to detect which formats are supported for Web Audio. This has worked for years since in all other browsers decodeAudioData() has always supported the same formats as <audio>. However in Safari 15 canPlayType() indicates WebM Opus is playable, but that misleads existing web content in to trying to decode WebM Opus with decodeAudioData(), which doesn't work. In our case if WebM Opus is detected as not playable, we fall back to a WebAssembly decoder. But since Safari 15 indicates support for WebM Opus, our code skips the WebAssembly decoder and tries to use decodeAudioData() directly, which fails. Since no feature detection API exists for Web Audio, it's also difficult to detect this case. Minimal repro: https://downloads.scirra.com/labs/audioCodecTests/ Look under the "WebM Opus" section. <audio> support is indicated via "HTML5 audio support: probably". However decodeAudioData support is missing via "Web Audio API decodeAudioData() support: No (error: null)". Real-world example: https://downloads.scirra.com/labs/kiwistory/ In Safari 14.x and older, both music and sound effects play fine. In Safari 15, the music plays (as it uses <audio>), but no sound effects play (as those use Web Audio). The console logs decoding errors as it has attempted to use decodeAudioData() with WebM Opus, which failed. Therefore users upgrading to Safari 15 will find Web Audio content regresses and stops playing sound. Even if we deploy a workaround in our engine, as noted there is years of content already published, and much of it is unlikely to be updated, so many Safari 15 users will still find audio regresses and stops working. So it's important this is fixed before Safari 15 is fully released. In general, Safari must support all the same formats with <audio> and decodeAudioData() in order to be compatible with existing Web Audio content, since canPlayType() is also the de-facto feature detection API for decodeAudioData(). 1769085 1 webkit-bug-importer 2021-06-11 15:10:11 -0700 <rdar://problem/79218243> 1770468 2 jean-yves.avenard 2021-06-16 16:50:56 -0700 It’s actually in the spec, that decodeAudioData : "Audio file data can be in any of the formats supported by the audio element." ref: https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-decodeaudiodata 1771218 3 431831 jean-yves.avenard 2021-06-20 23:28:41 -0700 Created attachment 431831 Patch 1771224 4 431833 jean-yves.avenard 2021-06-21 00:41:06 -0700 Created attachment 431833 Patch 1771328 5 431833 eric.carlson 2021-06-21 10:09:10 -0700 Comment on attachment 431833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431833&action=review > Source/WebCore/html/HTMLMediaElement.cpp:1049 > + // Temporary work around bug 226922. For now claim that the opus and vorbis codecs aren't supported s/Temporary/Temporarily/ 1771596 6 431945 jean-yves.avenard 2021-06-21 21:19:15 -0700 Created attachment 431945 Patch apply comment 1771602 7 ews-feeder 2021-06-21 21:57:31 -0700 Committed r279103 (239020@main): <https://commits.webkit.org/239020@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431945. 1773391 8 jean-yves.avenard 2021-06-29 06:05:48 -0700 *** Bug 227198 has been marked as a duplicate of this bug. *** 1802356 9 sam 2021-10-08 20:34:15 -0700 When will this fix be published? I noticed it was closed way back in June. Seems like it would've been published sooner since it's marked as critical. 1802383 10 jean-yves.avenard 2021-10-09 05:09:20 -0700 (In reply to sam from comment #9) > When will this fix be published? I noticed it was closed way back in June. > Seems like it would've been published sooner since it's marked as critical. It is now fixed. The fix is now available in Safari Technology Preview 132 and later. 431831 2021-06-20 23:28:41 -0700 2021-06-21 00:41:01 -0700 Patch bug-226922-20210621162840.patch text/plain 1953 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjNkYjY1MGUzY2Y1NzAy YTYyNDA1YmMyYmNjMWY2ZDg4MGJmN2E3MC4uNDA1ZTQ4MDc0ZjQxNzQ3MWMwOTkyYzg0NmY0YzJk MTk4MWJmOThjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTIwICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgU2FmYXJpIDE1IGJyZWFr cyBhbGwgV2ViIEF1ZGlvIGNvbnRlbnQgdXNpbmcgV2ViTSBPcHVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5MjIKKyAgICAgICAgcmRhcjovLzc5 MjE4MjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGVtcG9yYXJpbHkgcmVwb3J0cyB0aGF0IG5laXRoZXIgT3B1cyBhbmQgVm9yYmlzIGF1ZGlvIGNv ZGVjIGFyZSBzdXBwb3J0ZWQgdG8gYWxsb3cKKyAgICAgICAgd2ViYXVkaW8gc2l0ZXMgdG8gZmFs bGJhY2sgdG8gb3RoZXIgY29udGFpbmVycy4gVGhlIGNvbnRlbnQgd2lsbCBjb250aW51ZSB0byBw bGF5CisgICAgICAgIGFzIGJlZm9yZS4gV2lsbCBiZSByZXZlcnRlZCBvbmNlIGJ1ZyAyMjcxMTAg bGFuZHMuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6Y2FuUGxheVR5cGUgY29uc3QpOgorCiAyMDIxLTA2 LTIwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtM aXZlIFRleHRdIE1vdXNlIGV2ZW50cyBzaG91bGQgb25seSB0cmlnZ2VyIHRleHQgcmVjb2duaXRp b24gaWYgdGhlIGN1cnNvciBpcyBtb3ZpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwCmluZGV4IDNmMjFkZmU4ZWQxNzljMjY5NmU0YzYxODUyMTQ5OWNkNmE2NjdjZDQu LjI4N2I3M2IwMWMyZTU1MDRlNDBmZjFlNDUxZTU4OWE3ZjNkYWM0NDEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtMTA0NSw2ICsxMDQ1LDEyIEBAIFN0cmlu ZyBIVE1MTWVkaWFFbGVtZW50OjpjYW5QbGF5VHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlKSBj b25zdAogICAgIE1lZGlhUGxheWVyOjpTdXBwb3J0c1R5cGUgc3VwcG9ydCA9IE1lZGlhUGxheWVy OjpzdXBwb3J0c1R5cGUocGFyYW1ldGVycyk7CiAgICAgU3RyaW5nIGNhblBsYXk7CiAKKyAgICAv LyBUZW1wb3Jhcnkgd29yayBhcm91bmQgYnVnIDIyNjkyMi4gRm9yIG5vdyBjbGFpbSB0aGF0IHRo ZSBvcHVzIGFuZCB2b3JiaXMgY29kZWNzIGFyZW4ndCBzdXBwb3J0ZWQKKyAgICAvLyBzbyB0aGF0 IHNpdGVzIHJlbHlpbmcgb24gdGhpcyB0ZXN0IHRvIGRldGVybWluZSBpZiB3ZWJhdWRpbyB1c2Ug b2Ygb3B1cyBvciB2b3JiaXMgd29uJ3QgZXJyb3IuCisgICAgYXV0byBjb2RlY3MgPSBjb250ZW50 VHlwZS5jb2RlY3MoKTsKKyAgICBpZiAoc3VwcG9ydCA9PSBNZWRpYVBsYXllcjo6U3VwcG9ydHNU eXBlOjpJc1N1cHBvcnRlZCAmJiAoY29kZWNzLmNvbnRhaW5zKCJvcHVzIikgfHwgY29kZWNzLmNv bnRhaW5zKCJ2b3JiaXMiKSkpCisgICAgICAgIHN1cHBvcnQgPSBNZWRpYVBsYXllcjo6U3VwcG9y dHNUeXBlOjpJc05vdFN1cHBvcnRlZDsKKwogICAgIC8vIDQuOC4xMC4zCiAgICAgc3dpdGNoIChz dXBwb3J0KQogICAgIHsK 431833 2021-06-21 00:41:06 -0700 2021-06-21 21:19:10 -0700 Patch bug-226922-20210621174104.patch text/plain 1966 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk1MWY4Nzc5MzU5ODQ0 Nzk2MjFiYWYzNzRjNzZlY2YyZWZiNDU2MS4uZDg5ZTcwYTVlZTZkZmFmOWViNjM1ZTRiYTQxMjJl YTNiNGRlODE0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTIwICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgU2FmYXJpIDE1IGJyZWFr cyBhbGwgV2ViIEF1ZGlvIGNvbnRlbnQgdXNpbmcgV2ViTSBPcHVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5MjIKKyAgICAgICAgcmRhcjovLzc5 MjE4MjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGVtcG9yYXJpbHkgcmVwb3J0cyB0aGF0IG5laXRoZXIgT3B1cyBhbmQgVm9yYmlzIGF1ZGlvIGNv ZGVjIGFyZSBzdXBwb3J0ZWQgdG8gYWxsb3cKKyAgICAgICAgd2ViYXVkaW8gc2l0ZXMgdG8gZmFs bGJhY2sgdG8gb3RoZXIgY29udGFpbmVycy4gVGhlIGNvbnRlbnQgd2lsbCBjb250aW51ZSB0byBw bGF5CisgICAgICAgIGFzIGJlZm9yZS4gV2lsbCBiZSByZXZlcnRlZCBvbmNlIGJ1ZyAyMjcxMTAg bGFuZHMuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6Y2FuUGxheVR5cGUgY29uc3QpOgorCiAyMDIxLTA2 LTIxICBKZWFuLVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CiAKICAgICAgICAgTWVyZ2Ug QXVkaW9GaWxlUmVhZGVyTWFjIGFuZCBBdWRpb0ZpbGVSZWFkZXJJT1MgaW50byBBdWRpb0ZpbGVS ZWFkZXJDb2NvYQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXgg M2YyMWRmZThlZDE3OWMyNjk2ZTRjNjE4NTIxNDk5Y2Q2YTY2N2NkNC4uMGM4YTM1YWFhMmUwNzU5 OWVmYjM1MjA3YTg3ZmYwMWMxN2IwYTA5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwCkBAIC0xMDQ1LDYgKzEwNDUsMTQgQEAgU3RyaW5nIEhUTUxNZWRpYUVsZW1l bnQ6OmNhblBsYXlUeXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpIGNvbnN0CiAgICAgTWVkaWFQ bGF5ZXI6OlN1cHBvcnRzVHlwZSBzdXBwb3J0ID0gTWVkaWFQbGF5ZXI6OnN1cHBvcnRzVHlwZShw YXJhbWV0ZXJzKTsKICAgICBTdHJpbmcgY2FuUGxheTsKIAorI2lmIFBMQVRGT1JNKENPQ09BKQor ICAgIC8vIFRlbXBvcmFyeSB3b3JrIGFyb3VuZCBidWcgMjI2OTIyLiBGb3Igbm93IGNsYWltIHRo YXQgdGhlIG9wdXMgYW5kIHZvcmJpcyBjb2RlY3MgYXJlbid0IHN1cHBvcnRlZAorICAgIC8vIHNv IHRoYXQgc2l0ZXMgcmVseWluZyBvbiB0aGlzIHRlc3QgdG8gZGV0ZXJtaW5lIGlmIHdlYmF1ZGlv IHVzZSBvZiBvcHVzIG9yIHZvcmJpcyB3b24ndCBlcnJvci4KKyAgICBhdXRvIGNvZGVjcyA9IGNv bnRlbnRUeXBlLmNvZGVjcygpOworICAgIGlmIChzdXBwb3J0ID09IE1lZGlhUGxheWVyOjpTdXBw b3J0c1R5cGU6OklzU3VwcG9ydGVkICYmIChjb2RlY3MuY29udGFpbnMoIm9wdXMiKSB8fCBjb2Rl Y3MuY29udGFpbnMoInZvcmJpcyIpKSkKKyAgICAgICAgc3VwcG9ydCA9IE1lZGlhUGxheWVyOjpT dXBwb3J0c1R5cGU6OklzTm90U3VwcG9ydGVkOworI2VuZGlmCisKICAgICAvLyA0LjguMTAuMwog ICAgIHN3aXRjaCAoc3VwcG9ydCkKICAgICB7Cg== 431945 2021-06-21 21:19:15 -0700 2021-06-21 21:57:32 -0700 Patch bug-226922-20210622141914.patch text/plain 1966 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWFkZmIyYmVjMTI5NTkx ZGM3NDQ3MDIxN2I4Mzk2ZDI1ODU3ODRiYy4uOTJmYmQ0YTZmZjFiNmRiYjIwYzNkOWIyMTYxNGJl MTg2OGVkZTMyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTIwICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgU2FmYXJpIDE1IGJyZWFr cyBhbGwgV2ViIEF1ZGlvIGNvbnRlbnQgdXNpbmcgV2ViTSBPcHVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5MjIKKyAgICAgICAgcmRhcjovLzc5 MjE4MjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgorCisgICAgICAgIFRl bXBvcmFyaWx5IHJlcG9ydHMgdGhhdCBuZWl0aGVyIE9wdXMgYW5kIFZvcmJpcyBhdWRpbyBjb2Rl YyBhcmUgc3VwcG9ydGVkIHRvIGFsbG93CisgICAgICAgIHdlYmF1ZGlvIHNpdGVzIHRvIGZhbGxi YWNrIHRvIG90aGVyIGNvbnRhaW5lcnMuIFRoZSBjb250ZW50IHdpbGwgY29udGludWUgdG8gcGxh eQorICAgICAgICBhcyBiZWZvcmUuIFdpbGwgYmUgcmV2ZXJ0ZWQgb25jZSBidWcgMjI3MTEwIGxh bmRzLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNhblBsYXlUeXBlIGNvbnN0KToKKwogMjAyMS0wNi0y MSAgSmVhbi1ZdmVzIEF2ZW5hcmQgIDxqeWFAYXBwbGUuY29tPgogCiAgICAgICAgIE1lcmdlIEF1 ZGlvRmlsZVJlYWRlck1hYyBhbmQgQXVkaW9GaWxlUmVhZGVySU9TIGludG8gQXVkaW9GaWxlUmVh ZGVyQ29jb2EKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IDNm MjFkZmU4ZWQxNzljMjY5NmU0YzYxODUyMTQ5OWNkNmE2NjdjZDQuLmUwNTE2YTRhZjI1ZDJiNWE0 ZDQ5NGNlNDM1MDk2ODQxNDFiNjdkOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcApAQCAtMTA0NSw2ICsxMDQ1LDE0IEBAIFN0cmluZyBIVE1MTWVkaWFFbGVtZW50 OjpjYW5QbGF5VHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlKSBjb25zdAogICAgIE1lZGlhUGxh eWVyOjpTdXBwb3J0c1R5cGUgc3VwcG9ydCA9IE1lZGlhUGxheWVyOjpzdXBwb3J0c1R5cGUocGFy YW1ldGVycyk7CiAgICAgU3RyaW5nIGNhblBsYXk7CiAKKyNpZiBQTEFURk9STShDT0NPQSkKKyAg ICAvLyBUZW1wb3JhcmlseSB3b3JrIGFyb3VuZCBidWcgMjI2OTIyLiBGb3Igbm93IGNsYWltIHRo YXQgdGhlIG9wdXMgYW5kIHZvcmJpcyBjb2RlY3MgYXJlbid0IHN1cHBvcnRlZAorICAgIC8vIHNv IHRoYXQgc2l0ZXMgcmVseWluZyBvbiB0aGlzIHRlc3QgdG8gZGV0ZXJtaW5lIGlmIHdlYmF1ZGlv IHVzZSBvZiBvcHVzIG9yIHZvcmJpcyB3b24ndCBlcnJvci4KKyAgICBhdXRvIGNvZGVjcyA9IGNv bnRlbnRUeXBlLmNvZGVjcygpOworICAgIGlmIChzdXBwb3J0ID09IE1lZGlhUGxheWVyOjpTdXBw b3J0c1R5cGU6OklzU3VwcG9ydGVkICYmIChjb2RlY3MuY29udGFpbnMoIm9wdXMiKSB8fCBjb2Rl Y3MuY29udGFpbnMoInZvcmJpcyIpKSkKKyAgICAgICAgc3VwcG9ydCA9IE1lZGlhUGxheWVyOjpT dXBwb3J0c1R5cGU6OklzTm90U3VwcG9ydGVkOworI2VuZGlmCisKICAgICAvLyA0LjguMTAuMwog ICAgIHN3aXRjaCAoc3VwcG9ydCkKICAgICB7Cg==