226920 2021-06-11 07:54:05 -0700 GLES and EGL from ANGLE should link with libdl 2021-06-11 11:09:23 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Local Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 estea webkit-unassigned annulen dino don.olmstead ews-watchlist gyuyoung.kim kbr kkinnunen kondapallykalyan ryuan.choi sergio webkit-bug-importer oldest_to_newest 1768929 0 estea 2021-06-11 07:54:05 -0700 GLES and EGL that are generated from ANGLE should link with libdl because they use dlsym and dlopen. Also, initially I thought that we shouldn't link with libEGL when we use USE_ANGLE_WEBGL instead of USE_ANGLE_EGL because the symbols of EGL were found in generated libGLES. But with the new CMakeLists.txt I see that libEGL contains the right symbols and so, we can link with it in both cases. 1768932 1 431194 estea 2021-06-11 08:00:56 -0700 Created attachment 431194 Patch 1768933 2 ews-watchlist 2021-06-11 08:02:03 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1768939 3 431197 estea 2021-06-11 08:27:37 -0700 Created attachment 431197 Patch 1768940 4 estea 2021-06-11 08:29:50 -0700 [Update]: I've removed EGL from the case we use WEBGL and fixed -dl to be platform specific using the CMake variable (thanks Don Olmstead!). 1768975 5 431197 kbr 2021-06-11 10:33:51 -0700 Comment on attachment 431197 Patch Looks good; r+. 1768994 6 ews-feeder 2021-06-11 11:08:40 -0700 Committed r278768 (238727@main): <https://commits.webkit.org/238727@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431197. 1768996 7 webkit-bug-importer 2021-06-11 11:09:23 -0700 <rdar://problem/79207140> 431194 2021-06-11 08:00:56 -0700 2021-06-11 08:27:30 -0700 Patch bug-226920-20210611180054.patch text/plain 2345 estea U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNDA4ZjM4MzY0ZjgxN2MyZWM5YzI5ZGRkYzU0OThkMzU3ZDNiNGU0ZS4uZThhY2I3NjZhODEz OGI2NGNiZWI4MzM1M2YyZjllOTgyZDZlOTU2OSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTExICBFbGVuaSBNYXJpYSBTdGVhICA8ZXN0ZWFA aWdhbGlhLmNvbT4KKworICAgICAgICBBTkdMRSBFR0wgYW5kIEdMRVMgbGlicmFyaWVzIHNob3Vs ZCBsaW5rIHdpdGggbGliIGRsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI2OTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgR0xFUyBhbmQgRUdMIHRoYXQgYXJlIGdlbmVyYXRlZCBmcm9tIEFOR0xFIHNo b3VsZCBsaW5rCisgICAgICAgIHdpdGggbGliZGwgYmVjYXVzZSB0aGV5IHVzZSBkbHN5bSBhbmQg ZGxvcGVuLiBBbHNvLAorICAgICAgICB3aXRoIHRoZSB1cGRhdGVkIENNYWtlTGlzdHMudHh0IHdl IGNhbiBzYWZlbHkgbGluayB3aXRoIGxpYkVHTAorICAgICAgICB3aGVuIFVTRV9BTkdMRV9XRUJH TCBpcyBzZXQgYmVjYXVzZSB0aGUgc3ltYm9scyBvZiBFR0wgYXJlIG5vdworICAgICAgICBmb3Vu ZC4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDIxLTA2LTEwICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBNYWtlIEFOR0xF IGxpYnJhcnkgdHlwZXMgY29uZmlndXJhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NNYWtlTGlz dHMudHh0CmluZGV4IDAzMmVjYzljYjBlNGVmN2U0YmNlNjIyOWJkZTUyMGU2MjU5MGNhNTcuLmUx Y2ZlZDZjYWZlN2JhMzJjN2Q5ZDhiMzFhNDE1ZDA1ODQ4MTIzYjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL0NNYWtlTGlzdHMudHh0CkBAIC0xNTEsNyArMTUxLDcgQEAgaWYgKFVTRV9BTkdMRV9F R0wgT1IgVVNFX0FOR0xFX1dFQkdMKQogICAgICAgICAke25vX2dsX3Byb3RvdHlwZXN9CiAgICAg ICAgIExJQkdMRVNWMl9JTVBMRU1FTlRBVElPTgogICAgICkKLSAgICB0YXJnZXRfbGlua19saWJy YXJpZXMoR0xFU3YyIFBSSVZBVEUgJHtBTkdMRUdMRVN2Ml9MSUJSQVJJRVN9KQorICAgIHRhcmdl dF9saW5rX2xpYnJhcmllcyhHTEVTdjIgUFJJVkFURSAke0FOR0xFR0xFU3YyX0xJQlJBUklFU30g LWxkbCkKICAgICBpZiAoV0lOMzIpCiAgICAgICAgICMgT3V0cHV0IGxpYnJhcnkgbmFtZSBhY2Nv cmRpbmcgdG8gdGhlIC5kZWYKICAgICAgICAgdGFyZ2V0X3NvdXJjZXMoR0xFU3YyIFBSSVZBVEUg c3JjL2xpYkdMRVN2Mi9saWJHTEVTdjJfYXV0b2dlbi5kZWYpCkBAIC0xNjQsNyArMTY0LDcgQEAg aWYgKFVTRV9BTkdMRV9FR0wgT1IgVVNFX0FOR0xFX1dFQkdMKQogICAgIHRhcmdldF9jb21waWxl X2RlZmluaXRpb25zKEdMRVN2MkZyYW1ld29yayBJTlRFUkZBQ0UgVVNFX1NZU1RFTV9FR0wpCiAg ICAgYWRkX2xpYnJhcnkoQU5HTEU6OkdMRVMgQUxJQVMgR0xFU3YyRnJhbWV3b3JrKQogCi0gICAg aWYgKFVTRV9BTkdMRV9FR0wpCisgICAgaWYgKFVTRV9BTkdMRV9FR0wgT1IgVVNFX0FOR0xFX1dF QkdMKQogICAgICAgICBhZGRfbGlicmFyeShFR0wgJHtFR0xfTElCUkFSWV9UWVBFfQogICAgICAg ICAgICAgJHtsaWJlZ2xfc291cmNlc30KICAgICAgICAgKQpAQCAtMTc0LDcgKzE3NCw3IEBAIGlm IChVU0VfQU5HTEVfRUdMIE9SIFVTRV9BTkdMRV9XRUJHTCkKICAgICAgICAgICAgICR7Z2xfcHJv dG90eXBlc30KICAgICAgICAgICAgIEVHTEFQST0KICAgICAgICAgKQotICAgICAgICB0YXJnZXRf bGlua19saWJyYXJpZXMoRUdMIFBSSVZBVEUgR0xFU3YyKQorICAgICAgICB0YXJnZXRfbGlua19s aWJyYXJpZXMoRUdMIFBSSVZBVEUgR0xFU3YyIC1sZGwpCiAgICAgICAgIHNldF90YXJnZXRfcHJv cGVydGllcyhFR0wgUFJPUEVSVElFUyBMSU5LRVJfTEFOR1VBR0UgQ1hYKQogICAgICAgICBpZiAo V0lOMzIpCiAgICAgICAgICAgICAjIE91dHB1dCBsaWJyYXJ5IG5hbWVzIGFjY29yZGluZyB0byB0 aGUgLmRlZgo= 431197 2021-06-11 08:27:37 -0700 2021-06-11 11:08:42 -0700 Patch bug-226920-20210611182736.patch text/plain 2037 estea U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNDA4ZjM4MzY0ZjgxN2MyZWM5YzI5ZGRkYzU0OThkMzU3ZDNiNGU0ZS4uZThhY2I3NjZhODEz OGI2NGNiZWI4MzM1M2YyZjllOTgyZDZlOTU2OSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTExICBFbGVuaSBNYXJpYSBTdGVhICA8ZXN0ZWFA aWdhbGlhLmNvbT4KKworICAgICAgICBBTkdMRSBFR0wgYW5kIEdMRVMgbGlicmFyaWVzIHNob3Vs ZCBsaW5rIHdpdGggbGliIGRsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI2OTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgR0xFUyBhbmQgRUdMIHRoYXQgYXJlIGdlbmVyYXRlZCBmcm9tIEFOR0xFIHNo b3VsZCBsaW5rCisgICAgICAgIHdpdGggbGliZGwgYmVjYXVzZSB0aGV5IHVzZSBkbHN5bSBhbmQg ZGxvcGVuLiBBbHNvLAorICAgICAgICB3aXRoIHRoZSB1cGRhdGVkIENNYWtlTGlzdHMudHh0IHdl IGNhbiBzYWZlbHkgbGluayB3aXRoIGxpYkVHTAorICAgICAgICB3aGVuIFVTRV9BTkdMRV9XRUJH TCBpcyBzZXQgYmVjYXVzZSB0aGUgc3ltYm9scyBvZiBFR0wgYXJlIG5vdworICAgICAgICBmb3Vu ZC4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDIxLTA2LTEwICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBNYWtlIEFOR0xF IGxpYnJhcnkgdHlwZXMgY29uZmlndXJhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NNYWtlTGlz dHMudHh0CmluZGV4IDAzMmVjYzljYjBlNGVmN2U0YmNlNjIyOWJkZTUyMGU2MjU5MGNhNTcuLmQz ZTQ1MjRkMzcwMTQ2NjRhNzI1YWUzNGJmMmRmNmQwMWI4YWQ5YWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL0NNYWtlTGlzdHMudHh0CkBAIC0xNTEsNyArMTUxLDkgQEAgaWYgKFVTRV9BTkdMRV9F R0wgT1IgVVNFX0FOR0xFX1dFQkdMKQogICAgICAgICAke25vX2dsX3Byb3RvdHlwZXN9CiAgICAg ICAgIExJQkdMRVNWMl9JTVBMRU1FTlRBVElPTgogICAgICkKLSAgICB0YXJnZXRfbGlua19saWJy YXJpZXMoR0xFU3YyIFBSSVZBVEUgJHtBTkdMRUdMRVN2Ml9MSUJSQVJJRVN9KQorCisgICAgdGFy Z2V0X2xpbmtfbGlicmFyaWVzKEdMRVN2MiBQUklWQVRFICR7QU5HTEVHTEVTdjJfTElCUkFSSUVT fSAke0NNQUtFX0RMX0xJQlN9KQorCiAgICAgaWYgKFdJTjMyKQogICAgICAgICAjIE91dHB1dCBs aWJyYXJ5IG5hbWUgYWNjb3JkaW5nIHRvIHRoZSAuZGVmCiAgICAgICAgIHRhcmdldF9zb3VyY2Vz KEdMRVN2MiBQUklWQVRFIHNyYy9saWJHTEVTdjIvbGliR0xFU3YyX2F1dG9nZW4uZGVmKQpAQCAt MTc0LDcgKzE3Niw5IEBAIGlmIChVU0VfQU5HTEVfRUdMIE9SIFVTRV9BTkdMRV9XRUJHTCkKICAg ICAgICAgICAgICR7Z2xfcHJvdG90eXBlc30KICAgICAgICAgICAgIEVHTEFQST0KICAgICAgICAg KQotICAgICAgICB0YXJnZXRfbGlua19saWJyYXJpZXMoRUdMIFBSSVZBVEUgR0xFU3YyKQorCisg ICAgICAgIHRhcmdldF9saW5rX2xpYnJhcmllcyhFR0wgUFJJVkFURSBHTEVTdjIgJHtDTUFLRV9E TF9MSUJTfSkKKwogICAgICAgICBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoRUdMIFBST1BFUlRJRVMg TElOS0VSX0xBTkdVQUdFIENYWCkKICAgICAgICAgaWYgKFdJTjMyKQogICAgICAgICAgICAgIyBP dXRwdXQgbGlicmFyeSBuYW1lcyBhY2NvcmRpbmcgdG8gdGhlIC5kZWYK