226908 2021-06-10 18:10:25 -0700 [WinCairo] Can't open WebInspector UI since r277787 2021-11-11 12:34:29 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii ap don.olmstead ews-watchlist hi jasemabeed114 joepeck kkinnunen webkit-bug-importer oldest_to_newest 1768834 0 fujii 2021-06-10 18:10:25 -0700 [WinCairo][WK2] Can't open WebInspector UI since r277787 1. Start WinCairo WK2 MiniBrowser 2. Menu -> Develop -> Show Web Inspector Extected: Web Inspector appears. Actual: Nothing appears. r277787 (Bug 226001) changed the return type of WebURLSchemeTask::request() from const WebCore::ResourceRequest& to WebCore::ResourceRequest. InspectorResourceURLSchemeHandler::platformStartTask shouldn't hold the reference of temporary object. 1768836 1 431164 fujii 2021-06-10 18:21:02 -0700 Created attachment 431164 WIP patch 1768838 2 431165 fujii 2021-06-10 18:35:12 -0700 Created attachment 431165 Patch 1768849 3 431165 fujii 2021-06-10 19:36:49 -0700 Comment on attachment 431165 Patch Clearing flags on attachment: 431165 Committed r278748 (238709@main): <https://commits.webkit.org/238709@main> 1768850 4 fujii 2021-06-10 19:36:52 -0700 All reviewed patches have been landed. Closing bug. 1768851 5 webkit-bug-importer 2021-06-10 19:37:18 -0700 <rdar://problem/79174706> 1814145 6 431165 ap 2021-11-11 11:52:15 -0800 Comment on attachment 431165 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review > Source/WebKit/ChangeLog:13 > + InspectorResourceURLSchemeHandler::platformStartTask shouldn't > + hold the reference of the temporary object. What is the problem with that? Is it a bug in the compiler that you use? 1814152 7 431165 fujii 2021-11-11 12:04:24 -0800 Comment on attachment 431165 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review >> Source/WebKit/ChangeLog:13 >> + hold the reference of the temporary object. > > What is the problem with that? Is it a bug in the compiler that you use? This is not a compiler issue. task.request() returns a ResourceRequest object. task.request().url() returns a URL of it. However, the ResourceRequest object is destructed on the end of the line. 1814164 8 ap 2021-11-11 12:34:29 -0800 I see, so it's ResourceRequest that is the temporary object, not the URL. Makes sense. 431164 2021-06-10 18:21:02 -0700 2021-06-10 18:35:01 -0700 WIP patch a.diff text/plain 750 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci93aW4vSW5zcGVj dG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0luc3BlY3Rvci93aW4vSW5zcGVjdG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyLmNwcAppbmRl eCAyMTdkODMwODcwMTIuLjQ3NGE1OGNkZWIwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvSW5zcGVjdG9yL3dpbi9JbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci93aW4vSW5zcGVjdG9y UmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyLmNwcApAQCAtNDIsNyArNDIsNyBAQCBuYW1lc3BhY2Ug V2ViS2l0IHsKIHZvaWQgSW5zcGVjdG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyOjpwbGF0Zm9y bVN0YXJ0VGFzayhXZWJQYWdlUHJveHkmLCBXZWJVUkxTY2hlbWVUYXNrJiB0YXNrKQogewogI2lm IFVTRShDRikgJiYgVVNFKENVUkwpCi0gICAgYXV0byYgcmVxdWVzdFVSTCA9IHRhc2sucmVxdWVz dCgpLnVybCgpOworICAgIGF1dG8gcmVxdWVzdFVSTCA9IHRhc2sucmVxdWVzdCgpLnVybCgpOwog ICAgIGF1dG8gcmVxdWVzdFBhdGggPSByZXF1ZXN0VVJMLmZpbGVTeXN0ZW1QYXRoKCk7CiAgICAg aWYgKHJlcXVlc3RQYXRoLnN0YXJ0c1dpdGgoIlxcIikpCiAgICAgICAgIHJlcXVlc3RQYXRoLnJl bW92ZSgwKTsK 431165 2021-06-10 18:35:12 -0700 2021-06-10 19:36:49 -0700 Patch bug-226908-20210611103511.patch text/plain 1946 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQxZTkzNDFiZjQzYzdmOWI4 ZjZmYjBmMGU1MmM3NDE1MDI2NTM4ZGEuLmIwZGU0YWVkNGNiNmQ4YjkxYzdlYjU3NTFhNzA3Y2U3 MzkxYWQ3NDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDYtMTAgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBD YW4ndCBvcGVuIFdlYkluc3BlY3RvciBVSSBzaW5jZSByMjc3Nzg3CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY5MDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjc3Nzg3IChCdWcgMjI2MDAxKSBjaGFu Z2VkIHRoZSByZXR1cm4gdHlwZSBvZgorICAgICAgICBXZWJVUkxTY2hlbWVUYXNrOjpyZXF1ZXN0 KCkgZnJvbSBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmCisgICAgICAgIHRvIFdlYkNv cmU6OlJlc291cmNlUmVxdWVzdC4KKworICAgICAgICBJbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVt ZUhhbmRsZXI6OnBsYXRmb3JtU3RhcnRUYXNrIHNob3VsZG4ndAorICAgICAgICBob2xkIHRoZSBy ZWZlcmVuY2Ugb2YgdGhlIHRlbXBvcmFyeSBvYmplY3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv SW5zcGVjdG9yL3dpbi9JbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIuY3BwOgorICAg ICAgICAoV2ViS2l0OjpJbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXI6OnBsYXRmb3Jt U3RhcnRUYXNrKToKKyAgICAgICAgQ2hhbmdlZCB0aGUgdHlwZSBvZiByZXF1ZXN0VVJMIGZyb20g YXV0byYgdG8gYXV0byB0byBjb3B5IHRoZSBVUkwuCisKIDIwMjEtMDYtMTAgIFNpaHVpIExpdSAg PHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVncmVzc2lvbihyMjc4NDQ5KTogYWRk IG51bGwgY2hlY2sgZm9yIGNvbXBsZXRpb25IYW5kbGVyIGluIFdlYklEQlNlcnZlcjo6Y2xvc2UK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci93aW4vSW5zcGVj dG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0luc3BlY3Rvci93aW4vSW5zcGVjdG9yUmVzb3VyY2VVUkxTY2hlbWVIYW5kbGVyLmNwcAppbmRl eCAyMTdkODMwODcwMTJiYWViNWY0ZDcxNDI0YTE1ZTcyZjhiMTA4MDViLi40NzRhNThjZGViMDU2 YjY4ZWFmZTExYzA0ZWE5MDAyNDI5MDI3YjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9JbnNwZWN0b3Ivd2luL0luc3BlY3RvclJlc291cmNlVVJMU2NoZW1lSGFuZGxlci5j cHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL3dpbi9JbnNwZWN0b3JS ZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXIuY3BwCkBAIC00Miw3ICs0Miw3IEBAIG5hbWVzcGFjZSBX ZWJLaXQgewogdm9pZCBJbnNwZWN0b3JSZXNvdXJjZVVSTFNjaGVtZUhhbmRsZXI6OnBsYXRmb3Jt U3RhcnRUYXNrKFdlYlBhZ2VQcm94eSYsIFdlYlVSTFNjaGVtZVRhc2smIHRhc2spCiB7CiAjaWYg VVNFKENGKSAmJiBVU0UoQ1VSTCkKLSAgICBhdXRvJiByZXF1ZXN0VVJMID0gdGFzay5yZXF1ZXN0 KCkudXJsKCk7CisgICAgYXV0byByZXF1ZXN0VVJMID0gdGFzay5yZXF1ZXN0KCkudXJsKCk7CiAg ICAgYXV0byByZXF1ZXN0UGF0aCA9IHJlcXVlc3RVUkwuZmlsZVN5c3RlbVBhdGgoKTsKICAgICBp ZiAocmVxdWVzdFBhdGguc3RhcnRzV2l0aCgiXFwiKSkKICAgICAgICAgcmVxdWVzdFBhdGgucmVt b3ZlKDApOwo=